You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2021/01/23 15:33:04 UTC
[GitHub] [fineract] BLasan commented on a change in pull request #1584: Add init-container to check MYSQL server deployment (FINERACT-1300)
BLasan commented on a change in pull request #1584:
URL: https://github.com/apache/fineract/pull/1584#discussion_r563165591
##########
File path: kubernetes/fineract-server-deployment.yml
##########
@@ -54,6 +54,10 @@ spec:
app: fineract-server
tier: backend
spec:
+ initContainers:
+ - name: init-mydb
+ image: busybox:1.28
+ command: ['sh', '-c', 'echo -e "Checking for the availability of MYSQL server deployment"; while ! nc -z "fineractmysql" 3306; do sleep 1; printf "-"; done; echo -e " >> MYSQL server has started";']
Review comment:
Sir, in here we need to just check whether the MYSQL server (remote server) is up and running. By using busybox image we can achieve that easily (from the bash command). mysql:5.7 image will need some extra configurations to establish the connection and listen to a remote server.(setting up credentials etc.. which is unnecessary) Simply the idea here is to verify that mysql server is running properly on the correct port and then FINERACT server could properly connect to mysql server and do the required tasks. Otherwise if we get a problem with mysql server, fineract server will go in to a CrashLoopBackOff state which is unnecessary.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org