You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by schonfeld <gi...@git.apache.org> on 2015/11/05 16:22:13 UTC
[GitHub] storm pull request: [STORM-1177] Build fails because DISCLAIMER fi...
GitHub user schonfeld opened a pull request:
https://github.com/apache/storm/pull/861
[STORM-1177] Build fails because DISCLAIMER file is missing
Removing the requirement for the `DISCLAIMER` file
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/schonfeld/storm dont-require-disclaimer-file
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/861.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #861
----
commit ec4bc2221dd7d70b8099b0b1dd9245eee45b25ad
Author: Michael Schonfeld <mi...@schonfeld.org>
Date: 2015-11-05T15:20:06Z
dont require disclaimer file in build
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1177] Build fails because DISCLAIMER fi...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/861#issuecomment-154471753
@schonfeld it looks like this was already done on a different pull request.
```
commit d59eaac77ed65b85f6aa2d8ab56ca99b1075d468
Author: Sriharsha Chintalapani <harsha at hortonworks dot com>
Date: Thu Nov 5 16:45:15 2015 -0800
Removed DISCLAIMER from storm-dist.
```
If it looks OK to you could you close this pull request?
@harshach did you do this work as part of a JIRA? If so could you duple STORM-1177 to that JIRA?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1177] Build fails because DISCLAIMER fi...
Posted by harshach <gi...@git.apache.org>.
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/861#issuecomment-154890738
@revans2 checked into master without a jira since it was a small fix.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1177] Build fails because DISCLAIMER fi...
Posted by schonfeld <gi...@git.apache.org>.
Github user schonfeld closed the pull request at:
https://github.com/apache/storm/pull/861
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1177] Build fails because DISCLAIMER fi...
Posted by schonfeld <gi...@git.apache.org>.
Github user schonfeld commented on the pull request:
https://github.com/apache/storm/pull/861#issuecomment-154765068
@revans2 you are correct!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---