You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@samza.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/05/02 17:48:00 UTC
[jira] [Commented] (SAMZA-1696) Flaky test: TestKeyValueStores
testParallelReadWriteSameKey
[ https://issues.apache.org/jira/browse/SAMZA-1696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16461388#comment-16461388 ]
ASF GitHub Bot commented on SAMZA-1696:
---------------------------------------
GitHub user ahmedahamid opened a pull request:
https://github.com/apache/samza/pull/500
SAMZA-1696: Fix TestKeyValueStores flaky test
Fix flaky test testParallelReadWriteSameKey that was failing due to a race condition between the main test thread and the thread manipulating the key value store under test. Specifically, the main test thread could assert the store has received a value before the other thread gets to set it. The hard-coded wait durations did not guarantee the main test thread would wait for all other threads to complete, causing it to assert prematurely.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ahmedahamid/samza dev/fix-1696
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/samza/pull/500.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #500
----
commit 36a2a1b09d6fa0216d556e594e566918f52295a2
Author: Ahmed Abdul Hamid <ah...@...>
Date: 2018-05-02T17:26:28Z
SAMZA-1696: Fix TestKeyValueStores flaky test
Fix flaky test testParallelReadWriteSameKey that was failing due to a race condition between the main test thread and the thread manipulating the key value store under test. Specifically, the main test thread could assert the store has received a value before the other thread gets to set it. The hard-coded wait durations did not guarantee the main test thread would wait for all other threads to complete, causing it to assert prematurely.
----
> Flaky test: TestKeyValueStores testParallelReadWriteSameKey
> -----------------------------------------------------------
>
> Key: SAMZA-1696
> URL: https://issues.apache.org/jira/browse/SAMZA-1696
> Project: Samza
> Issue Type: Bug
> Reporter: Ahmed Abdul Hamid
> Priority: Major
> Fix For: 0.15.0
>
>
> {code}:samza-test_2.11:test
> testParallelReadWriteSameKey[5] FAILED
> java.lang.NullPointerException
> at java.lang.String.<init>(String.java:491)
> at org.apache.samza.storage.kv.TestKeyValueStores.testParallelReadWriteSameKey(TestKeyValueStores.scala:416)
> 189 tests completed, 1 failed, 1 skipped
> :samza-test_2.11:test FAILED{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)