[GitHub] [incubator-daffodil] stevedlawrence commented on a change in pull request #411: Added SDWs for discouraged assert and discriminator placements

[GitBox <gi...@apache.org>]

stevedlawrence commented on a change in pull request #411:
URL: https://github.com/apache/incubator-daffodil/pull/411#discussion_r483697407



##########
File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/SequenceGroup.scala
##########
@@ -147,6 +151,18 @@ abstract class SequenceGroupTermBase(
     }
   }.value
 
+  /**
+   * Provides validation for assert and discriminator placement
+   */
+  protected final lazy val checkIfNonEmptyAndDiscrimsOrAsserts: Unit = {
+    val msg = "Counterintuitive placement detected. Wrap the discriminator or assert " +
+      "in an empty sequence to evaluate before the contents.\n"

Review comment:
       Looks like you still need to remove the \n.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org