You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by corneadoug <gi...@git.apache.org> on 2016/07/13 10:23:21 UTC
[GitHub] zeppelin pull request #1180: [ZEPPELIN-1059] Fix the Print CSS file
GitHub user corneadoug opened a pull request:
https://github.com/apache/zeppelin/pull/1180
[ZEPPELIN-1059] Fix the Print CSS file
### What is this PR for?
While investigating the original issue, I discovered that the `printMode.css` file was never used before.
I changed it so it is taken into account when printing, and added some CSS to remove unnecessary components in the printing page.
### What type of PR is it?
Bug Fix
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1059
### How should this be tested?
Try to print a Note with your web-browser and look at the preview.
There shouldn't be the Zeppelin Navbar or a weird Title hiding the content.
### Screenshots (if appropriate)
After this PR:
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/corneadoug/incubator-zeppelin ZEPPELIN-1059
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1180.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1180
----
commit bb3542d135765ff123f69b74bf6ec2b1e77e66e7
Author: Damien CORNEAU <co...@gmail.com>
Date: 2016-07-13T10:18:33Z
fix the print css
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1180: [ZEPPELIN-1059] Fix the Print CSS file
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1180
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1180: [ZEPPELIN-1059] Fix the Print CSS file
Posted by corneadoug <gi...@git.apache.org>.
GitHub user corneadoug reopened a pull request:
https://github.com/apache/zeppelin/pull/1180
[ZEPPELIN-1059] Fix the Print CSS file
### What is this PR for?
While investigating the original issue, I discovered that the `printMode.css` file was never used before.
I changed it so it is taken into account when printing, and added some CSS to remove unnecessary components in the printing page.
### What type of PR is it?
Bug Fix
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1059
### How should this be tested?
Try to print a Note with your web-browser and look at the preview.
There shouldn't be the Zeppelin Navbar or a weird Title hiding the content.
### Screenshots (if appropriate)
After this PR:
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/corneadoug/incubator-zeppelin ZEPPELIN-1059
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1180.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1180
----
commit bb3542d135765ff123f69b74bf6ec2b1e77e66e7
Author: Damien CORNEAU <co...@gmail.com>
Date: 2016-07-13T10:18:33Z
fix the print css
commit 39182b5ff811dd5994a86f7dbeb41420ec3d802c
Author: Damien CORNEAU <co...@gmail.com>
Date: 2016-07-14T03:16:54Z
remove a ng-if that wasnt necessary
commit cbbbc26ed630cfbc830e4485f045d222b4957d79
Author: Damien CORNEAU <co...@gmail.com>
Date: 2016-07-14T06:53:39Z
Apply print CSS file in production
commit 9e81cb371ee5745505c7961215e6931d02846c89
Author: Damien CORNEAU <co...@gmail.com>
Date: 2016-07-14T08:07:04Z
fix the Selenium tests errors
commit 9f14a133521819cc45e1c9d5c06ae98322b0def8
Author: Damien CORNEAU <co...@gmail.com>
Date: 2016-07-14T08:13:01Z
modify a test name to fit better
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1180: [ZEPPELIN-1059] Fix the Print CSS file
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1180
CI failure is unrelated
Merging if there is no more discussion.
(re-triggering CI at the same time)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1180: [ZEPPELIN-1059] Fix the Print CSS file
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug closed the pull request at:
https://github.com/apache/zeppelin/pull/1180
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1180: [ZEPPELIN-1059] Fix the Print CSS file
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1180
This is cool!!
Tested and LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1180: [ZEPPELIN-1059] Fix the Print CSS file
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/1180
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1180: [ZEPPELIN-1059] Fix the Print CSS file
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1180
Had to change some tests because of bad behaviour of `pu-elastic-input` with printing.
Added some functions to activate/deactivate the Implicit wait, it is mainly useful in the case of testing for elements that are not in the DOM.
Also added a line to handle firebug for people with higher version of Firefox
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---