You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@buildr.apache.org by "Ketan Padegaonkar (JIRA)" <ji...@apache.org> on 2008/11/16 12:31:44 UTC
[jira] Created: (BUILDR-215) [patch] buildr:freeze and unfreeze
tasks do not work
[patch] buildr:freeze and unfreeze tasks do not work
----------------------------------------------------
Key: BUILDR-215
URL: https://issues.apache.org/jira/browse/BUILDR-215
Project: Buildr
Issue Type: Bug
Reporter: Ketan Padegaonkar
Fix For: 1.3.4
Here's a patch that fixes minor issues with buildr:freeze and :unfreeze tasks.
This was caused because the type of Buildr.application.buildfile was changed to a BuildfileTask
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (BUILDR-215) [patch] buildr:freeze and unfreeze
tasks do not work
Posted by "Ketan Padegaonkar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12656645#action_12656645 ]
Ketan Padegaonkar commented on BUILDR-215:
------------------------------------------
Any updates on why this has not been accepted yet ?
> [patch] buildr:freeze and unfreeze tasks do not work
> ----------------------------------------------------
>
> Key: BUILDR-215
> URL: https://issues.apache.org/jira/browse/BUILDR-215
> Project: Buildr
> Issue Type: Bug
> Reporter: Ketan Padegaonkar
> Fix For: 1.3.4
>
> Attachments: patch
>
>
> Here's a patch that fixes minor issues with buildr:freeze and :unfreeze tasks.
> This was caused because the type of Buildr.application.buildfile was changed to a BuildfileTask
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (BUILDR-215) [patch] buildr:freeze and unfreeze
tasks do not work
Posted by "Assaf Arkin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Assaf Arkin resolved BUILDR-215.
--------------------------------
Resolution: Won't Fix
The freeze/unfreeze task used to work on rake by loading a specific version of Buildr first thing in the rakefile. They won't work with buildr, since by the time the buildfile is loaded, Buildr is already activated in a given version.
> [patch] buildr:freeze and unfreeze tasks do not work
> ----------------------------------------------------
>
> Key: BUILDR-215
> URL: https://issues.apache.org/jira/browse/BUILDR-215
> Project: Buildr
> Issue Type: Bug
> Reporter: Ketan Padegaonkar
> Fix For: 1.3.4
>
> Attachments: patch
>
>
> Here's a patch that fixes minor issues with buildr:freeze and :unfreeze tasks.
> This was caused because the type of Buildr.application.buildfile was changed to a BuildfileTask
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (BUILDR-215) [patch] buildr:freeze and unfreeze
tasks do not work
Posted by "Alex Boisvert (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12656646#action_12656646 ]
Alex Boisvert commented on BUILDR-215:
--------------------------------------
Hi Ketan, I don't think there's a specific reason, however one thing missing from your patch is a test-case reproducing the issue. Everytime we change or fix the code we try to have a test-case to increase our confidence in the change and in the future. At this point, one of the committers would have to write one to apply the patch. If you could write a test-case for it, it would certainly speed up the process!
> [patch] buildr:freeze and unfreeze tasks do not work
> ----------------------------------------------------
>
> Key: BUILDR-215
> URL: https://issues.apache.org/jira/browse/BUILDR-215
> Project: Buildr
> Issue Type: Bug
> Reporter: Ketan Padegaonkar
> Fix For: 1.3.4
>
> Attachments: patch
>
>
> Here's a patch that fixes minor issues with buildr:freeze and :unfreeze tasks.
> This was caused because the type of Buildr.application.buildfile was changed to a BuildfileTask
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (BUILDR-215) [patch] buildr:freeze and unfreeze
tasks do not work
Posted by "Ketan Padegaonkar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ketan Padegaonkar updated BUILDR-215:
-------------------------------------
Attachment: patch
the proposed patch.
> [patch] buildr:freeze and unfreeze tasks do not work
> ----------------------------------------------------
>
> Key: BUILDR-215
> URL: https://issues.apache.org/jira/browse/BUILDR-215
> Project: Buildr
> Issue Type: Bug
> Reporter: Ketan Padegaonkar
> Fix For: 1.3.4
>
> Attachments: patch
>
>
> Here's a patch that fixes minor issues with buildr:freeze and :unfreeze tasks.
> This was caused because the type of Buildr.application.buildfile was changed to a BuildfileTask
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.