You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Ivan Vasilev (JIRA)" <ji...@apache.org> on 2010/12/22 17:09:03 UTC
[jira] Created: (WICKET-3278) DropDownChoice no selection value
DropDownChoice no selection value
---------------------------------
Key: WICKET-3278
URL: https://issues.apache.org/jira/browse/WICKET-3278
Project: Wicket
Issue Type: Bug
Components: wicket
Affects Versions: 1.5-M3
Environment: Any
Reporter: Ivan Vasilev
This problem came from this topic:
http://apache-wicket.1842946.n4.nabble.com/DropDownChoice-no-selection-value-td3160661.html
I've noticed that the method AbstractSingleSelectChoice.getNoSelectionValue() returns the value for no selection. In AbstractSingleSelectChoice.getDefaultChoice(final Object selected) on line 314:
return "\n<option selected=\"selected\" value=\"\">" + option + "</option>";
and on line 296:
buffer.append(" value=\"\">").append(option).append("</option>");
In those cases the null value option has empty value attribute. Wouldn't it be more consistent for this option to have the "value" attribute with the result provided from getNoSelectionValue()?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (WICKET-3278) DropDownChoice no selection value
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Grigorov reassigned WICKET-3278:
---------------------------------------
Assignee: Martin Grigorov
> DropDownChoice no selection value
> ---------------------------------
>
> Key: WICKET-3278
> URL: https://issues.apache.org/jira/browse/WICKET-3278
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5-M3
> Environment: Any
> Reporter: Ivan Vasilev
> Assignee: Martin Grigorov
>
> This problem came from this topic:
> http://apache-wicket.1842946.n4.nabble.com/DropDownChoice-no-selection-value-td3160661.html
> I've noticed that the method AbstractSingleSelectChoice.getNoSelectionValue() returns the value for no selection. In AbstractSingleSelectChoice.getDefaultChoice(final Object selected) on line 314:
> return "\n<option selected=\"selected\" value=\"\">" + option + "</option>";
> and on line 296:
> buffer.append(" value=\"\">").append(option).append("</option>");
> In those cases the null value option has empty value attribute. Wouldn't it be more consistent for this option to have the "value" attribute with the result provided from getNoSelectionValue()?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-3278) DropDownChoice no selection value
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Grigorov resolved WICKET-3278.
-------------------------------------
Resolution: Fixed
Fix Version/s: 1.5-M4
Fixed with r1052911.
Will not merge to 1.4 because applications may depend on the current value ("").
> DropDownChoice no selection value
> ---------------------------------
>
> Key: WICKET-3278
> URL: https://issues.apache.org/jira/browse/WICKET-3278
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5-M3
> Environment: Any
> Reporter: Ivan Vasilev
> Assignee: Martin Grigorov
> Fix For: 1.5-M4
>
>
> This problem came from this topic:
> http://apache-wicket.1842946.n4.nabble.com/DropDownChoice-no-selection-value-td3160661.html
> I've noticed that the method AbstractSingleSelectChoice.getNoSelectionValue() returns the value for no selection. In AbstractSingleSelectChoice.getDefaultChoice(final Object selected) on line 314:
> return "\n<option selected=\"selected\" value=\"\">" + option + "</option>";
> and on line 296:
> buffer.append(" value=\"\">").append(option).append("</option>");
> In those cases the null value option has empty value attribute. Wouldn't it be more consistent for this option to have the "value" attribute with the result provided from getNoSelectionValue()?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.