You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/12/20 00:52:27 UTC

[GitHub] [airflow] uranusjr commented on a change in pull request #20378: Reduce deprecation warnings from www

uranusjr commented on a change in pull request #20378:
URL: https://github.com/apache/airflow/pull/20378#discussion_r772027255



##########
File path: tests/www/test_app.py
##########
@@ -240,7 +240,8 @@ def test_should_set_permanent_session_timeout(self):
     @conf_vars({('webserver', 'cookie_samesite'): ''})
     @dont_initialize_flask_app_submodules
     def test_correct_default_is_set_for_cookie_samesite(self):
-        app = application.cached_app(testing=True)
+        with pytest.deprecated_call():
+            app = application.cached_app(testing=True)

Review comment:
       The default value of `cookie_samesite` was an empty string, but was changed to `Lax` in 2.0. Setting the config to an empty string now emits a deprecation warning, and the value is automatically corrected to `Lax`. I’ll add a note as a code comment.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org