You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/02/24 04:35:36 UTC
[GitHub] [skywalking] haoyann opened a new pull request #6431: Fix alarm httpclient connection leak
haoyann opened a new pull request #6431:
URL: https://github.com/apache/skywalking/pull/6431
<!--
⚠️ Please make sure to read this template first, pull requests that don't accord with this template
maybe closed without notice.
Texts surrounded by `<` and `>` are meant to be replaced by you, e.g. <framework name>, <issue number>.
Put an `x` in the `[ ]` to mark the item as CHECKED. `[x]`
-->
<!-- ==== 🐛 Remove this line WHEN AND ONLY WHEN you're fixing a bug, follow the checklist 👇 ====
### Fix <bug description or the bug issue number or bug issue link>
- [ ] Add a unit test to verify that the fix works.
- [ ] Explain briefly why the bug exists and how to fix it.
==== 🐛 Remove this line WHEN AND ONLY WHEN you're fixing a bug, follow the checklist 👆 ==== -->
<!-- ==== 🔌 Remove this line WHEN AND ONLY WHEN you're adding a new plugin, follow the checklist 👇 ====
### Add an agent plugin to support <framework name>
- [ ] Add a test case for the new plugin, refer to [the doc](https://github.com/apache/skywalking/blob/master/docs/en/guides/Plugin-test.md)
- [ ] Add a component id in [the component-libraries.yml](https://github.com/apache/skywalking/blob/master/oap-server/server-bootstrap/src/main/resources/component-libraries.yml)
- [ ] Add a logo in [the UI repo](https://github.com/apache/skywalking-rocketbot-ui/tree/master/src/views/components/topology/assets)
==== 🔌 Remove this line WHEN AND ONLY WHEN you're adding a new plugin, follow the checklist 👆 ==== -->
<!-- ==== 📈 Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist 👇 ====
### Improve the performance of <class or module or ...>
- [ ] Add a benchmark for the improvement, refer to [the existing ones](https://github.com/apache/skywalking/blob/master/apm-commons/apm-datacarrier/src/test/java/org/apache/skywalking/apm/commons/datacarrier/LinkedArrayBenchmark.java)
- [ ] The benchmark result.
```text
<Paste the benchmark results here>
```
- [ ] Links/URLs to the theory proof or discussion articles/blogs. <links/URLs here>
==== 📈 Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist 👆 ==== -->
<!-- ==== 🆕 Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist 👇 ====
### <Feature description>
- [ ] If this is non-trivial feature, paste the links/URLs to the design doc.
- [ ] Update the documentation to include this new feature.
- [ ] Tests(including UT, IT, E2E) are added to verify the new feature.
- [ ] If it's UI related, attach the screenshots below.
==== 🆕 Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist 👆 ==== -->
- [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #6424.
- [x] Update the [`CHANGES` log](https://github.com/apache/skywalking/blob/master/CHANGES.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6431: Fix alarm httpclient connection leak
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6431:
URL: https://github.com/apache/skywalking/pull/6431#issuecomment-784759581
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=h1) Report
> Merging [#6431](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=desc) (b7520a5) into [master](https://codecov.io/gh/apache/skywalking/commit/1c52995cbf26fa1442ba6b81fb3c4635625e3702?el=desc) (1c52995) will **decrease** coverage by `5.26%`.
> The diff coverage is `41.81%`.
[](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6431 +/- ##
============================================
- Coverage 56.82% 51.55% -5.27%
+ Complexity 3970 3715 -255
============================================
Files 985 999 +14
Lines 24397 24618 +221
Branches 2401 2411 +10
============================================
- Hits 13864 12693 -1171
- Misses 9305 10824 +1519
+ Partials 1228 1101 -127
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/log/analyzer/dsl/spec/sink/sampler/Sampler.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvU2FtcGxlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ap/server/core/alarm/provider/WebhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9XZWJob29rQ2FsbGJhY2suamF2YQ==) | `25.00% <0.00%> (-46.43%)` | `2.00 <0.00> (-2.00)` | |
| [.../alarm/provider/dingtalk/DingtalkHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9kaW5ndGFsay9EaW5ndGFsa0hvb2tDYWxsYmFjay5qYXZh) | `16.98% <0.00%> (-1.89%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/feishu/FeishuHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9mZWlzaHUvRmVpc2h1SG9va0NhbGxiYWNrLmphdmE=) | `12.85% <0.00%> (-1.43%)` | `2.00 <0.00> (-1.00)` | |
| [...r/core/alarm/provider/slack/SlackhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9zbGFjay9TbGFja2hvb2tDYWxsYmFjay5qYXZh) | `20.83% <0.00%> (-4.75%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <0.00%> (-2.64%)` | `2.00 <0.00> (-1.00)` | |
| [...zer/dsl/spec/sink/sampler/RateLimitingSampler.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvUmF0ZUxpbWl0aW5nU2FtcGxlci5qYXZh) | `12.12% <12.12%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `18.51% <18.51%> (ø)` | `2.00 <2.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `18.75% <18.75%> (ø)` | `1.00 <1.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `26.43% <26.43%> (ø)` | `4.00 <4.00> (?)` | |
| ... and [149 more](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=footer). Last update [665a07c...b7520a5](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6431: Fix alarm httpclient connection leak
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6431:
URL: https://github.com/apache/skywalking/pull/6431#issuecomment-784759581
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=h1) Report
> Merging [#6431](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=desc) (f55956d) into [master](https://codecov.io/gh/apache/skywalking/commit/0f8b6d641a963adafd3f4dd2a7388dfd27a626c9?el=desc) (0f8b6d6) will **decrease** coverage by `4.83%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6431 +/- ##
============================================
- Coverage 53.66% 48.82% -4.84%
+ Complexity 4069 3559 -510
============================================
Files 1789 998 -791
Lines 38172 24590 -13582
Branches 4217 2414 -1803
============================================
- Hits 20484 12007 -8477
+ Misses 16688 11582 -5106
- Partials 1000 1001 +1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/server/core/alarm/provider/WebhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9XZWJob29rQ2FsbGJhY2suamF2YQ==) | `25.00% <0.00%> (-42.57%)` | `2.00 <0.00> (-2.00)` | |
| [.../alarm/provider/dingtalk/DingtalkHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9kaW5ndGFsay9EaW5ndGFsa0hvb2tDYWxsYmFjay5qYXZh) | `15.51% <0.00%> (-62.67%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/feishu/FeishuHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9mZWlzaHUvRmVpc2h1SG9va0NhbGxiYWNrLmphdmE=) | `12.00% <0.00%> (-71.34%)` | `2.00 <0.00> (-1.00)` | |
| [...r/core/alarm/provider/slack/SlackhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9zbGFjay9TbGFja2hvb2tDYWxsYmFjay5qYXZh) | `20.83% <0.00%> (-3.62%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `20.93% <0.00%> (-56.57%)` | `2.00 <0.00> (-1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1291 more](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=footer). Last update [08bceb9...f55956d](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6431: Fix alarm httpclient connection leak
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6431:
URL: https://github.com/apache/skywalking/pull/6431#issuecomment-784759581
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=h1) Report
> Merging [#6431](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=desc) (5c8c304) into [master](https://codecov.io/gh/apache/skywalking/commit/8c3d1679e37f992b697835b2402401a26eac19e8?el=desc) (8c3d167) will **decrease** coverage by `2.63%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6431 +/- ##
============================================
- Coverage 51.80% 49.17% -2.64%
+ Complexity 3788 3581 -207
============================================
Files 1016 999 -17
Lines 24957 24600 -357
Branches 2447 2399 -48
============================================
- Hits 12930 12098 -832
- Misses 10913 11455 +542
+ Partials 1114 1047 -67
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/server/core/alarm/provider/WebhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9XZWJob29rQ2FsbGJhY2suamF2YQ==) | `25.00% <0.00%> (-46.43%)` | `2.00 <0.00> (-2.00)` | |
| [.../alarm/provider/dingtalk/DingtalkHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9kaW5ndGFsay9EaW5ndGFsa0hvb2tDYWxsYmFjay5qYXZh) | `15.51% <0.00%> (-3.36%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/feishu/FeishuHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9mZWlzaHUvRmVpc2h1SG9va0NhbGxiYWNrLmphdmE=) | `12.00% <0.00%> (-2.29%)` | `2.00 <0.00> (-1.00)` | |
| [...r/core/alarm/provider/slack/SlackhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9zbGFjay9TbGFja2hvb2tDYWxsYmFjay5qYXZh) | `20.83% <0.00%> (-4.75%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `20.93% <0.00%> (-5.39%)` | `2.00 <0.00> (-1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...in/elasticsearch/base/TimeRangeIndexNameMaker.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9UaW1lUmFuZ2VJbmRleE5hbWVNYWtlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [.../provider/parser/performance/PerfDataAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL3BhcnNlci9wZXJmb3JtYW5jZS9QZXJmRGF0YUFuYWx5emVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| ... and [140 more](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=footer). Last update [8c3d167...3573922](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6431: Fix alarm httpclient connection leak
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6431:
URL: https://github.com/apache/skywalking/pull/6431#issuecomment-784759581
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=h1) Report
> Merging [#6431](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=desc) (f55956d) into [master](https://codecov.io/gh/apache/skywalking/commit/0f8b6d641a963adafd3f4dd2a7388dfd27a626c9?el=desc) (0f8b6d6) will **decrease** coverage by `1.66%`.
> The diff coverage is `11.42%`.
[](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6431 +/- ##
============================================
- Coverage 53.66% 51.99% -1.67%
+ Complexity 4069 3798 -271
============================================
Files 1789 998 -791
Lines 38172 24712 -13460
Branches 4217 2423 -1794
============================================
- Hits 20484 12849 -7635
+ Misses 16688 10776 -5912
- Partials 1000 1087 +87
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../alarm/provider/dingtalk/DingtalkHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9kaW5ndGFsay9EaW5ndGFsa0hvb2tDYWxsYmFjay5qYXZh) | `17.24% <0.00%> (-60.95%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/feishu/FeishuHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9mZWlzaHUvRmVpc2h1SG9va0NhbGxiYWNrLmphdmE=) | `13.33% <0.00%> (-70.00%)` | `3.00 <0.00> (ø)` | |
| [...r/core/alarm/provider/slack/SlackhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9zbGFjay9TbGFja2hvb2tDYWxsYmFjay5qYXZh) | `22.91% <0.00%> (-1.53%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.25% <0.00%> (-54.25%)` | `3.00 <0.00> (ø)` | |
| [...ap/server/core/alarm/provider/WebhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9XZWJob29rQ2FsbGJhY2suamF2YQ==) | `67.50% <57.14%> (-0.07%)` | `4.00 <0.00> (ø)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...lking/oap/server/analyzer/event/EventAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L0V2ZW50QW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| ... and [1260 more](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=footer). Last update [08bceb9...f55956d](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6431: Fix alarm httpclient connection leak
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6431:
URL: https://github.com/apache/skywalking/pull/6431#issuecomment-784759581
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=h1) Report
> Merging [#6431](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=desc) (f55956d) into [master](https://codecov.io/gh/apache/skywalking/commit/0f8b6d641a963adafd3f4dd2a7388dfd27a626c9?el=desc) (0f8b6d6) will **decrease** coverage by `8.00%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6431 +/- ##
============================================
- Coverage 53.66% 45.65% -8.01%
+ Complexity 4069 2755 -1314
============================================
Files 1789 848 -941
Lines 38172 20989 -17183
Branches 4217 2006 -2211
============================================
- Hits 20484 9583 -10901
+ Misses 16688 10697 -5991
+ Partials 1000 709 -291
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/server/core/alarm/provider/WebhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9XZWJob29rQ2FsbGJhY2suamF2YQ==) | `25.00% <0.00%> (-42.57%)` | `2.00 <0.00> (-2.00)` | |
| [.../alarm/provider/dingtalk/DingtalkHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9kaW5ndGFsay9EaW5ndGFsa0hvb2tDYWxsYmFjay5qYXZh) | `15.51% <0.00%> (-62.67%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/feishu/FeishuHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9mZWlzaHUvRmVpc2h1SG9va0NhbGxiYWNrLmphdmE=) | `12.00% <0.00%> (-71.34%)` | `2.00 <0.00> (-1.00)` | |
| [...r/core/alarm/provider/slack/SlackhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9zbGFjay9TbGFja2hvb2tDYWxsYmFjay5qYXZh) | `20.83% <0.00%> (-3.62%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `20.93% <0.00%> (-56.57%)` | `2.00 <0.00> (-1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...lking/oap/server/analyzer/event/EventAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L0V2ZW50QW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| ... and [1363 more](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=footer). Last update [08bceb9...f55956d](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6431: Fix alarm httpclient connection leak
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6431:
URL: https://github.com/apache/skywalking/pull/6431#issuecomment-784759581
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=h1) Report
> Merging [#6431](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=desc) (b8320cc) into [master](https://codecov.io/gh/apache/skywalking/commit/0f8b6d641a963adafd3f4dd2a7388dfd27a626c9?el=desc) (0f8b6d6) will **decrease** coverage by `3.70%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6431 +/- ##
============================================
- Coverage 53.66% 49.95% -3.71%
+ Complexity 4069 3641 -428
============================================
Files 1789 999 -790
Lines 38172 24610 -13562
Branches 4217 2415 -1802
============================================
- Hits 20484 12294 -8190
+ Misses 16688 11235 -5453
- Partials 1000 1081 +81
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/server/core/alarm/provider/WebhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9XZWJob29rQ2FsbGJhY2suamF2YQ==) | `25.00% <0.00%> (-42.57%)` | `2.00 <0.00> (-2.00)` | |
| [.../alarm/provider/dingtalk/DingtalkHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9kaW5ndGFsay9EaW5ndGFsa0hvb2tDYWxsYmFjay5qYXZh) | `15.51% <0.00%> (-62.67%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/feishu/FeishuHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9mZWlzaHUvRmVpc2h1SG9va0NhbGxiYWNrLmphdmE=) | `12.00% <0.00%> (-71.34%)` | `2.00 <0.00> (-1.00)` | |
| [...r/core/alarm/provider/slack/SlackhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9zbGFjay9TbGFja2hvb2tDYWxsYmFjay5qYXZh) | `20.83% <0.00%> (-3.62%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `20.93% <0.00%> (-56.57%)` | `2.00 <0.00> (-1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1280 more](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=footer). Last update [08bceb9...f55956d](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6431: Fix alarm httpclient connection leak
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6431:
URL: https://github.com/apache/skywalking/pull/6431#issuecomment-784759581
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=h1) Report
> Merging [#6431](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=desc) (f55956d) into [master](https://codecov.io/gh/apache/skywalking/commit/0f8b6d641a963adafd3f4dd2a7388dfd27a626c9?el=desc) (0f8b6d6) will **decrease** coverage by `7.58%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6431 +/- ##
============================================
- Coverage 53.66% 46.07% -7.59%
+ Complexity 4069 2771 -1298
============================================
Files 1789 848 -941
Lines 38172 20989 -17183
Branches 4217 2006 -2211
============================================
- Hits 20484 9671 -10813
+ Misses 16688 10599 -6089
+ Partials 1000 719 -281
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/server/core/alarm/provider/WebhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9XZWJob29rQ2FsbGJhY2suamF2YQ==) | `25.00% <0.00%> (-42.57%)` | `2.00 <0.00> (-2.00)` | |
| [.../alarm/provider/dingtalk/DingtalkHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9kaW5ndGFsay9EaW5ndGFsa0hvb2tDYWxsYmFjay5qYXZh) | `15.51% <0.00%> (-62.67%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/feishu/FeishuHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9mZWlzaHUvRmVpc2h1SG9va0NhbGxiYWNrLmphdmE=) | `12.00% <0.00%> (-71.34%)` | `2.00 <0.00> (-1.00)` | |
| [...r/core/alarm/provider/slack/SlackhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9zbGFjay9TbGFja2hvb2tDYWxsYmFjay5qYXZh) | `20.83% <0.00%> (-3.62%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `20.93% <0.00%> (-56.57%)` | `2.00 <0.00> (-1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...lking/oap/server/analyzer/event/EventAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L0V2ZW50QW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| ... and [1360 more](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=footer). Last update [08bceb9...f55956d](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6431: Fix alarm httpclient connection leak
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6431:
URL: https://github.com/apache/skywalking/pull/6431#issuecomment-784759581
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=h1) Report
> Merging [#6431](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=desc) (b8320cc) into [master](https://codecov.io/gh/apache/skywalking/commit/0f8b6d641a963adafd3f4dd2a7388dfd27a626c9?el=desc) (0f8b6d6) will **decrease** coverage by `8.28%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6431 +/- ##
============================================
- Coverage 53.66% 45.37% -8.29%
+ Complexity 4069 3370 -699
============================================
Files 1789 999 -790
Lines 38172 24582 -13590
Branches 4217 2413 -1804
============================================
- Hits 20484 11154 -9330
+ Misses 16688 12473 -4215
+ Partials 1000 955 -45
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/server/core/alarm/provider/WebhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9XZWJob29rQ2FsbGJhY2suamF2YQ==) | `25.00% <0.00%> (-42.57%)` | `2.00 <0.00> (-2.00)` | |
| [.../alarm/provider/dingtalk/DingtalkHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9kaW5ndGFsay9EaW5ndGFsa0hvb2tDYWxsYmFjay5qYXZh) | `15.51% <0.00%> (-62.67%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/feishu/FeishuHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9mZWlzaHUvRmVpc2h1SG9va0NhbGxiYWNrLmphdmE=) | `12.00% <0.00%> (-71.34%)` | `2.00 <0.00> (-1.00)` | |
| [...r/core/alarm/provider/slack/SlackhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9zbGFjay9TbGFja2hvb2tDYWxsYmFjay5qYXZh) | `20.83% <0.00%> (-3.62%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `20.93% <0.00%> (-56.57%)` | `2.00 <0.00> (-1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1312 more](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=footer). Last update [08bceb9...f55956d](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6431: Fix alarm httpclient connection leak
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6431:
URL: https://github.com/apache/skywalking/pull/6431#issuecomment-784759581
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=h1) Report
> Merging [#6431](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=desc) (b8320cc) into [master](https://codecov.io/gh/apache/skywalking/commit/0f8b6d641a963adafd3f4dd2a7388dfd27a626c9?el=desc) (0f8b6d6) will **decrease** coverage by `8.70%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6431 +/- ##
============================================
- Coverage 53.66% 44.95% -8.71%
+ Complexity 4069 3349 -720
============================================
Files 1789 999 -790
Lines 38172 24579 -13593
Branches 4217 2413 -1804
============================================
- Hits 20484 11050 -9434
+ Misses 16688 12575 -4113
+ Partials 1000 954 -46
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/server/core/alarm/provider/WebhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9XZWJob29rQ2FsbGJhY2suamF2YQ==) | `25.00% <0.00%> (-42.57%)` | `2.00 <0.00> (-2.00)` | |
| [.../alarm/provider/dingtalk/DingtalkHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9kaW5ndGFsay9EaW5ndGFsa0hvb2tDYWxsYmFjay5qYXZh) | `15.51% <0.00%> (-62.67%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/feishu/FeishuHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9mZWlzaHUvRmVpc2h1SG9va0NhbGxiYWNrLmphdmE=) | `12.00% <0.00%> (-71.34%)` | `2.00 <0.00> (-1.00)` | |
| [...r/core/alarm/provider/slack/SlackhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9zbGFjay9TbGFja2hvb2tDYWxsYmFjay5qYXZh) | `20.83% <0.00%> (-3.62%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `20.93% <0.00%> (-56.57%)` | `2.00 <0.00> (-1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1316 more](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=footer). Last update [08bceb9...f55956d](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6431: Fix alarm httpclient connection leak
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6431:
URL: https://github.com/apache/skywalking/pull/6431#issuecomment-784759581
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=h1) Report
> Merging [#6431](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=desc) (700fa56) into [master](https://codecov.io/gh/apache/skywalking/commit/1c52995cbf26fa1442ba6b81fb3c4635625e3702?el=desc) (1c52995) will **decrease** coverage by `7.04%`.
> The diff coverage is `47.93%`.
[](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6431 +/- ##
============================================
- Coverage 56.82% 49.78% -7.05%
+ Complexity 3970 3647 -323
============================================
Files 985 1789 +804
Lines 24397 38094 +13697
Branches 2401 4209 +1808
============================================
+ Hits 13864 18964 +5100
- Misses 9305 18132 +8827
+ Partials 1228 998 -230
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...in/finagle/ClientDestTracingFilterInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vZmluYWdsZS02LjI1LngtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9wbHVnaW4vZmluYWdsZS9DbGllbnREZXN0VHJhY2luZ0ZpbHRlckludGVyY2VwdG9yLmphdmE=) | `55.00% <ø> (ø)` | `0.00 <0.00> (?)` | |
| [...flux/v5/webclient/WebFluxWebClientInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvc3ByaW5nLXdlYmZsdXgtNS54LXdlYmNsaWVudC1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3BsdWdpbi9zcHJpbmcvd2ViZmx1eC92NS93ZWJjbGllbnQvV2ViRmx1eFdlYkNsaWVudEludGVyY2VwdG9yLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (?)` | |
| [...ap/log/analyzer/dsl/spec/sink/sampler/Sampler.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvU2FtcGxlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...r/core/alarm/provider/slack/SlackhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9zbGFjay9TbGFja2hvb2tDYWxsYmFjay5qYXZh) | `19.60% <0.00%> (-5.98%)` | `2.00 <0.00> (-1.00)` | |
| [...zer/dsl/spec/sink/sampler/RateLimitingSampler.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvUmF0ZUxpbWl0aW5nU2FtcGxlci5qYXZh) | `11.76% <11.76%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `18.51% <18.51%> (ø)` | `2.00 <2.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `18.75% <18.75%> (ø)` | `1.00 <1.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `26.43% <26.43%> (ø)` | `4.00 <4.00> (?)` | |
| [...g/analyzer/provider/LogAnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9Mb2dBbmFseXplck1vZHVsZVByb3ZpZGVyLmphdmE=) | `86.66% <50.00%> (-13.34%)` | `8.00 <1.00> (ø)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `50.87% <50.87%> (ø)` | `7.00 <7.00> (?)` | |
| ... and [1303 more](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=footer). Last update [665a07c...b7520a5](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6431: Fix alarm httpclient connection leak
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6431:
URL: https://github.com/apache/skywalking/pull/6431#issuecomment-784759581
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=h1) Report
> Merging [#6431](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=desc) (b7520a5) into [master](https://codecov.io/gh/apache/skywalking/commit/1c52995cbf26fa1442ba6b81fb3c4635625e3702?el=desc) (1c52995) will **decrease** coverage by `4.20%`.
> The diff coverage is `41.81%`.
[](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6431 +/- ##
============================================
- Coverage 56.82% 52.62% -4.21%
+ Complexity 3970 3799 -171
============================================
Files 985 999 +14
Lines 24397 24646 +249
Branches 2401 2416 +15
============================================
- Hits 13864 12969 -895
- Misses 9305 10569 +1264
+ Partials 1228 1108 -120
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/log/analyzer/dsl/spec/sink/sampler/Sampler.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvU2FtcGxlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ap/server/core/alarm/provider/WebhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9XZWJob29rQ2FsbGJhY2suamF2YQ==) | `25.00% <0.00%> (-46.43%)` | `2.00 <0.00> (-2.00)` | |
| [.../alarm/provider/dingtalk/DingtalkHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9kaW5ndGFsay9EaW5ndGFsa0hvb2tDYWxsYmFjay5qYXZh) | `16.98% <0.00%> (-1.89%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/feishu/FeishuHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9mZWlzaHUvRmVpc2h1SG9va0NhbGxiYWNrLmphdmE=) | `12.85% <0.00%> (-1.43%)` | `2.00 <0.00> (-1.00)` | |
| [...r/core/alarm/provider/slack/SlackhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9zbGFjay9TbGFja2hvb2tDYWxsYmFjay5qYXZh) | `20.83% <0.00%> (-4.75%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <0.00%> (-2.64%)` | `2.00 <0.00> (-1.00)` | |
| [...zer/dsl/spec/sink/sampler/RateLimitingSampler.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvUmF0ZUxpbWl0aW5nU2FtcGxlci5qYXZh) | `12.12% <12.12%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `18.51% <18.51%> (ø)` | `2.00 <2.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `18.75% <18.75%> (ø)` | `1.00 <1.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `26.43% <26.43%> (ø)` | `4.00 <4.00> (?)` | |
| ... and [141 more](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=footer). Last update [665a07c...b7520a5](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6431: Fix alarm httpclient connection leak
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6431:
URL: https://github.com/apache/skywalking/pull/6431#issuecomment-784759581
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=h1) Report
> Merging [#6431](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=desc) (5c8c304) into [master](https://codecov.io/gh/apache/skywalking/commit/8c3d1679e37f992b697835b2402401a26eac19e8?el=desc) (8c3d167) will **increase** coverage by `1.30%`.
> The diff coverage is `45.71%`.
[](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6431 +/- ##
============================================
+ Coverage 51.86% 53.17% +1.30%
- Complexity 3794 4041 +247
============================================
Files 1016 1789 +773
Lines 24957 38202 +13245
Branches 2447 4222 +1775
============================================
+ Hits 12945 20315 +7370
- Misses 10900 16891 +5991
+ Partials 1112 996 -116
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/alarm/provider/slack/SlackhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9zbGFjay9TbGFja2hvb2tDYWxsYmFjay5qYXZh) | `21.56% <0.00%> (-4.02%)` | `3.00 <0.00> (ø)` | |
| [...ap/server/core/alarm/provider/WebhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9XZWJob29rQ2FsbGJhY2suamF2YQ==) | `62.79% <57.14%> (-8.64%)` | `4.00 <0.00> (ø)` | |
| [.../alarm/provider/dingtalk/DingtalkHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9kaW5ndGFsay9EaW5ndGFsa0hvb2tDYWxsYmFjay5qYXZh) | `73.77% <57.14%> (+54.90%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/feishu/FeishuHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9mZWlzaHUvRmVpc2h1SG9va0NhbGxiYWNrLmphdmE=) | `79.48% <57.14%> (+65.20%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `71.73% <57.14%> (+45.42%)` | `3.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `30.23% <0.00%> (-62.63%)` | `3.00% <0.00%> (ø%)` | |
| [...r/receiver/event/grpc/EventGrpcServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctZXZlbnQtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZXZlbnQvZ3JwYy9FdmVudEdycGNTZXJ2aWNlSGFuZGxlci5qYXZh) | `42.30% <0.00%> (-49.36%)` | `2.00% <0.00%> (ø%)` | |
| [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `17.85% <0.00%> (-37.70%)` | `2.00% <0.00%> (ø%)` | |
| [...ient/elasticsearch/ElasticSearchInsertRequest.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaEluc2VydFJlcXVlc3QuamF2YQ==) | `80.00% <0.00%> (-20.00%)` | `2.00% <0.00%> (ø%)` | |
| [...ient/elasticsearch/ElasticSearchUpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaFVwZGF0ZVJlcXVlc3QuamF2YQ==) | `80.00% <0.00%> (-20.00%)` | `2.00% <0.00%> (ø%)` | |
| ... and [1258 more](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=footer). Last update [8c3d167...3573922](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6431: Fix alarm httpclient connection leak
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6431:
URL: https://github.com/apache/skywalking/pull/6431#issuecomment-784759581
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=h1) Report
> Merging [#6431](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=desc) (b7520a5) into [master](https://codecov.io/gh/apache/skywalking/commit/1c52995cbf26fa1442ba6b81fb3c4635625e3702?el=desc) (1c52995) will **increase** coverage by `1.94%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6431 +/- ##
============================================
+ Coverage 56.82% 58.77% +1.94%
+ Complexity 3970 823 -3147
============================================
Files 985 171 -814
Lines 24397 4179 -20218
Branches 2401 482 -1919
============================================
- Hits 13864 2456 -11408
+ Misses 9305 1410 -7895
+ Partials 1228 313 -915
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=) | `38.46% <0.00%> (-25.65%)` | `6.00% <0.00%> (-4.00%)` | |
| [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `69.56% <0.00%> (-17.40%)` | `7.00% <0.00%> (-1.00%)` | |
| [...skywalking/apm/util/PropertyPlaceholderHelper.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUHJvcGVydHlQbGFjZWhvbGRlckhlbHBlci5qYXZh) | `67.60% <0.00%> (-12.68%)` | `11.00% <0.00%> (-4.00%)` | |
| [...m/network/trace/component/command/BaseCommand.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0Jhc2VDb21tYW5kLmphdmE=) | `92.30% <0.00%> (-7.70%)` | `3.00% <0.00%> (-1.00%)` | |
| [...lking/apm/commons/datacarrier/buffer/Channels.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9DaGFubmVscy5qYXZh) | `53.57% <0.00%> (-7.15%)` | `5.00% <0.00%> (-1.00%)` | |
| [.../apm/agent/core/conf/SnifferConfigInitializer.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9TbmlmZmVyQ29uZmlnSW5pdGlhbGl6ZXIuamF2YQ==) | `55.31% <0.00%> (-4.26%)` | `14.00% <0.00%> (-1.00%)` | |
| [...r/tool/profile/exporter/ProfileSnapshotDumper.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3QtYm9vdHN0cmFwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdG9vbC9wcm9maWxlL2V4cG9ydGVyL1Byb2ZpbGVTbmFwc2hvdER1bXBlci5qYXZh) | | | |
| [.../plugin/influxdb/query/NetworkAddressAliasDAO.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9OZXR3b3JrQWRkcmVzc0FsaWFzREFPLmphdmE=) | | | |
| [...ver/receiver/zipkin/analysis/data/ZipkinTrace.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vYW5hbHlzaXMvZGF0YS9aaXBraW5UcmFjZS5qYXZh) | | | |
| [...rver/receiver/otel/OtelMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL290ZWwtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvb3RlbC9PdGVsTWV0cmljUmVjZWl2ZXJQcm92aWRlci5qYXZh) | | | |
| ... and [800 more](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=footer). Last update [665a07c...b7520a5](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6431: Fix alarm httpclient connection leak
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6431:
URL: https://github.com/apache/skywalking/pull/6431#issuecomment-784759581
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=h1) Report
> Merging [#6431](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=desc) (5c8c304) into [master](https://codecov.io/gh/apache/skywalking/commit/8c3d1679e37f992b697835b2402401a26eac19e8?el=desc) (8c3d167) will **increase** coverage by `4.68%`.
> The diff coverage is `11.42%`.
[](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6431 +/- ##
============================================
+ Coverage 51.86% 56.55% +4.68%
- Complexity 3794 4033 +239
============================================
Files 1016 999 -17
Lines 24957 24770 -187
Branches 2447 2414 -33
============================================
+ Hits 12945 14008 +1063
+ Misses 10900 9565 -1335
- Partials 1112 1197 +85
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../alarm/provider/dingtalk/DingtalkHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9kaW5ndGFsay9EaW5ndGFsa0hvb2tDYWxsYmFjay5qYXZh) | `17.24% <0.00%> (-1.63%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/feishu/FeishuHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9mZWlzaHUvRmVpc2h1SG9va0NhbGxiYWNrLmphdmE=) | `13.33% <0.00%> (-0.96%)` | `3.00 <0.00> (ø)` | |
| [...r/core/alarm/provider/slack/SlackhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9zbGFjay9TbGFja2hvb2tDYWxsYmFjay5qYXZh) | `22.91% <0.00%> (-2.67%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.25% <0.00%> (-3.06%)` | `3.00 <0.00> (ø)` | |
| [...ap/server/core/alarm/provider/WebhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9XZWJob29rQ2FsbGJhY2suamF2YQ==) | `67.50% <57.14%> (-3.93%)` | `4.00 <0.00> (ø)` | |
| [...g/oap/server/telemetry/prometheus/BaseMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvQmFzZU1ldHJpY3MuamF2YQ==) | `90.00% <0.00%> (-6.67%)` | `9.00% <0.00%> (-1.00%)` | |
| [...r/telemetry/prometheus/PrometheusGaugeMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c0dhdWdlTWV0cmljcy5qYXZh) | `25.00% <0.00%> (-4.17%)` | `3.00% <0.00%> (-1.00%)` | |
| [...king/oap/meter/analyzer/prometheus/rule/Rules.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9ydWxlL1J1bGVzLmphdmE=) | `66.66% <0.00%> (-4.17%)` | `4.00% <0.00%> (ø%)` | |
| [.../agent/core/profile/ProfileTaskChannelService.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlVGFza0NoYW5uZWxTZXJ2aWNlLmphdmE=) | `51.51% <0.00%> (-3.04%)` | `10.00% <0.00%> (ø%)` | |
| [...king/apm/agent/core/context/ExtensionInjector.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9FeHRlbnNpb25JbmplY3Rvci5qYXZh) | | | |
| ... and [97 more](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=footer). Last update [8c3d167...3573922](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6431: Fix alarm httpclient connection leak
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6431:
URL: https://github.com/apache/skywalking/pull/6431#issuecomment-784759581
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=h1) Report
> Merging [#6431](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=desc) (b8320cc) into [master](https://codecov.io/gh/apache/skywalking/commit/0f8b6d641a963adafd3f4dd2a7388dfd27a626c9?el=desc) (0f8b6d6) will **decrease** coverage by `3.43%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6431 +/- ##
============================================
- Coverage 53.66% 50.22% -3.44%
+ Complexity 4069 3655 -414
============================================
Files 1789 999 -790
Lines 38172 24610 -13562
Branches 4217 2415 -1802
============================================
- Hits 20484 12360 -8124
+ Misses 16688 11152 -5536
- Partials 1000 1098 +98
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/server/core/alarm/provider/WebhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9XZWJob29rQ2FsbGJhY2suamF2YQ==) | `25.00% <0.00%> (-42.57%)` | `2.00 <0.00> (-2.00)` | |
| [.../alarm/provider/dingtalk/DingtalkHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9kaW5ndGFsay9EaW5ndGFsa0hvb2tDYWxsYmFjay5qYXZh) | `15.51% <0.00%> (-62.67%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/feishu/FeishuHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9mZWlzaHUvRmVpc2h1SG9va0NhbGxiYWNrLmphdmE=) | `12.00% <0.00%> (-71.34%)` | `2.00 <0.00> (-1.00)` | |
| [...r/core/alarm/provider/slack/SlackhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9zbGFjay9TbGFja2hvb2tDYWxsYmFjay5qYXZh) | `20.83% <0.00%> (-3.62%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `20.93% <0.00%> (-56.57%)` | `2.00 <0.00> (-1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1277 more](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=footer). Last update [08bceb9...f55956d](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6431: Fix alarm httpclient connection leak
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6431:
URL: https://github.com/apache/skywalking/pull/6431#issuecomment-784759581
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=h1) Report
> Merging [#6431](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=desc) (f55956d) into [master](https://codecov.io/gh/apache/skywalking/commit/0f8b6d641a963adafd3f4dd2a7388dfd27a626c9?el=desc) (0f8b6d6) will **decrease** coverage by `7.47%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6431 +/- ##
============================================
- Coverage 53.66% 46.19% -7.48%
+ Complexity 4069 2780 -1289
============================================
Files 1789 848 -941
Lines 38172 20989 -17183
Branches 4217 2006 -2211
============================================
- Hits 20484 9695 -10789
+ Misses 16688 10575 -6113
+ Partials 1000 719 -281
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/server/core/alarm/provider/WebhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9XZWJob29rQ2FsbGJhY2suamF2YQ==) | `25.00% <0.00%> (-42.57%)` | `2.00 <0.00> (-2.00)` | |
| [.../alarm/provider/dingtalk/DingtalkHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9kaW5ndGFsay9EaW5ndGFsa0hvb2tDYWxsYmFjay5qYXZh) | `15.51% <0.00%> (-62.67%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/feishu/FeishuHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9mZWlzaHUvRmVpc2h1SG9va0NhbGxiYWNrLmphdmE=) | `12.00% <0.00%> (-71.34%)` | `2.00 <0.00> (-1.00)` | |
| [...r/core/alarm/provider/slack/SlackhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9zbGFjay9TbGFja2hvb2tDYWxsYmFjay5qYXZh) | `20.83% <0.00%> (-3.62%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `20.93% <0.00%> (-56.57%)` | `2.00 <0.00> (-1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...lking/oap/server/analyzer/event/EventAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L0V2ZW50QW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| ... and [1358 more](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=footer). Last update [08bceb9...f55956d](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6431: Fix alarm httpclient connection leak
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6431:
URL: https://github.com/apache/skywalking/pull/6431#issuecomment-784759581
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=h1) Report
> Merging [#6431](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=desc) (5c8c304) into [master](https://codecov.io/gh/apache/skywalking/commit/8c3d1679e37f992b697835b2402401a26eac19e8?el=desc) (8c3d167) will **decrease** coverage by `1.78%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6431 +/- ##
============================================
- Coverage 51.80% 50.02% -1.79%
+ Complexity 3788 3619 -169
============================================
Files 1016 999 -17
Lines 24957 24600 -357
Branches 2447 2399 -48
============================================
- Hits 12930 12305 -625
- Misses 10913 11231 +318
+ Partials 1114 1064 -50
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/server/core/alarm/provider/WebhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9XZWJob29rQ2FsbGJhY2suamF2YQ==) | `25.00% <0.00%> (-46.43%)` | `2.00 <0.00> (-2.00)` | |
| [.../alarm/provider/dingtalk/DingtalkHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9kaW5ndGFsay9EaW5ndGFsa0hvb2tDYWxsYmFjay5qYXZh) | `15.51% <0.00%> (-3.36%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/feishu/FeishuHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9mZWlzaHUvRmVpc2h1SG9va0NhbGxiYWNrLmphdmE=) | `12.00% <0.00%> (-2.29%)` | `2.00 <0.00> (-1.00)` | |
| [...r/core/alarm/provider/slack/SlackhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9zbGFjay9TbGFja2hvb2tDYWxsYmFjay5qYXZh) | `20.83% <0.00%> (-4.75%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `20.93% <0.00%> (-5.39%)` | `2.00 <0.00> (-1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [.../provider/parser/performance/PerfDataAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL3BhcnNlci9wZXJmb3JtYW5jZS9QZXJmRGF0YUFuYWx5emVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...ovider/parser/errorlog/listener/SourceBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL3BhcnNlci9lcnJvcmxvZy9saXN0ZW5lci9Tb3VyY2VCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| ... and [144 more](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=footer). Last update [8c3d167...3573922](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6431: Fix alarm httpclient connection leak
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6431:
URL: https://github.com/apache/skywalking/pull/6431#issuecomment-784759581
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=h1) Report
> Merging [#6431](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=desc) (5c8c304) into [master](https://codecov.io/gh/apache/skywalking/commit/8c3d1679e37f992b697835b2402401a26eac19e8?el=desc) (8c3d167) will **increase** coverage by `0.07%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6431 +/- ##
============================================
+ Coverage 45.34% 45.42% +0.07%
+ Complexity 3454 2752 -702
============================================
Files 1016 848 -168
Lines 24860 20957 -3903
Branches 2421 1987 -434
============================================
- Hits 11273 9519 -1754
+ Misses 12608 10712 -1896
+ Partials 979 726 -253
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/server/core/alarm/provider/WebhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9XZWJob29rQ2FsbGJhY2suamF2YQ==) | `25.00% <0.00%> (-3.58%)` | `2.00 <0.00> (ø)` | |
| [.../alarm/provider/dingtalk/DingtalkHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9kaW5ndGFsay9EaW5ndGFsa0hvb2tDYWxsYmFjay5qYXZh) | `15.51% <0.00%> (-1.47%)` | `2.00 <0.00> (ø)` | |
| [...core/alarm/provider/feishu/FeishuHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9mZWlzaHUvRmVpc2h1SG9va0NhbGxiYWNrLmphdmE=) | `12.00% <0.00%> (-0.86%)` | `2.00 <0.00> (ø)` | |
| [...r/core/alarm/provider/slack/SlackhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9zbGFjay9TbGFja2hvb2tDYWxsYmFjay5qYXZh) | `20.83% <0.00%> (-2.43%)` | `2.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `20.93% <0.00%> (-2.76%)` | `2.00 <0.00> (ø)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [.../provider/parser/performance/PerfDataAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL3BhcnNlci9wZXJmb3JtYW5jZS9QZXJmRGF0YUFuYWx5emVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...ovider/parser/errorlog/listener/SourceBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL3BhcnNlci9lcnJvcmxvZy9saXN0ZW5lci9Tb3VyY2VCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=) | `0.00% <0.00%> (-98.86%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [279 more](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=footer). Last update [8c3d167...3573922](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6431: Fix alarm httpclient connection leak
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6431:
URL: https://github.com/apache/skywalking/pull/6431#issuecomment-784759581
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=h1) Report
> Merging [#6431](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=desc) (5c8c304) into [master](https://codecov.io/gh/apache/skywalking/commit/8c3d1679e37f992b697835b2402401a26eac19e8?el=desc) (8c3d167) will **increase** coverage by `4.72%`.
> The diff coverage is `11.42%`.
[](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6431 +/- ##
============================================
+ Coverage 51.86% 56.59% +4.72%
- Complexity 3794 4038 +244
============================================
Files 1016 999 -17
Lines 24957 24770 -187
Branches 2447 2414 -33
============================================
+ Hits 12945 14019 +1074
+ Misses 10900 9557 -1343
- Partials 1112 1194 +82
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../alarm/provider/dingtalk/DingtalkHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9kaW5ndGFsay9EaW5ndGFsa0hvb2tDYWxsYmFjay5qYXZh) | `17.24% <0.00%> (-1.63%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/feishu/FeishuHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9mZWlzaHUvRmVpc2h1SG9va0NhbGxiYWNrLmphdmE=) | `13.33% <0.00%> (-0.96%)` | `3.00 <0.00> (ø)` | |
| [...r/core/alarm/provider/slack/SlackhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9zbGFjay9TbGFja2hvb2tDYWxsYmFjay5qYXZh) | `22.91% <0.00%> (-2.67%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.25% <0.00%> (-3.06%)` | `3.00 <0.00> (ø)` | |
| [...ap/server/core/alarm/provider/WebhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9XZWJob29rQ2FsbGJhY2suamF2YQ==) | `67.50% <57.14%> (-3.93%)` | `4.00 <0.00> (ø)` | |
| [...king/oap/meter/analyzer/prometheus/rule/Rules.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9ydWxlL1J1bGVzLmphdmE=) | `66.66% <0.00%> (-4.17%)` | `4.00% <0.00%> (ø%)` | |
| [.../agent/core/profile/ProfileTaskChannelService.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlVGFza0NoYW5uZWxTZXJ2aWNlLmphdmE=) | `51.51% <0.00%> (-3.04%)` | `10.00% <0.00%> (ø%)` | |
| [...ore/plugin/bootstrap/BootstrapPluginLogBridge.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2Jvb3RzdHJhcC9Cb290c3RyYXBQbHVnaW5Mb2dCcmlkZ2UuamF2YQ==) | | | |
| [...ng/apm/agent/core/context/trace/LogDataEntity.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2dEYXRhRW50aXR5LmphdmE=) | | | |
| [...t/core/plugin/bytebuddy/ArgumentTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9Bcmd1bWVudFR5cGVOYW1lTWF0Y2guamF2YQ==) | | | |
| ... and [99 more](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=footer). Last update [8c3d167...3573922](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6431: Fix alarm httpclient connection leak
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6431:
URL: https://github.com/apache/skywalking/pull/6431#issuecomment-784759581
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=h1) Report
> Merging [#6431](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=desc) (3573922) into [master](https://codecov.io/gh/apache/skywalking/commit/8c3d1679e37f992b697835b2402401a26eac19e8?el=desc) (8c3d167) will **decrease** coverage by `11.31%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6431 +/- ##
=============================================
- Coverage 46.77% 35.45% -11.32%
+ Complexity 3516 2179 -1337
=============================================
Files 1016 831 -185
Lines 24879 20405 -4474
Branches 2440 1945 -495
=============================================
- Hits 11636 7235 -4401
- Misses 12240 12626 +386
+ Partials 1003 544 -459
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/server/core/alarm/provider/WebhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9XZWJob29rQ2FsbGJhY2suamF2YQ==) | `25.00% <0.00%> (-3.58%)` | `2.00 <0.00> (ø)` | |
| [.../alarm/provider/dingtalk/DingtalkHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9kaW5ndGFsay9EaW5ndGFsa0hvb2tDYWxsYmFjay5qYXZh) | `15.51% <0.00%> (-1.47%)` | `2.00 <0.00> (ø)` | |
| [...core/alarm/provider/feishu/FeishuHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9mZWlzaHUvRmVpc2h1SG9va0NhbGxiYWNrLmphdmE=) | `12.00% <0.00%> (-0.86%)` | `2.00 <0.00> (ø)` | |
| [...r/core/alarm/provider/slack/SlackhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9zbGFjay9TbGFja2hvb2tDYWxsYmFjay5qYXZh) | `20.83% <0.00%> (-2.43%)` | `2.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `20.93% <0.00%> (-2.76%)` | `2.00 <0.00> (ø)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...ient/elasticsearch/ElasticSearchInsertRequest.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaEluc2VydFJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...erver/storage/plugin/elasticsearch/base/EsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9Fc0RBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| ... and [354 more](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=footer). Last update [8c3d167...3573922](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6431: Fix alarm httpclient connection leak
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6431:
URL: https://github.com/apache/skywalking/pull/6431#issuecomment-784759581
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=h1) Report
> Merging [#6431](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=desc) (5c8c304) into [master](https://codecov.io/gh/apache/skywalking/commit/8c3d1679e37f992b697835b2402401a26eac19e8?el=desc) (8c3d167) will **increase** coverage by `1.30%`.
> The diff coverage is `45.71%`.
[](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6431 +/- ##
============================================
+ Coverage 51.86% 53.17% +1.30%
- Complexity 3794 4041 +247
============================================
Files 1016 1789 +773
Lines 24957 38202 +13245
Branches 2447 4222 +1775
============================================
+ Hits 12945 20315 +7370
- Misses 10900 16891 +5991
+ Partials 1112 996 -116
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/alarm/provider/slack/SlackhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9zbGFjay9TbGFja2hvb2tDYWxsYmFjay5qYXZh) | `21.56% <0.00%> (-4.02%)` | `3.00 <0.00> (ø)` | |
| [...ap/server/core/alarm/provider/WebhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9XZWJob29rQ2FsbGJhY2suamF2YQ==) | `62.79% <57.14%> (-8.64%)` | `4.00 <0.00> (ø)` | |
| [.../alarm/provider/dingtalk/DingtalkHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9kaW5ndGFsay9EaW5ndGFsa0hvb2tDYWxsYmFjay5qYXZh) | `73.77% <57.14%> (+54.90%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/feishu/FeishuHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9mZWlzaHUvRmVpc2h1SG9va0NhbGxiYWNrLmphdmE=) | `79.48% <57.14%> (+65.20%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `71.73% <57.14%> (+45.42%)` | `3.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `30.23% <0.00%> (-62.63%)` | `3.00% <0.00%> (ø%)` | |
| [...r/receiver/event/grpc/EventGrpcServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctZXZlbnQtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZXZlbnQvZ3JwYy9FdmVudEdycGNTZXJ2aWNlSGFuZGxlci5qYXZh) | `42.30% <0.00%> (-49.36%)` | `2.00% <0.00%> (ø%)` | |
| [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `17.85% <0.00%> (-37.70%)` | `2.00% <0.00%> (ø%)` | |
| [...ient/elasticsearch/ElasticSearchInsertRequest.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaEluc2VydFJlcXVlc3QuamF2YQ==) | `80.00% <0.00%> (-20.00%)` | `2.00% <0.00%> (ø%)` | |
| [...ient/elasticsearch/ElasticSearchUpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaFVwZGF0ZVJlcXVlc3QuamF2YQ==) | `80.00% <0.00%> (-20.00%)` | `2.00% <0.00%> (ø%)` | |
| ... and [1258 more](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=footer). Last update [8c3d167...3573922](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6431: Fix alarm httpclient connection leak
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6431:
URL: https://github.com/apache/skywalking/pull/6431#issuecomment-784759581
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=h1) Report
> Merging [#6431](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=desc) (f55956d) into [master](https://codecov.io/gh/apache/skywalking/commit/0f8b6d641a963adafd3f4dd2a7388dfd27a626c9?el=desc) (0f8b6d6) will **decrease** coverage by `3.80%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6431 +/- ##
============================================
- Coverage 53.66% 49.85% -3.81%
+ Complexity 4069 3631 -438
============================================
Files 1789 998 -791
Lines 38172 24694 -13478
Branches 4217 2422 -1795
============================================
- Hits 20484 12311 -8173
+ Misses 16688 11358 -5330
- Partials 1000 1025 +25
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/server/core/alarm/provider/WebhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9XZWJob29rQ2FsbGJhY2suamF2YQ==) | `25.00% <0.00%> (-42.57%)` | `2.00 <0.00> (-2.00)` | |
| [.../alarm/provider/dingtalk/DingtalkHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9kaW5ndGFsay9EaW5ndGFsa0hvb2tDYWxsYmFjay5qYXZh) | `15.51% <0.00%> (-62.67%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/feishu/FeishuHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9mZWlzaHUvRmVpc2h1SG9va0NhbGxiYWNrLmphdmE=) | `12.00% <0.00%> (-71.34%)` | `2.00 <0.00> (-1.00)` | |
| [...r/core/alarm/provider/slack/SlackhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9zbGFjay9TbGFja2hvb2tDYWxsYmFjay5qYXZh) | `20.83% <0.00%> (-3.62%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `20.93% <0.00%> (-56.57%)` | `2.00 <0.00> (-1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1282 more](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=footer). Last update [08bceb9...f55956d](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6431: Fix alarm httpclient connection leak
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6431:
URL: https://github.com/apache/skywalking/pull/6431#issuecomment-784759581
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=h1) Report
> Merging [#6431](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=desc) (3573922) into [master](https://codecov.io/gh/apache/skywalking/commit/8c3d1679e37f992b697835b2402401a26eac19e8?el=desc) (8c3d167) will **decrease** coverage by `7.51%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6431 +/- ##
============================================
- Coverage 51.82% 44.30% -7.52%
+ Complexity 3791 3346 -445
============================================
Files 1016 999 -17
Lines 24957 24602 -355
Branches 2447 2413 -34
============================================
- Hits 12935 10901 -2034
- Misses 10912 12775 +1863
+ Partials 1110 926 -184
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/server/core/alarm/provider/WebhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9XZWJob29rQ2FsbGJhY2suamF2YQ==) | `25.00% <0.00%> (-46.43%)` | `2.00 <0.00> (-2.00)` | |
| [.../alarm/provider/dingtalk/DingtalkHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9kaW5ndGFsay9EaW5ndGFsa0hvb2tDYWxsYmFjay5qYXZh) | `15.51% <0.00%> (-3.36%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/feishu/FeishuHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9mZWlzaHUvRmVpc2h1SG9va0NhbGxiYWNrLmphdmE=) | `12.00% <0.00%> (-2.29%)` | `2.00 <0.00> (-1.00)` | |
| [...r/core/alarm/provider/slack/SlackhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9zbGFjay9TbGFja2hvb2tDYWxsYmFjay5qYXZh) | `20.83% <0.00%> (-4.75%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `20.93% <0.00%> (-5.39%)` | `2.00 <0.00> (-1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...server/storage/plugin/influxdb/base/RecordDAO.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL1JlY29yZERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-7.00%)` | |
| [...er/storage/plugin/influxdb/base/NoneStreamDAO.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL05vbmVTdHJlYW1EQU8uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...storage/plugin/influxdb/base/InfluxStorageDAO.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL0luZmx1eFN0b3JhZ2VEQU8uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| ... and [192 more](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=footer). Last update [8c3d167...3573922](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6431: Fix alarm httpclient connection leak
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6431:
URL: https://github.com/apache/skywalking/pull/6431#issuecomment-784759581
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=h1) Report
> Merging [#6431](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=desc) (b7520a5) into [master](https://codecov.io/gh/apache/skywalking/commit/1c52995cbf26fa1442ba6b81fb3c4635625e3702?el=desc) (1c52995) will **decrease** coverage by `11.58%`.
> The diff coverage is `41.81%`.
[](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6431 +/- ##
=============================================
- Coverage 56.82% 45.23% -11.59%
+ Complexity 3970 3367 -603
=============================================
Files 985 999 +14
Lines 24397 24577 +180
Branches 2401 2410 +9
=============================================
- Hits 13864 11118 -2746
- Misses 9305 12500 +3195
+ Partials 1228 959 -269
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/log/analyzer/dsl/spec/sink/sampler/Sampler.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvU2FtcGxlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ap/server/core/alarm/provider/WebhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9XZWJob29rQ2FsbGJhY2suamF2YQ==) | `25.00% <0.00%> (-46.43%)` | `2.00 <0.00> (-2.00)` | |
| [.../alarm/provider/dingtalk/DingtalkHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9kaW5ndGFsay9EaW5ndGFsa0hvb2tDYWxsYmFjay5qYXZh) | `16.98% <0.00%> (-1.89%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/feishu/FeishuHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9mZWlzaHUvRmVpc2h1SG9va0NhbGxiYWNrLmphdmE=) | `12.85% <0.00%> (-1.43%)` | `2.00 <0.00> (-1.00)` | |
| [...r/core/alarm/provider/slack/SlackhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9zbGFjay9TbGFja2hvb2tDYWxsYmFjay5qYXZh) | `20.83% <0.00%> (-4.75%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <0.00%> (-2.64%)` | `2.00 <0.00> (-1.00)` | |
| [...zer/dsl/spec/sink/sampler/RateLimitingSampler.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvUmF0ZUxpbWl0aW5nU2FtcGxlci5qYXZh) | `12.12% <12.12%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `18.51% <18.51%> (ø)` | `2.00 <2.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `18.75% <18.75%> (ø)` | `1.00 <1.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `26.43% <26.43%> (ø)` | `4.00 <4.00> (?)` | |
| ... and [217 more](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=footer). Last update [665a07c...b7520a5](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6431: Fix alarm httpclient connection leak
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6431:
URL: https://github.com/apache/skywalking/pull/6431#issuecomment-784759581
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=h1) Report
> Merging [#6431](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=desc) (3573922) into [master](https://codecov.io/gh/apache/skywalking/commit/8c3d1679e37f992b697835b2402401a26eac19e8?el=desc) (8c3d167) will **decrease** coverage by `12.85%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6431 +/- ##
=============================================
- Coverage 51.82% 38.97% -12.86%
+ Complexity 3791 2381 -1410
=============================================
Files 1016 831 -185
Lines 24957 20439 -4518
Branches 2447 1951 -496
=============================================
- Hits 12935 7966 -4969
- Misses 10912 11887 +975
+ Partials 1110 586 -524
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/server/core/alarm/provider/WebhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9XZWJob29rQ2FsbGJhY2suamF2YQ==) | `25.00% <0.00%> (-46.43%)` | `2.00 <0.00> (-2.00)` | |
| [.../alarm/provider/dingtalk/DingtalkHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9kaW5ndGFsay9EaW5ndGFsa0hvb2tDYWxsYmFjay5qYXZh) | `15.51% <0.00%> (-3.36%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/feishu/FeishuHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9mZWlzaHUvRmVpc2h1SG9va0NhbGxiYWNrLmphdmE=) | `12.00% <0.00%> (-2.29%)` | `2.00 <0.00> (-1.00)` | |
| [...r/core/alarm/provider/slack/SlackhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9zbGFjay9TbGFja2hvb2tDYWxsYmFjay5qYXZh) | `20.83% <0.00%> (-4.75%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `20.93% <0.00%> (-5.39%)` | `2.00 <0.00> (-1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...server/storage/plugin/influxdb/base/RecordDAO.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL1JlY29yZERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-7.00%)` | |
| ... and [378 more](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=footer). Last update [8c3d167...3573922](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6431: Fix alarm httpclient connection leak
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6431:
URL: https://github.com/apache/skywalking/pull/6431#issuecomment-784759581
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=h1) Report
> Merging [#6431](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=desc) (5c8c304) into [master](https://codecov.io/gh/apache/skywalking/commit/8c3d1679e37f992b697835b2402401a26eac19e8?el=desc) (8c3d167) will **increase** coverage by `0.55%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6431 +/- ##
============================================
+ Coverage 51.86% 52.42% +0.55%
+ Complexity 3794 3783 -11
============================================
Files 1016 999 -17
Lines 24957 24618 -339
Branches 2447 2400 -47
============================================
- Hits 12945 12905 -40
+ Misses 10900 10564 -336
- Partials 1112 1149 +37
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/server/core/alarm/provider/WebhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9XZWJob29rQ2FsbGJhY2suamF2YQ==) | `25.00% <0.00%> (-46.43%)` | `2.00 <0.00> (-2.00)` | |
| [.../alarm/provider/dingtalk/DingtalkHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9kaW5ndGFsay9EaW5ndGFsa0hvb2tDYWxsYmFjay5qYXZh) | `15.51% <0.00%> (-3.36%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/feishu/FeishuHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9mZWlzaHUvRmVpc2h1SG9va0NhbGxiYWNrLmphdmE=) | `12.00% <0.00%> (-2.29%)` | `2.00 <0.00> (-1.00)` | |
| [...r/core/alarm/provider/slack/SlackhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9zbGFjay9TbGFja2hvb2tDYWxsYmFjay5qYXZh) | `20.83% <0.00%> (-4.75%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `20.93% <0.00%> (-5.39%)` | `2.00 <0.00> (-1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh) | `4.65% <0.00%> (-89.54%)` | `1.00% <0.00%> (-10.00%)` | |
| [...tworkalias/NetworkAddressAliasSetupDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzU2V0dXBEaXNwYXRjaGVyLmphdmE=) | `11.11% <0.00%> (-88.89%)` | `1.00% <0.00%> (-1.00%)` | |
| [...lugin/elasticsearch/query/ProfileTaskLogEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRhc2tMb2dFc0RBTy5qYXZh) | `13.63% <0.00%> (-86.37%)` | `1.00% <0.00%> (-3.00%)` | |
| [...er/core/server/auth/AuthenticationInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL2F1dGgvQXV0aGVudGljYXRpb25JbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (-84.62%)` | `0.00% <0.00%> (-4.00%)` | |
| ... and [131 more](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=footer). Last update [8c3d167...3573922](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6431: Fix alarm httpclient connection leak
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6431:
URL: https://github.com/apache/skywalking/pull/6431#issuecomment-784759581
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=h1) Report
> Merging [#6431](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=desc) (b7520a5) into [master](https://codecov.io/gh/apache/skywalking/commit/1c52995cbf26fa1442ba6b81fb3c4635625e3702?el=desc) (1c52995) will **decrease** coverage by `1.18%`.
> The diff coverage is `42.85%`.
[](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6431 +/- ##
============================================
- Coverage 56.82% 55.64% -1.19%
- Complexity 3970 3986 +16
============================================
Files 985 999 +14
Lines 24397 24760 +363
Branches 2401 2425 +24
============================================
- Hits 13864 13777 -87
- Misses 9305 9811 +506
+ Partials 1228 1172 -56
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/log/analyzer/dsl/spec/sink/sampler/Sampler.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvU2FtcGxlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../alarm/provider/dingtalk/DingtalkHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9kaW5ndGFsay9EaW5ndGFsa0hvb2tDYWxsYmFjay5qYXZh) | `18.86% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/feishu/FeishuHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9mZWlzaHUvRmVpc2h1SG9va0NhbGxiYWNrLmphdmE=) | `14.28% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...r/core/alarm/provider/slack/SlackhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9zbGFjay9TbGFja2hvb2tDYWxsYmFjay5qYXZh) | `22.91% <0.00%> (-2.67%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `26.31% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...zer/dsl/spec/sink/sampler/RateLimitingSampler.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvUmF0ZUxpbWl0aW5nU2FtcGxlci5qYXZh) | `12.12% <12.12%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `18.51% <18.51%> (ø)` | `2.00 <2.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `18.75% <18.75%> (ø)` | `1.00 <1.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `26.43% <26.43%> (ø)` | `4.00 <4.00> (?)` | |
| [...g/analyzer/provider/LogAnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9Mb2dBbmFseXplck1vZHVsZVByb3ZpZGVyLmphdmE=) | `86.66% <50.00%> (-13.34%)` | `8.00 <1.00> (ø)` | |
| ... and [93 more](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=footer). Last update [665a07c...b7520a5](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6431: Fix alarm httpclient connection leak
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6431:
URL: https://github.com/apache/skywalking/pull/6431#issuecomment-784759581
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=h1) Report
> Merging [#6431](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=desc) (b7520a5) into [master](https://codecov.io/gh/apache/skywalking/commit/1c52995cbf26fa1442ba6b81fb3c4635625e3702?el=desc) (1c52995) will **decrease** coverage by `4.65%`.
> The diff coverage is `41.81%`.
[](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6431 +/- ##
============================================
- Coverage 56.82% 52.17% -4.66%
+ Complexity 3970 3759 -211
============================================
Files 985 999 +14
Lines 24397 24618 +221
Branches 2401 2411 +10
============================================
- Hits 13864 12844 -1020
- Misses 9305 10671 +1366
+ Partials 1228 1103 -125
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/log/analyzer/dsl/spec/sink/sampler/Sampler.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvU2FtcGxlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ap/server/core/alarm/provider/WebhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9XZWJob29rQ2FsbGJhY2suamF2YQ==) | `25.00% <0.00%> (-46.43%)` | `2.00 <0.00> (-2.00)` | |
| [.../alarm/provider/dingtalk/DingtalkHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9kaW5ndGFsay9EaW5ndGFsa0hvb2tDYWxsYmFjay5qYXZh) | `16.98% <0.00%> (-1.89%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/feishu/FeishuHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9mZWlzaHUvRmVpc2h1SG9va0NhbGxiYWNrLmphdmE=) | `12.85% <0.00%> (-1.43%)` | `2.00 <0.00> (-1.00)` | |
| [...r/core/alarm/provider/slack/SlackhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9zbGFjay9TbGFja2hvb2tDYWxsYmFjay5qYXZh) | `20.83% <0.00%> (-4.75%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <0.00%> (-2.64%)` | `2.00 <0.00> (-1.00)` | |
| [...zer/dsl/spec/sink/sampler/RateLimitingSampler.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvUmF0ZUxpbWl0aW5nU2FtcGxlci5qYXZh) | `12.12% <12.12%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `18.51% <18.51%> (ø)` | `2.00 <2.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `18.75% <18.75%> (ø)` | `1.00 <1.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `26.43% <26.43%> (ø)` | `4.00 <4.00> (?)` | |
| ... and [139 more](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=footer). Last update [665a07c...b7520a5](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6431: Fix alarm httpclient connection leak
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6431:
URL: https://github.com/apache/skywalking/pull/6431#issuecomment-784759581
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6431: Fix alarm httpclient connection leak
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6431:
URL: https://github.com/apache/skywalking/pull/6431#issuecomment-784759581
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=h1) Report
> Merging [#6431](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=desc) (b7520a5) into [master](https://codecov.io/gh/apache/skywalking/commit/1c52995cbf26fa1442ba6b81fb3c4635625e3702?el=desc) (1c52995) will **decrease** coverage by `4.30%`.
> The diff coverage is `41.81%`.
[](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6431 +/- ##
============================================
- Coverage 56.82% 52.52% -4.31%
+ Complexity 3970 3790 -180
============================================
Files 985 999 +14
Lines 24397 24646 +249
Branches 2401 2416 +15
============================================
- Hits 13864 12945 -919
- Misses 9305 10593 +1288
+ Partials 1228 1108 -120
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/log/analyzer/dsl/spec/sink/sampler/Sampler.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvU2FtcGxlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ap/server/core/alarm/provider/WebhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9XZWJob29rQ2FsbGJhY2suamF2YQ==) | `25.00% <0.00%> (-46.43%)` | `2.00 <0.00> (-2.00)` | |
| [.../alarm/provider/dingtalk/DingtalkHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9kaW5ndGFsay9EaW5ndGFsa0hvb2tDYWxsYmFjay5qYXZh) | `16.98% <0.00%> (-1.89%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/feishu/FeishuHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9mZWlzaHUvRmVpc2h1SG9va0NhbGxiYWNrLmphdmE=) | `12.85% <0.00%> (-1.43%)` | `2.00 <0.00> (-1.00)` | |
| [...r/core/alarm/provider/slack/SlackhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9zbGFjay9TbGFja2hvb2tDYWxsYmFjay5qYXZh) | `20.83% <0.00%> (-4.75%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <0.00%> (-2.64%)` | `2.00 <0.00> (-1.00)` | |
| [...zer/dsl/spec/sink/sampler/RateLimitingSampler.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvUmF0ZUxpbWl0aW5nU2FtcGxlci5qYXZh) | `12.12% <12.12%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `18.51% <18.51%> (ø)` | `2.00 <2.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `18.75% <18.75%> (ø)` | `1.00 <1.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `26.43% <26.43%> (ø)` | `4.00 <4.00> (?)` | |
| ... and [145 more](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=footer). Last update [665a07c...b7520a5](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6431: Fix alarm httpclient connection leak
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6431:
URL: https://github.com/apache/skywalking/pull/6431#issuecomment-784759581
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=h1) Report
> Merging [#6431](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=desc) (700fa56) into [master](https://codecov.io/gh/apache/skywalking/commit/1c52995cbf26fa1442ba6b81fb3c4635625e3702?el=desc) (1c52995) will **decrease** coverage by `12.45%`.
> The diff coverage is `41.81%`.
[](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6431 +/- ##
=============================================
- Coverage 56.82% 44.37% -12.46%
+ Complexity 3970 2753 -1217
=============================================
Files 985 848 -137
Lines 24397 20953 -3444
Branches 2401 1986 -415
=============================================
- Hits 13864 9297 -4567
- Misses 9305 10926 +1621
+ Partials 1228 730 -498
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/log/analyzer/dsl/spec/sink/sampler/Sampler.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvU2FtcGxlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ap/server/core/alarm/provider/WebhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9XZWJob29rQ2FsbGJhY2suamF2YQ==) | `25.00% <0.00%> (-46.43%)` | `2.00 <0.00> (-2.00)` | |
| [.../alarm/provider/dingtalk/DingtalkHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9kaW5ndGFsay9EaW5ndGFsa0hvb2tDYWxsYmFjay5qYXZh) | `16.98% <0.00%> (-1.89%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/feishu/FeishuHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9mZWlzaHUvRmVpc2h1SG9va0NhbGxiYWNrLmphdmE=) | `12.85% <0.00%> (-1.43%)` | `2.00 <0.00> (-1.00)` | |
| [...r/core/alarm/provider/slack/SlackhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9zbGFjay9TbGFja2hvb2tDYWxsYmFjay5qYXZh) | `20.83% <0.00%> (-4.75%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <0.00%> (-2.64%)` | `2.00 <0.00> (-1.00)` | |
| [...zer/dsl/spec/sink/sampler/RateLimitingSampler.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvUmF0ZUxpbWl0aW5nU2FtcGxlci5qYXZh) | `12.12% <12.12%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `18.51% <18.51%> (ø)` | `2.00 <2.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `18.75% <18.75%> (ø)` | `1.00 <1.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `26.43% <26.43%> (ø)` | `4.00 <4.00> (?)` | |
| ... and [349 more](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=footer). Last update [665a07c...b7520a5](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6431: Fix alarm httpclient connection leak
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6431:
URL: https://github.com/apache/skywalking/pull/6431#issuecomment-784759581
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=h1) Report
> Merging [#6431](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=desc) (b8320cc) into [master](https://codecov.io/gh/apache/skywalking/commit/0f8b6d641a963adafd3f4dd2a7388dfd27a626c9?el=desc) (0f8b6d6) will **decrease** coverage by `2.83%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6431 +/- ##
============================================
- Coverage 53.66% 50.82% -2.84%
+ Complexity 4069 3694 -375
============================================
Files 1789 999 -790
Lines 38172 24623 -13549
Branches 4217 2415 -1802
============================================
- Hits 20484 12515 -7969
+ Misses 16688 11001 -5687
- Partials 1000 1107 +107
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/server/core/alarm/provider/WebhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9XZWJob29rQ2FsbGJhY2suamF2YQ==) | `25.00% <0.00%> (-42.57%)` | `2.00 <0.00> (-2.00)` | |
| [.../alarm/provider/dingtalk/DingtalkHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9kaW5ndGFsay9EaW5ndGFsa0hvb2tDYWxsYmFjay5qYXZh) | `15.51% <0.00%> (-62.67%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/feishu/FeishuHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9mZWlzaHUvRmVpc2h1SG9va0NhbGxiYWNrLmphdmE=) | `12.00% <0.00%> (-71.34%)` | `2.00 <0.00> (-1.00)` | |
| [...r/core/alarm/provider/slack/SlackhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9zbGFjay9TbGFja2hvb2tDYWxsYmFjay5qYXZh) | `20.83% <0.00%> (-3.62%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `20.93% <0.00%> (-56.57%)` | `2.00 <0.00> (-1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1269 more](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=footer). Last update [08bceb9...f55956d](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6431: Fix alarm httpclient connection leak
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6431:
URL: https://github.com/apache/skywalking/pull/6431#issuecomment-784759581
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=h1) Report
> Merging [#6431](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=desc) (b8320cc) into [master](https://codecov.io/gh/apache/skywalking/commit/0f8b6d641a963adafd3f4dd2a7388dfd27a626c9?el=desc) (0f8b6d6) will **decrease** coverage by `3.45%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6431 +/- ##
============================================
- Coverage 53.66% 50.21% -3.46%
+ Complexity 4069 3653 -416
============================================
Files 1789 999 -790
Lines 38172 24610 -13562
Branches 4217 2415 -1802
============================================
- Hits 20484 12357 -8127
+ Misses 16688 11155 -5533
- Partials 1000 1098 +98
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/server/core/alarm/provider/WebhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9XZWJob29rQ2FsbGJhY2suamF2YQ==) | `25.00% <0.00%> (-42.57%)` | `2.00 <0.00> (-2.00)` | |
| [.../alarm/provider/dingtalk/DingtalkHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9kaW5ndGFsay9EaW5ndGFsa0hvb2tDYWxsYmFjay5qYXZh) | `15.51% <0.00%> (-62.67%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/feishu/FeishuHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9mZWlzaHUvRmVpc2h1SG9va0NhbGxiYWNrLmphdmE=) | `12.00% <0.00%> (-71.34%)` | `2.00 <0.00> (-1.00)` | |
| [...r/core/alarm/provider/slack/SlackhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9zbGFjay9TbGFja2hvb2tDYWxsYmFjay5qYXZh) | `20.83% <0.00%> (-3.62%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `20.93% <0.00%> (-56.57%)` | `2.00 <0.00> (-1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1278 more](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=footer). Last update [08bceb9...f55956d](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6431: Fix alarm httpclient connection leak
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6431:
URL: https://github.com/apache/skywalking/pull/6431#issuecomment-784759581
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=h1) Report
> Merging [#6431](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=desc) (f55956d) into [master](https://codecov.io/gh/apache/skywalking/commit/0f8b6d641a963adafd3f4dd2a7388dfd27a626c9?el=desc) (0f8b6d6) will **decrease** coverage by `2.86%`.
> The diff coverage is `45.71%`.
[](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6431 +/- ##
============================================
- Coverage 53.66% 50.80% -2.87%
+ Complexity 4069 3836 -233
============================================
Files 1789 1789
Lines 38172 38202 +30
Branches 4217 4223 +6
============================================
- Hits 20484 19407 -1077
- Misses 16688 17792 +1104
- Partials 1000 1003 +3
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/alarm/provider/slack/SlackhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9zbGFjay9TbGFja2hvb2tDYWxsYmFjay5qYXZh) | `21.56% <0.00%> (-2.88%)` | `3.00 <0.00> (ø)` | |
| [...ap/server/core/alarm/provider/WebhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9XZWJob29rQ2FsbGJhY2suamF2YQ==) | `62.79% <57.14%> (-4.78%)` | `4.00 <0.00> (ø)` | |
| [.../alarm/provider/dingtalk/DingtalkHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9kaW5ndGFsay9EaW5ndGFsa0hvb2tDYWxsYmFjay5qYXZh) | `73.77% <57.14%> (-4.42%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/feishu/FeishuHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9mZWlzaHUvRmVpc2h1SG9va0NhbGxiYWNrLmphdmE=) | `79.48% <57.14%> (-3.85%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `71.73% <57.14%> (-5.77%)` | `3.00 <0.00> (ø)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lking/oap/server/analyzer/event/EventAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L0V2ZW50QW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...n/jdbc/postgresql/dao/PostgreSQLTraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvcG9zdGdyZXNxbC9kYW8vUG9zdGdyZVNRTFRyYWNlUXVlcnlEQU8uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...in/influxdb/query/UITemplateManagementDAOImpl.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9VSVRlbXBsYXRlTWFuYWdlbWVudERBT0ltcGwuamF2YQ==) | `1.75% <0.00%> (-85.97%)` | `1.00% <0.00%> (-6.00%)` | |
| ... and [66 more](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=footer). Last update [08bceb9...f55956d](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6431: Fix alarm httpclient connection leak
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6431:
URL: https://github.com/apache/skywalking/pull/6431#issuecomment-784759581
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=h1) Report
> Merging [#6431](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=desc) (b7520a5) into [master](https://codecov.io/gh/apache/skywalking/commit/1c52995cbf26fa1442ba6b81fb3c4635625e3702?el=desc) (1c52995) will **decrease** coverage by `0.89%`.
> The diff coverage is `42.85%`.
[](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6431 +/- ##
============================================
- Coverage 56.82% 55.93% -0.90%
- Complexity 3970 3999 +29
============================================
Files 985 999 +14
Lines 24397 24760 +363
Branches 2401 2425 +24
============================================
- Hits 13864 13849 -15
- Misses 9305 9736 +431
+ Partials 1228 1175 -53
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/log/analyzer/dsl/spec/sink/sampler/Sampler.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvU2FtcGxlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../alarm/provider/dingtalk/DingtalkHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9kaW5ndGFsay9EaW5ndGFsa0hvb2tDYWxsYmFjay5qYXZh) | `18.86% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/feishu/FeishuHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9mZWlzaHUvRmVpc2h1SG9va0NhbGxiYWNrLmphdmE=) | `14.28% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...r/core/alarm/provider/slack/SlackhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9zbGFjay9TbGFja2hvb2tDYWxsYmFjay5qYXZh) | `22.91% <0.00%> (-2.67%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `26.31% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...zer/dsl/spec/sink/sampler/RateLimitingSampler.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvUmF0ZUxpbWl0aW5nU2FtcGxlci5qYXZh) | `12.12% <12.12%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `18.51% <18.51%> (ø)` | `2.00 <2.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `18.75% <18.75%> (ø)` | `1.00 <1.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `26.43% <26.43%> (ø)` | `4.00 <4.00> (?)` | |
| [...g/analyzer/provider/LogAnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9Mb2dBbmFseXplck1vZHVsZVByb3ZpZGVyLmphdmE=) | `86.66% <50.00%> (-13.34%)` | `8.00 <1.00> (ø)` | |
| ... and [90 more](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=footer). Last update [665a07c...b7520a5](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6431: Fix alarm httpclient connection leak
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6431:
URL: https://github.com/apache/skywalking/pull/6431#issuecomment-784759581
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=h1) Report
> Merging [#6431](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=desc) (700fa56) into [master](https://codecov.io/gh/apache/skywalking/commit/1c52995cbf26fa1442ba6b81fb3c4635625e3702?el=desc) (1c52995) will **decrease** coverage by `16.25%`.
> The diff coverage is `32.89%`.
[](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6431 +/- ##
=============================================
- Coverage 56.82% 40.57% -16.26%
+ Complexity 3970 2502 -1468
=============================================
Files 985 831 -154
Lines 24397 20407 -3990
Branches 2401 1928 -473
=============================================
- Hits 13864 8280 -5584
- Misses 9305 11475 +2170
+ Partials 1228 652 -576
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/log/analyzer/dsl/spec/sink/sampler/Sampler.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvU2FtcGxlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ap/server/core/alarm/provider/WebhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9XZWJob29rQ2FsbGJhY2suamF2YQ==) | `25.00% <0.00%> (-46.43%)` | `2.00 <0.00> (-2.00)` | |
| [.../alarm/provider/dingtalk/DingtalkHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9kaW5ndGFsay9EaW5ndGFsa0hvb2tDYWxsYmFjay5qYXZh) | `16.98% <0.00%> (-1.89%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/feishu/FeishuHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9mZWlzaHUvRmVpc2h1SG9va0NhbGxiYWNrLmphdmE=) | `12.85% <0.00%> (-1.43%)` | `2.00 <0.00> (-1.00)` | |
| [...r/core/alarm/provider/slack/SlackhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9zbGFjay9TbGFja2hvb2tDYWxsYmFjay5qYXZh) | `20.83% <0.00%> (-4.75%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <0.00%> (-2.64%)` | `2.00 <0.00> (-1.00)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `8.86% <8.86%> (ø)` | `1.00 <1.00> (?)` | |
| [...zer/dsl/spec/sink/sampler/RateLimitingSampler.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvUmF0ZUxpbWl0aW5nU2FtcGxlci5qYXZh) | `12.12% <12.12%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `16.66% <16.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `18.51% <18.51%> (ø)` | `2.00 <2.00> (?)` | |
| ... and [390 more](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=footer). Last update [665a07c...b7520a5](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6431: Fix alarm httpclient connection leak
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6431:
URL: https://github.com/apache/skywalking/pull/6431#issuecomment-784759581
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=h1) Report
> Merging [#6431](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=desc) (b7520a5) into [master](https://codecov.io/gh/apache/skywalking/commit/1c52995cbf26fa1442ba6b81fb3c4635625e3702?el=desc) (1c52995) will **decrease** coverage by `1.57%`.
> The diff coverage is `42.85%`.
[](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6431 +/- ##
============================================
- Coverage 56.82% 55.25% -1.58%
+ Complexity 3970 3958 -12
============================================
Files 985 999 +14
Lines 24397 24760 +363
Branches 2401 2425 +24
============================================
- Hits 13864 13681 -183
- Misses 9305 9914 +609
+ Partials 1228 1165 -63
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/log/analyzer/dsl/spec/sink/sampler/Sampler.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvU2FtcGxlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../alarm/provider/dingtalk/DingtalkHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9kaW5ndGFsay9EaW5ndGFsa0hvb2tDYWxsYmFjay5qYXZh) | `18.86% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/feishu/FeishuHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9mZWlzaHUvRmVpc2h1SG9va0NhbGxiYWNrLmphdmE=) | `14.28% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...r/core/alarm/provider/slack/SlackhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9zbGFjay9TbGFja2hvb2tDYWxsYmFjay5qYXZh) | `22.91% <0.00%> (-2.67%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `26.31% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...zer/dsl/spec/sink/sampler/RateLimitingSampler.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvUmF0ZUxpbWl0aW5nU2FtcGxlci5qYXZh) | `12.12% <12.12%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `18.51% <18.51%> (ø)` | `2.00 <2.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `18.75% <18.75%> (ø)` | `1.00 <1.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `26.43% <26.43%> (ø)` | `4.00 <4.00> (?)` | |
| [...g/analyzer/provider/LogAnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9Mb2dBbmFseXplck1vZHVsZVByb3ZpZGVyLmphdmE=) | `86.66% <50.00%> (-13.34%)` | `8.00 <1.00> (ø)` | |
| ... and [102 more](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=footer). Last update [665a07c...b7520a5](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6431: Fix alarm httpclient connection leak
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6431:
URL: https://github.com/apache/skywalking/pull/6431#issuecomment-784759581
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=h1) Report
> Merging [#6431](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=desc) (3573922) into [master](https://codecov.io/gh/apache/skywalking/commit/8c3d1679e37f992b697835b2402401a26eac19e8?el=desc) (8c3d167) will **decrease** coverage by `5.97%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6431 +/- ##
============================================
- Coverage 51.82% 45.84% -5.98%
+ Complexity 3791 3455 -336
============================================
Files 1016 999 -17
Lines 24957 24602 -355
Branches 2447 2413 -34
============================================
- Hits 12935 11280 -1655
- Misses 10912 12354 +1442
+ Partials 1110 968 -142
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/server/core/alarm/provider/WebhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9XZWJob29rQ2FsbGJhY2suamF2YQ==) | `25.00% <0.00%> (-46.43%)` | `2.00 <0.00> (-2.00)` | |
| [.../alarm/provider/dingtalk/DingtalkHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9kaW5ndGFsay9EaW5ndGFsa0hvb2tDYWxsYmFjay5qYXZh) | `15.51% <0.00%> (-3.36%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/feishu/FeishuHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9mZWlzaHUvRmVpc2h1SG9va0NhbGxiYWNrLmphdmE=) | `12.00% <0.00%> (-2.29%)` | `2.00 <0.00> (-1.00)` | |
| [...r/core/alarm/provider/slack/SlackhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9zbGFjay9TbGFja2hvb2tDYWxsYmFjay5qYXZh) | `20.83% <0.00%> (-4.75%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `20.93% <0.00%> (-5.39%)` | `2.00 <0.00> (-1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...in/elasticsearch/base/TimeRangeIndexNameMaker.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9UaW1lUmFuZ2VJbmRleE5hbWVNYWtlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh) | `4.65% <0.00%> (-89.54%)` | `1.00% <0.00%> (-10.00%)` | |
| [...tworkalias/NetworkAddressAliasSetupDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzU2V0dXBEaXNwYXRjaGVyLmphdmE=) | `11.11% <0.00%> (-88.89%)` | `1.00% <0.00%> (-1.00%)` | |
| ... and [181 more](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=footer). Last update [8c3d167...3573922](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6431: Fix alarm httpclient connection leak
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6431:
URL: https://github.com/apache/skywalking/pull/6431#issuecomment-784759581
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=h1) Report
> Merging [#6431](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=desc) (3573922) into [master](https://codecov.io/gh/apache/skywalking/commit/8c3d1679e37f992b697835b2402401a26eac19e8?el=desc) (8c3d167) will **decrease** coverage by `9.32%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6431 +/- ##
============================================
- Coverage 51.82% 42.50% -9.33%
+ Complexity 3791 3199 -592
============================================
Files 1016 999 -17
Lines 24957 24561 -396
Branches 2447 2411 -36
============================================
- Hits 12935 10440 -2495
- Misses 10912 13244 +2332
+ Partials 1110 877 -233
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/server/core/alarm/provider/WebhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9XZWJob29rQ2FsbGJhY2suamF2YQ==) | `25.00% <0.00%> (-46.43%)` | `2.00 <0.00> (-2.00)` | |
| [.../alarm/provider/dingtalk/DingtalkHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9kaW5ndGFsay9EaW5ndGFsa0hvb2tDYWxsYmFjay5qYXZh) | `15.51% <0.00%> (-3.36%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/feishu/FeishuHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9mZWlzaHUvRmVpc2h1SG9va0NhbGxiYWNrLmphdmE=) | `12.00% <0.00%> (-2.29%)` | `2.00 <0.00> (-1.00)` | |
| [...r/core/alarm/provider/slack/SlackhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9zbGFjay9TbGFja2hvb2tDYWxsYmFjay5qYXZh) | `20.83% <0.00%> (-4.75%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `20.93% <0.00%> (-5.39%)` | `2.00 <0.00> (-1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...server/storage/plugin/influxdb/base/RecordDAO.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL1JlY29yZERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-7.00%)` | |
| ... and [217 more](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=footer). Last update [8c3d167...3573922](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6431: Fix alarm httpclient connection leak
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6431:
URL: https://github.com/apache/skywalking/pull/6431#issuecomment-784759581
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=h1) Report
> Merging [#6431](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=desc) (5c8c304) into [master](https://codecov.io/gh/apache/skywalking/commit/8c3d1679e37f992b697835b2402401a26eac19e8?el=desc) (8c3d167) will **decrease** coverage by `10.55%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6431 +/- ##
=============================================
- Coverage 45.34% 34.79% -10.56%
+ Complexity 3454 2248 -1206
=============================================
Files 1016 847 -169
Lines 24860 20869 -3991
Branches 2421 1980 -441
=============================================
- Hits 11273 7261 -4012
- Misses 12608 13061 +453
+ Partials 979 547 -432
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/server/core/alarm/provider/WebhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9XZWJob29rQ2FsbGJhY2suamF2YQ==) | `25.00% <0.00%> (-3.58%)` | `2.00 <0.00> (ø)` | |
| [.../alarm/provider/dingtalk/DingtalkHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9kaW5ndGFsay9EaW5ndGFsa0hvb2tDYWxsYmFjay5qYXZh) | `15.51% <0.00%> (-1.47%)` | `2.00 <0.00> (ø)` | |
| [...core/alarm/provider/feishu/FeishuHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9mZWlzaHUvRmVpc2h1SG9va0NhbGxiYWNrLmphdmE=) | `12.00% <0.00%> (-0.86%)` | `2.00 <0.00> (ø)` | |
| [...r/core/alarm/provider/slack/SlackhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9zbGFjay9TbGFja2hvb2tDYWxsYmFjay5qYXZh) | `20.83% <0.00%> (-2.43%)` | `2.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `20.93% <0.00%> (-2.76%)` | `2.00 <0.00> (ø)` | |
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/oap/server/core/source/MemoryPoolType.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL01lbW9yeVBvb2xUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/oap/server/core/analysis/record/Record.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvcmVjb3JkL1JlY29yZC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/analysis/metrics/SumMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9TdW1NZXRyaWNzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [...m/network/trace/component/command/BaseCommand.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0Jhc2VDb21tYW5kLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| ... and [326 more](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=footer). Last update [8c3d167...3573922](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6431: Fix alarm httpclient connection leak
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6431:
URL: https://github.com/apache/skywalking/pull/6431#issuecomment-784759581
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=h1) Report
> Merging [#6431](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=desc) (b7520a5) into [master](https://codecov.io/gh/apache/skywalking/commit/1c52995cbf26fa1442ba6b81fb3c4635625e3702?el=desc) (1c52995) will **decrease** coverage by `2.56%`.
> The diff coverage is `41.81%`.
[](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6431 +/- ##
============================================
- Coverage 56.82% 54.25% -2.57%
+ Complexity 3970 3896 -74
============================================
Files 985 999 +14
Lines 24397 24760 +363
Branches 2401 2425 +24
============================================
- Hits 13864 13434 -430
- Misses 9305 10174 +869
+ Partials 1228 1152 -76
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/log/analyzer/dsl/spec/sink/sampler/Sampler.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvU2FtcGxlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ap/server/core/alarm/provider/WebhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9XZWJob29rQ2FsbGJhY2suamF2YQ==) | `25.00% <0.00%> (-46.43%)` | `2.00 <0.00> (-2.00)` | |
| [.../alarm/provider/dingtalk/DingtalkHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9kaW5ndGFsay9EaW5ndGFsa0hvb2tDYWxsYmFjay5qYXZh) | `16.98% <0.00%> (-1.89%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/feishu/FeishuHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9mZWlzaHUvRmVpc2h1SG9va0NhbGxiYWNrLmphdmE=) | `12.85% <0.00%> (-1.43%)` | `2.00 <0.00> (-1.00)` | |
| [...r/core/alarm/provider/slack/SlackhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9zbGFjay9TbGFja2hvb2tDYWxsYmFjay5qYXZh) | `20.83% <0.00%> (-4.75%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <0.00%> (-2.64%)` | `2.00 <0.00> (-1.00)` | |
| [...zer/dsl/spec/sink/sampler/RateLimitingSampler.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvUmF0ZUxpbWl0aW5nU2FtcGxlci5qYXZh) | `12.12% <12.12%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `18.51% <18.51%> (ø)` | `2.00 <2.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `18.75% <18.75%> (ø)` | `1.00 <1.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `26.43% <26.43%> (ø)` | `4.00 <4.00> (?)` | |
| ... and [120 more](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=footer). Last update [665a07c...b7520a5](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6431: Fix alarm httpclient connection leak
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6431:
URL: https://github.com/apache/skywalking/pull/6431#issuecomment-784759581
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=h1) Report
> Merging [#6431](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=desc) (f55956d) into [master](https://codecov.io/gh/apache/skywalking/commit/0f8b6d641a963adafd3f4dd2a7388dfd27a626c9?el=desc) (0f8b6d6) will **decrease** coverage by `1.00%`.
> The diff coverage is `11.42%`.
[](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6431 +/- ##
============================================
- Coverage 53.66% 52.65% -1.01%
+ Complexity 4069 3836 -233
============================================
Files 1789 998 -791
Lines 38172 24715 -13457
Branches 4217 2423 -1794
============================================
- Hits 20484 13014 -7470
+ Misses 16688 10613 -6075
- Partials 1000 1088 +88
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../alarm/provider/dingtalk/DingtalkHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9kaW5ndGFsay9EaW5ndGFsa0hvb2tDYWxsYmFjay5qYXZh) | `17.24% <0.00%> (-60.95%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/feishu/FeishuHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9mZWlzaHUvRmVpc2h1SG9va0NhbGxiYWNrLmphdmE=) | `13.33% <0.00%> (-70.00%)` | `3.00 <0.00> (ø)` | |
| [...r/core/alarm/provider/slack/SlackhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9zbGFjay9TbGFja2hvb2tDYWxsYmFjay5qYXZh) | `22.91% <0.00%> (-1.53%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.25% <0.00%> (-54.25%)` | `3.00 <0.00> (ø)` | |
| [...ap/server/core/alarm/provider/WebhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9XZWJob29rQ2FsbGJhY2suamF2YQ==) | `67.50% <57.14%> (-0.07%)` | `4.00 <0.00> (ø)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...lking/oap/server/analyzer/event/EventAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L0V2ZW50QW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| ... and [1254 more](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=footer). Last update [08bceb9...f55956d](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6431: Fix alarm httpclient connection leak
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6431:
URL: https://github.com/apache/skywalking/pull/6431#issuecomment-784759581
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=h1) Report
> Merging [#6431](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=desc) (b7520a5) into [master](https://codecov.io/gh/apache/skywalking/commit/1c52995cbf26fa1442ba6b81fb3c4635625e3702?el=desc) (1c52995) will **decrease** coverage by `5.88%`.
> The diff coverage is `41.81%`.
[](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6431 +/- ##
============================================
- Coverage 56.82% 50.94% -5.89%
+ Complexity 3970 3693 -277
============================================
Files 985 999 +14
Lines 24397 24618 +221
Branches 2401 2411 +10
============================================
- Hits 13864 12541 -1323
- Misses 9305 10979 +1674
+ Partials 1228 1098 -130
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/log/analyzer/dsl/spec/sink/sampler/Sampler.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvU2FtcGxlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ap/server/core/alarm/provider/WebhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9XZWJob29rQ2FsbGJhY2suamF2YQ==) | `25.00% <0.00%> (-46.43%)` | `2.00 <0.00> (-2.00)` | |
| [.../alarm/provider/dingtalk/DingtalkHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9kaW5ndGFsay9EaW5ndGFsa0hvb2tDYWxsYmFjay5qYXZh) | `16.98% <0.00%> (-1.89%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/feishu/FeishuHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9mZWlzaHUvRmVpc2h1SG9va0NhbGxiYWNrLmphdmE=) | `12.85% <0.00%> (-1.43%)` | `2.00 <0.00> (-1.00)` | |
| [...r/core/alarm/provider/slack/SlackhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9zbGFjay9TbGFja2hvb2tDYWxsYmFjay5qYXZh) | `20.83% <0.00%> (-4.75%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <0.00%> (-2.64%)` | `2.00 <0.00> (-1.00)` | |
| [...zer/dsl/spec/sink/sampler/RateLimitingSampler.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvUmF0ZUxpbWl0aW5nU2FtcGxlci5qYXZh) | `12.12% <12.12%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `18.51% <18.51%> (ø)` | `2.00 <2.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `18.75% <18.75%> (ø)` | `1.00 <1.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `26.43% <26.43%> (ø)` | `4.00 <4.00> (?)` | |
| ... and [152 more](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=footer). Last update [665a07c...b7520a5](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6431: Fix alarm httpclient connection leak
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6431:
URL: https://github.com/apache/skywalking/pull/6431#issuecomment-784759581
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=h1) Report
> Merging [#6431](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=desc) (5c8c304) into [master](https://codecov.io/gh/apache/skywalking/commit/8c3d1679e37f992b697835b2402401a26eac19e8?el=desc) (8c3d167) will **decrease** coverage by `3.19%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6431 +/- ##
============================================
- Coverage 51.80% 48.61% -3.20%
+ Complexity 3788 3558 -230
============================================
Files 1016 999 -17
Lines 24957 24600 -357
Branches 2447 2399 -48
============================================
- Hits 12930 11960 -970
- Misses 10913 11615 +702
+ Partials 1114 1025 -89
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/server/core/alarm/provider/WebhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9XZWJob29rQ2FsbGJhY2suamF2YQ==) | `25.00% <0.00%> (-46.43%)` | `2.00 <0.00> (-2.00)` | |
| [.../alarm/provider/dingtalk/DingtalkHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9kaW5ndGFsay9EaW5ndGFsa0hvb2tDYWxsYmFjay5qYXZh) | `15.51% <0.00%> (-3.36%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/feishu/FeishuHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9mZWlzaHUvRmVpc2h1SG9va0NhbGxiYWNrLmphdmE=) | `12.00% <0.00%> (-2.29%)` | `2.00 <0.00> (-1.00)` | |
| [...r/core/alarm/provider/slack/SlackhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9zbGFjay9TbGFja2hvb2tDYWxsYmFjay5qYXZh) | `20.83% <0.00%> (-4.75%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `20.93% <0.00%> (-5.39%)` | `2.00 <0.00> (-1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...in/elasticsearch/base/TimeRangeIndexNameMaker.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9UaW1lUmFuZ2VJbmRleE5hbWVNYWtlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ticsearch7/client/ElasticSearch7UpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9jbGllbnQvRWxhc3RpY1NlYXJjaDdVcGRhdGVSZXF1ZXN0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [148 more](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=footer). Last update [8c3d167...3573922](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6431: Fix alarm httpclient connection leak
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6431:
URL: https://github.com/apache/skywalking/pull/6431#issuecomment-784759581
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=h1) Report
> Merging [#6431](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=desc) (700fa56) into [master](https://codecov.io/gh/apache/skywalking/commit/1c52995cbf26fa1442ba6b81fb3c4635625e3702?el=desc) (1c52995) will **decrease** coverage by `7.04%`.
> The diff coverage is `47.93%`.
[](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6431 +/- ##
============================================
- Coverage 56.82% 49.78% -7.05%
+ Complexity 3970 3647 -323
============================================
Files 985 1789 +804
Lines 24397 38094 +13697
Branches 2401 4209 +1808
============================================
+ Hits 13864 18964 +5100
- Misses 9305 18132 +8827
+ Partials 1228 998 -230
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...in/finagle/ClientDestTracingFilterInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vZmluYWdsZS02LjI1LngtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9wbHVnaW4vZmluYWdsZS9DbGllbnREZXN0VHJhY2luZ0ZpbHRlckludGVyY2VwdG9yLmphdmE=) | `55.00% <ø> (ø)` | `0.00 <0.00> (?)` | |
| [...flux/v5/webclient/WebFluxWebClientInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvc3ByaW5nLXdlYmZsdXgtNS54LXdlYmNsaWVudC1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3BsdWdpbi9zcHJpbmcvd2ViZmx1eC92NS93ZWJjbGllbnQvV2ViRmx1eFdlYkNsaWVudEludGVyY2VwdG9yLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (?)` | |
| [...ap/log/analyzer/dsl/spec/sink/sampler/Sampler.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvU2FtcGxlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...r/core/alarm/provider/slack/SlackhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9zbGFjay9TbGFja2hvb2tDYWxsYmFjay5qYXZh) | `19.60% <0.00%> (-5.98%)` | `2.00 <0.00> (-1.00)` | |
| [...zer/dsl/spec/sink/sampler/RateLimitingSampler.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvUmF0ZUxpbWl0aW5nU2FtcGxlci5qYXZh) | `11.76% <11.76%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `18.51% <18.51%> (ø)` | `2.00 <2.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `18.75% <18.75%> (ø)` | `1.00 <1.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `26.43% <26.43%> (ø)` | `4.00 <4.00> (?)` | |
| [...g/analyzer/provider/LogAnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9Mb2dBbmFseXplck1vZHVsZVByb3ZpZGVyLmphdmE=) | `86.66% <50.00%> (-13.34%)` | `8.00 <1.00> (ø)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `50.87% <50.87%> (ø)` | `7.00 <7.00> (?)` | |
| ... and [1303 more](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=footer). Last update [665a07c...e67ccd5](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6431: Fix alarm httpclient connection leak
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6431:
URL: https://github.com/apache/skywalking/pull/6431#issuecomment-784759581
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=h1) Report
> Merging [#6431](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=desc) (700fa56) into [master](https://codecov.io/gh/apache/skywalking/commit/1c52995cbf26fa1442ba6b81fb3c4635625e3702?el=desc) (1c52995) will **decrease** coverage by `7.04%`.
> The diff coverage is `47.93%`.
[](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6431 +/- ##
============================================
- Coverage 56.82% 49.78% -7.05%
+ Complexity 3970 3647 -323
============================================
Files 985 1789 +804
Lines 24397 38094 +13697
Branches 2401 4209 +1808
============================================
+ Hits 13864 18964 +5100
- Misses 9305 18132 +8827
+ Partials 1228 998 -230
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...in/finagle/ClientDestTracingFilterInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vZmluYWdsZS02LjI1LngtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9wbHVnaW4vZmluYWdsZS9DbGllbnREZXN0VHJhY2luZ0ZpbHRlckludGVyY2VwdG9yLmphdmE=) | `55.00% <ø> (ø)` | `0.00 <0.00> (?)` | |
| [...flux/v5/webclient/WebFluxWebClientInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvc3ByaW5nLXdlYmZsdXgtNS54LXdlYmNsaWVudC1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3BsdWdpbi9zcHJpbmcvd2ViZmx1eC92NS93ZWJjbGllbnQvV2ViRmx1eFdlYkNsaWVudEludGVyY2VwdG9yLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (?)` | |
| [...ap/log/analyzer/dsl/spec/sink/sampler/Sampler.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvU2FtcGxlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...r/core/alarm/provider/slack/SlackhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9zbGFjay9TbGFja2hvb2tDYWxsYmFjay5qYXZh) | `19.60% <0.00%> (-5.98%)` | `2.00 <0.00> (-1.00)` | |
| [...zer/dsl/spec/sink/sampler/RateLimitingSampler.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvUmF0ZUxpbWl0aW5nU2FtcGxlci5qYXZh) | `11.76% <11.76%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `18.51% <18.51%> (ø)` | `2.00 <2.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `18.75% <18.75%> (ø)` | `1.00 <1.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `26.43% <26.43%> (ø)` | `4.00 <4.00> (?)` | |
| [...g/analyzer/provider/LogAnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9Mb2dBbmFseXplck1vZHVsZVByb3ZpZGVyLmphdmE=) | `86.66% <50.00%> (-13.34%)` | `8.00 <1.00> (ø)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `50.87% <50.87%> (ø)` | `7.00 <7.00> (?)` | |
| ... and [1303 more](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=footer). Last update [8c3d167...3573922](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6431: Fix alarm httpclient connection leak
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6431:
URL: https://github.com/apache/skywalking/pull/6431#issuecomment-784759581
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6431: Fix alarm httpclient connection leak
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6431:
URL: https://github.com/apache/skywalking/pull/6431#issuecomment-784759581
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=h1) Report
> Merging [#6431](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=desc) (5c8c304) into [master](https://codecov.io/gh/apache/skywalking/commit/8c3d1679e37f992b697835b2402401a26eac19e8?el=desc) (8c3d167) will **decrease** coverage by `19.32%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6431 +/- ##
=============================================
- Coverage 45.34% 26.02% -19.33%
+ Complexity 3454 1646 -1808
=============================================
Files 1016 830 -186
Lines 24860 20215 -4645
Branches 2421 1897 -524
=============================================
- Hits 11273 5261 -6012
- Misses 12608 14570 +1962
+ Partials 979 384 -595
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/server/core/alarm/provider/WebhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9XZWJob29rQ2FsbGJhY2suamF2YQ==) | `25.00% <0.00%> (-3.58%)` | `2.00 <0.00> (ø)` | |
| [.../alarm/provider/dingtalk/DingtalkHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9kaW5ndGFsay9EaW5ndGFsa0hvb2tDYWxsYmFjay5qYXZh) | `15.51% <0.00%> (-1.47%)` | `2.00 <0.00> (ø)` | |
| [...core/alarm/provider/feishu/FeishuHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9mZWlzaHUvRmVpc2h1SG9va0NhbGxiYWNrLmphdmE=) | `12.00% <0.00%> (-0.86%)` | `2.00 <0.00> (ø)` | |
| [...r/core/alarm/provider/slack/SlackhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9zbGFjay9TbGFja2hvb2tDYWxsYmFjay5qYXZh) | `20.83% <0.00%> (-2.43%)` | `2.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `20.93% <0.00%> (-2.76%)` | `2.00 <0.00> (ø)` | |
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/oap/server/core/source/MemoryPoolType.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL01lbW9yeVBvb2xUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/oap/server/core/analysis/record/Record.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvcmVjb3JkL1JlY29yZC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ache/skywalking/oap/meter/analyzer/dsl/Sample.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...g/oap/server/core/analysis/metrics/SumMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9TdW1NZXRyaWNzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| ... and [457 more](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=footer). Last update [8c3d167...3573922](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6431: Fix alarm httpclient connection leak
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6431:
URL: https://github.com/apache/skywalking/pull/6431#issuecomment-784759581
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=h1) Report
> Merging [#6431](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=desc) (b8320cc) into [master](https://codecov.io/gh/apache/skywalking/commit/0f8b6d641a963adafd3f4dd2a7388dfd27a626c9?el=desc) (0f8b6d6) will **decrease** coverage by `21.30%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6431 +/- ##
=============================================
- Coverage 53.66% 32.35% -21.31%
+ Complexity 4069 1978 -2091
=============================================
Files 1789 819 -970
Lines 38172 19961 -18211
Branches 4217 1862 -2355
=============================================
- Hits 20484 6458 -14026
+ Misses 16688 13044 -3644
+ Partials 1000 459 -541
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/server/core/alarm/provider/WebhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9XZWJob29rQ2FsbGJhY2suamF2YQ==) | `25.00% <0.00%> (-42.57%)` | `2.00 <0.00> (-2.00)` | |
| [.../alarm/provider/dingtalk/DingtalkHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9kaW5ndGFsay9EaW5ndGFsa0hvb2tDYWxsYmFjay5qYXZh) | `15.51% <0.00%> (-62.67%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/feishu/FeishuHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9mZWlzaHUvRmVpc2h1SG9va0NhbGxiYWNrLmphdmE=) | `12.00% <0.00%> (-71.34%)` | `2.00 <0.00> (-1.00)` | |
| [...r/core/alarm/provider/slack/SlackhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9zbGFjay9TbGFja2hvb2tDYWxsYmFjay5qYXZh) | `20.83% <0.00%> (-3.62%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `20.93% <0.00%> (-56.57%)` | `2.00 <0.00> (-1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1452 more](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=footer). Last update [08bceb9...f55956d](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6431: Fix alarm httpclient connection leak
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6431:
URL: https://github.com/apache/skywalking/pull/6431#issuecomment-784759581
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=h1) Report
> Merging [#6431](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=desc) (3573922) into [master](https://codecov.io/gh/apache/skywalking/commit/8c3d1679e37f992b697835b2402401a26eac19e8?el=desc) (8c3d167) will **decrease** coverage by `10.95%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6431 +/- ##
=============================================
- Coverage 46.40% 35.45% -10.96%
+ Complexity 3504 2179 -1325
=============================================
Files 1016 831 -185
Lines 24879 20405 -4474
Branches 2440 1945 -495
=============================================
- Hits 11546 7235 -4311
- Misses 12342 12626 +284
+ Partials 991 544 -447
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/server/core/alarm/provider/WebhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9XZWJob29rQ2FsbGJhY2suamF2YQ==) | `25.00% <0.00%> (-3.58%)` | `2.00 <0.00> (ø)` | |
| [.../alarm/provider/dingtalk/DingtalkHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9kaW5ndGFsay9EaW5ndGFsa0hvb2tDYWxsYmFjay5qYXZh) | `15.51% <0.00%> (-1.47%)` | `2.00 <0.00> (ø)` | |
| [...core/alarm/provider/feishu/FeishuHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9mZWlzaHUvRmVpc2h1SG9va0NhbGxiYWNrLmphdmE=) | `12.00% <0.00%> (-0.86%)` | `2.00 <0.00> (ø)` | |
| [...r/core/alarm/provider/slack/SlackhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9zbGFjay9TbGFja2hvb2tDYWxsYmFjay5qYXZh) | `20.83% <0.00%> (-2.43%)` | `2.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `20.93% <0.00%> (-2.76%)` | `2.00 <0.00> (ø)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...ient/elasticsearch/ElasticSearchInsertRequest.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaEluc2VydFJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...erver/storage/plugin/elasticsearch/base/EsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9Fc0RBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| ... and [352 more](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=footer). Last update [8c3d167...3573922](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6431: Fix alarm httpclient connection leak
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6431:
URL: https://github.com/apache/skywalking/pull/6431#issuecomment-784759581
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=h1) Report
> Merging [#6431](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=desc) (700fa56) into [master](https://codecov.io/gh/apache/skywalking/commit/1c52995cbf26fa1442ba6b81fb3c4635625e3702?el=desc) (1c52995) will **decrease** coverage by `10.86%`.
> The diff coverage is `41.81%`.
[](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6431 +/- ##
=============================================
- Coverage 56.82% 45.96% -10.87%
+ Complexity 3970 2813 -1157
=============================================
Files 985 848 -137
Lines 24397 20953 -3444
Branches 2401 1986 -415
=============================================
- Hits 13864 9631 -4233
- Misses 9305 10554 +1249
+ Partials 1228 768 -460
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/log/analyzer/dsl/spec/sink/sampler/Sampler.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvU2FtcGxlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ap/server/core/alarm/provider/WebhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9XZWJob29rQ2FsbGJhY2suamF2YQ==) | `25.00% <0.00%> (-46.43%)` | `2.00 <0.00> (-2.00)` | |
| [.../alarm/provider/dingtalk/DingtalkHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9kaW5ndGFsay9EaW5ndGFsa0hvb2tDYWxsYmFjay5qYXZh) | `16.98% <0.00%> (-1.89%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/feishu/FeishuHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9mZWlzaHUvRmVpc2h1SG9va0NhbGxiYWNrLmphdmE=) | `12.85% <0.00%> (-1.43%)` | `2.00 <0.00> (-1.00)` | |
| [...r/core/alarm/provider/slack/SlackhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9zbGFjay9TbGFja2hvb2tDYWxsYmFjay5qYXZh) | `20.83% <0.00%> (-4.75%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <0.00%> (-2.64%)` | `2.00 <0.00> (-1.00)` | |
| [...zer/dsl/spec/sink/sampler/RateLimitingSampler.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvUmF0ZUxpbWl0aW5nU2FtcGxlci5qYXZh) | `12.12% <12.12%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `18.51% <18.51%> (ø)` | `2.00 <2.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `18.75% <18.75%> (ø)` | `1.00 <1.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `26.43% <26.43%> (ø)` | `4.00 <4.00> (?)` | |
| ... and [336 more](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=footer). Last update [665a07c...b7520a5](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6431: Fix alarm httpclient connection leak
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6431:
URL: https://github.com/apache/skywalking/pull/6431#issuecomment-784759581
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=h1) Report
> Merging [#6431](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=desc) (5c8c304) into [master](https://codecov.io/gh/apache/skywalking/commit/8c3d1679e37f992b697835b2402401a26eac19e8?el=desc) (8c3d167) will **decrease** coverage by `3.73%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6431 +/- ##
============================================
- Coverage 51.80% 48.07% -3.74%
+ Complexity 3788 3523 -265
============================================
Files 1016 999 -17
Lines 24957 24578 -379
Branches 2447 2397 -50
============================================
- Hits 12930 11816 -1114
- Misses 10913 11751 +838
+ Partials 1114 1011 -103
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/server/core/alarm/provider/WebhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9XZWJob29rQ2FsbGJhY2suamF2YQ==) | `25.00% <0.00%> (-46.43%)` | `2.00 <0.00> (-2.00)` | |
| [.../alarm/provider/dingtalk/DingtalkHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9kaW5ndGFsay9EaW5ndGFsa0hvb2tDYWxsYmFjay5qYXZh) | `15.51% <0.00%> (-3.36%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/feishu/FeishuHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9mZWlzaHUvRmVpc2h1SG9va0NhbGxiYWNrLmphdmE=) | `12.00% <0.00%> (-2.29%)` | `2.00 <0.00> (-1.00)` | |
| [...r/core/alarm/provider/slack/SlackhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9zbGFjay9TbGFja2hvb2tDYWxsYmFjay5qYXZh) | `20.83% <0.00%> (-4.75%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `20.93% <0.00%> (-5.39%)` | `2.00 <0.00> (-1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...ient/elasticsearch/ElasticSearchUpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaFVwZGF0ZVJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...in/elasticsearch/base/TimeRangeIndexNameMaker.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9UaW1lUmFuZ2VJbmRleE5hbWVNYWtlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [159 more](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=footer). Last update [8c3d167...3573922](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6431: Fix alarm httpclient connection leak
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6431:
URL: https://github.com/apache/skywalking/pull/6431#issuecomment-784759581
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=h1) Report
> Merging [#6431](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=desc) (b8320cc) into [master](https://codecov.io/gh/apache/skywalking/commit/0f8b6d641a963adafd3f4dd2a7388dfd27a626c9?el=desc) (0f8b6d6) will **decrease** coverage by `8.71%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6431 +/- ##
============================================
- Coverage 53.66% 44.94% -8.72%
+ Complexity 4069 3347 -722
============================================
Files 1789 999 -790
Lines 38172 24579 -13593
Branches 4217 2413 -1804
============================================
- Hits 20484 11047 -9437
+ Misses 16688 12577 -4111
+ Partials 1000 955 -45
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/server/core/alarm/provider/WebhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9XZWJob29rQ2FsbGJhY2suamF2YQ==) | `25.00% <0.00%> (-42.57%)` | `2.00 <0.00> (-2.00)` | |
| [.../alarm/provider/dingtalk/DingtalkHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9kaW5ndGFsay9EaW5ndGFsa0hvb2tDYWxsYmFjay5qYXZh) | `15.51% <0.00%> (-62.67%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/feishu/FeishuHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9mZWlzaHUvRmVpc2h1SG9va0NhbGxiYWNrLmphdmE=) | `12.00% <0.00%> (-71.34%)` | `2.00 <0.00> (-1.00)` | |
| [...r/core/alarm/provider/slack/SlackhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9zbGFjay9TbGFja2hvb2tDYWxsYmFjay5qYXZh) | `20.83% <0.00%> (-3.62%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `20.93% <0.00%> (-56.57%)` | `2.00 <0.00> (-1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1316 more](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=footer). Last update [08bceb9...f55956d](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6431: Fix alarm httpclient connection leak
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6431:
URL: https://github.com/apache/skywalking/pull/6431#issuecomment-784759581
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=h1) Report
> Merging [#6431](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=desc) (b8320cc) into [master](https://codecov.io/gh/apache/skywalking/commit/0f8b6d641a963adafd3f4dd2a7388dfd27a626c9?el=desc) (0f8b6d6) will **decrease** coverage by `5.25%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6431 +/- ##
============================================
- Coverage 53.66% 48.41% -5.26%
+ Complexity 4069 3513 -556
============================================
Files 1789 999 -790
Lines 38172 24592 -13580
Branches 4217 2414 -1803
============================================
- Hits 20484 11905 -8579
+ Misses 16688 11654 -5034
- Partials 1000 1033 +33
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/server/core/alarm/provider/WebhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9XZWJob29rQ2FsbGJhY2suamF2YQ==) | `25.00% <0.00%> (-42.57%)` | `2.00 <0.00> (-2.00)` | |
| [.../alarm/provider/dingtalk/DingtalkHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9kaW5ndGFsay9EaW5ndGFsa0hvb2tDYWxsYmFjay5qYXZh) | `15.51% <0.00%> (-62.67%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/feishu/FeishuHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9mZWlzaHUvRmVpc2h1SG9va0NhbGxiYWNrLmphdmE=) | `12.00% <0.00%> (-71.34%)` | `2.00 <0.00> (-1.00)` | |
| [...r/core/alarm/provider/slack/SlackhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9zbGFjay9TbGFja2hvb2tDYWxsYmFjay5qYXZh) | `20.83% <0.00%> (-3.62%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `20.93% <0.00%> (-56.57%)` | `2.00 <0.00> (-1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1299 more](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=footer). Last update [08bceb9...f55956d](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6431: Fix alarm httpclient connection leak
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6431:
URL: https://github.com/apache/skywalking/pull/6431#issuecomment-784759581
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=h1) Report
> Merging [#6431](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=desc) (b7520a5) into [master](https://codecov.io/gh/apache/skywalking/commit/1c52995cbf26fa1442ba6b81fb3c4635625e3702?el=desc) (1c52995) will **decrease** coverage by `0.89%`.
> The diff coverage is `42.85%`.
[](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6431 +/- ##
============================================
- Coverage 56.82% 55.93% -0.90%
- Complexity 3970 3999 +29
============================================
Files 985 999 +14
Lines 24397 24760 +363
Branches 2401 2425 +24
============================================
- Hits 13864 13849 -15
- Misses 9305 9736 +431
+ Partials 1228 1175 -53
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/log/analyzer/dsl/spec/sink/sampler/Sampler.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvU2FtcGxlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../alarm/provider/dingtalk/DingtalkHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9kaW5ndGFsay9EaW5ndGFsa0hvb2tDYWxsYmFjay5qYXZh) | `18.86% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/feishu/FeishuHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9mZWlzaHUvRmVpc2h1SG9va0NhbGxiYWNrLmphdmE=) | `14.28% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...r/core/alarm/provider/slack/SlackhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9zbGFjay9TbGFja2hvb2tDYWxsYmFjay5qYXZh) | `22.91% <0.00%> (-2.67%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `26.31% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...zer/dsl/spec/sink/sampler/RateLimitingSampler.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvUmF0ZUxpbWl0aW5nU2FtcGxlci5qYXZh) | `12.12% <12.12%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `18.51% <18.51%> (ø)` | `2.00 <2.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `18.75% <18.75%> (ø)` | `1.00 <1.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `26.43% <26.43%> (ø)` | `4.00 <4.00> (?)` | |
| [...g/analyzer/provider/LogAnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9Mb2dBbmFseXplck1vZHVsZVByb3ZpZGVyLmphdmE=) | `86.66% <50.00%> (-13.34%)` | `8.00 <1.00> (ø)` | |
| ... and [90 more](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=footer). Last update [665a07c...b7520a5](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6431: Fix alarm httpclient connection leak
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6431:
URL: https://github.com/apache/skywalking/pull/6431#issuecomment-784759581
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=h1) Report
> Merging [#6431](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=desc) (3573922) into [master](https://codecov.io/gh/apache/skywalking/commit/8c3d1679e37f992b697835b2402401a26eac19e8?el=desc) (8c3d167) will **decrease** coverage by `12.96%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6431 +/- ##
=============================================
- Coverage 51.82% 38.86% -12.97%
+ Complexity 3791 2428 -1363
=============================================
Files 1016 848 -168
Lines 24957 20943 -4014
Branches 2447 2004 -443
=============================================
- Hits 12935 8140 -4795
- Misses 10912 12212 +1300
+ Partials 1110 591 -519
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/server/core/alarm/provider/WebhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9XZWJob29rQ2FsbGJhY2suamF2YQ==) | `25.00% <0.00%> (-46.43%)` | `2.00 <0.00> (-2.00)` | |
| [.../alarm/provider/dingtalk/DingtalkHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9kaW5ndGFsay9EaW5ndGFsa0hvb2tDYWxsYmFjay5qYXZh) | `15.51% <0.00%> (-3.36%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/feishu/FeishuHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9mZWlzaHUvRmVpc2h1SG9va0NhbGxiYWNrLmphdmE=) | `12.00% <0.00%> (-2.29%)` | `2.00 <0.00> (-1.00)` | |
| [...r/core/alarm/provider/slack/SlackhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9zbGFjay9TbGFja2hvb2tDYWxsYmFjay5qYXZh) | `20.83% <0.00%> (-4.75%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `20.93% <0.00%> (-5.39%)` | `2.00 <0.00> (-1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...server/storage/plugin/influxdb/base/RecordDAO.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL1JlY29yZERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-7.00%)` | |
| ... and [366 more](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=footer). Last update [8c3d167...3573922](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6431: Fix alarm httpclient connection leak
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6431:
URL: https://github.com/apache/skywalking/pull/6431#issuecomment-784759581
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=h1) Report
> Merging [#6431](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=desc) (b8320cc) into [master](https://codecov.io/gh/apache/skywalking/commit/0f8b6d641a963adafd3f4dd2a7388dfd27a626c9?el=desc) (0f8b6d6) will **decrease** coverage by `2.80%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6431 +/- ##
============================================
- Coverage 53.66% 50.85% -2.81%
+ Complexity 4069 3695 -374
============================================
Files 1789 999 -790
Lines 38172 24623 -13549
Branches 4217 2415 -1802
============================================
- Hits 20484 12523 -7961
+ Misses 16688 10993 -5695
- Partials 1000 1107 +107
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/server/core/alarm/provider/WebhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9XZWJob29rQ2FsbGJhY2suamF2YQ==) | `25.00% <0.00%> (-42.57%)` | `2.00 <0.00> (-2.00)` | |
| [.../alarm/provider/dingtalk/DingtalkHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9kaW5ndGFsay9EaW5ndGFsa0hvb2tDYWxsYmFjay5qYXZh) | `15.51% <0.00%> (-62.67%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/feishu/FeishuHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9mZWlzaHUvRmVpc2h1SG9va0NhbGxiYWNrLmphdmE=) | `12.00% <0.00%> (-71.34%)` | `2.00 <0.00> (-1.00)` | |
| [...r/core/alarm/provider/slack/SlackhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9zbGFjay9TbGFja2hvb2tDYWxsYmFjay5qYXZh) | `20.83% <0.00%> (-3.62%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `20.93% <0.00%> (-56.57%)` | `2.00 <0.00> (-1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1268 more](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=footer). Last update [08bceb9...f55956d](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6431: Fix alarm httpclient connection leak
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6431:
URL: https://github.com/apache/skywalking/pull/6431#issuecomment-784759581
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=h1) Report
> Merging [#6431](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=desc) (5c8c304) into [master](https://codecov.io/gh/apache/skywalking/commit/8c3d1679e37f992b697835b2402401a26eac19e8?el=desc) (8c3d167) will **increase** coverage by `1.75%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6431 +/- ##
============================================
+ Coverage 51.86% 53.62% +1.75%
- Complexity 3794 3843 +49
============================================
Files 1016 999 -17
Lines 24957 24638 -319
Branches 2447 2401 -46
============================================
+ Hits 12945 13211 +266
+ Misses 10900 10274 -626
- Partials 1112 1153 +41
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/server/core/alarm/provider/WebhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9XZWJob29rQ2FsbGJhY2suamF2YQ==) | `25.00% <0.00%> (-46.43%)` | `2.00 <0.00> (-2.00)` | |
| [.../alarm/provider/dingtalk/DingtalkHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9kaW5ndGFsay9EaW5ndGFsa0hvb2tDYWxsYmFjay5qYXZh) | `15.51% <0.00%> (-3.36%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/feishu/FeishuHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9mZWlzaHUvRmVpc2h1SG9va0NhbGxiYWNrLmphdmE=) | `12.00% <0.00%> (-2.29%)` | `2.00 <0.00> (-1.00)` | |
| [...r/core/alarm/provider/slack/SlackhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9zbGFjay9TbGFja2hvb2tDYWxsYmFjay5qYXZh) | `20.83% <0.00%> (-4.75%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `20.93% <0.00%> (-5.39%)` | `2.00 <0.00> (-1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...er/core/server/auth/AuthenticationInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL2F1dGgvQXV0aGVudGljYXRpb25JbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (-84.62%)` | `0.00% <0.00%> (-4.00%)` | |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | `0.00% <0.00%> (-6.00%)` | |
| [...n/jdbc/h2/dao/H2ProfileThreadSnapshotQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlEQU8uamF2YQ==) | `2.45% <0.00%> (-79.00%)` | `1.00% <0.00%> (-10.00%)` | |
| [...e/plugin/jdbc/h2/dao/H2ProfileTaskLogQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyUHJvZmlsZVRhc2tMb2dRdWVyeURBTy5qYXZh) | `13.63% <0.00%> (-77.28%)` | `1.00% <0.00%> (-3.00%)` | |
| ... and [103 more](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=footer). Last update [8c3d167...3573922](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6431: Fix alarm httpclient connection leak
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6431:
URL: https://github.com/apache/skywalking/pull/6431#issuecomment-784759581
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=h1) Report
> Merging [#6431](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=desc) (5c8c304) into [master](https://codecov.io/gh/apache/skywalking/commit/8c3d1679e37f992b697835b2402401a26eac19e8?el=desc) (8c3d167) will **increase** coverage by `4.73%`.
> The diff coverage is `11.42%`.
[](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6431 +/- ##
============================================
+ Coverage 51.86% 56.60% +4.73%
- Complexity 3794 4041 +247
============================================
Files 1016 999 -17
Lines 24957 24778 -179
Branches 2447 2429 -18
============================================
+ Hits 12945 14025 +1080
+ Misses 10900 9559 -1341
- Partials 1112 1194 +82
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../alarm/provider/dingtalk/DingtalkHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9kaW5ndGFsay9EaW5ndGFsa0hvb2tDYWxsYmFjay5qYXZh) | `17.24% <0.00%> (-1.63%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/feishu/FeishuHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9mZWlzaHUvRmVpc2h1SG9va0NhbGxiYWNrLmphdmE=) | `13.33% <0.00%> (-0.96%)` | `3.00 <0.00> (ø)` | |
| [...r/core/alarm/provider/slack/SlackhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9zbGFjay9TbGFja2hvb2tDYWxsYmFjay5qYXZh) | `22.91% <0.00%> (-2.67%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.25% <0.00%> (-3.06%)` | `3.00 <0.00> (ø)` | |
| [...ap/server/core/alarm/provider/WebhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9XZWJob29rQ2FsbGJhY2suamF2YQ==) | `67.50% <57.14%> (-3.93%)` | `4.00 <0.00> (ø)` | |
| [.../agent/core/profile/ProfileTaskChannelService.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlVGFza0NoYW5uZWxTZXJ2aWNlLmphdmE=) | `51.51% <0.00%> (-3.04%)` | `10.00% <0.00%> (ø%)` | |
| [...ache/skywalking/apm/agent/core/util/FileUtils.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9GaWxlVXRpbHMuamF2YQ==) | | | |
| [...ent/core/jvm/memorypool/SerialCollectorModule.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeXBvb2wvU2VyaWFsQ29sbGVjdG9yTW9kdWxlLmphdmE=) | | | |
| [...ng/apm/agent/core/context/trace/LogDataEntity.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2dEYXRhRW50aXR5LmphdmE=) | | | |
| [.../agent/core/context/util/ThrowableTransformer.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC91dGlsL1Rocm93YWJsZVRyYW5zZm9ybWVyLmphdmE=) | | | |
| ... and [96 more](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=footer). Last update [8c3d167...3573922](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6431: Fix alarm httpclient connection leak
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6431:
URL: https://github.com/apache/skywalking/pull/6431#issuecomment-784759581
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=h1) Report
> Merging [#6431](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=desc) (b8320cc) into [master](https://codecov.io/gh/apache/skywalking/commit/0f8b6d641a963adafd3f4dd2a7388dfd27a626c9?el=desc) (0f8b6d6) will **decrease** coverage by `15.63%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6431 +/- ##
=============================================
- Coverage 53.66% 38.03% -15.64%
+ Complexity 4069 2360 -1709
=============================================
Files 1789 848 -941
Lines 38172 20802 -17370
Branches 4217 1958 -2259
=============================================
- Hits 20484 7911 -12573
+ Misses 16688 12314 -4374
+ Partials 1000 577 -423
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/server/core/alarm/provider/WebhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9XZWJob29rQ2FsbGJhY2suamF2YQ==) | `25.00% <0.00%> (-42.57%)` | `2.00 <0.00> (-2.00)` | |
| [.../alarm/provider/dingtalk/DingtalkHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9kaW5ndGFsay9EaW5ndGFsa0hvb2tDYWxsYmFjay5qYXZh) | `15.51% <0.00%> (-62.67%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/feishu/FeishuHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9mZWlzaHUvRmVpc2h1SG9va0NhbGxiYWNrLmphdmE=) | `12.00% <0.00%> (-71.34%)` | `2.00 <0.00> (-1.00)` | |
| [...r/core/alarm/provider/slack/SlackhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9zbGFjay9TbGFja2hvb2tDYWxsYmFjay5qYXZh) | `20.83% <0.00%> (-3.62%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `20.93% <0.00%> (-56.57%)` | `2.00 <0.00> (-1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1402 more](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=footer). Last update [08bceb9...f55956d](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6431: Fix alarm httpclient connection leak
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6431:
URL: https://github.com/apache/skywalking/pull/6431#issuecomment-784759581
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=h1) Report
> Merging [#6431](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=desc) (5c8c304) into [master](https://codecov.io/gh/apache/skywalking/commit/8c3d1679e37f992b697835b2402401a26eac19e8?el=desc) (8c3d167) will **increase** coverage by `2.38%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6431 +/- ##
============================================
+ Coverage 51.86% 54.25% +2.38%
- Complexity 3794 3867 +73
============================================
Files 1016 999 -17
Lines 24957 24638 -319
Branches 2447 2401 -46
============================================
+ Hits 12945 13367 +422
+ Misses 10900 10117 -783
- Partials 1112 1154 +42
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/server/core/alarm/provider/WebhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9XZWJob29rQ2FsbGJhY2suamF2YQ==) | `25.00% <0.00%> (-46.43%)` | `2.00 <0.00> (-2.00)` | |
| [.../alarm/provider/dingtalk/DingtalkHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9kaW5ndGFsay9EaW5ndGFsa0hvb2tDYWxsYmFjay5qYXZh) | `15.51% <0.00%> (-3.36%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/feishu/FeishuHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9mZWlzaHUvRmVpc2h1SG9va0NhbGxiYWNrLmphdmE=) | `12.00% <0.00%> (-2.29%)` | `2.00 <0.00> (-1.00)` | |
| [...r/core/alarm/provider/slack/SlackhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9zbGFjay9TbGFja2hvb2tDYWxsYmFjay5qYXZh) | `20.83% <0.00%> (-4.75%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `20.93% <0.00%> (-5.39%)` | `2.00 <0.00> (-1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...er/core/server/auth/AuthenticationInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL2F1dGgvQXV0aGVudGljYXRpb25JbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (-84.62%)` | `0.00% <0.00%> (-4.00%)` | |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | `0.00% <0.00%> (-6.00%)` | |
| [...ap/server/core/alarm/AlarmStandardPersistence.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1TdGFuZGFyZFBlcnNpc3RlbmNlLmphdmE=) | `11.76% <0.00%> (-76.48%)` | `2.00% <0.00%> (-2.00%)` | |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | `0.00% <0.00%> (-8.00%)` | |
| ... and [101 more](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=footer). Last update [8c3d167...3573922](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6431: Fix alarm httpclient connection leak
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6431:
URL: https://github.com/apache/skywalking/pull/6431#issuecomment-784759581
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=h1) Report
> Merging [#6431](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=desc) (5c8c304) into [master](https://codecov.io/gh/apache/skywalking/commit/8c3d1679e37f992b697835b2402401a26eac19e8?el=desc) (8c3d167) will **increase** coverage by `1.14%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6431 +/- ##
============================================
+ Coverage 51.86% 53.01% +1.14%
- Complexity 3794 3808 +14
============================================
Files 1016 999 -17
Lines 24957 24635 -322
Branches 2447 2401 -46
============================================
+ Hits 12945 13060 +115
+ Misses 10900 10427 -473
- Partials 1112 1148 +36
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/server/core/alarm/provider/WebhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9XZWJob29rQ2FsbGJhY2suamF2YQ==) | `25.00% <0.00%> (-46.43%)` | `2.00 <0.00> (-2.00)` | |
| [.../alarm/provider/dingtalk/DingtalkHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9kaW5ndGFsay9EaW5ndGFsa0hvb2tDYWxsYmFjay5qYXZh) | `15.51% <0.00%> (-3.36%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/feishu/FeishuHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9mZWlzaHUvRmVpc2h1SG9va0NhbGxiYWNrLmphdmE=) | `12.00% <0.00%> (-2.29%)` | `2.00 <0.00> (-1.00)` | |
| [...r/core/alarm/provider/slack/SlackhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9zbGFjay9TbGFja2hvb2tDYWxsYmFjay5qYXZh) | `20.83% <0.00%> (-4.75%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `20.93% <0.00%> (-5.39%)` | `2.00 <0.00> (-1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...tworkalias/NetworkAddressAliasSetupDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzU2V0dXBEaXNwYXRjaGVyLmphdmE=) | `11.11% <0.00%> (-88.89%)` | `1.00% <0.00%> (-1.00%)` | |
| [...er/core/server/auth/AuthenticationInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL2F1dGgvQXV0aGVudGljYXRpb25JbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (-84.62%)` | `0.00% <0.00%> (-4.00%)` | |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | `0.00% <0.00%> (-6.00%)` | |
| [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (-80.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [123 more](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=footer). Last update [8c3d167...3573922](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng merged pull request #6431: Fix alarm httpclient connection leak
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #6431:
URL: https://github.com/apache/skywalking/pull/6431
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6431: Fix alarm httpclient connection leak
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6431:
URL: https://github.com/apache/skywalking/pull/6431#issuecomment-784759581
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=h1) Report
> Merging [#6431](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=desc) (5c8c304) into [master](https://codecov.io/gh/apache/skywalking/commit/8c3d1679e37f992b697835b2402401a26eac19e8?el=desc) (8c3d167) will **increase** coverage by `1.40%`.
> The diff coverage is `45.71%`.
[](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6431 +/- ##
============================================
+ Coverage 51.86% 53.27% +1.40%
- Complexity 3794 4051 +257
============================================
Files 1016 1789 +773
Lines 24957 38202 +13245
Branches 2447 4222 +1775
============================================
+ Hits 12945 20351 +7406
- Misses 10900 16855 +5955
+ Partials 1112 996 -116
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/alarm/provider/slack/SlackhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9zbGFjay9TbGFja2hvb2tDYWxsYmFjay5qYXZh) | `21.56% <0.00%> (-4.02%)` | `3.00 <0.00> (ø)` | |
| [...ap/server/core/alarm/provider/WebhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9XZWJob29rQ2FsbGJhY2suamF2YQ==) | `62.79% <57.14%> (-8.64%)` | `4.00 <0.00> (ø)` | |
| [.../alarm/provider/dingtalk/DingtalkHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9kaW5ndGFsay9EaW5ndGFsa0hvb2tDYWxsYmFjay5qYXZh) | `73.77% <57.14%> (+54.90%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/feishu/FeishuHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9mZWlzaHUvRmVpc2h1SG9va0NhbGxiYWNrLmphdmE=) | `79.48% <57.14%> (+65.20%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `71.73% <57.14%> (+45.42%)` | `3.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `30.23% <0.00%> (-62.63%)` | `3.00% <0.00%> (ø%)` | |
| [...r/receiver/event/grpc/EventGrpcServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctZXZlbnQtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZXZlbnQvZ3JwYy9FdmVudEdycGNTZXJ2aWNlSGFuZGxlci5qYXZh) | `42.30% <0.00%> (-49.36%)` | `2.00% <0.00%> (ø%)` | |
| [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `17.85% <0.00%> (-37.70%)` | `2.00% <0.00%> (ø%)` | |
| [...ient/elasticsearch/ElasticSearchInsertRequest.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaEluc2VydFJlcXVlc3QuamF2YQ==) | `80.00% <0.00%> (-20.00%)` | `2.00% <0.00%> (ø%)` | |
| [...ient/elasticsearch/ElasticSearchUpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaFVwZGF0ZVJlcXVlc3QuamF2YQ==) | `80.00% <0.00%> (-20.00%)` | `2.00% <0.00%> (ø%)` | |
| ... and [1263 more](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=footer). Last update [8c3d167...3573922](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6431: Fix alarm httpclient connection leak
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6431:
URL: https://github.com/apache/skywalking/pull/6431#issuecomment-784759581
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=h1) Report
> Merging [#6431](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=desc) (700fa56) into [master](https://codecov.io/gh/apache/skywalking/commit/1c52995cbf26fa1442ba6b81fb3c4635625e3702?el=desc) (1c52995) will **decrease** coverage by `7.11%`.
> The diff coverage is `41.81%`.
[](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6431 +/- ##
============================================
- Coverage 56.82% 49.71% -7.12%
+ Complexity 3970 3647 -323
============================================
Files 985 999 +14
Lines 24397 24571 +174
Branches 2401 2393 -8
============================================
- Hits 13864 12215 -1649
- Misses 9305 11268 +1963
+ Partials 1228 1088 -140
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/log/analyzer/dsl/spec/sink/sampler/Sampler.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvU2FtcGxlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ap/server/core/alarm/provider/WebhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9XZWJob29rQ2FsbGJhY2suamF2YQ==) | `25.00% <0.00%> (-46.43%)` | `2.00 <0.00> (-2.00)` | |
| [.../alarm/provider/dingtalk/DingtalkHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9kaW5ndGFsay9EaW5ndGFsa0hvb2tDYWxsYmFjay5qYXZh) | `16.98% <0.00%> (-1.89%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/feishu/FeishuHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9mZWlzaHUvRmVpc2h1SG9va0NhbGxiYWNrLmphdmE=) | `12.85% <0.00%> (-1.43%)` | `2.00 <0.00> (-1.00)` | |
| [...r/core/alarm/provider/slack/SlackhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9zbGFjay9TbGFja2hvb2tDYWxsYmFjay5qYXZh) | `20.83% <0.00%> (-4.75%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <0.00%> (-2.64%)` | `2.00 <0.00> (-1.00)` | |
| [...zer/dsl/spec/sink/sampler/RateLimitingSampler.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvUmF0ZUxpbWl0aW5nU2FtcGxlci5qYXZh) | `12.12% <12.12%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `18.51% <18.51%> (ø)` | `2.00 <2.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `18.75% <18.75%> (ø)` | `1.00 <1.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `26.43% <26.43%> (ø)` | `4.00 <4.00> (?)` | |
| ... and [164 more](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=footer). Last update [665a07c...b7520a5](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6431: Fix alarm httpclient connection leak
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6431:
URL: https://github.com/apache/skywalking/pull/6431#issuecomment-784759581
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=h1) Report
> Merging [#6431](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=desc) (b8320cc) into [master](https://codecov.io/gh/apache/skywalking/commit/0f8b6d641a963adafd3f4dd2a7388dfd27a626c9?el=desc) (0f8b6d6) will **decrease** coverage by `5.24%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6431 +/- ##
============================================
- Coverage 53.66% 48.41% -5.25%
+ Complexity 4069 3513 -556
============================================
Files 1789 999 -790
Lines 38172 24592 -13580
Branches 4217 2414 -1803
============================================
- Hits 20484 11906 -8578
+ Misses 16688 11654 -5034
- Partials 1000 1032 +32
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/server/core/alarm/provider/WebhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9XZWJob29rQ2FsbGJhY2suamF2YQ==) | `25.00% <0.00%> (-42.57%)` | `2.00 <0.00> (-2.00)` | |
| [.../alarm/provider/dingtalk/DingtalkHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9kaW5ndGFsay9EaW5ndGFsa0hvb2tDYWxsYmFjay5qYXZh) | `15.51% <0.00%> (-62.67%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/feishu/FeishuHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9mZWlzaHUvRmVpc2h1SG9va0NhbGxiYWNrLmphdmE=) | `12.00% <0.00%> (-71.34%)` | `2.00 <0.00> (-1.00)` | |
| [...r/core/alarm/provider/slack/SlackhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9zbGFjay9TbGFja2hvb2tDYWxsYmFjay5qYXZh) | `20.83% <0.00%> (-3.62%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `20.93% <0.00%> (-56.57%)` | `2.00 <0.00> (-1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1299 more](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=footer). Last update [08bceb9...f55956d](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6431: Fix alarm httpclient connection leak
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6431:
URL: https://github.com/apache/skywalking/pull/6431#issuecomment-784759581
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=h1) Report
> Merging [#6431](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=desc) (b8320cc) into [master](https://codecov.io/gh/apache/skywalking/commit/0f8b6d641a963adafd3f4dd2a7388dfd27a626c9?el=desc) (0f8b6d6) will **decrease** coverage by `2.50%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6431 +/- ##
============================================
- Coverage 53.66% 51.15% -2.51%
+ Complexity 4069 3705 -364
============================================
Files 1789 999 -790
Lines 38172 24623 -13549
Branches 4217 2415 -1802
============================================
- Hits 20484 12596 -7888
+ Misses 16688 10902 -5786
- Partials 1000 1125 +125
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/server/core/alarm/provider/WebhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9XZWJob29rQ2FsbGJhY2suamF2YQ==) | `25.00% <0.00%> (-42.57%)` | `2.00 <0.00> (-2.00)` | |
| [.../alarm/provider/dingtalk/DingtalkHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9kaW5ndGFsay9EaW5ndGFsa0hvb2tDYWxsYmFjay5qYXZh) | `15.51% <0.00%> (-62.67%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/feishu/FeishuHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9mZWlzaHUvRmVpc2h1SG9va0NhbGxiYWNrLmphdmE=) | `12.00% <0.00%> (-71.34%)` | `2.00 <0.00> (-1.00)` | |
| [...r/core/alarm/provider/slack/SlackhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9zbGFjay9TbGFja2hvb2tDYWxsYmFjay5qYXZh) | `20.83% <0.00%> (-3.62%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `20.93% <0.00%> (-56.57%)` | `2.00 <0.00> (-1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1268 more](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=footer). Last update [08bceb9...f55956d](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6431: Fix alarm httpclient connection leak
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6431:
URL: https://github.com/apache/skywalking/pull/6431#issuecomment-784759581
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=h1) Report
> Merging [#6431](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=desc) (5c8c304) into [master](https://codecov.io/gh/apache/skywalking/commit/8c3d1679e37f992b697835b2402401a26eac19e8?el=desc) (8c3d167) will **increase** coverage by `0.53%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6431 +/- ##
============================================
+ Coverage 51.86% 52.40% +0.53%
+ Complexity 3794 3780 -14
============================================
Files 1016 999 -17
Lines 24957 24618 -339
Branches 2447 2400 -47
============================================
- Hits 12945 12900 -45
+ Misses 10900 10568 -332
- Partials 1112 1150 +38
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/server/core/alarm/provider/WebhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9XZWJob29rQ2FsbGJhY2suamF2YQ==) | `25.00% <0.00%> (-46.43%)` | `2.00 <0.00> (-2.00)` | |
| [.../alarm/provider/dingtalk/DingtalkHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9kaW5ndGFsay9EaW5ndGFsa0hvb2tDYWxsYmFjay5qYXZh) | `15.51% <0.00%> (-3.36%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/feishu/FeishuHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9mZWlzaHUvRmVpc2h1SG9va0NhbGxiYWNrLmphdmE=) | `12.00% <0.00%> (-2.29%)` | `2.00 <0.00> (-1.00)` | |
| [...r/core/alarm/provider/slack/SlackhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9zbGFjay9TbGFja2hvb2tDYWxsYmFjay5qYXZh) | `20.83% <0.00%> (-4.75%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `20.93% <0.00%> (-5.39%)` | `2.00 <0.00> (-1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh) | `4.65% <0.00%> (-89.54%)` | `1.00% <0.00%> (-10.00%)` | |
| [...tworkalias/NetworkAddressAliasSetupDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzU2V0dXBEaXNwYXRjaGVyLmphdmE=) | `11.11% <0.00%> (-88.89%)` | `1.00% <0.00%> (-1.00%)` | |
| [...lugin/elasticsearch/query/ProfileTaskLogEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRhc2tMb2dFc0RBTy5qYXZh) | `13.63% <0.00%> (-86.37%)` | `1.00% <0.00%> (-3.00%)` | |
| [...er/core/server/auth/AuthenticationInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL2F1dGgvQXV0aGVudGljYXRpb25JbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (-84.62%)` | `0.00% <0.00%> (-4.00%)` | |
| ... and [131 more](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=footer). Last update [8c3d167...3573922](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6431: Fix alarm httpclient connection leak
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6431:
URL: https://github.com/apache/skywalking/pull/6431#issuecomment-784759581
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=h1) Report
> Merging [#6431](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=desc) (5c8c304) into [master](https://codecov.io/gh/apache/skywalking/commit/8c3d1679e37f992b697835b2402401a26eac19e8?el=desc) (8c3d167) will **decrease** coverage by `10.04%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6431 +/- ##
=============================================
- Coverage 45.34% 35.29% -10.05%
+ Complexity 3454 2279 -1175
=============================================
Files 1016 847 -169
Lines 24860 20869 -3991
Branches 2421 1980 -441
=============================================
- Hits 11273 7366 -3907
- Misses 12608 12951 +343
+ Partials 979 552 -427
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/server/core/alarm/provider/WebhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9XZWJob29rQ2FsbGJhY2suamF2YQ==) | `25.00% <0.00%> (-3.58%)` | `2.00 <0.00> (ø)` | |
| [.../alarm/provider/dingtalk/DingtalkHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9kaW5ndGFsay9EaW5ndGFsa0hvb2tDYWxsYmFjay5qYXZh) | `15.51% <0.00%> (-1.47%)` | `2.00 <0.00> (ø)` | |
| [...core/alarm/provider/feishu/FeishuHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9mZWlzaHUvRmVpc2h1SG9va0NhbGxiYWNrLmphdmE=) | `12.00% <0.00%> (-0.86%)` | `2.00 <0.00> (ø)` | |
| [...r/core/alarm/provider/slack/SlackhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9zbGFjay9TbGFja2hvb2tDYWxsYmFjay5qYXZh) | `20.83% <0.00%> (-2.43%)` | `2.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `20.93% <0.00%> (-2.76%)` | `2.00 <0.00> (ø)` | |
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/oap/server/core/source/MemoryPoolType.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL01lbW9yeVBvb2xUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/oap/server/core/analysis/record/Record.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvcmVjb3JkL1JlY29yZC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/analysis/metrics/SumMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9TdW1NZXRyaWNzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [...m/network/trace/component/command/BaseCommand.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0Jhc2VDb21tYW5kLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| ... and [320 more](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=footer). Last update [8c3d167...3573922](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6431: Fix alarm httpclient connection leak
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6431:
URL: https://github.com/apache/skywalking/pull/6431#issuecomment-784759581
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=h1) Report
> Merging [#6431](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=desc) (b7520a5) into [master](https://codecov.io/gh/apache/skywalking/commit/1c52995cbf26fa1442ba6b81fb3c4635625e3702?el=desc) (1c52995) will **decrease** coverage by `5.25%`.
> The diff coverage is `41.81%`.
[](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6431 +/- ##
============================================
- Coverage 56.82% 51.56% -5.26%
+ Complexity 3970 3717 -253
============================================
Files 985 999 +14
Lines 24397 24618 +221
Branches 2401 2411 +10
============================================
- Hits 13864 12695 -1169
- Misses 9305 10822 +1517
+ Partials 1228 1101 -127
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/log/analyzer/dsl/spec/sink/sampler/Sampler.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvU2FtcGxlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ap/server/core/alarm/provider/WebhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9XZWJob29rQ2FsbGJhY2suamF2YQ==) | `25.00% <0.00%> (-46.43%)` | `2.00 <0.00> (-2.00)` | |
| [.../alarm/provider/dingtalk/DingtalkHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9kaW5ndGFsay9EaW5ndGFsa0hvb2tDYWxsYmFjay5qYXZh) | `16.98% <0.00%> (-1.89%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/feishu/FeishuHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9mZWlzaHUvRmVpc2h1SG9va0NhbGxiYWNrLmphdmE=) | `12.85% <0.00%> (-1.43%)` | `2.00 <0.00> (-1.00)` | |
| [...r/core/alarm/provider/slack/SlackhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9zbGFjay9TbGFja2hvb2tDYWxsYmFjay5qYXZh) | `20.83% <0.00%> (-4.75%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <0.00%> (-2.64%)` | `2.00 <0.00> (-1.00)` | |
| [...zer/dsl/spec/sink/sampler/RateLimitingSampler.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvUmF0ZUxpbWl0aW5nU2FtcGxlci5qYXZh) | `12.12% <12.12%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `18.51% <18.51%> (ø)` | `2.00 <2.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `18.75% <18.75%> (ø)` | `1.00 <1.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `26.43% <26.43%> (ø)` | `4.00 <4.00> (?)` | |
| ... and [148 more](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=footer). Last update [665a07c...b7520a5](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6431: Fix alarm httpclient connection leak
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6431:
URL: https://github.com/apache/skywalking/pull/6431#issuecomment-784759581
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=h1) Report
> Merging [#6431](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=desc) (b7520a5) into [master](https://codecov.io/gh/apache/skywalking/commit/1c52995cbf26fa1442ba6b81fb3c4635625e3702?el=desc) (1c52995) will **decrease** coverage by `4.64%`.
> The diff coverage is `41.81%`.
[](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6431 +/- ##
============================================
- Coverage 56.82% 52.17% -4.65%
+ Complexity 3970 3760 -210
============================================
Files 985 999 +14
Lines 24397 24618 +221
Branches 2401 2411 +10
============================================
- Hits 13864 12845 -1019
- Misses 9305 10671 +1366
+ Partials 1228 1102 -126
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/log/analyzer/dsl/spec/sink/sampler/Sampler.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvU2FtcGxlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ap/server/core/alarm/provider/WebhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9XZWJob29rQ2FsbGJhY2suamF2YQ==) | `25.00% <0.00%> (-46.43%)` | `2.00 <0.00> (-2.00)` | |
| [.../alarm/provider/dingtalk/DingtalkHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9kaW5ndGFsay9EaW5ndGFsa0hvb2tDYWxsYmFjay5qYXZh) | `16.98% <0.00%> (-1.89%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/feishu/FeishuHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9mZWlzaHUvRmVpc2h1SG9va0NhbGxiYWNrLmphdmE=) | `12.85% <0.00%> (-1.43%)` | `2.00 <0.00> (-1.00)` | |
| [...r/core/alarm/provider/slack/SlackhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9zbGFjay9TbGFja2hvb2tDYWxsYmFjay5qYXZh) | `20.83% <0.00%> (-4.75%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <0.00%> (-2.64%)` | `2.00 <0.00> (-1.00)` | |
| [...zer/dsl/spec/sink/sampler/RateLimitingSampler.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvUmF0ZUxpbWl0aW5nU2FtcGxlci5qYXZh) | `12.12% <12.12%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `18.51% <18.51%> (ø)` | `2.00 <2.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `18.75% <18.75%> (ø)` | `1.00 <1.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `26.43% <26.43%> (ø)` | `4.00 <4.00> (?)` | |
| ... and [139 more](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=footer). Last update [665a07c...b7520a5](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6431: Fix alarm httpclient connection leak
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6431:
URL: https://github.com/apache/skywalking/pull/6431#issuecomment-784759581
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=h1) Report
> Merging [#6431](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=desc) (5c8c304) into [master](https://codecov.io/gh/apache/skywalking/commit/8c3d1679e37f992b697835b2402401a26eac19e8?el=desc) (8c3d167) will **increase** coverage by `2.48%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6431 +/- ##
============================================
+ Coverage 51.86% 54.35% +2.48%
- Complexity 3794 3876 +82
============================================
Files 1016 999 -17
Lines 24957 24638 -319
Branches 2447 2401 -46
============================================
+ Hits 12945 13391 +446
+ Misses 10900 10093 -807
- Partials 1112 1154 +42
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/server/core/alarm/provider/WebhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9XZWJob29rQ2FsbGJhY2suamF2YQ==) | `25.00% <0.00%> (-46.43%)` | `2.00 <0.00> (-2.00)` | |
| [.../alarm/provider/dingtalk/DingtalkHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9kaW5ndGFsay9EaW5ndGFsa0hvb2tDYWxsYmFjay5qYXZh) | `15.51% <0.00%> (-3.36%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/feishu/FeishuHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9mZWlzaHUvRmVpc2h1SG9va0NhbGxiYWNrLmphdmE=) | `12.00% <0.00%> (-2.29%)` | `2.00 <0.00> (-1.00)` | |
| [...r/core/alarm/provider/slack/SlackhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9zbGFjay9TbGFja2hvb2tDYWxsYmFjay5qYXZh) | `20.83% <0.00%> (-4.75%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `20.93% <0.00%> (-5.39%)` | `2.00 <0.00> (-1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | `0.00% <0.00%> (-6.00%)` | |
| [...ap/server/core/alarm/AlarmStandardPersistence.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1TdGFuZGFyZFBlcnNpc3RlbmNlLmphdmE=) | `11.76% <0.00%> (-76.48%)` | `2.00% <0.00%> (-2.00%)` | |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...er/core/alarm/provider/CompositeRuleEvaluator.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdG9yLmphdmE=) | `9.52% <0.00%> (-73.81%)` | `1.00% <0.00%> (-6.00%)` | |
| ... and [97 more](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=footer). Last update [8c3d167...3573922](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6431: Fix alarm httpclient connection leak
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6431:
URL: https://github.com/apache/skywalking/pull/6431#issuecomment-784759581
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=h1) Report
> Merging [#6431](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=desc) (3573922) into [master](https://codecov.io/gh/apache/skywalking/commit/8c3d1679e37f992b697835b2402401a26eac19e8?el=desc) (8c3d167) will **decrease** coverage by `15.30%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6431 +/- ##
=============================================
- Coverage 51.80% 36.50% -15.31%
+ Complexity 3788 2242 -1546
=============================================
Files 1016 831 -185
Lines 24957 20406 -4551
Branches 2447 1948 -499
=============================================
- Hits 12930 7449 -5481
- Misses 10913 12415 +1502
+ Partials 1114 542 -572
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/server/core/alarm/provider/WebhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9XZWJob29rQ2FsbGJhY2suamF2YQ==) | `25.00% <0.00%> (-46.43%)` | `2.00 <0.00> (-2.00)` | |
| [.../alarm/provider/dingtalk/DingtalkHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9kaW5ndGFsay9EaW5ndGFsa0hvb2tDYWxsYmFjay5qYXZh) | `15.51% <0.00%> (-3.36%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/feishu/FeishuHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9mZWlzaHUvRmVpc2h1SG9va0NhbGxiYWNrLmphdmE=) | `12.00% <0.00%> (-2.29%)` | `2.00 <0.00> (-1.00)` | |
| [...r/core/alarm/provider/slack/SlackhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9zbGFjay9TbGFja2hvb2tDYWxsYmFjay5qYXZh) | `20.83% <0.00%> (-4.75%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `20.93% <0.00%> (-5.39%)` | `2.00 <0.00> (-1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [389 more](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=footer). Last update [8c3d167...3573922](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6431: Fix alarm httpclient connection leak
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6431:
URL: https://github.com/apache/skywalking/pull/6431#issuecomment-784759581
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=h1) Report
> Merging [#6431](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=desc) (b8320cc) into [master](https://codecov.io/gh/apache/skywalking/commit/0f8b6d641a963adafd3f4dd2a7388dfd27a626c9?el=desc) (0f8b6d6) will **decrease** coverage by `5.13%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6431 +/- ##
============================================
- Coverage 53.66% 48.52% -5.14%
+ Complexity 4069 3519 -550
============================================
Files 1789 999 -790
Lines 38172 24592 -13580
Branches 4217 2414 -1803
============================================
- Hits 20484 11933 -8551
+ Misses 16688 11624 -5064
- Partials 1000 1035 +35
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/server/core/alarm/provider/WebhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9XZWJob29rQ2FsbGJhY2suamF2YQ==) | `25.00% <0.00%> (-42.57%)` | `2.00 <0.00> (-2.00)` | |
| [.../alarm/provider/dingtalk/DingtalkHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9kaW5ndGFsay9EaW5ndGFsa0hvb2tDYWxsYmFjay5qYXZh) | `15.51% <0.00%> (-62.67%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/feishu/FeishuHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9mZWlzaHUvRmVpc2h1SG9va0NhbGxiYWNrLmphdmE=) | `12.00% <0.00%> (-71.34%)` | `2.00 <0.00> (-1.00)` | |
| [...r/core/alarm/provider/slack/SlackhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9zbGFjay9TbGFja2hvb2tDYWxsYmFjay5qYXZh) | `20.83% <0.00%> (-3.62%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `20.93% <0.00%> (-56.57%)` | `2.00 <0.00> (-1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1299 more](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=footer). Last update [08bceb9...f55956d](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6431: Fix alarm httpclient connection leak
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6431:
URL: https://github.com/apache/skywalking/pull/6431#issuecomment-784759581
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=h1) Report
> Merging [#6431](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=desc) (5c8c304) into [master](https://codecov.io/gh/apache/skywalking/commit/8c3d1679e37f992b697835b2402401a26eac19e8?el=desc) (8c3d167) will **decrease** coverage by `1.01%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6431 +/- ##
============================================
- Coverage 51.80% 50.79% -1.02%
+ Complexity 3788 3653 -135
============================================
Files 1016 999 -17
Lines 24957 24600 -357
Branches 2447 2399 -48
============================================
- Hits 12930 12496 -434
- Misses 10913 11017 +104
+ Partials 1114 1087 -27
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/server/core/alarm/provider/WebhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9XZWJob29rQ2FsbGJhY2suamF2YQ==) | `25.00% <0.00%> (-46.43%)` | `2.00 <0.00> (-2.00)` | |
| [.../alarm/provider/dingtalk/DingtalkHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9kaW5ndGFsay9EaW5ndGFsa0hvb2tDYWxsYmFjay5qYXZh) | `15.51% <0.00%> (-3.36%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/feishu/FeishuHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9mZWlzaHUvRmVpc2h1SG9va0NhbGxiYWNrLmphdmE=) | `12.00% <0.00%> (-2.29%)` | `2.00 <0.00> (-1.00)` | |
| [...r/core/alarm/provider/slack/SlackhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9zbGFjay9TbGFja2hvb2tDYWxsYmFjay5qYXZh) | `20.83% <0.00%> (-4.75%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `20.93% <0.00%> (-5.39%)` | `2.00 <0.00> (-1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [.../provider/parser/performance/PerfDataAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL3BhcnNlci9wZXJmb3JtYW5jZS9QZXJmRGF0YUFuYWx5emVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...ovider/parser/errorlog/listener/SourceBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL3BhcnNlci9lcnJvcmxvZy9saXN0ZW5lci9Tb3VyY2VCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| ... and [151 more](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=footer). Last update [8c3d167...3573922](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6431: Fix alarm httpclient connection leak
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6431:
URL: https://github.com/apache/skywalking/pull/6431#issuecomment-784759581
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=h1) Report
> Merging [#6431](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=desc) (3573922) into [master](https://codecov.io/gh/apache/skywalking/commit/8c3d1679e37f992b697835b2402401a26eac19e8?el=desc) (8c3d167) will **decrease** coverage by `15.66%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6431 +/- ##
=============================================
- Coverage 51.13% 35.47% -15.67%
+ Complexity 3745 2180 -1565
=============================================
Files 1016 831 -185
Lines 24957 20406 -4551
Branches 2447 1948 -499
=============================================
- Hits 12762 7239 -5523
- Misses 11096 12624 +1528
+ Partials 1099 543 -556
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/server/core/alarm/provider/WebhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9XZWJob29rQ2FsbGJhY2suamF2YQ==) | `25.00% <0.00%> (-3.58%)` | `2.00 <0.00> (ø)` | |
| [.../alarm/provider/dingtalk/DingtalkHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9kaW5ndGFsay9EaW5ndGFsa0hvb2tDYWxsYmFjay5qYXZh) | `15.51% <0.00%> (-1.47%)` | `2.00 <0.00> (ø)` | |
| [...core/alarm/provider/feishu/FeishuHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9mZWlzaHUvRmVpc2h1SG9va0NhbGxiYWNrLmphdmE=) | `12.00% <0.00%> (-0.86%)` | `2.00 <0.00> (ø)` | |
| [...r/core/alarm/provider/slack/SlackhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9zbGFjay9TbGFja2hvb2tDYWxsYmFjay5qYXZh) | `20.83% <0.00%> (-2.43%)` | `2.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `20.93% <0.00%> (-2.76%)` | `2.00 <0.00> (ø)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...server/storage/plugin/influxdb/base/RecordDAO.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL1JlY29yZERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-7.00%)` | |
| ... and [382 more](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=footer). Last update [8c3d167...3573922](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6431: Fix alarm httpclient connection leak
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6431:
URL: https://github.com/apache/skywalking/pull/6431#issuecomment-784759581
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=h1) Report
> Merging [#6431](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=desc) (3573922) into [master](https://codecov.io/gh/apache/skywalking/commit/8c3d1679e37f992b697835b2402401a26eac19e8?el=desc) (8c3d167) will **decrease** coverage by `5.81%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6431 +/- ##
============================================
- Coverage 51.84% 46.02% -5.82%
+ Complexity 3792 3461 -331
============================================
Files 1016 999 -17
Lines 24957 24602 -355
Branches 2447 2413 -34
============================================
- Hits 12939 11324 -1615
- Misses 10908 12308 +1400
+ Partials 1110 970 -140
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/server/core/alarm/provider/WebhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9XZWJob29rQ2FsbGJhY2suamF2YQ==) | `25.00% <0.00%> (-46.43%)` | `2.00 <0.00> (-2.00)` | |
| [.../alarm/provider/dingtalk/DingtalkHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9kaW5ndGFsay9EaW5ndGFsa0hvb2tDYWxsYmFjay5qYXZh) | `15.51% <0.00%> (-3.36%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/feishu/FeishuHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9mZWlzaHUvRmVpc2h1SG9va0NhbGxiYWNrLmphdmE=) | `12.00% <0.00%> (-2.29%)` | `2.00 <0.00> (-1.00)` | |
| [...r/core/alarm/provider/slack/SlackhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9zbGFjay9TbGFja2hvb2tDYWxsYmFjay5qYXZh) | `20.83% <0.00%> (-4.75%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `20.93% <0.00%> (-5.39%)` | `2.00 <0.00> (-1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...in/elasticsearch/base/TimeRangeIndexNameMaker.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9UaW1lUmFuZ2VJbmRleE5hbWVNYWtlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh) | `4.65% <0.00%> (-89.54%)` | `1.00% <0.00%> (-10.00%)` | |
| [...tworkalias/NetworkAddressAliasSetupDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzU2V0dXBEaXNwYXRjaGVyLmphdmE=) | `11.11% <0.00%> (-88.89%)` | `1.00% <0.00%> (-1.00%)` | |
| ... and [181 more](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=footer). Last update [8c3d167...3573922](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6431: Fix alarm httpclient connection leak
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6431:
URL: https://github.com/apache/skywalking/pull/6431#issuecomment-784759581
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6431: Fix alarm httpclient connection leak
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6431:
URL: https://github.com/apache/skywalking/pull/6431#issuecomment-784759581
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=h1) Report
> Merging [#6431](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=desc) (b8320cc) into [master](https://codecov.io/gh/apache/skywalking/commit/0f8b6d641a963adafd3f4dd2a7388dfd27a626c9?el=desc) (0f8b6d6) will **decrease** coverage by `5.11%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6431 +/- ##
============================================
- Coverage 53.66% 48.55% -5.11%
+ Complexity 4069 3522 -547
============================================
Files 1789 999 -790
Lines 38172 24592 -13580
Branches 4217 2414 -1803
============================================
- Hits 20484 11940 -8544
+ Misses 16688 11617 -5071
- Partials 1000 1035 +35
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/server/core/alarm/provider/WebhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9XZWJob29rQ2FsbGJhY2suamF2YQ==) | `25.00% <0.00%> (-42.57%)` | `2.00 <0.00> (-2.00)` | |
| [.../alarm/provider/dingtalk/DingtalkHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9kaW5ndGFsay9EaW5ndGFsa0hvb2tDYWxsYmFjay5qYXZh) | `15.51% <0.00%> (-62.67%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/feishu/FeishuHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9mZWlzaHUvRmVpc2h1SG9va0NhbGxiYWNrLmphdmE=) | `12.00% <0.00%> (-71.34%)` | `2.00 <0.00> (-1.00)` | |
| [...r/core/alarm/provider/slack/SlackhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9zbGFjay9TbGFja2hvb2tDYWxsYmFjay5qYXZh) | `20.83% <0.00%> (-3.62%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `20.93% <0.00%> (-56.57%)` | `2.00 <0.00> (-1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1299 more](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=footer). Last update [08bceb9...f55956d](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6431: Fix alarm httpclient connection leak
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6431:
URL: https://github.com/apache/skywalking/pull/6431#issuecomment-784759581
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=h1) Report
> Merging [#6431](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=desc) (b7520a5) into [master](https://codecov.io/gh/apache/skywalking/commit/1c52995cbf26fa1442ba6b81fb3c4635625e3702?el=desc) (1c52995) will **decrease** coverage by `5.91%`.
> The diff coverage is `41.81%`.
[](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6431 +/- ##
============================================
- Coverage 56.82% 50.90% -5.92%
+ Complexity 3970 3692 -278
============================================
Files 985 999 +14
Lines 24397 24618 +221
Branches 2401 2411 +10
============================================
- Hits 13864 12533 -1331
- Misses 9305 10987 +1682
+ Partials 1228 1098 -130
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/log/analyzer/dsl/spec/sink/sampler/Sampler.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvU2FtcGxlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ap/server/core/alarm/provider/WebhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9XZWJob29rQ2FsbGJhY2suamF2YQ==) | `25.00% <0.00%> (-46.43%)` | `2.00 <0.00> (-2.00)` | |
| [.../alarm/provider/dingtalk/DingtalkHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9kaW5ndGFsay9EaW5ndGFsa0hvb2tDYWxsYmFjay5qYXZh) | `16.98% <0.00%> (-1.89%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/feishu/FeishuHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9mZWlzaHUvRmVpc2h1SG9va0NhbGxiYWNrLmphdmE=) | `12.85% <0.00%> (-1.43%)` | `2.00 <0.00> (-1.00)` | |
| [...r/core/alarm/provider/slack/SlackhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9zbGFjay9TbGFja2hvb2tDYWxsYmFjay5qYXZh) | `20.83% <0.00%> (-4.75%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <0.00%> (-2.64%)` | `2.00 <0.00> (-1.00)` | |
| [...zer/dsl/spec/sink/sampler/RateLimitingSampler.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvUmF0ZUxpbWl0aW5nU2FtcGxlci5qYXZh) | `12.12% <12.12%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `18.51% <18.51%> (ø)` | `2.00 <2.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `18.75% <18.75%> (ø)` | `1.00 <1.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `26.43% <26.43%> (ø)` | `4.00 <4.00> (?)` | |
| ... and [153 more](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=footer). Last update [665a07c...b7520a5](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6431: Fix alarm httpclient connection leak
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6431:
URL: https://github.com/apache/skywalking/pull/6431#issuecomment-784759581
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=h1) Report
> Merging [#6431](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=desc) (f55956d) into [master](https://codecov.io/gh/apache/skywalking/commit/0f8b6d641a963adafd3f4dd2a7388dfd27a626c9?el=desc) (0f8b6d6) will **decrease** coverage by `19.82%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6431 +/- ##
=============================================
- Coverage 53.66% 33.84% -19.83%
+ Complexity 4069 2050 -2019
=============================================
Files 1789 830 -959
Lines 38172 20257 -17915
Branches 4217 1897 -2320
=============================================
- Hits 20484 6855 -13629
+ Misses 16688 12910 -3778
+ Partials 1000 492 -508
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/server/core/alarm/provider/WebhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9XZWJob29rQ2FsbGJhY2suamF2YQ==) | `25.00% <0.00%> (-42.57%)` | `2.00 <0.00> (-2.00)` | |
| [.../alarm/provider/dingtalk/DingtalkHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9kaW5ndGFsay9EaW5ndGFsa0hvb2tDYWxsYmFjay5qYXZh) | `15.51% <0.00%> (-62.67%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/feishu/FeishuHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9mZWlzaHUvRmVpc2h1SG9va0NhbGxiYWNrLmphdmE=) | `12.00% <0.00%> (-71.34%)` | `2.00 <0.00> (-1.00)` | |
| [...r/core/alarm/provider/slack/SlackhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9zbGFjay9TbGFja2hvb2tDYWxsYmFjay5qYXZh) | `20.83% <0.00%> (-3.62%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `20.93% <0.00%> (-56.57%)` | `2.00 <0.00> (-1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1425 more](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=footer). Last update [08bceb9...f55956d](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6431: Fix alarm httpclient connection leak
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6431:
URL: https://github.com/apache/skywalking/pull/6431#issuecomment-784759581
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=h1) Report
> Merging [#6431](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=desc) (b7520a5) into [master](https://codecov.io/gh/apache/skywalking/commit/1c52995cbf26fa1442ba6b81fb3c4635625e3702?el=desc) (1c52995) will **decrease** coverage by `2.25%`.
> The diff coverage is `41.81%`.
[](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6431 +/- ##
============================================
- Coverage 56.82% 54.57% -2.26%
+ Complexity 3970 3915 -55
============================================
Files 985 999 +14
Lines 24397 24760 +363
Branches 2401 2425 +24
============================================
- Hits 13864 13513 -351
- Misses 9305 10097 +792
+ Partials 1228 1150 -78
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/log/analyzer/dsl/spec/sink/sampler/Sampler.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvU2FtcGxlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ap/server/core/alarm/provider/WebhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9XZWJob29rQ2FsbGJhY2suamF2YQ==) | `25.00% <0.00%> (-46.43%)` | `2.00 <0.00> (-2.00)` | |
| [.../alarm/provider/dingtalk/DingtalkHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9kaW5ndGFsay9EaW5ndGFsa0hvb2tDYWxsYmFjay5qYXZh) | `16.98% <0.00%> (-1.89%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/feishu/FeishuHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9mZWlzaHUvRmVpc2h1SG9va0NhbGxiYWNrLmphdmE=) | `12.85% <0.00%> (-1.43%)` | `2.00 <0.00> (-1.00)` | |
| [...r/core/alarm/provider/slack/SlackhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9zbGFjay9TbGFja2hvb2tDYWxsYmFjay5qYXZh) | `20.83% <0.00%> (-4.75%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <0.00%> (-2.64%)` | `2.00 <0.00> (-1.00)` | |
| [...zer/dsl/spec/sink/sampler/RateLimitingSampler.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvUmF0ZUxpbWl0aW5nU2FtcGxlci5qYXZh) | `12.12% <12.12%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `18.51% <18.51%> (ø)` | `2.00 <2.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `18.75% <18.75%> (ø)` | `1.00 <1.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `26.43% <26.43%> (ø)` | `4.00 <4.00> (?)` | |
| ... and [121 more](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=footer). Last update [665a07c...b7520a5](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6431: Fix alarm httpclient connection leak
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6431:
URL: https://github.com/apache/skywalking/pull/6431#issuecomment-784759581
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=h1) Report
> Merging [#6431](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=desc) (700fa56) into [master](https://codecov.io/gh/apache/skywalking/commit/1c52995cbf26fa1442ba6b81fb3c4635625e3702?el=desc) (1c52995) will **decrease** coverage by `7.79%`.
> The diff coverage is `41.81%`.
[](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6431 +/- ##
============================================
- Coverage 56.82% 49.02% -7.80%
+ Complexity 3970 3602 -368
============================================
Files 985 998 +13
Lines 24397 24526 +129
Branches 2401 2389 -12
============================================
- Hits 13864 12025 -1839
- Misses 9305 11437 +2132
+ Partials 1228 1064 -164
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/log/analyzer/dsl/spec/sink/sampler/Sampler.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvU2FtcGxlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ap/server/core/alarm/provider/WebhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9XZWJob29rQ2FsbGJhY2suamF2YQ==) | `25.00% <0.00%> (-46.43%)` | `2.00 <0.00> (-2.00)` | |
| [.../alarm/provider/dingtalk/DingtalkHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9kaW5ndGFsay9EaW5ndGFsa0hvb2tDYWxsYmFjay5qYXZh) | `16.98% <0.00%> (-1.89%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/feishu/FeishuHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9mZWlzaHUvRmVpc2h1SG9va0NhbGxiYWNrLmphdmE=) | `12.85% <0.00%> (-1.43%)` | `2.00 <0.00> (-1.00)` | |
| [...r/core/alarm/provider/slack/SlackhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9zbGFjay9TbGFja2hvb2tDYWxsYmFjay5qYXZh) | `20.83% <0.00%> (-4.75%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <0.00%> (-2.64%)` | `2.00 <0.00> (-1.00)` | |
| [...zer/dsl/spec/sink/sampler/RateLimitingSampler.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvUmF0ZUxpbWl0aW5nU2FtcGxlci5qYXZh) | `12.12% <12.12%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `18.51% <18.51%> (ø)` | `2.00 <2.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `18.75% <18.75%> (ø)` | `1.00 <1.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `26.43% <26.43%> (ø)` | `4.00 <4.00> (?)` | |
| ... and [193 more](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=footer). Last update [665a07c...b7520a5](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6431: Fix alarm httpclient connection leak
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6431:
URL: https://github.com/apache/skywalking/pull/6431#issuecomment-784759581
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=h1) Report
> Merging [#6431](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=desc) (5c8c304) into [master](https://codecov.io/gh/apache/skywalking/commit/8c3d1679e37f992b697835b2402401a26eac19e8?el=desc) (8c3d167) will **increase** coverage by `2.37%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6431 +/- ##
============================================
+ Coverage 51.86% 54.24% +2.37%
- Complexity 3794 3866 +72
============================================
Files 1016 999 -17
Lines 24957 24638 -319
Branches 2447 2401 -46
============================================
+ Hits 12945 13365 +420
+ Misses 10900 10118 -782
- Partials 1112 1155 +43
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/server/core/alarm/provider/WebhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9XZWJob29rQ2FsbGJhY2suamF2YQ==) | `25.00% <0.00%> (-46.43%)` | `2.00 <0.00> (-2.00)` | |
| [.../alarm/provider/dingtalk/DingtalkHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9kaW5ndGFsay9EaW5ndGFsa0hvb2tDYWxsYmFjay5qYXZh) | `15.51% <0.00%> (-3.36%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/feishu/FeishuHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9mZWlzaHUvRmVpc2h1SG9va0NhbGxiYWNrLmphdmE=) | `12.00% <0.00%> (-2.29%)` | `2.00 <0.00> (-1.00)` | |
| [...r/core/alarm/provider/slack/SlackhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9zbGFjay9TbGFja2hvb2tDYWxsYmFjay5qYXZh) | `20.83% <0.00%> (-4.75%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `20.93% <0.00%> (-5.39%)` | `2.00 <0.00> (-1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...er/core/server/auth/AuthenticationInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL2F1dGgvQXV0aGVudGljYXRpb25JbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (-84.62%)` | `0.00% <0.00%> (-4.00%)` | |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | `0.00% <0.00%> (-6.00%)` | |
| [...ap/server/core/alarm/AlarmStandardPersistence.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1TdGFuZGFyZFBlcnNpc3RlbmNlLmphdmE=) | `11.76% <0.00%> (-76.48%)` | `2.00% <0.00%> (-2.00%)` | |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | `0.00% <0.00%> (-8.00%)` | |
| ... and [100 more](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=footer). Last update [8c3d167...3573922](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6431: Fix alarm httpclient connection leak
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6431:
URL: https://github.com/apache/skywalking/pull/6431#issuecomment-784759581
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=h1) Report
> Merging [#6431](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=desc) (b8320cc) into [master](https://codecov.io/gh/apache/skywalking/commit/0f8b6d641a963adafd3f4dd2a7388dfd27a626c9?el=desc) (0f8b6d6) will **decrease** coverage by `19.09%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6431 +/- ##
=============================================
- Coverage 53.66% 34.56% -19.10%
+ Complexity 4069 2177 -1892
=============================================
Files 1789 848 -941
Lines 38172 20793 -17379
Branches 4217 1958 -2259
=============================================
- Hits 20484 7187 -13297
+ Misses 16688 13068 -3620
+ Partials 1000 538 -462
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/server/core/alarm/provider/WebhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9XZWJob29rQ2FsbGJhY2suamF2YQ==) | `25.00% <0.00%> (-42.57%)` | `2.00 <0.00> (-2.00)` | |
| [.../alarm/provider/dingtalk/DingtalkHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9kaW5ndGFsay9EaW5ndGFsa0hvb2tDYWxsYmFjay5qYXZh) | `15.51% <0.00%> (-62.67%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/feishu/FeishuHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9mZWlzaHUvRmVpc2h1SG9va0NhbGxiYWNrLmphdmE=) | `12.00% <0.00%> (-71.34%)` | `2.00 <0.00> (-1.00)` | |
| [...r/core/alarm/provider/slack/SlackhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9zbGFjay9TbGFja2hvb2tDYWxsYmFjay5qYXZh) | `20.83% <0.00%> (-3.62%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `20.93% <0.00%> (-56.57%)` | `2.00 <0.00> (-1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1414 more](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=footer). Last update [08bceb9...f55956d](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6431: Fix alarm httpclient connection leak
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6431:
URL: https://github.com/apache/skywalking/pull/6431#issuecomment-784759581
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6431: Fix alarm httpclient connection leak
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6431:
URL: https://github.com/apache/skywalking/pull/6431#issuecomment-784759581
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=h1) Report
> Merging [#6431](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=desc) (5c8c304) into [master](https://codecov.io/gh/apache/skywalking/commit/8c3d1679e37f992b697835b2402401a26eac19e8?el=desc) (8c3d167) will **increase** coverage by `4.69%`.
> The diff coverage is `11.42%`.
[](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6431 +/- ##
============================================
+ Coverage 51.86% 56.56% +4.69%
- Complexity 3794 4035 +241
============================================
Files 1016 999 -17
Lines 24957 24770 -187
Branches 2447 2414 -33
============================================
+ Hits 12945 14011 +1066
+ Misses 10900 9565 -1335
- Partials 1112 1194 +82
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../alarm/provider/dingtalk/DingtalkHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9kaW5ndGFsay9EaW5ndGFsa0hvb2tDYWxsYmFjay5qYXZh) | `17.24% <0.00%> (-1.63%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/feishu/FeishuHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9mZWlzaHUvRmVpc2h1SG9va0NhbGxiYWNrLmphdmE=) | `13.33% <0.00%> (-0.96%)` | `3.00 <0.00> (ø)` | |
| [...r/core/alarm/provider/slack/SlackhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9zbGFjay9TbGFja2hvb2tDYWxsYmFjay5qYXZh) | `22.91% <0.00%> (-2.67%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.25% <0.00%> (-3.06%)` | `3.00 <0.00> (ø)` | |
| [...ap/server/core/alarm/provider/WebhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9XZWJob29rQ2FsbGJhY2suamF2YQ==) | `67.50% <57.14%> (-3.93%)` | `4.00 <0.00> (ø)` | |
| [...king/oap/meter/analyzer/prometheus/rule/Rules.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9ydWxlL1J1bGVzLmphdmE=) | `66.66% <0.00%> (-4.17%)` | `4.00% <0.00%> (ø%)` | |
| [.../agent/core/profile/ProfileTaskChannelService.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlVGFza0NoYW5uZWxTZXJ2aWNlLmphdmE=) | `51.51% <0.00%> (-3.04%)` | `10.00% <0.00%> (ø%)` | |
| [...ywalking/apm/agent/core/jvm/gc/SerialGCModule.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1NlcmlhbEdDTW9kdWxlLmphdmE=) | | | |
| [...lugin/bytebuddy/CacheableTransformerDecorator.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9DYWNoZWFibGVUcmFuc2Zvcm1lckRlY29yYXRvci5qYXZh) | | | |
| [...apm/agent/core/context/RuntimeContextSnapshot.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9SdW50aW1lQ29udGV4dFNuYXBzaG90LmphdmE=) | | | |
| ... and [95 more](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=footer). Last update [8c3d167...3573922](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6431: Fix alarm httpclient connection leak
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6431:
URL: https://github.com/apache/skywalking/pull/6431#issuecomment-784759581
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6431: Fix alarm httpclient connection leak
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6431:
URL: https://github.com/apache/skywalking/pull/6431#issuecomment-784759581
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=h1) Report
> Merging [#6431](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=desc) (b8320cc) into [master](https://codecov.io/gh/apache/skywalking/commit/0f8b6d641a963adafd3f4dd2a7388dfd27a626c9?el=desc) (0f8b6d6) will **decrease** coverage by `3.66%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6431 +/- ##
============================================
- Coverage 53.66% 49.99% -3.67%
+ Complexity 4069 3646 -423
============================================
Files 1789 999 -790
Lines 38172 24610 -13562
Branches 4217 2415 -1802
============================================
- Hits 20484 12304 -8180
+ Misses 16688 11225 -5463
- Partials 1000 1081 +81
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/server/core/alarm/provider/WebhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9XZWJob29rQ2FsbGJhY2suamF2YQ==) | `25.00% <0.00%> (-42.57%)` | `2.00 <0.00> (-2.00)` | |
| [.../alarm/provider/dingtalk/DingtalkHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9kaW5ndGFsay9EaW5ndGFsa0hvb2tDYWxsYmFjay5qYXZh) | `15.51% <0.00%> (-62.67%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/feishu/FeishuHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9mZWlzaHUvRmVpc2h1SG9va0NhbGxiYWNrLmphdmE=) | `12.00% <0.00%> (-71.34%)` | `2.00 <0.00> (-1.00)` | |
| [...r/core/alarm/provider/slack/SlackhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9zbGFjay9TbGFja2hvb2tDYWxsYmFjay5qYXZh) | `20.83% <0.00%> (-3.62%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `20.93% <0.00%> (-56.57%)` | `2.00 <0.00> (-1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1278 more](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=footer). Last update [08bceb9...f55956d](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6431: Fix alarm httpclient connection leak
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6431:
URL: https://github.com/apache/skywalking/pull/6431#issuecomment-784759581
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=h1) Report
> Merging [#6431](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=desc) (3573922) into [master](https://codecov.io/gh/apache/skywalking/commit/8c3d1679e37f992b697835b2402401a26eac19e8?el=desc) (8c3d167) will **decrease** coverage by `13.42%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6431 +/- ##
=============================================
- Coverage 48.88% 35.46% -13.43%
+ Complexity 3628 2179 -1449
=============================================
Files 1016 831 -185
Lines 24929 20405 -4524
Branches 2442 1945 -497
=============================================
- Hits 12187 7237 -4950
- Misses 11694 12625 +931
+ Partials 1048 543 -505
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/server/core/alarm/provider/WebhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9XZWJob29rQ2FsbGJhY2suamF2YQ==) | `25.00% <0.00%> (-3.58%)` | `2.00 <0.00> (ø)` | |
| [.../alarm/provider/dingtalk/DingtalkHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9kaW5ndGFsay9EaW5ndGFsa0hvb2tDYWxsYmFjay5qYXZh) | `15.51% <0.00%> (-1.47%)` | `2.00 <0.00> (ø)` | |
| [...core/alarm/provider/feishu/FeishuHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9mZWlzaHUvRmVpc2h1SG9va0NhbGxiYWNrLmphdmE=) | `12.00% <0.00%> (-0.86%)` | `2.00 <0.00> (ø)` | |
| [...r/core/alarm/provider/slack/SlackhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9zbGFjay9TbGFja2hvb2tDYWxsYmFjay5qYXZh) | `20.83% <0.00%> (-2.43%)` | `2.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `20.93% <0.00%> (-2.76%)` | `2.00 <0.00> (ø)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...ient/elasticsearch/ElasticSearchInsertRequest.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaEluc2VydFJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [373 more](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=footer). Last update [8c3d167...3573922](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6431: Fix alarm httpclient connection leak
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6431:
URL: https://github.com/apache/skywalking/pull/6431#issuecomment-784759581
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=h1) Report
> Merging [#6431](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=desc) (f55956d) into [master](https://codecov.io/gh/apache/skywalking/commit/0f8b6d641a963adafd3f4dd2a7388dfd27a626c9?el=desc) (0f8b6d6) will **decrease** coverage by `8.71%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6431 +/- ##
============================================
- Coverage 53.66% 44.94% -8.72%
+ Complexity 4069 2713 -1356
============================================
Files 1789 848 -941
Lines 38172 20989 -17183
Branches 4217 2006 -2211
============================================
- Hits 20484 9434 -11050
+ Misses 16688 10848 -5840
+ Partials 1000 707 -293
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/server/core/alarm/provider/WebhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9XZWJob29rQ2FsbGJhY2suamF2YQ==) | `25.00% <0.00%> (-42.57%)` | `2.00 <0.00> (-2.00)` | |
| [.../alarm/provider/dingtalk/DingtalkHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9kaW5ndGFsay9EaW5ndGFsa0hvb2tDYWxsYmFjay5qYXZh) | `15.51% <0.00%> (-62.67%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/feishu/FeishuHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9mZWlzaHUvRmVpc2h1SG9va0NhbGxiYWNrLmphdmE=) | `12.00% <0.00%> (-71.34%)` | `2.00 <0.00> (-1.00)` | |
| [...r/core/alarm/provider/slack/SlackhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9zbGFjay9TbGFja2hvb2tDYWxsYmFjay5qYXZh) | `20.83% <0.00%> (-3.62%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `20.93% <0.00%> (-56.57%)` | `2.00 <0.00> (-1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...lking/oap/server/analyzer/event/EventAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L0V2ZW50QW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| ... and [1367 more](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=footer). Last update [08bceb9...f55956d](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6431: Fix alarm httpclient connection leak
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6431:
URL: https://github.com/apache/skywalking/pull/6431#issuecomment-784759581
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=h1) Report
> Merging [#6431](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=desc) (b8320cc) into [master](https://codecov.io/gh/apache/skywalking/commit/0f8b6d641a963adafd3f4dd2a7388dfd27a626c9?el=desc) (0f8b6d6) will **decrease** coverage by `7.34%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6431 +/- ##
============================================
- Coverage 53.66% 46.31% -7.35%
+ Complexity 4069 3410 -659
============================================
Files 1789 999 -790
Lines 38172 24582 -13590
Branches 4217 2413 -1804
============================================
- Hits 20484 11386 -9098
+ Misses 16688 12214 -4474
+ Partials 1000 982 -18
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/server/core/alarm/provider/WebhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9XZWJob29rQ2FsbGJhY2suamF2YQ==) | `25.00% <0.00%> (-42.57%)` | `2.00 <0.00> (-2.00)` | |
| [.../alarm/provider/dingtalk/DingtalkHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9kaW5ndGFsay9EaW5ndGFsa0hvb2tDYWxsYmFjay5qYXZh) | `15.51% <0.00%> (-62.67%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/feishu/FeishuHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9mZWlzaHUvRmVpc2h1SG9va0NhbGxiYWNrLmphdmE=) | `12.00% <0.00%> (-71.34%)` | `2.00 <0.00> (-1.00)` | |
| [...r/core/alarm/provider/slack/SlackhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9zbGFjay9TbGFja2hvb2tDYWxsYmFjay5qYXZh) | `20.83% <0.00%> (-3.62%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `20.93% <0.00%> (-56.57%)` | `2.00 <0.00> (-1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1307 more](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=footer). Last update [08bceb9...f55956d](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6431: Fix alarm httpclient connection leak
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6431:
URL: https://github.com/apache/skywalking/pull/6431#issuecomment-784759581
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=h1) Report
> Merging [#6431](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=desc) (5c8c304) into [master](https://codecov.io/gh/apache/skywalking/commit/8c3d1679e37f992b697835b2402401a26eac19e8?el=desc) (8c3d167) will **decrease** coverage by `2.82%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6431 +/- ##
============================================
- Coverage 51.80% 48.98% -2.83%
+ Complexity 3788 3573 -215
============================================
Files 1016 999 -17
Lines 24957 24600 -357
Branches 2447 2399 -48
============================================
- Hits 12930 12051 -879
- Misses 10913 11504 +591
+ Partials 1114 1045 -69
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/server/core/alarm/provider/WebhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9XZWJob29rQ2FsbGJhY2suamF2YQ==) | `25.00% <0.00%> (-46.43%)` | `2.00 <0.00> (-2.00)` | |
| [.../alarm/provider/dingtalk/DingtalkHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9kaW5ndGFsay9EaW5ndGFsa0hvb2tDYWxsYmFjay5qYXZh) | `15.51% <0.00%> (-3.36%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/feishu/FeishuHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9mZWlzaHUvRmVpc2h1SG9va0NhbGxiYWNrLmphdmE=) | `12.00% <0.00%> (-2.29%)` | `2.00 <0.00> (-1.00)` | |
| [...r/core/alarm/provider/slack/SlackhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9zbGFjay9TbGFja2hvb2tDYWxsYmFjay5qYXZh) | `20.83% <0.00%> (-4.75%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `20.93% <0.00%> (-5.39%)` | `2.00 <0.00> (-1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...in/elasticsearch/base/TimeRangeIndexNameMaker.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9UaW1lUmFuZ2VJbmRleE5hbWVNYWtlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [.../provider/parser/performance/PerfDataAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL3BhcnNlci9wZXJmb3JtYW5jZS9QZXJmRGF0YUFuYWx5emVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| ... and [142 more](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=footer). Last update [8c3d167...3573922](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6431: Fix alarm httpclient connection leak
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6431:
URL: https://github.com/apache/skywalking/pull/6431#issuecomment-784759581
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=h1) Report
> Merging [#6431](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=desc) (b8320cc) into [master](https://codecov.io/gh/apache/skywalking/commit/0f8b6d641a963adafd3f4dd2a7388dfd27a626c9?el=desc) (0f8b6d6) will **decrease** coverage by `2.66%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6431 +/- ##
============================================
- Coverage 53.66% 50.99% -2.67%
+ Complexity 4069 3699 -370
============================================
Files 1789 999 -790
Lines 38172 24623 -13549
Branches 4217 2415 -1802
============================================
- Hits 20484 12556 -7928
+ Misses 16688 10951 -5737
- Partials 1000 1116 +116
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/server/core/alarm/provider/WebhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9XZWJob29rQ2FsbGJhY2suamF2YQ==) | `25.00% <0.00%> (-42.57%)` | `2.00 <0.00> (-2.00)` | |
| [.../alarm/provider/dingtalk/DingtalkHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9kaW5ndGFsay9EaW5ndGFsa0hvb2tDYWxsYmFjay5qYXZh) | `15.51% <0.00%> (-62.67%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/feishu/FeishuHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9mZWlzaHUvRmVpc2h1SG9va0NhbGxiYWNrLmphdmE=) | `12.00% <0.00%> (-71.34%)` | `2.00 <0.00> (-1.00)` | |
| [...r/core/alarm/provider/slack/SlackhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9zbGFjay9TbGFja2hvb2tDYWxsYmFjay5qYXZh) | `20.83% <0.00%> (-3.62%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `20.93% <0.00%> (-56.57%)` | `2.00 <0.00> (-1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1268 more](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=footer). Last update [08bceb9...f55956d](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6431: Fix alarm httpclient connection leak
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6431:
URL: https://github.com/apache/skywalking/pull/6431#issuecomment-784759581
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=h1) Report
> Merging [#6431](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=desc) (f55956d) into [master](https://codecov.io/gh/apache/skywalking/commit/0f8b6d641a963adafd3f4dd2a7388dfd27a626c9?el=desc) (0f8b6d6) will **decrease** coverage by `7.94%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6431 +/- ##
============================================
- Coverage 53.66% 45.71% -7.95%
+ Complexity 4069 2756 -1313
============================================
Files 1789 848 -941
Lines 38172 20989 -17183
Branches 4217 2006 -2211
============================================
- Hits 20484 9595 -10889
+ Misses 16688 10684 -6004
+ Partials 1000 710 -290
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/server/core/alarm/provider/WebhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9XZWJob29rQ2FsbGJhY2suamF2YQ==) | `25.00% <0.00%> (-42.57%)` | `2.00 <0.00> (-2.00)` | |
| [.../alarm/provider/dingtalk/DingtalkHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9kaW5ndGFsay9EaW5ndGFsa0hvb2tDYWxsYmFjay5qYXZh) | `15.51% <0.00%> (-62.67%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/feishu/FeishuHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9mZWlzaHUvRmVpc2h1SG9va0NhbGxiYWNrLmphdmE=) | `12.00% <0.00%> (-71.34%)` | `2.00 <0.00> (-1.00)` | |
| [...r/core/alarm/provider/slack/SlackhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9zbGFjay9TbGFja2hvb2tDYWxsYmFjay5qYXZh) | `20.83% <0.00%> (-3.62%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `20.93% <0.00%> (-56.57%)` | `2.00 <0.00> (-1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...lking/oap/server/analyzer/event/EventAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L0V2ZW50QW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| ... and [1363 more](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=footer). Last update [08bceb9...f55956d](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6431: Fix alarm httpclient connection leak
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6431:
URL: https://github.com/apache/skywalking/pull/6431#issuecomment-784759581
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=h1) Report
> Merging [#6431](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=desc) (3573922) into [master](https://codecov.io/gh/apache/skywalking/commit/8c3d1679e37f992b697835b2402401a26eac19e8?el=desc) (8c3d167) will **decrease** coverage by `10.24%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6431 +/- ##
=============================================
- Coverage 45.67% 35.42% -10.25%
+ Complexity 3469 2178 -1291
=============================================
Files 1016 831 -185
Lines 24871 20405 -4466
Branches 2439 1945 -494
=============================================
- Hits 11359 7228 -4131
- Misses 12542 12630 +88
+ Partials 970 547 -423
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/server/core/alarm/provider/WebhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9XZWJob29rQ2FsbGJhY2suamF2YQ==) | `25.00% <0.00%> (-3.58%)` | `2.00 <0.00> (ø)` | |
| [.../alarm/provider/dingtalk/DingtalkHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9kaW5ndGFsay9EaW5ndGFsa0hvb2tDYWxsYmFjay5qYXZh) | `15.51% <0.00%> (-1.47%)` | `2.00 <0.00> (ø)` | |
| [...core/alarm/provider/feishu/FeishuHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9mZWlzaHUvRmVpc2h1SG9va0NhbGxiYWNrLmphdmE=) | `12.00% <0.00%> (-0.86%)` | `2.00 <0.00> (ø)` | |
| [...r/core/alarm/provider/slack/SlackhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9zbGFjay9TbGFja2hvb2tDYWxsYmFjay5qYXZh) | `20.83% <0.00%> (-2.43%)` | `2.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `20.93% <0.00%> (-2.76%)` | `2.00 <0.00> (ø)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...ient/elasticsearch/ElasticSearchInsertRequest.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaEluc2VydFJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...erver/storage/plugin/elasticsearch/base/EsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9Fc0RBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| ... and [343 more](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=footer). Last update [8c3d167...3573922](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6431: Fix alarm httpclient connection leak
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6431:
URL: https://github.com/apache/skywalking/pull/6431#issuecomment-784759581
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=h1) Report
> Merging [#6431](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=desc) (b7520a5) into [master](https://codecov.io/gh/apache/skywalking/commit/1c52995cbf26fa1442ba6b81fb3c4635625e3702?el=desc) (1c52995) will **decrease** coverage by `3.19%`.
> The diff coverage is `41.81%`.
[](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6431 +/- ##
============================================
- Coverage 56.82% 53.62% -3.20%
+ Complexity 3970 3871 -99
============================================
Files 985 999 +14
Lines 24397 24750 +353
Branches 2401 2424 +23
============================================
- Hits 13864 13273 -591
- Misses 9305 10345 +1040
+ Partials 1228 1132 -96
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/log/analyzer/dsl/spec/sink/sampler/Sampler.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvU2FtcGxlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ap/server/core/alarm/provider/WebhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9XZWJob29rQ2FsbGJhY2suamF2YQ==) | `25.00% <0.00%> (-46.43%)` | `2.00 <0.00> (-2.00)` | |
| [.../alarm/provider/dingtalk/DingtalkHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9kaW5ndGFsay9EaW5ndGFsa0hvb2tDYWxsYmFjay5qYXZh) | `16.98% <0.00%> (-1.89%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/feishu/FeishuHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9mZWlzaHUvRmVpc2h1SG9va0NhbGxiYWNrLmphdmE=) | `12.85% <0.00%> (-1.43%)` | `2.00 <0.00> (-1.00)` | |
| [...r/core/alarm/provider/slack/SlackhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9zbGFjay9TbGFja2hvb2tDYWxsYmFjay5qYXZh) | `20.83% <0.00%> (-4.75%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <0.00%> (-2.64%)` | `2.00 <0.00> (-1.00)` | |
| [...zer/dsl/spec/sink/sampler/RateLimitingSampler.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvUmF0ZUxpbWl0aW5nU2FtcGxlci5qYXZh) | `12.12% <12.12%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `18.51% <18.51%> (ø)` | `2.00 <2.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `18.75% <18.75%> (ø)` | `1.00 <1.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `26.43% <26.43%> (ø)` | `4.00 <4.00> (?)` | |
| ... and [126 more](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=footer). Last update [665a07c...b7520a5](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6431: Fix alarm httpclient connection leak
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6431:
URL: https://github.com/apache/skywalking/pull/6431#issuecomment-784759581
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=h1) Report
> Merging [#6431](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=desc) (b8320cc) into [master](https://codecov.io/gh/apache/skywalking/commit/0f8b6d641a963adafd3f4dd2a7388dfd27a626c9?el=desc) (0f8b6d6) will **decrease** coverage by `6.87%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6431 +/- ##
============================================
- Coverage 53.66% 46.78% -6.88%
+ Complexity 4069 3446 -623
============================================
Files 1789 999 -790
Lines 38172 24582 -13590
Branches 4217 2413 -1804
============================================
- Hits 20484 11501 -8983
+ Misses 16688 12091 -4597
+ Partials 1000 990 -10
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/server/core/alarm/provider/WebhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9XZWJob29rQ2FsbGJhY2suamF2YQ==) | `25.00% <0.00%> (-42.57%)` | `2.00 <0.00> (-2.00)` | |
| [.../alarm/provider/dingtalk/DingtalkHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9kaW5ndGFsay9EaW5ndGFsa0hvb2tDYWxsYmFjay5qYXZh) | `15.51% <0.00%> (-62.67%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/feishu/FeishuHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9mZWlzaHUvRmVpc2h1SG9va0NhbGxiYWNrLmphdmE=) | `12.00% <0.00%> (-71.34%)` | `2.00 <0.00> (-1.00)` | |
| [...r/core/alarm/provider/slack/SlackhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9zbGFjay9TbGFja2hvb2tDYWxsYmFjay5qYXZh) | `20.83% <0.00%> (-3.62%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `20.93% <0.00%> (-56.57%)` | `2.00 <0.00> (-1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1301 more](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=footer). Last update [08bceb9...f55956d](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6431: Fix alarm httpclient connection leak
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6431:
URL: https://github.com/apache/skywalking/pull/6431#issuecomment-784759581
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=h1) Report
> Merging [#6431](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=desc) (5c8c304) into [master](https://codecov.io/gh/apache/skywalking/commit/8c3d1679e37f992b697835b2402401a26eac19e8?el=desc) (8c3d167) will **decrease** coverage by `2.99%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6431 +/- ##
============================================
- Coverage 51.80% 48.81% -3.00%
+ Complexity 3788 3567 -221
============================================
Files 1016 999 -17
Lines 24957 24600 -357
Branches 2447 2399 -48
============================================
- Hits 12930 12009 -921
- Misses 10913 11557 +644
+ Partials 1114 1034 -80
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/server/core/alarm/provider/WebhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9XZWJob29rQ2FsbGJhY2suamF2YQ==) | `25.00% <0.00%> (-46.43%)` | `2.00 <0.00> (-2.00)` | |
| [.../alarm/provider/dingtalk/DingtalkHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9kaW5ndGFsay9EaW5ndGFsa0hvb2tDYWxsYmFjay5qYXZh) | `15.51% <0.00%> (-3.36%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/feishu/FeishuHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9mZWlzaHUvRmVpc2h1SG9va0NhbGxiYWNrLmphdmE=) | `12.00% <0.00%> (-2.29%)` | `2.00 <0.00> (-1.00)` | |
| [...r/core/alarm/provider/slack/SlackhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9zbGFjay9TbGFja2hvb2tDYWxsYmFjay5qYXZh) | `20.83% <0.00%> (-4.75%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `20.93% <0.00%> (-5.39%)` | `2.00 <0.00> (-1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...in/elasticsearch/base/TimeRangeIndexNameMaker.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9UaW1lUmFuZ2VJbmRleE5hbWVNYWtlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [.../provider/parser/performance/PerfDataAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL3BhcnNlci9wZXJmb3JtYW5jZS9QZXJmRGF0YUFuYWx5emVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| ... and [143 more](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=footer). Last update [8c3d167...3573922](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6431: Fix alarm httpclient connection leak
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6431:
URL: https://github.com/apache/skywalking/pull/6431#issuecomment-784759581
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=h1) Report
> Merging [#6431](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=desc) (5c8c304) into [master](https://codecov.io/gh/apache/skywalking/commit/8c3d1679e37f992b697835b2402401a26eac19e8?el=desc) (8c3d167) will **decrease** coverage by `3.67%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6431 +/- ##
============================================
- Coverage 45.34% 41.66% -3.68%
+ Complexity 3454 2590 -864
============================================
Files 1016 848 -168
Lines 24860 20913 -3947
Branches 2421 1986 -435
============================================
- Hits 11273 8714 -2559
+ Misses 12608 11549 -1059
+ Partials 979 650 -329
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/server/core/alarm/provider/WebhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9XZWJob29rQ2FsbGJhY2suamF2YQ==) | `25.00% <0.00%> (-3.58%)` | `2.00 <0.00> (ø)` | |
| [.../alarm/provider/dingtalk/DingtalkHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9kaW5ndGFsay9EaW5ndGFsa0hvb2tDYWxsYmFjay5qYXZh) | `15.51% <0.00%> (-1.47%)` | `2.00 <0.00> (ø)` | |
| [...core/alarm/provider/feishu/FeishuHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9mZWlzaHUvRmVpc2h1SG9va0NhbGxiYWNrLmphdmE=) | `12.00% <0.00%> (-0.86%)` | `2.00 <0.00> (ø)` | |
| [...r/core/alarm/provider/slack/SlackhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9zbGFjay9TbGFja2hvb2tDYWxsYmFjay5qYXZh) | `20.83% <0.00%> (-2.43%)` | `2.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `20.93% <0.00%> (-2.76%)` | `2.00 <0.00> (ø)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...analyzer/provider/meter/process/SampleBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL21ldGVyL3Byb2Nlc3MvU2FtcGxlQnVpbGRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../provider/parser/performance/PerfDataAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL3BhcnNlci9wZXJmb3JtYW5jZS9QZXJmRGF0YUFuYWx5emVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...ovider/parser/errorlog/listener/SourceBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL3BhcnNlci9lcnJvcmxvZy9saXN0ZW5lci9Tb3VyY2VCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| ... and [253 more](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=footer). Last update [8c3d167...3573922](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6431: Fix alarm httpclient connection leak
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6431:
URL: https://github.com/apache/skywalking/pull/6431#issuecomment-784759581
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=h1) Report
> Merging [#6431](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=desc) (5c8c304) into [master](https://codecov.io/gh/apache/skywalking/commit/8c3d1679e37f992b697835b2402401a26eac19e8?el=desc) (8c3d167) will **decrease** coverage by `1.00%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6431 +/- ##
============================================
- Coverage 51.80% 50.80% -1.01%
+ Complexity 3788 3655 -133
============================================
Files 1016 999 -17
Lines 24957 24600 -357
Branches 2447 2399 -48
============================================
- Hits 12930 12499 -431
- Misses 10913 11014 +101
+ Partials 1114 1087 -27
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/server/core/alarm/provider/WebhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9XZWJob29rQ2FsbGJhY2suamF2YQ==) | `25.00% <0.00%> (-46.43%)` | `2.00 <0.00> (-2.00)` | |
| [.../alarm/provider/dingtalk/DingtalkHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9kaW5ndGFsay9EaW5ndGFsa0hvb2tDYWxsYmFjay5qYXZh) | `15.51% <0.00%> (-3.36%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/feishu/FeishuHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9mZWlzaHUvRmVpc2h1SG9va0NhbGxiYWNrLmphdmE=) | `12.00% <0.00%> (-2.29%)` | `2.00 <0.00> (-1.00)` | |
| [...r/core/alarm/provider/slack/SlackhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9zbGFjay9TbGFja2hvb2tDYWxsYmFjay5qYXZh) | `20.83% <0.00%> (-4.75%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `20.93% <0.00%> (-5.39%)` | `2.00 <0.00> (-1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [.../provider/parser/performance/PerfDataAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL3BhcnNlci9wZXJmb3JtYW5jZS9QZXJmRGF0YUFuYWx5emVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...ovider/parser/errorlog/listener/SourceBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL3BhcnNlci9lcnJvcmxvZy9saXN0ZW5lci9Tb3VyY2VCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| ... and [150 more](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=footer). Last update [8c3d167...3573922](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6431: Fix alarm httpclient connection leak
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6431:
URL: https://github.com/apache/skywalking/pull/6431#issuecomment-784759581
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=h1) Report
> Merging [#6431](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=desc) (5c8c304) into [master](https://codecov.io/gh/apache/skywalking/commit/8c3d1679e37f992b697835b2402401a26eac19e8?el=desc) (8c3d167) will **increase** coverage by `4.49%`.
> The diff coverage is `11.42%`.
[](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6431 +/- ##
============================================
+ Coverage 51.86% 56.36% +4.49%
- Complexity 3794 4021 +227
============================================
Files 1016 999 -17
Lines 24957 24770 -187
Branches 2447 2414 -33
============================================
+ Hits 12945 13962 +1017
+ Misses 10900 9608 -1292
- Partials 1112 1200 +88
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../alarm/provider/dingtalk/DingtalkHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9kaW5ndGFsay9EaW5ndGFsa0hvb2tDYWxsYmFjay5qYXZh) | `17.24% <0.00%> (-1.63%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/feishu/FeishuHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9mZWlzaHUvRmVpc2h1SG9va0NhbGxiYWNrLmphdmE=) | `13.33% <0.00%> (-0.96%)` | `3.00 <0.00> (ø)` | |
| [...r/core/alarm/provider/slack/SlackhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9zbGFjay9TbGFja2hvb2tDYWxsYmFjay5qYXZh) | `22.91% <0.00%> (-2.67%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.25% <0.00%> (-3.06%)` | `3.00 <0.00> (ø)` | |
| [...ap/server/core/alarm/provider/WebhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9XZWJob29rQ2FsbGJhY2suamF2YQ==) | `67.50% <57.14%> (-3.93%)` | `4.00 <0.00> (ø)` | |
| [...g/oap/server/telemetry/prometheus/BaseMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvQmFzZU1ldHJpY3MuamF2YQ==) | `90.00% <0.00%> (-6.67%)` | `9.00% <0.00%> (-1.00%)` | |
| [...r/telemetry/prometheus/PrometheusGaugeMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c0dhdWdlTWV0cmljcy5qYXZh) | `25.00% <0.00%> (-4.17%)` | `3.00% <0.00%> (-1.00%)` | |
| [...king/oap/meter/analyzer/prometheus/rule/Rules.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9ydWxlL1J1bGVzLmphdmE=) | `66.66% <0.00%> (-4.17%)` | `4.00% <0.00%> (ø%)` | |
| [.../agent/core/profile/ProfileTaskChannelService.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlVGFza0NoYW5uZWxTZXJ2aWNlLmphdmE=) | `51.51% <0.00%> (-3.04%)` | `10.00% <0.00%> (ø%)` | |
| [...apm/agent/core/context/RuntimeContextSnapshot.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9SdW50aW1lQ29udGV4dFNuYXBzaG90LmphdmE=) | | | |
| ... and [90 more](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=footer). Last update [8c3d167...3573922](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6431: Fix alarm httpclient connection leak
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6431:
URL: https://github.com/apache/skywalking/pull/6431#issuecomment-784759581
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=h1) Report
> Merging [#6431](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=desc) (f55956d) into [master](https://codecov.io/gh/apache/skywalking/commit/0f8b6d641a963adafd3f4dd2a7388dfd27a626c9?el=desc) (0f8b6d6) will **decrease** coverage by `7.05%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6431 +/- ##
============================================
- Coverage 53.66% 46.60% -7.06%
+ Complexity 4069 2810 -1259
============================================
Files 1789 848 -941
Lines 38172 21017 -17155
Branches 4217 2011 -2206
============================================
- Hits 20484 9795 -10689
+ Misses 16688 10497 -6191
+ Partials 1000 725 -275
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/server/core/alarm/provider/WebhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9XZWJob29rQ2FsbGJhY2suamF2YQ==) | `25.00% <0.00%> (-42.57%)` | `2.00 <0.00> (-2.00)` | |
| [.../alarm/provider/dingtalk/DingtalkHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9kaW5ndGFsay9EaW5ndGFsa0hvb2tDYWxsYmFjay5qYXZh) | `15.51% <0.00%> (-62.67%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/feishu/FeishuHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9mZWlzaHUvRmVpc2h1SG9va0NhbGxiYWNrLmphdmE=) | `12.00% <0.00%> (-71.34%)` | `2.00 <0.00> (-1.00)` | |
| [...r/core/alarm/provider/slack/SlackhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9zbGFjay9TbGFja2hvb2tDYWxsYmFjay5qYXZh) | `20.83% <0.00%> (-3.62%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `20.93% <0.00%> (-56.57%)` | `2.00 <0.00> (-1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...lking/oap/server/analyzer/event/EventAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L0V2ZW50QW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| ... and [1356 more](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=footer). Last update [08bceb9...f55956d](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6431: Fix alarm httpclient connection leak
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6431:
URL: https://github.com/apache/skywalking/pull/6431#issuecomment-784759581
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=h1) Report
> Merging [#6431](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=desc) (700fa56) into [master](https://codecov.io/gh/apache/skywalking/commit/1c52995cbf26fa1442ba6b81fb3c4635625e3702?el=desc) (1c52995) will **decrease** coverage by `15.47%`.
> The diff coverage is `41.81%`.
[](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6431 +/- ##
=============================================
- Coverage 56.82% 41.34% -15.48%
+ Complexity 3970 2545 -1425
=============================================
Files 985 831 -154
Lines 24397 20415 -3982
Branches 2401 1929 -472
=============================================
- Hits 13864 8441 -5423
- Misses 9305 11312 +2007
+ Partials 1228 662 -566
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/log/analyzer/dsl/spec/sink/sampler/Sampler.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvU2FtcGxlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ap/server/core/alarm/provider/WebhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9XZWJob29rQ2FsbGJhY2suamF2YQ==) | `25.00% <0.00%> (-46.43%)` | `2.00 <0.00> (-2.00)` | |
| [.../alarm/provider/dingtalk/DingtalkHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9kaW5ndGFsay9EaW5ndGFsa0hvb2tDYWxsYmFjay5qYXZh) | `16.98% <0.00%> (-1.89%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/feishu/FeishuHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9mZWlzaHUvRmVpc2h1SG9va0NhbGxiYWNrLmphdmE=) | `12.85% <0.00%> (-1.43%)` | `2.00 <0.00> (-1.00)` | |
| [...r/core/alarm/provider/slack/SlackhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9zbGFjay9TbGFja2hvb2tDYWxsYmFjay5qYXZh) | `20.83% <0.00%> (-4.75%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <0.00%> (-2.64%)` | `2.00 <0.00> (-1.00)` | |
| [...zer/dsl/spec/sink/sampler/RateLimitingSampler.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvUmF0ZUxpbWl0aW5nU2FtcGxlci5qYXZh) | `12.12% <12.12%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `18.51% <18.51%> (ø)` | `2.00 <2.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `18.75% <18.75%> (ø)` | `1.00 <1.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `26.43% <26.43%> (ø)` | `4.00 <4.00> (?)` | |
| ... and [385 more](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=footer). Last update [665a07c...b7520a5](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6431: Fix alarm httpclient connection leak
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6431:
URL: https://github.com/apache/skywalking/pull/6431#issuecomment-784759581
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=h1) Report
> Merging [#6431](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=desc) (b7520a5) into [master](https://codecov.io/gh/apache/skywalking/commit/1c52995cbf26fa1442ba6b81fb3c4635625e3702?el=desc) (1c52995) will **decrease** coverage by `1.19%`.
> The diff coverage is `42.85%`.
[](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6431 +/- ##
============================================
- Coverage 56.82% 55.63% -1.20%
- Complexity 3970 3986 +16
============================================
Files 985 999 +14
Lines 24397 24760 +363
Branches 2401 2425 +24
============================================
- Hits 13864 13774 -90
- Misses 9305 9814 +509
+ Partials 1228 1172 -56
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/log/analyzer/dsl/spec/sink/sampler/Sampler.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvU2FtcGxlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../alarm/provider/dingtalk/DingtalkHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9kaW5ndGFsay9EaW5ndGFsa0hvb2tDYWxsYmFjay5qYXZh) | `18.86% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/feishu/FeishuHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9mZWlzaHUvRmVpc2h1SG9va0NhbGxiYWNrLmphdmE=) | `14.28% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...r/core/alarm/provider/slack/SlackhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9zbGFjay9TbGFja2hvb2tDYWxsYmFjay5qYXZh) | `22.91% <0.00%> (-2.67%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `26.31% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...zer/dsl/spec/sink/sampler/RateLimitingSampler.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvUmF0ZUxpbWl0aW5nU2FtcGxlci5qYXZh) | `12.12% <12.12%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `18.51% <18.51%> (ø)` | `2.00 <2.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `18.75% <18.75%> (ø)` | `1.00 <1.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `26.43% <26.43%> (ø)` | `4.00 <4.00> (?)` | |
| [...g/analyzer/provider/LogAnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9Mb2dBbmFseXplck1vZHVsZVByb3ZpZGVyLmphdmE=) | `86.66% <50.00%> (-13.34%)` | `8.00 <1.00> (ø)` | |
| ... and [95 more](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=footer). Last update [665a07c...b7520a5](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6431: Fix alarm httpclient connection leak
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6431:
URL: https://github.com/apache/skywalking/pull/6431#issuecomment-784759581
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=h1) Report
> Merging [#6431](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=desc) (5c8c304) into [master](https://codecov.io/gh/apache/skywalking/commit/8c3d1679e37f992b697835b2402401a26eac19e8?el=desc) (8c3d167) will **decrease** coverage by `1.12%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6431 +/- ##
============================================
- Coverage 51.80% 50.68% -1.13%
+ Complexity 3788 3645 -143
============================================
Files 1016 999 -17
Lines 24957 24600 -357
Branches 2447 2399 -48
============================================
- Hits 12930 12468 -462
- Misses 10913 11047 +134
+ Partials 1114 1085 -29
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/server/core/alarm/provider/WebhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9XZWJob29rQ2FsbGJhY2suamF2YQ==) | `25.00% <0.00%> (-46.43%)` | `2.00 <0.00> (-2.00)` | |
| [.../alarm/provider/dingtalk/DingtalkHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9kaW5ndGFsay9EaW5ndGFsa0hvb2tDYWxsYmFjay5qYXZh) | `15.51% <0.00%> (-3.36%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/feishu/FeishuHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9mZWlzaHUvRmVpc2h1SG9va0NhbGxiYWNrLmphdmE=) | `12.00% <0.00%> (-2.29%)` | `2.00 <0.00> (-1.00)` | |
| [...r/core/alarm/provider/slack/SlackhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9zbGFjay9TbGFja2hvb2tDYWxsYmFjay5qYXZh) | `20.83% <0.00%> (-4.75%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `20.93% <0.00%> (-5.39%)` | `2.00 <0.00> (-1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [.../provider/parser/performance/PerfDataAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL3BhcnNlci9wZXJmb3JtYW5jZS9QZXJmRGF0YUFuYWx5emVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...ovider/parser/errorlog/listener/SourceBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL3BhcnNlci9lcnJvcmxvZy9saXN0ZW5lci9Tb3VyY2VCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| ... and [149 more](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=footer). Last update [8c3d167...3573922](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6431: Fix alarm httpclient connection leak
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6431:
URL: https://github.com/apache/skywalking/pull/6431#issuecomment-784759581
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=h1) Report
> Merging [#6431](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=desc) (5c8c304) into [master](https://codecov.io/gh/apache/skywalking/commit/8c3d1679e37f992b697835b2402401a26eac19e8?el=desc) (8c3d167) will **decrease** coverage by `2.98%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6431 +/- ##
============================================
- Coverage 51.80% 48.82% -2.99%
+ Complexity 3788 3568 -220
============================================
Files 1016 999 -17
Lines 24957 24600 -357
Branches 2447 2399 -48
============================================
- Hits 12930 12010 -920
- Misses 10913 11557 +644
+ Partials 1114 1033 -81
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/server/core/alarm/provider/WebhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9XZWJob29rQ2FsbGJhY2suamF2YQ==) | `25.00% <0.00%> (-46.43%)` | `2.00 <0.00> (-2.00)` | |
| [.../alarm/provider/dingtalk/DingtalkHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9kaW5ndGFsay9EaW5ndGFsa0hvb2tDYWxsYmFjay5qYXZh) | `15.51% <0.00%> (-3.36%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/feishu/FeishuHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9mZWlzaHUvRmVpc2h1SG9va0NhbGxiYWNrLmphdmE=) | `12.00% <0.00%> (-2.29%)` | `2.00 <0.00> (-1.00)` | |
| [...r/core/alarm/provider/slack/SlackhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9zbGFjay9TbGFja2hvb2tDYWxsYmFjay5qYXZh) | `20.83% <0.00%> (-4.75%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `20.93% <0.00%> (-5.39%)` | `2.00 <0.00> (-1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...in/elasticsearch/base/TimeRangeIndexNameMaker.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9UaW1lUmFuZ2VJbmRleE5hbWVNYWtlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [.../provider/parser/performance/PerfDataAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL3BhcnNlci9wZXJmb3JtYW5jZS9QZXJmRGF0YUFuYWx5emVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| ... and [143 more](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=footer). Last update [8c3d167...3573922](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6431: Fix alarm httpclient connection leak
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6431:
URL: https://github.com/apache/skywalking/pull/6431#issuecomment-784759581
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=h1) Report
> Merging [#6431](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=desc) (5c8c304) into [master](https://codecov.io/gh/apache/skywalking/commit/8c3d1679e37f992b697835b2402401a26eac19e8?el=desc) (8c3d167) will **increase** coverage by `2.82%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6431 +/- ##
============================================
+ Coverage 51.86% 54.69% +2.82%
- Complexity 3794 3906 +112
============================================
Files 1016 999 -17
Lines 24957 24666 -291
Branches 2447 2406 -41
============================================
+ Hits 12945 13491 +546
+ Misses 10900 10015 -885
- Partials 1112 1160 +48
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/server/core/alarm/provider/WebhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9XZWJob29rQ2FsbGJhY2suamF2YQ==) | `25.00% <0.00%> (-46.43%)` | `2.00 <0.00> (-2.00)` | |
| [.../alarm/provider/dingtalk/DingtalkHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9kaW5ndGFsay9EaW5ndGFsa0hvb2tDYWxsYmFjay5qYXZh) | `15.51% <0.00%> (-3.36%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/feishu/FeishuHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9mZWlzaHUvRmVpc2h1SG9va0NhbGxiYWNrLmphdmE=) | `12.00% <0.00%> (-2.29%)` | `2.00 <0.00> (-1.00)` | |
| [...r/core/alarm/provider/slack/SlackhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9zbGFjay9TbGFja2hvb2tDYWxsYmFjay5qYXZh) | `20.83% <0.00%> (-4.75%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `20.93% <0.00%> (-5.39%)` | `2.00 <0.00> (-1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ap/server/core/alarm/AlarmStandardPersistence.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1TdGFuZGFyZFBlcnNpc3RlbmNlLmphdmE=) | `11.76% <0.00%> (-76.48%)` | `2.00% <0.00%> (-2.00%)` | |
| [...er/core/alarm/provider/CompositeRuleEvaluator.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdG9yLmphdmE=) | `9.52% <0.00%> (-73.81%)` | `1.00% <0.00%> (-6.00%)` | |
| [...er/storage/plugin/jdbc/h2/dao/H2AlarmQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyQWxhcm1RdWVyeURBTy5qYXZh) | `6.97% <0.00%> (-72.10%)` | `1.00% <0.00%> (-4.00%)` | |
| [.../skywalking/oap/server/core/alarm/AlarmRecord.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1SZWNvcmQuamF2YQ==) | `4.34% <0.00%> (-52.18%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [90 more](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=footer). Last update [8c3d167...3573922](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6431: Fix alarm httpclient connection leak
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6431:
URL: https://github.com/apache/skywalking/pull/6431#issuecomment-784759581
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=h1) Report
> Merging [#6431](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=desc) (b7520a5) into [master](https://codecov.io/gh/apache/skywalking/commit/1c52995cbf26fa1442ba6b81fb3c4635625e3702?el=desc) (1c52995) will **decrease** coverage by `14.02%`.
> The diff coverage is `32.89%`.
[](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6431 +/- ##
=============================================
- Coverage 56.82% 42.80% -14.03%
+ Complexity 3970 3196 -774
=============================================
Files 985 999 +14
Lines 24397 24547 +150
Branches 2401 2409 +8
=============================================
- Hits 13864 10507 -3357
- Misses 9305 13148 +3843
+ Partials 1228 892 -336
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/log/analyzer/dsl/spec/sink/sampler/Sampler.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvU2FtcGxlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ap/server/core/alarm/provider/WebhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9XZWJob29rQ2FsbGJhY2suamF2YQ==) | `25.00% <0.00%> (-46.43%)` | `2.00 <0.00> (-2.00)` | |
| [.../alarm/provider/dingtalk/DingtalkHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9kaW5ndGFsay9EaW5ndGFsa0hvb2tDYWxsYmFjay5qYXZh) | `16.98% <0.00%> (-1.89%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/feishu/FeishuHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9mZWlzaHUvRmVpc2h1SG9va0NhbGxiYWNrLmphdmE=) | `12.85% <0.00%> (-1.43%)` | `2.00 <0.00> (-1.00)` | |
| [...r/core/alarm/provider/slack/SlackhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9zbGFjay9TbGFja2hvb2tDYWxsYmFjay5qYXZh) | `20.83% <0.00%> (-4.75%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <0.00%> (-2.64%)` | `2.00 <0.00> (-1.00)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `8.86% <8.86%> (ø)` | `1.00 <1.00> (?)` | |
| [...zer/dsl/spec/sink/sampler/RateLimitingSampler.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvUmF0ZUxpbWl0aW5nU2FtcGxlci5qYXZh) | `12.12% <12.12%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `16.66% <16.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `18.51% <18.51%> (ø)` | `2.00 <2.00> (?)` | |
| ... and [240 more](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=footer). Last update [665a07c...b7520a5](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6431: Fix alarm httpclient connection leak
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6431:
URL: https://github.com/apache/skywalking/pull/6431#issuecomment-784759581
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=h1) Report
> Merging [#6431](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=desc) (b8320cc) into [master](https://codecov.io/gh/apache/skywalking/commit/0f8b6d641a963adafd3f4dd2a7388dfd27a626c9?el=desc) (0f8b6d6) will **decrease** coverage by `11.90%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6431 +/- ##
=============================================
- Coverage 53.66% 41.75% -11.91%
+ Complexity 4069 3124 -945
=============================================
Files 1789 999 -790
Lines 38172 24420 -13752
Branches 4217 2365 -1852
=============================================
- Hits 20484 10197 -10287
+ Misses 16688 13361 -3327
+ Partials 1000 862 -138
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/server/core/alarm/provider/WebhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9XZWJob29rQ2FsbGJhY2suamF2YQ==) | `25.00% <0.00%> (-42.57%)` | `2.00 <0.00> (-2.00)` | |
| [.../alarm/provider/dingtalk/DingtalkHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9kaW5ndGFsay9EaW5ndGFsa0hvb2tDYWxsYmFjay5qYXZh) | `15.51% <0.00%> (-62.67%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/feishu/FeishuHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9mZWlzaHUvRmVpc2h1SG9va0NhbGxiYWNrLmphdmE=) | `12.00% <0.00%> (-71.34%)` | `2.00 <0.00> (-1.00)` | |
| [...r/core/alarm/provider/slack/SlackhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9zbGFjay9TbGFja2hvb2tDYWxsYmFjay5qYXZh) | `20.83% <0.00%> (-3.62%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `20.93% <0.00%> (-56.57%)` | `2.00 <0.00> (-1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1336 more](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=footer). Last update [08bceb9...f55956d](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6431: Fix alarm httpclient connection leak
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6431:
URL: https://github.com/apache/skywalking/pull/6431#issuecomment-784759581
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=h1) Report
> Merging [#6431](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=desc) (5c8c304) into [master](https://codecov.io/gh/apache/skywalking/commit/8c3d1679e37f992b697835b2402401a26eac19e8?el=desc) (8c3d167) will **decrease** coverage by `2.87%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6431 +/- ##
============================================
- Coverage 45.34% 42.46% -2.88%
+ Complexity 3454 2629 -825
============================================
Files 1016 848 -168
Lines 24860 20938 -3922
Branches 2421 1987 -434
============================================
- Hits 11273 8892 -2381
+ Misses 12608 11381 -1227
+ Partials 979 665 -314
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/server/core/alarm/provider/WebhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9XZWJob29rQ2FsbGJhY2suamF2YQ==) | `25.00% <0.00%> (-3.58%)` | `2.00 <0.00> (ø)` | |
| [.../alarm/provider/dingtalk/DingtalkHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9kaW5ndGFsay9EaW5ndGFsa0hvb2tDYWxsYmFjay5qYXZh) | `15.51% <0.00%> (-1.47%)` | `2.00 <0.00> (ø)` | |
| [...core/alarm/provider/feishu/FeishuHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9mZWlzaHUvRmVpc2h1SG9va0NhbGxiYWNrLmphdmE=) | `12.00% <0.00%> (-0.86%)` | `2.00 <0.00> (ø)` | |
| [...r/core/alarm/provider/slack/SlackhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9zbGFjay9TbGFja2hvb2tDYWxsYmFjay5qYXZh) | `20.83% <0.00%> (-2.43%)` | `2.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `20.93% <0.00%> (-2.76%)` | `2.00 <0.00> (ø)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [.../provider/parser/performance/PerfDataAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL3BhcnNlci9wZXJmb3JtYW5jZS9QZXJmRGF0YUFuYWx5emVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...ovider/parser/errorlog/listener/SourceBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL3BhcnNlci9lcnJvcmxvZy9saXN0ZW5lci9Tb3VyY2VCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=) | `0.00% <0.00%> (-98.86%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [249 more](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=footer). Last update [8c3d167...3573922](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6431: Fix alarm httpclient connection leak
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6431:
URL: https://github.com/apache/skywalking/pull/6431#issuecomment-784759581
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=h1) Report
> Merging [#6431](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=desc) (5c8c304) into [master](https://codecov.io/gh/apache/skywalking/commit/8c3d1679e37f992b697835b2402401a26eac19e8?el=desc) (8c3d167) will **decrease** coverage by `2.61%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6431 +/- ##
============================================
- Coverage 51.80% 49.19% -2.62%
+ Complexity 3788 3582 -206
============================================
Files 1016 999 -17
Lines 24957 24600 -357
Branches 2447 2399 -48
============================================
- Hits 12930 12102 -828
- Misses 10913 11451 +538
+ Partials 1114 1047 -67
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/server/core/alarm/provider/WebhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9XZWJob29rQ2FsbGJhY2suamF2YQ==) | `25.00% <0.00%> (-46.43%)` | `2.00 <0.00> (-2.00)` | |
| [.../alarm/provider/dingtalk/DingtalkHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9kaW5ndGFsay9EaW5ndGFsa0hvb2tDYWxsYmFjay5qYXZh) | `15.51% <0.00%> (-3.36%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/feishu/FeishuHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9mZWlzaHUvRmVpc2h1SG9va0NhbGxiYWNrLmphdmE=) | `12.00% <0.00%> (-2.29%)` | `2.00 <0.00> (-1.00)` | |
| [...r/core/alarm/provider/slack/SlackhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9zbGFjay9TbGFja2hvb2tDYWxsYmFjay5qYXZh) | `20.83% <0.00%> (-4.75%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `20.93% <0.00%> (-5.39%)` | `2.00 <0.00> (-1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...in/elasticsearch/base/TimeRangeIndexNameMaker.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9UaW1lUmFuZ2VJbmRleE5hbWVNYWtlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [.../provider/parser/performance/PerfDataAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL3BhcnNlci9wZXJmb3JtYW5jZS9QZXJmRGF0YUFuYWx5emVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| ... and [141 more](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=footer). Last update [8c3d167...3573922](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6431: Fix alarm httpclient connection leak
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6431:
URL: https://github.com/apache/skywalking/pull/6431#issuecomment-784759581
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=h1) Report
> Merging [#6431](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=desc) (5c8c304) into [master](https://codecov.io/gh/apache/skywalking/commit/0f8b6d641a963adafd3f4dd2a7388dfd27a626c9?el=desc) (0f8b6d6) will **decrease** coverage by `0.39%`.
> The diff coverage is `45.71%`.
[](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6431 +/- ##
============================================
- Coverage 53.66% 53.27% -0.40%
+ Complexity 4069 4051 -18
============================================
Files 1789 1789
Lines 38172 38202 +30
Branches 4217 4222 +5
============================================
- Hits 20484 20351 -133
- Misses 16688 16855 +167
+ Partials 1000 996 -4
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/alarm/provider/slack/SlackhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9zbGFjay9TbGFja2hvb2tDYWxsYmFjay5qYXZh) | `21.56% <0.00%> (-2.88%)` | `3.00 <0.00> (ø)` | |
| [...ap/server/core/alarm/provider/WebhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9XZWJob29rQ2FsbGJhY2suamF2YQ==) | `62.79% <57.14%> (-4.78%)` | `4.00 <0.00> (ø)` | |
| [.../alarm/provider/dingtalk/DingtalkHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9kaW5ndGFsay9EaW5ndGFsa0hvb2tDYWxsYmFjay5qYXZh) | `73.77% <57.14%> (-4.42%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/feishu/FeishuHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9mZWlzaHUvRmVpc2h1SG9va0NhbGxiYWNrLmphdmE=) | `79.48% <57.14%> (-3.85%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `71.73% <57.14%> (-5.77%)` | `3.00 <0.00> (ø)` | |
| [...lking/oap/server/analyzer/event/EventAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L0V2ZW50QW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [.../plugin/elasticsearch7/query/ES7EventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9FUzdFdmVudFF1ZXJ5REFPLmphdmE=) | `20.00% <0.00%> (-80.00%)` | `1.00% <0.00%> (-1.00%)` | |
| [...erver/analyzer/event/EventAnalyzerServiceImpl.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L0V2ZW50QW5hbHl6ZXJTZXJ2aWNlSW1wbC5qYXZh) | `33.33% <0.00%> (-66.67%)` | `1.00% <0.00%> (-2.00%)` | |
| [...er/event/listener/EventRecordAnalyzerListener.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L2xpc3RlbmVyL0V2ZW50UmVjb3JkQW5hbHl6ZXJMaXN0ZW5lci5qYXZh) | `18.51% <0.00%> (-62.97%)` | `0.00% <0.00%> (-3.00%)` | |
| [...r/storage/plugin/influxdb/query/EventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9FdmVudFF1ZXJ5REFPLmphdmE=) | `1.51% <0.00%> (-60.61%)` | `1.00% <0.00%> (-6.00%)` | |
| ... and [16 more](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=footer). Last update [08bceb9...f55956d](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6431: Fix alarm httpclient connection leak
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6431:
URL: https://github.com/apache/skywalking/pull/6431#issuecomment-784759581
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=h1) Report
> Merging [#6431](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=desc) (5c8c304) into [master](https://codecov.io/gh/apache/skywalking/commit/8c3d1679e37f992b697835b2402401a26eac19e8?el=desc) (8c3d167) will **increase** coverage by `0.07%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6431 +/- ##
============================================
+ Coverage 45.34% 45.41% +0.07%
+ Complexity 3454 2753 -701
============================================
Files 1016 848 -168
Lines 24860 20960 -3900
Branches 2421 1990 -431
============================================
- Hits 11273 9520 -1753
+ Misses 12608 10714 -1894
+ Partials 979 726 -253
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/server/core/alarm/provider/WebhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9XZWJob29rQ2FsbGJhY2suamF2YQ==) | `25.00% <0.00%> (-3.58%)` | `2.00 <0.00> (ø)` | |
| [.../alarm/provider/dingtalk/DingtalkHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9kaW5ndGFsay9EaW5ndGFsa0hvb2tDYWxsYmFjay5qYXZh) | `15.51% <0.00%> (-1.47%)` | `2.00 <0.00> (ø)` | |
| [...core/alarm/provider/feishu/FeishuHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9mZWlzaHUvRmVpc2h1SG9va0NhbGxiYWNrLmphdmE=) | `12.00% <0.00%> (-0.86%)` | `2.00 <0.00> (ø)` | |
| [...r/core/alarm/provider/slack/SlackhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9zbGFjay9TbGFja2hvb2tDYWxsYmFjay5qYXZh) | `20.83% <0.00%> (-2.43%)` | `2.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `20.93% <0.00%> (-2.76%)` | `2.00 <0.00> (ø)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [.../provider/parser/performance/PerfDataAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL3BhcnNlci9wZXJmb3JtYW5jZS9QZXJmRGF0YUFuYWx5emVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...ovider/parser/errorlog/listener/SourceBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL3BhcnNlci9lcnJvcmxvZy9saXN0ZW5lci9Tb3VyY2VCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=) | `0.00% <0.00%> (-98.86%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [280 more](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=footer). Last update [8c3d167...3573922](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6431: Fix alarm httpclient connection leak
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6431:
URL: https://github.com/apache/skywalking/pull/6431#issuecomment-784759581
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=h1) Report
> Merging [#6431](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=desc) (b8320cc) into [master](https://codecov.io/gh/apache/skywalking/commit/0f8b6d641a963adafd3f4dd2a7388dfd27a626c9?el=desc) (0f8b6d6) will **decrease** coverage by `2.68%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6431 +/- ##
============================================
- Coverage 53.66% 50.97% -2.69%
+ Complexity 4069 3698 -371
============================================
Files 1789 999 -790
Lines 38172 24623 -13549
Branches 4217 2415 -1802
============================================
- Hits 20484 12552 -7932
+ Misses 16688 10955 -5733
- Partials 1000 1116 +116
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/server/core/alarm/provider/WebhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9XZWJob29rQ2FsbGJhY2suamF2YQ==) | `25.00% <0.00%> (-42.57%)` | `2.00 <0.00> (-2.00)` | |
| [.../alarm/provider/dingtalk/DingtalkHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9kaW5ndGFsay9EaW5ndGFsa0hvb2tDYWxsYmFjay5qYXZh) | `15.51% <0.00%> (-62.67%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/feishu/FeishuHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9mZWlzaHUvRmVpc2h1SG9va0NhbGxiYWNrLmphdmE=) | `12.00% <0.00%> (-71.34%)` | `2.00 <0.00> (-1.00)` | |
| [...r/core/alarm/provider/slack/SlackhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9zbGFjay9TbGFja2hvb2tDYWxsYmFjay5qYXZh) | `20.83% <0.00%> (-3.62%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `20.93% <0.00%> (-56.57%)` | `2.00 <0.00> (-1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1268 more](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=footer). Last update [08bceb9...f55956d](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] commented on pull request #6431: Fix alarm httpclient connection leak
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #6431:
URL: https://github.com/apache/skywalking/pull/6431#issuecomment-784759581
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=h1) Report
> Merging [#6431](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=desc) (700fa56) into [master](https://codecov.io/gh/apache/skywalking/commit/1c52995cbf26fa1442ba6b81fb3c4635625e3702?el=desc) (1c52995) will **decrease** coverage by `20.68%`.
> The diff coverage is `32.89%`.
[](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6431 +/- ##
=============================================
- Coverage 56.82% 36.14% -20.69%
+ Complexity 3970 2223 -1747
=============================================
Files 985 831 -154
Lines 24397 20380 -4017
Branches 2401 1927 -474
=============================================
- Hits 13864 7366 -6498
- Misses 9305 12468 +3163
+ Partials 1228 546 -682
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/log/analyzer/dsl/spec/sink/sampler/Sampler.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvU2FtcGxlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ap/server/core/alarm/provider/WebhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9XZWJob29rQ2FsbGJhY2suamF2YQ==) | `25.00% <0.00%> (-46.43%)` | `2.00 <0.00> (-2.00)` | |
| [.../alarm/provider/dingtalk/DingtalkHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9kaW5ndGFsay9EaW5ndGFsa0hvb2tDYWxsYmFjay5qYXZh) | `16.98% <0.00%> (-1.89%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/feishu/FeishuHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9mZWlzaHUvRmVpc2h1SG9va0NhbGxiYWNrLmphdmE=) | `12.85% <0.00%> (-1.43%)` | `2.00 <0.00> (-1.00)` | |
| [...r/core/alarm/provider/slack/SlackhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9zbGFjay9TbGFja2hvb2tDYWxsYmFjay5qYXZh) | `20.83% <0.00%> (-4.75%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <0.00%> (-2.64%)` | `2.00 <0.00> (-1.00)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `8.86% <8.86%> (ø)` | `1.00 <1.00> (?)` | |
| [...zer/dsl/spec/sink/sampler/RateLimitingSampler.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvUmF0ZUxpbWl0aW5nU2FtcGxlci5qYXZh) | `12.12% <12.12%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `16.66% <16.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `18.51% <18.51%> (ø)` | `2.00 <2.00> (?)` | |
| ... and [441 more](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=footer). Last update [665a07c...b7520a5](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6431: Fix alarm httpclient connection leak
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6431:
URL: https://github.com/apache/skywalking/pull/6431#issuecomment-784759581
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=h1) Report
> Merging [#6431](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=desc) (5c8c304) into [master](https://codecov.io/gh/apache/skywalking/commit/8c3d1679e37f992b697835b2402401a26eac19e8?el=desc) (8c3d167) will **decrease** coverage by `3.74%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6431 +/- ##
============================================
- Coverage 51.80% 48.05% -3.75%
+ Complexity 3788 3522 -266
============================================
Files 1016 999 -17
Lines 24957 24578 -379
Branches 2447 2397 -50
============================================
- Hits 12930 11812 -1118
- Misses 10913 11756 +843
+ Partials 1114 1010 -104
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/server/core/alarm/provider/WebhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9XZWJob29rQ2FsbGJhY2suamF2YQ==) | `25.00% <0.00%> (-46.43%)` | `2.00 <0.00> (-2.00)` | |
| [.../alarm/provider/dingtalk/DingtalkHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9kaW5ndGFsay9EaW5ndGFsa0hvb2tDYWxsYmFjay5qYXZh) | `15.51% <0.00%> (-3.36%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/feishu/FeishuHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9mZWlzaHUvRmVpc2h1SG9va0NhbGxiYWNrLmphdmE=) | `12.00% <0.00%> (-2.29%)` | `2.00 <0.00> (-1.00)` | |
| [...r/core/alarm/provider/slack/SlackhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9zbGFjay9TbGFja2hvb2tDYWxsYmFjay5qYXZh) | `20.83% <0.00%> (-4.75%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `20.93% <0.00%> (-5.39%)` | `2.00 <0.00> (-1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...ient/elasticsearch/ElasticSearchUpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaFVwZGF0ZVJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...in/elasticsearch/base/TimeRangeIndexNameMaker.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9UaW1lUmFuZ2VJbmRleE5hbWVNYWtlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [159 more](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=footer). Last update [8c3d167...3573922](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6431: Fix alarm httpclient connection leak
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6431:
URL: https://github.com/apache/skywalking/pull/6431#issuecomment-784759581
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=h1) Report
> Merging [#6431](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=desc) (f55956d) into [master](https://codecov.io/gh/apache/skywalking/commit/0f8b6d641a963adafd3f4dd2a7388dfd27a626c9?el=desc) (0f8b6d6) will **decrease** coverage by `3.13%`.
> The diff coverage is `11.42%`.
[](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6431 +/- ##
============================================
- Coverage 53.66% 50.53% -3.14%
+ Complexity 4069 3674 -395
============================================
Files 1789 998 -791
Lines 38172 24694 -13478
Branches 4217 2422 -1795
============================================
- Hits 20484 12478 -8006
+ Misses 16688 11175 -5513
- Partials 1000 1041 +41
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../alarm/provider/dingtalk/DingtalkHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9kaW5ndGFsay9EaW5ndGFsa0hvb2tDYWxsYmFjay5qYXZh) | `17.24% <0.00%> (-60.95%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/feishu/FeishuHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9mZWlzaHUvRmVpc2h1SG9va0NhbGxiYWNrLmphdmE=) | `13.33% <0.00%> (-70.00%)` | `3.00 <0.00> (ø)` | |
| [...r/core/alarm/provider/slack/SlackhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9zbGFjay9TbGFja2hvb2tDYWxsYmFjay5qYXZh) | `22.91% <0.00%> (-1.53%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.25% <0.00%> (-54.25%)` | `3.00 <0.00> (ø)` | |
| [...ap/server/core/alarm/provider/WebhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9XZWJob29rQ2FsbGJhY2suamF2YQ==) | `67.50% <57.14%> (-0.07%)` | `4.00 <0.00> (ø)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...lking/oap/server/analyzer/event/EventAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L0V2ZW50QW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| ... and [1279 more](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=footer). Last update [08bceb9...f55956d](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6431: Fix alarm httpclient connection leak
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6431:
URL: https://github.com/apache/skywalking/pull/6431#issuecomment-784759581
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=h1) Report
> Merging [#6431](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=desc) (5c8c304) into [master](https://codecov.io/gh/apache/skywalking/commit/8c3d1679e37f992b697835b2402401a26eac19e8?el=desc) (8c3d167) will **increase** coverage by `0.44%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6431 +/- ##
============================================
+ Coverage 51.86% 52.31% +0.44%
+ Complexity 3794 3777 -17
============================================
Files 1016 999 -17
Lines 24957 24618 -339
Branches 2447 2400 -47
============================================
- Hits 12945 12878 -67
+ Misses 10900 10597 -303
- Partials 1112 1143 +31
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/server/core/alarm/provider/WebhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9XZWJob29rQ2FsbGJhY2suamF2YQ==) | `25.00% <0.00%> (-46.43%)` | `2.00 <0.00> (-2.00)` | |
| [.../alarm/provider/dingtalk/DingtalkHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9kaW5ndGFsay9EaW5ndGFsa0hvb2tDYWxsYmFjay5qYXZh) | `15.51% <0.00%> (-3.36%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/feishu/FeishuHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9mZWlzaHUvRmVpc2h1SG9va0NhbGxiYWNrLmphdmE=) | `12.00% <0.00%> (-2.29%)` | `2.00 <0.00> (-1.00)` | |
| [...r/core/alarm/provider/slack/SlackhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9zbGFjay9TbGFja2hvb2tDYWxsYmFjay5qYXZh) | `20.83% <0.00%> (-4.75%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `20.93% <0.00%> (-5.39%)` | `2.00 <0.00> (-1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh) | `4.65% <0.00%> (-89.54%)` | `1.00% <0.00%> (-10.00%)` | |
| [...tworkalias/NetworkAddressAliasSetupDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzU2V0dXBEaXNwYXRjaGVyLmphdmE=) | `11.11% <0.00%> (-88.89%)` | `1.00% <0.00%> (-1.00%)` | |
| [...lugin/elasticsearch/query/ProfileTaskLogEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRhc2tMb2dFc0RBTy5qYXZh) | `13.63% <0.00%> (-86.37%)` | `1.00% <0.00%> (-3.00%)` | |
| [...er/core/server/auth/AuthenticationInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL2F1dGgvQXV0aGVudGljYXRpb25JbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (-84.62%)` | `0.00% <0.00%> (-4.00%)` | |
| ... and [130 more](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=footer). Last update [8c3d167...3573922](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6431: Fix alarm httpclient connection leak
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6431:
URL: https://github.com/apache/skywalking/pull/6431#issuecomment-784759581
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=h1) Report
> Merging [#6431](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=desc) (5c8c304) into [master](https://codecov.io/gh/apache/skywalking/commit/8c3d1679e37f992b697835b2402401a26eac19e8?el=desc) (8c3d167) will **decrease** coverage by `1.67%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6431 +/- ##
============================================
- Coverage 51.80% 50.13% -1.68%
+ Complexity 3788 3622 -166
============================================
Files 1016 999 -17
Lines 24957 24600 -357
Branches 2447 2399 -48
============================================
- Hits 12930 12334 -596
- Misses 10913 11192 +279
+ Partials 1114 1074 -40
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/server/core/alarm/provider/WebhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9XZWJob29rQ2FsbGJhY2suamF2YQ==) | `25.00% <0.00%> (-46.43%)` | `2.00 <0.00> (-2.00)` | |
| [.../alarm/provider/dingtalk/DingtalkHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9kaW5ndGFsay9EaW5ndGFsa0hvb2tDYWxsYmFjay5qYXZh) | `15.51% <0.00%> (-3.36%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/feishu/FeishuHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9mZWlzaHUvRmVpc2h1SG9va0NhbGxiYWNrLmphdmE=) | `12.00% <0.00%> (-2.29%)` | `2.00 <0.00> (-1.00)` | |
| [...r/core/alarm/provider/slack/SlackhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9zbGFjay9TbGFja2hvb2tDYWxsYmFjay5qYXZh) | `20.83% <0.00%> (-4.75%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `20.93% <0.00%> (-5.39%)` | `2.00 <0.00> (-1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [.../provider/parser/performance/PerfDataAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL3BhcnNlci9wZXJmb3JtYW5jZS9QZXJmRGF0YUFuYWx5emVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...ovider/parser/errorlog/listener/SourceBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL3BhcnNlci9lcnJvcmxvZy9saXN0ZW5lci9Tb3VyY2VCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| ... and [144 more](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=footer). Last update [8c3d167...3573922](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6431: Fix alarm httpclient connection leak
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6431:
URL: https://github.com/apache/skywalking/pull/6431#issuecomment-784759581
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=h1) Report
> Merging [#6431](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=desc) (b8320cc) into [master](https://codecov.io/gh/apache/skywalking/commit/0f8b6d641a963adafd3f4dd2a7388dfd27a626c9?el=desc) (0f8b6d6) will **decrease** coverage by `7.46%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6431 +/- ##
============================================
- Coverage 53.66% 46.20% -7.47%
+ Complexity 4069 3407 -662
============================================
Files 1789 999 -790
Lines 38172 24582 -13590
Branches 4217 2413 -1804
============================================
- Hits 20484 11357 -9127
+ Misses 16688 12253 -4435
+ Partials 1000 972 -28
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/server/core/alarm/provider/WebhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9XZWJob29rQ2FsbGJhY2suamF2YQ==) | `25.00% <0.00%> (-42.57%)` | `2.00 <0.00> (-2.00)` | |
| [.../alarm/provider/dingtalk/DingtalkHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9kaW5ndGFsay9EaW5ndGFsa0hvb2tDYWxsYmFjay5qYXZh) | `15.51% <0.00%> (-62.67%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/feishu/FeishuHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9mZWlzaHUvRmVpc2h1SG9va0NhbGxiYWNrLmphdmE=) | `12.00% <0.00%> (-71.34%)` | `2.00 <0.00> (-1.00)` | |
| [...r/core/alarm/provider/slack/SlackhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9zbGFjay9TbGFja2hvb2tDYWxsYmFjay5qYXZh) | `20.83% <0.00%> (-3.62%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `20.93% <0.00%> (-56.57%)` | `2.00 <0.00> (-1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1307 more](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=footer). Last update [08bceb9...f55956d](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6431: Fix alarm httpclient connection leak
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6431:
URL: https://github.com/apache/skywalking/pull/6431#issuecomment-784759581
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6431: Fix alarm httpclient connection leak
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6431:
URL: https://github.com/apache/skywalking/pull/6431#issuecomment-784759581
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6431: Fix alarm httpclient connection leak
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6431:
URL: https://github.com/apache/skywalking/pull/6431#issuecomment-784759581
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=h1) Report
> Merging [#6431](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=desc) (5c8c304) into [master](https://codecov.io/gh/apache/skywalking/commit/8c3d1679e37f992b697835b2402401a26eac19e8?el=desc) (8c3d167) will **increase** coverage by `3.50%`.
> The diff coverage is `11.42%`.
[](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6431 +/- ##
============================================
+ Coverage 51.86% 55.37% +3.50%
- Complexity 3794 3949 +155
============================================
Files 1016 999 -17
Lines 24957 24666 -291
Branches 2447 2406 -41
============================================
+ Hits 12945 13658 +713
+ Misses 10900 9832 -1068
- Partials 1112 1176 +64
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../alarm/provider/dingtalk/DingtalkHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9kaW5ndGFsay9EaW5ndGFsa0hvb2tDYWxsYmFjay5qYXZh) | `17.24% <0.00%> (-1.63%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/feishu/FeishuHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9mZWlzaHUvRmVpc2h1SG9va0NhbGxiYWNrLmphdmE=) | `13.33% <0.00%> (-0.96%)` | `3.00 <0.00> (ø)` | |
| [...r/core/alarm/provider/slack/SlackhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9zbGFjay9TbGFja2hvb2tDYWxsYmFjay5qYXZh) | `22.91% <0.00%> (-2.67%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.25% <0.00%> (-3.06%)` | `3.00 <0.00> (ø)` | |
| [...ap/server/core/alarm/provider/WebhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9XZWJob29rQ2FsbGJhY2suamF2YQ==) | `67.50% <57.14%> (-3.93%)` | `4.00 <0.00> (ø)` | |
| [...g/oap/server/telemetry/prometheus/BaseMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvQmFzZU1ldHJpY3MuamF2YQ==) | `90.00% <0.00%> (-6.67%)` | `9.00% <0.00%> (-1.00%)` | |
| [...r/telemetry/prometheus/PrometheusGaugeMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c0dhdWdlTWV0cmljcy5qYXZh) | `25.00% <0.00%> (-4.17%)` | `3.00% <0.00%> (-1.00%)` | |
| [...king/oap/meter/analyzer/prometheus/rule/Rules.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9ydWxlL1J1bGVzLmphdmE=) | `66.66% <0.00%> (-4.17%)` | `4.00% <0.00%> (ø%)` | |
| [.../agent/core/profile/ProfileTaskChannelService.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlVGFza0NoYW5uZWxTZXJ2aWNlLmphdmE=) | `51.51% <0.00%> (-3.04%)` | `10.00% <0.00%> (ø%)` | |
| [...apm/agent/core/context/RuntimeContextSnapshot.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9SdW50aW1lQ29udGV4dFNuYXBzaG90LmphdmE=) | | | |
| ... and [73 more](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=footer). Last update [8c3d167...3573922](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6431: Fix alarm httpclient connection leak
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6431:
URL: https://github.com/apache/skywalking/pull/6431#issuecomment-784759581
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=h1) Report
> Merging [#6431](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=desc) (b8320cc) into [master](https://codecov.io/gh/apache/skywalking/commit/0f8b6d641a963adafd3f4dd2a7388dfd27a626c9?el=desc) (0f8b6d6) will **decrease** coverage by `5.08%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6431 +/- ##
============================================
- Coverage 53.66% 48.57% -5.09%
+ Complexity 4069 3523 -546
============================================
Files 1789 999 -790
Lines 38172 24592 -13580
Branches 4217 2414 -1803
============================================
- Hits 20484 11946 -8538
+ Misses 16688 11611 -5077
- Partials 1000 1035 +35
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/server/core/alarm/provider/WebhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9XZWJob29rQ2FsbGJhY2suamF2YQ==) | `25.00% <0.00%> (-42.57%)` | `2.00 <0.00> (-2.00)` | |
| [.../alarm/provider/dingtalk/DingtalkHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9kaW5ndGFsay9EaW5ndGFsa0hvb2tDYWxsYmFjay5qYXZh) | `15.51% <0.00%> (-62.67%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/feishu/FeishuHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9mZWlzaHUvRmVpc2h1SG9va0NhbGxiYWNrLmphdmE=) | `12.00% <0.00%> (-71.34%)` | `2.00 <0.00> (-1.00)` | |
| [...r/core/alarm/provider/slack/SlackhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9zbGFjay9TbGFja2hvb2tDYWxsYmFjay5qYXZh) | `20.83% <0.00%> (-3.62%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `20.93% <0.00%> (-56.57%)` | `2.00 <0.00> (-1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1299 more](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=footer). Last update [08bceb9...f55956d](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6431: Fix alarm httpclient connection leak
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6431:
URL: https://github.com/apache/skywalking/pull/6431#issuecomment-784759581
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=h1) Report
> Merging [#6431](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=desc) (b8320cc) into [master](https://codecov.io/gh/apache/skywalking/commit/0f8b6d641a963adafd3f4dd2a7388dfd27a626c9?el=desc) (0f8b6d6) will **decrease** coverage by `19.97%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6431 +/- ##
=============================================
- Coverage 53.66% 33.68% -19.98%
+ Complexity 4069 2140 -1929
=============================================
Files 1789 848 -941
Lines 38172 20793 -17379
Branches 4217 1958 -2259
=============================================
- Hits 20484 7004 -13480
+ Misses 16688 13268 -3420
+ Partials 1000 521 -479
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/server/core/alarm/provider/WebhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9XZWJob29rQ2FsbGJhY2suamF2YQ==) | `25.00% <0.00%> (-42.57%)` | `2.00 <0.00> (-2.00)` | |
| [.../alarm/provider/dingtalk/DingtalkHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9kaW5ndGFsay9EaW5ndGFsa0hvb2tDYWxsYmFjay5qYXZh) | `15.51% <0.00%> (-62.67%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/feishu/FeishuHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9mZWlzaHUvRmVpc2h1SG9va0NhbGxiYWNrLmphdmE=) | `12.00% <0.00%> (-71.34%)` | `2.00 <0.00> (-1.00)` | |
| [...r/core/alarm/provider/slack/SlackhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9zbGFjay9TbGFja2hvb2tDYWxsYmFjay5qYXZh) | `20.83% <0.00%> (-3.62%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `20.93% <0.00%> (-56.57%)` | `2.00 <0.00> (-1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1417 more](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=footer). Last update [08bceb9...f55956d](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6431: Fix alarm httpclient connection leak
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6431:
URL: https://github.com/apache/skywalking/pull/6431#issuecomment-784759581
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org