You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/12/27 09:23:55 UTC
[GitHub] [spark] HyukjinKwon commented on a change in pull request #30929: [SPARK-33914][SQL][DOCS] Describe the structure of unified DS v1 and v2 tests
HyukjinKwon commented on a change in pull request #30929:
URL: https://github.com/apache/spark/pull/30929#discussion_r549088250
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/command/AlterTableAddPartitionSuiteBase.scala
##########
@@ -22,6 +22,20 @@ import org.apache.spark.sql.catalyst.analysis.PartitionsAlreadyExistException
import org.apache.spark.sql.catalyst.catalog.CatalogTypes.TablePartitionSpec
import org.apache.spark.sql.internal.SQLConf
+/**
+ * This base suite contains unified tests for the `ALTER TABLE .. ADD PARTITION` command that
+ * check V1 and V2 table catalogs. The tests that cannot run for all supported catalogs are
+ * located in more specific test suites:
+ *
+ * - V2 table catalog tests:
+ * [[org.apache.spark.sql.execution.command.v2.AlterTableAddPartitionSuite]]
+ * - V1 table catalog tests:
+ * [[org.apache.spark.sql.execution.command.v1.AlterTableAddPartitionSuiteBase]]
Review comment:
Unidoc doesn't work for the referencing in Javadoc with Scala's trait. it should be `` `org.apache.spark.sql.execution.command.v1.AlterTableAddPartitionSuite` ``
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org