You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "aglinxinyuan (via GitHub)" <gi...@apache.org> on 2026/05/02 06:55:59 UTC
[PR] chore(deps): upgrade frontend Node engine to 24 [texera]
aglinxinyuan opened a new pull request, #4658:
URL: https://github.com/apache/texera/pull/4658
### What changes were proposed in this PR?
Bump the frontend from Node 20 to Node 24 (current Active LTS) ahead of the Node 20 end-of-life window (October 2026 maintenance / April 2027 EOL).
- `frontend/package.json`
- `engines.node`: `>=20.19.0` → `>=24.0.0`
- `@types/node`: `20.19.39` → `24.10.1`
- `.github/workflows/build.yml`
- frontend matrix `node-version`: `20.19.0` → `24.10.0`
- fixed stale literal `18` in the frontend job-name format string (now `24`, matching the matrix)
- `bin/texera-web-application.dockerfile`
- frontend build stage: `node:22-bookworm` → `node:24-bookworm`
- `AGENTS.md` — two doc references to the Node engine bumped to `>=24.0.0`
- `frontend/yarn.lock` — regenerated; only `@types/node` and its `undici-types` peer changed
Out of scope:
- The root `Dockerfile` still pins `node:18-alpine` but references the long-removed `core/gui/` paths. It is stale and should be cleaned up or removed separately.
- The `frontend/.nvmrc` already says `lts/*`, so no change was needed.
- The Node 24 audit of the GitHub Actions themselves is tracked in #4647.
### Any related issues, documentation, discussions?
Closes #4657. Related: #4647 (Node 24 inside GitHub Actions runtimes).
### How was this PR tested?
Locally on Windows with Node 24.15.0 + Yarn 4.14.1:
- `yarn --cwd frontend install` — lockfile updated cleanly (only `@types/node` 20.19.39 → 24.10.1 and `undici-types` 6.21.0 → 7.16.0).
- `yarn --cwd frontend build:ci` — production bundle built (initial total 13.82 MB raw / 2.87 MB transfer), exit 0.
- `yarn --cwd frontend test:ci` — Karma/Jasmine, 298 of 299 specs passed (1 pre-existing skip), exit 0 under Chrome Headless 147.
CI will exercise the new `24.10.0` matrix value across `ubuntu-latest`, `windows-latest`, and `macos-latest`.
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Opus 4.7)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(deps): upgrade frontend Node engine to 24 [texera]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #4658:
URL: https://github.com/apache/texera/pull/4658#issuecomment-4365391798
## [Codecov](https://app.codecov.io/gh/apache/texera/pull/4658?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 42.85%. Comparing base ([`5a5ee19`](https://app.codecov.io/gh/apache/texera/commit/5a5ee195418dae593699eb06c7a19566096a5a15?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`25bfe0d`](https://app.codecov.io/gh/apache/texera/commit/25bfe0d70c386947d72d8a3b4fa954afbab7bdca?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #4658 +/- ##
=========================================
Coverage 42.85% 42.85%
Complexity 2027 2027
=========================================
Files 957 957
Lines 34077 34077
Branches 3753 3753
=========================================
Hits 14604 14604
Misses 18692 18692
Partials 781 781
```
| [Flag](https://app.codecov.io/gh/apache/texera/pull/4658/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [agent-service](https://app.codecov.io/gh/apache/texera/pull/4658/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.72% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/texera/pull/4658?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(deps): upgrade frontend Node engine to 24 [texera]
Posted by "aglinxinyuan (via GitHub)" <gi...@apache.org>.
aglinxinyuan commented on code in PR #4658:
URL: https://github.com/apache/texera/pull/4658#discussion_r3176305676
##########
frontend/package.json:
##########
@@ -2,7 +2,7 @@
"name": "gui",
"version": "0.0.0",
"engines": {
- "node": ">=20.19.0"
+ "node": ">=24.0.0"
Review Comment:
We could skip it, but those versions will easily get out of sync.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(deps): upgrade frontend Node engine to 24 [texera]
Posted by "Yicong-Huang (via GitHub)" <gi...@apache.org>.
Yicong-Huang commented on code in PR #4658:
URL: https://github.com/apache/texera/pull/4658#discussion_r3176287391
##########
frontend/package.json:
##########
@@ -2,7 +2,7 @@
"name": "gui",
"version": "0.0.0",
"engines": {
- "node": ">=20.19.0"
+ "node": ">=24.0.0"
Review Comment:
This we need to alert all developers to upgrade. do we have to do it now?
##########
.github/workflows/build.yml:
##########
@@ -59,7 +59,7 @@ env:
jobs:
frontend:
if: ${{ inputs.run_frontend }}
- name: ${{ format('frontend{0} ({1}, 18)', inputs.job_name_suffix, matrix.os) }}
+ name: ${{ format('frontend{0} ({1}, 24)', inputs.job_name_suffix, matrix.os) }}
Review Comment:
let's remove those names? we don't need them any more to match a check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(deps): upgrade frontend Node engine to 24 [texera]
Posted by "aglinxinyuan (via GitHub)" <gi...@apache.org>.
aglinxinyuan commented on code in PR #4658:
URL: https://github.com/apache/texera/pull/4658#discussion_r3176318944
##########
frontend/package.json:
##########
@@ -2,7 +2,7 @@
"name": "gui",
"version": "0.0.0",
"engines": {
- "node": ">=20.19.0"
+ "node": ">=24.0.0"
Review Comment:
Sure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(deps): upgrade frontend Node engine to 24 [texera]
Posted by "aglinxinyuan (via GitHub)" <gi...@apache.org>.
aglinxinyuan merged PR #4658:
URL: https://github.com/apache/texera/pull/4658
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(deps): upgrade frontend Node engine to 24 [texera]
Posted by "Yicong-Huang (via GitHub)" <gi...@apache.org>.
Yicong-Huang commented on code in PR #4658:
URL: https://github.com/apache/texera/pull/4658#discussion_r3176319487
##########
.github/workflows/build.yml:
##########
@@ -59,7 +59,6 @@ env:
jobs:
frontend:
if: ${{ inputs.run_frontend }}
- name: ${{ format('frontend{0} ({1}, 18)', inputs.job_name_suffix, matrix.os) }}
Review Comment:
rename to something simpler. I think frontend + os should be good, just remove the node version. if you leave out the name, what is the default name?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(deps): upgrade frontend Node engine to 24 [texera]
Posted by "aglinxinyuan (via GitHub)" <gi...@apache.org>.
aglinxinyuan commented on code in PR #4658:
URL: https://github.com/apache/texera/pull/4658#discussion_r3176293978
##########
.github/workflows/build.yml:
##########
@@ -59,7 +59,7 @@ env:
jobs:
frontend:
if: ${{ inputs.run_frontend }}
- name: ${{ format('frontend{0} ({1}, 18)', inputs.job_name_suffix, matrix.os) }}
+ name: ${{ format('frontend{0} ({1}, 24)', inputs.job_name_suffix, matrix.os) }}
Review Comment:
Removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(deps): upgrade frontend Node engine to 24 [texera]
Posted by "Yicong-Huang (via GitHub)" <gi...@apache.org>.
Yicong-Huang commented on code in PR #4658:
URL: https://github.com/apache/texera/pull/4658#discussion_r3176299216
##########
frontend/package.json:
##########
@@ -2,7 +2,7 @@
"name": "gui",
"version": "0.0.0",
"engines": {
- "node": ">=20.19.0"
+ "node": ">=24.0.0"
Review Comment:
it is required. this is package.json, it will break developers from continuing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(deps): upgrade frontend Node engine to 24 [texera]
Posted by "Yicong-Huang (via GitHub)" <gi...@apache.org>.
Yicong-Huang commented on code in PR #4658:
URL: https://github.com/apache/texera/pull/4658#discussion_r3176317722
##########
frontend/package.json:
##########
@@ -2,7 +2,7 @@
"name": "gui",
"version": "0.0.0",
"engines": {
- "node": ">=20.19.0"
+ "node": ">=24.0.0"
Review Comment:
I think we can combine it in this PR. But I think better send an email to dev list after this is merged, to alert all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(deps): upgrade frontend Node engine to 24 [texera]
Posted by "aglinxinyuan (via GitHub)" <gi...@apache.org>.
aglinxinyuan commented on code in PR #4658:
URL: https://github.com/apache/texera/pull/4658#discussion_r3176302964
##########
frontend/package.json:
##########
@@ -2,7 +2,7 @@
"name": "gui",
"version": "0.0.0",
"engines": {
- "node": ">=20.19.0"
+ "node": ">=24.0.0"
Review Comment:
Then let's require it? Angular upgraded to @types/node": "24.10.1".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(deps): upgrade frontend Node engine to 24 [texera]
Posted by "aglinxinyuan (via GitHub)" <gi...@apache.org>.
aglinxinyuan commented on code in PR #4658:
URL: https://github.com/apache/texera/pull/4658#discussion_r3176290795
##########
frontend/package.json:
##########
@@ -2,7 +2,7 @@
"name": "gui",
"version": "0.0.0",
"engines": {
- "node": ">=20.19.0"
+ "node": ">=24.0.0"
Review Comment:
Let's give them the alert. It's not required to upgrade.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(deps): upgrade frontend Node engine to 24 [texera]
Posted by "aglinxinyuan (via GitHub)" <gi...@apache.org>.
aglinxinyuan commented on code in PR #4658:
URL: https://github.com/apache/texera/pull/4658#discussion_r3176311500
##########
.github/workflows/build.yml:
##########
@@ -59,7 +59,6 @@ env:
jobs:
frontend:
if: ${{ inputs.run_frontend }}
- name: ${{ format('frontend{0} ({1}, 18)', inputs.job_name_suffix, matrix.os) }}
Review Comment:
@Yicong-Huang , do you want me to remove the name like this? Or rename to something simpler?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(deps): upgrade frontend Node engine to 24 [texera]
Posted by "aglinxinyuan (via GitHub)" <gi...@apache.org>.
aglinxinyuan commented on code in PR #4658:
URL: https://github.com/apache/texera/pull/4658#discussion_r3176327573
##########
.github/workflows/build.yml:
##########
@@ -59,7 +59,6 @@ env:
jobs:
frontend:
if: ${{ inputs.run_frontend }}
- name: ${{ format('frontend{0} ({1}, 18)', inputs.job_name_suffix, matrix.os) }}
Review Comment:
It looks like the default name is frontend + os + node. Maybe we can just use the default name?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(deps): upgrade frontend Node engine to 24 [texera]
Posted by "aglinxinyuan (via GitHub)" <gi...@apache.org>.
aglinxinyuan commented on code in PR #4658:
URL: https://github.com/apache/texera/pull/4658#discussion_r3176327573
##########
.github/workflows/build.yml:
##########
@@ -59,7 +59,6 @@ env:
jobs:
frontend:
if: ${{ inputs.run_frontend }}
- name: ${{ format('frontend{0} ({1}, 18)', inputs.job_name_suffix, matrix.os) }}
Review Comment:
It looks like the default name is frontend + os + node.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(deps): upgrade frontend Node engine to 24 [texera]
Posted by "Yicong-Huang (via GitHub)" <gi...@apache.org>.
Yicong-Huang commented on code in PR #4658:
URL: https://github.com/apache/texera/pull/4658#discussion_r3176383122
##########
.github/workflows/build.yml:
##########
@@ -59,7 +59,6 @@ env:
jobs:
frontend:
if: ${{ inputs.run_frontend }}
- name: ${{ format('frontend{0} ({1}, 18)', inputs.job_name_suffix, matrix.os) }}
Review Comment:
ok. maybe that's easier.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(deps): upgrade frontend Node engine to 24 [texera]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #4658:
URL: https://github.com/apache/texera/pull/4658#discussion_r3177629030
##########
AGENTS.md:
##########
@@ -17,7 +17,7 @@ Major areas:
- `config-service/`, `access-control-service/`, `file-service/`,
`computing-unit-managing-service/`, `workflow-compiling-service/`: backend
services wired through `build.sbt`.
-- `frontend/`: Angular application. Uses Yarn 4.14.1, Node >= 20.19.0, Nx,
+- `frontend/`: Angular application. Uses Yarn 4.14.1, Node >= 24.0.0, Nx,
Prettier, ESLint, Karma/Jasmine, and ng-zorro.
Review Comment:
AGENTS.md states the frontend uses Yarn 4.14.1 via Corepack, but `bin/texera-web-application.dockerfile` pins Yarn 4.5.1 in its frontend build stage. With the Node bump, it would be good to keep these aligned (either update the Dockerfile to 4.14.1 or note in docs that the Docker image build uses a different Yarn version).
##########
.github/workflows/build.yml:
##########
@@ -63,7 +63,6 @@ env:
jobs:
frontend:
if: ${{ inputs.run_frontend }}
- name: ${{ format('frontend{0} ({1}, 18)', inputs.job_name_suffix, matrix.os) }}
runs-on: ${{ matrix.os }}
Review Comment:
The PR description says the frontend job name format string was updated to show Node 24, but the `name:` field for the `frontend` job was removed entirely. If the intent is to keep the explicit job name (including Node version), reintroduce it with the updated version; otherwise please update the PR description to reflect that job naming was removed.
##########
.github/workflows/build.yml:
##########
@@ -348,7 +347,6 @@ jobs:
python:
if: ${{ inputs.run_python }}
Review Comment:
The `python` job’s `name:` field was removed. This changes how the job is displayed in GitHub Actions (and may affect any tooling that expects stable job names). If this wasn’t intentional, please restore the `name:` line; if it was, consider calling it out in the PR description since it’s unrelated to the Node 24 bump.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org