[GitHub] [pulsar] eolivelli commented on a change in pull request #8306: Support exclude the message when reset cursor by message ID

[GitBox <gi...@apache.org>]

eolivelli commented on a change in pull request #8306:
URL: https://github.com/apache/pulsar/pull/8306#discussion_r509066533



##########
File path: tests/integration/src/test/java/org/apache/pulsar/tests/integration/messaging/PersistentTopicMessagingTest.java
##########
@@ -63,4 +63,9 @@ public void testNonPartitionedTopicMessagingWithKeyShared(String serviceUrl) thr
     public void testPartitionedTopicMessagingWithKeyShared(String serviceUrl) throws Exception {
         partitionedTopicSendAndReceiveWithKeyShared(serviceUrl, true);
     }
+
+    @Test(dataProvider = "ServiceUrls")
+    public void testResetCursorCompatibility(String serviceUrl) throws Exception {
+        resetCursorCompatibility(serviceUrl, true);

Review comment:
       `resetCursorCompatibility` is a new method and you are only calling it with 'true' parameter.
   is it expected ?
   what about calling also` resetCursorCompatibility(serviceUrl, false);` ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org