You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Gilbert Song <so...@gmail.com> on 2017/08/15 22:50:11 UTC
Review Request 61675: Updated doc for the changes of pid namespace
sharing.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61675/
-----------------------------------------------------------
Review request for mesos, Anand Mazumdar, Gastón Kleiman, Greg Mann, Jie Yu, Qian Zhang, and Vinod Kone.
Repository: mesos
Description
-------
Updated doc for the changes of pid namespace sharing.
Diffs
-----
docs/mesos-containerizer.md feaaa556c9646435c6c9d677569962576ebf4c74
Diff: https://reviews.apache.org/r/61675/diff/1/
Testing
-------
N/A.
Thanks,
Gilbert Song
Re: Review Request 61675: Updated doc for the changes of pid namespace
sharing.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61675/#review183786
-----------------------------------------------------------
docs/mesos-containerizer.md
Lines 67 (patched)
<https://reviews.apache.org/r/61675/#comment259835>
s/Pid/PID/ ?
docs/mesos-containerizer.md
Lines 76 (patched)
<https://reviews.apache.org/r/61675/#comment259834>
s/ontainer/container/
docs/mesos-containerizer.md
Lines 83 (patched)
<https://reviews.apache.org/r/61675/#comment259836>
s/to share/which shares its/
- Greg Mann
On Aug. 15, 2017, 10:50 p.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61675/
> -----------------------------------------------------------
>
> (Updated Aug. 15, 2017, 10:50 p.m.)
>
>
> Review request for mesos, Anand Mazumdar, Gastón Kleiman, Greg Mann, Jie Yu, Qian Zhang, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated doc for the changes of pid namespace sharing.
>
>
> Diffs
> -----
>
> docs/mesos-containerizer.md feaaa556c9646435c6c9d677569962576ebf4c74
>
>
> Diff: https://reviews.apache.org/r/61675/diff/1/
>
>
> Testing
> -------
>
> N/A.
>
>
> Thanks,
>
> Gilbert Song
>
>
Re: Review Request 61675: Updated doc for the changes of pid namespace
sharing.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61675/#review187894
-----------------------------------------------------------
FAIL: Failed to apply the current review.
Failed command: `python.exe .\support\apply-reviews.py -n -r 61675`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/61675
Relevant logs:
- [apply-review-61675-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/61675/logs/apply-review-61675-stdout.log):
```
error: patch failed: docs/isolators/namespaces-pid.md:27
error: docs/isolators/namespaces-pid.md: patch does not apply
```
- Mesos Reviewbot Windows
On Oct. 12, 2017, 11:14 p.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61675/
> -----------------------------------------------------------
>
> (Updated Oct. 12, 2017, 11:14 p.m.)
>
>
> Review request for mesos, Anand Mazumdar, Gaston Kleiman, Greg Mann, Jie Yu, Qian Zhang, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated doc for the changes of pid namespace sharing.
>
>
> Diffs
> -----
>
> docs/isolators/namespaces-pid.md bf4dadceddf862cd90bcc6960e8135314d5a92ec
>
>
> Diff: https://reviews.apache.org/r/61675/diff/2/
>
>
> Testing
> -------
>
> N/A.
>
>
> Thanks,
>
> Gilbert Song
>
>
Re: Review Request 61675: Updated doc for the changes of pid namespace
sharing.
Posted by Gilbert Song <so...@gmail.com>.
> On Oct. 12, 2017, 4:21 p.m., Gaston Kleiman wrote:
> > This is great, thanks!
Ah, I missed your comments. Let me submit a separate patch to address them!
- Gilbert
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61675/#review187891
-----------------------------------------------------------
On Oct. 12, 2017, 4:14 p.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61675/
> -----------------------------------------------------------
>
> (Updated Oct. 12, 2017, 4:14 p.m.)
>
>
> Review request for mesos, Anand Mazumdar, Gaston Kleiman, Greg Mann, Jie Yu, Qian Zhang, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated doc for the changes of pid namespace sharing.
>
>
> Diffs
> -----
>
> docs/isolators/namespaces-pid.md bf4dadceddf862cd90bcc6960e8135314d5a92ec
>
>
> Diff: https://reviews.apache.org/r/61675/diff/2/
>
>
> Testing
> -------
>
> N/A.
>
>
> Thanks,
>
> Gilbert Song
>
>
Re: Review Request 61675: Updated doc for the changes of pid namespace
sharing.
Posted by Gaston Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61675/#review187891
-----------------------------------------------------------
Fix it, then Ship it!
This is great, thanks!
docs/isolators/namespaces-pid.md
Lines 31 (patched)
<https://reviews.apache.org/r/61675/#comment264933>
Nit: s/Namespace/namespace/ =)
docs/isolators/namespaces-pid.md
Lines 37 (patched)
<https://reviews.apache.org/r/61675/#comment264934>
Also a nit: s/top level/top-level/
docs/isolators/namespaces-pid.md
Lines 46 (patched)
<https://reviews.apache.org/r/61675/#comment264937>
Nit: s/as `true`/to `true`/
s/top level/top-level/
- Gaston Kleiman
On Oct. 12, 2017, 4:14 p.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61675/
> -----------------------------------------------------------
>
> (Updated Oct. 12, 2017, 4:14 p.m.)
>
>
> Review request for mesos, Anand Mazumdar, Gaston Kleiman, Greg Mann, Jie Yu, Qian Zhang, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated doc for the changes of pid namespace sharing.
>
>
> Diffs
> -----
>
> docs/isolators/namespaces-pid.md bf4dadceddf862cd90bcc6960e8135314d5a92ec
>
>
> Diff: https://reviews.apache.org/r/61675/diff/2/
>
>
> Testing
> -------
>
> N/A.
>
>
> Thanks,
>
> Gilbert Song
>
>
Re: Review Request 61675: Updated doc for the changes of pid namespace
sharing.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61675/
-----------------------------------------------------------
(Updated Oct. 12, 2017, 4:14 p.m.)
Review request for mesos, Anand Mazumdar, Gaston Kleiman, Greg Mann, Jie Yu, Qian Zhang, and Vinod Kone.
Repository: mesos
Description
-------
Updated doc for the changes of pid namespace sharing.
Diffs (updated)
-----
docs/isolators/namespaces-pid.md bf4dadceddf862cd90bcc6960e8135314d5a92ec
Diff: https://reviews.apache.org/r/61675/diff/2/
Changes: https://reviews.apache.org/r/61675/diff/1-2/
Testing
-------
N/A.
Thanks,
Gilbert Song
Re: Review Request 61675: Updated doc for the changes of pid namespace
sharing.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61675/#review183014
-----------------------------------------------------------
Fix it, then Ship it!
docs/mesos-containerizer.md
Lines 79 (patched)
<https://reviews.apache.org/r/61675/#comment259002>
s/access/share/ to be consistent with the name of the agent flag.
docs/mesos-containerizer.md
Lines 82 (patched)
<https://reviews.apache.org/r/61675/#comment259003>
s/'/`
- Qian Zhang
On Aug. 16, 2017, 6:50 a.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61675/
> -----------------------------------------------------------
>
> (Updated Aug. 16, 2017, 6:50 a.m.)
>
>
> Review request for mesos, Anand Mazumdar, Gastón Kleiman, Greg Mann, Jie Yu, Qian Zhang, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated doc for the changes of pid namespace sharing.
>
>
> Diffs
> -----
>
> docs/mesos-containerizer.md feaaa556c9646435c6c9d677569962576ebf4c74
>
>
> Diff: https://reviews.apache.org/r/61675/diff/1/
>
>
> Testing
> -------
>
> N/A.
>
>
> Thanks,
>
> Gilbert Song
>
>
Re: Review Request 61675: Updated doc for the changes of pid namespace
sharing.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61675/#review183011
-----------------------------------------------------------
Patch looks great!
Reviews applied: [61675]
Passed command: support\windows-build.bat
- Mesos Reviewbot Windows
On Aug. 15, 2017, 10:50 p.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61675/
> -----------------------------------------------------------
>
> (Updated Aug. 15, 2017, 10:50 p.m.)
>
>
> Review request for mesos, Anand Mazumdar, Gastón Kleiman, Greg Mann, Jie Yu, Qian Zhang, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated doc for the changes of pid namespace sharing.
>
>
> Diffs
> -----
>
> docs/mesos-containerizer.md feaaa556c9646435c6c9d677569962576ebf4c74
>
>
> Diff: https://reviews.apache.org/r/61675/diff/1/
>
>
> Testing
> -------
>
> N/A.
>
>
> Thanks,
>
> Gilbert Song
>
>
Re: Review Request 61675: Updated doc for the changes of pid namespace
sharing.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61675/#review183265
-----------------------------------------------------------
Fix it, then Ship it!
docs/mesos-containerizer.md
Lines 79 (patched)
<https://reviews.apache.org/r/61675/#comment259281>
s/concern/measure/
- Vinod Kone
On Aug. 15, 2017, 10:50 p.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61675/
> -----------------------------------------------------------
>
> (Updated Aug. 15, 2017, 10:50 p.m.)
>
>
> Review request for mesos, Anand Mazumdar, Gastón Kleiman, Greg Mann, Jie Yu, Qian Zhang, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated doc for the changes of pid namespace sharing.
>
>
> Diffs
> -----
>
> docs/mesos-containerizer.md feaaa556c9646435c6c9d677569962576ebf4c74
>
>
> Diff: https://reviews.apache.org/r/61675/diff/1/
>
>
> Testing
> -------
>
> N/A.
>
>
> Thanks,
>
> Gilbert Song
>
>