You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@calcite.apache.org by "Vladimir Sitnikov (JIRA)" <ji...@apache.org> on 2014/11/28 09:01:13 UTC

[jira] [Created] (CALCITE-485) Avoid recreate/reparse of CalciteConnectionConfigImpl in CalciteConnectionImpl.config()

Vladimir Sitnikov created CALCITE-485:
-----------------------------------------

             Summary: Avoid recreate/reparse of CalciteConnectionConfigImpl in CalciteConnectionImpl.config()
                 Key: CALCITE-485
                 URL: https://issues.apache.org/jira/browse/CALCITE-485
             Project: Calcite
          Issue Type: Bug
    Affects Versions: 1.0.0-incubating
            Reporter: Vladimir Sitnikov
            Assignee: Julian Hyde


{{CalciteConnectionImpl.config}} is used in lots of places, however the resulting {{CalciteConnectionConfig}} is immutable enough, so:
1) No need to recreate new config object every time
2) No need to "parse" the values of input map (e.g. like {{CalciteConnectionProperty.QUOTING.wrap(properties).getEnum(Quoting.class, lex().quoting)}}).

I think we can just pre-parse all the values in the {{CalciteConnectionConfig}} constructor and store the results to fields.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)