[GitHub] [kafka] showuon commented on a change in pull request #9885: MINOR: replace NotLeaderForPartitionException with NotLeaderOrFollowerException

[GitBox <gi...@apache.org>]

showuon commented on a change in pull request #9885:
URL: https://github.com/apache/kafka/pull/9885#discussion_r557040890



##########
File path: core/src/main/scala/kafka/server/KafkaApis.scala
##########
@@ -1068,13 +1068,14 @@ class KafkaApis(val requestChannel: RequestChannel,
             response
           } catch {
             // NOTE: These exceptions are special cases since these error messages are typically transient or the client
-            // would have received a clear exception and there is no value in logging the entire stack trace for the same
+            // would have received a clear exception.
             case e @ (_ : UnknownTopicOrPartitionException |
-                      _ : NotLeaderForPartitionException |
+                      _ : NotLeaderOrFollowerException |
                       _ : UnknownLeaderEpochException |
                       _ : FencedLeaderEpochException |
                       _ : KafkaStorageException |
                       _ : UnsupportedForMessageFormatException) =>
+              // print the stack trace for debugging
               e.printStackTrace()

Review comment:
       I agree. But I'd like to confirm with @mimaison since he added it in #8295. Thanks.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org