You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by "Jason Dillon (JIRA)" <ji...@apache.org> on 2007/11/09 03:33:50 UTC

[jira] Created: (GSHELL-46) Add flag to show exception stacktraces

Add flag to show exception stacktraces
--------------------------------------

                 Key: GSHELL-46
                 URL: https://issues.apache.org/jira/browse/GSHELL-46
             Project: GShell
          Issue Type: New Feature
      Security Level: public (Regular issues)
          Components: CLI
    Affects Versions: 1.0-alpha-1
            Reporter: Jason Dillon
            Priority: Trivial
             Fix For: 1.0-alpha-2


Add a flag to the main CLI to show exception stacktraces (like mvn -e)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (GSHELL-46) Add flag to show exception stacktraces

Posted by "Jason Dillon (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/GSHELL-46?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jason Dillon closed GSHELL-46.
------------------------------

    Resolution: Fixed

Applied... thx Jason :-)

> Add flag to show exception stacktraces
> --------------------------------------
>
>                 Key: GSHELL-46
>                 URL: https://issues.apache.org/jira/browse/GSHELL-46
>             Project: GShell
>          Issue Type: New Feature
>      Security Level: public(Regular issues) 
>          Components: CLI
>    Affects Versions: 1.0-alpha-1
>            Reporter: Jason Dillon
>            Assignee: Jason Dillon
>            Priority: Trivial
>             Fix For: 1.0-alpha-2
>
>         Attachments: GShell-46.patch
>
>
> Add a flag to the main CLI to show exception stacktraces (like mvn -e)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (GSHELL-46) Add flag to show exception stacktraces

Posted by "Jason Dillon (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/GSHELL-46?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12548848 ] 

Jason Dillon commented on GSHELL-46:
------------------------------------

The idea is to show the stack traces w/o increasing any other output.  So, basically use like {{mvn -e}}.

> Add flag to show exception stacktraces
> --------------------------------------
>
>                 Key: GSHELL-46
>                 URL: https://issues.apache.org/jira/browse/GSHELL-46
>             Project: GShell
>          Issue Type: New Feature
>      Security Level: public(Regular issues) 
>          Components: CLI
>    Affects Versions: 1.0-alpha-1
>            Reporter: Jason Dillon
>            Assignee: Jason Warner
>            Priority: Trivial
>             Fix For: 1.0-alpha-2
>
>
> Add a flag to the main CLI to show exception stacktraces (like mvn -e)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (GSHELL-46) Add flag to show exception stacktraces

Posted by "Jason Warner (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/GSHELL-46?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jason Warner reassigned GSHELL-46:
----------------------------------

    Assignee: Jason Warner

> Add flag to show exception stacktraces
> --------------------------------------
>
>                 Key: GSHELL-46
>                 URL: https://issues.apache.org/jira/browse/GSHELL-46
>             Project: GShell
>          Issue Type: New Feature
>      Security Level: public(Regular issues) 
>          Components: CLI
>    Affects Versions: 1.0-alpha-1
>            Reporter: Jason Dillon
>            Assignee: Jason Warner
>            Priority: Trivial
>             Fix For: 1.0-alpha-2
>
>
> Add a flag to the main CLI to show exception stacktraces (like mvn -e)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (GSHELL-46) Add flag to show exception stacktraces

Posted by "Guillaume Nodet (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/GSHELL-46?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12546750 ] 

Guillaume Nodet commented on GSHELL-46:
---------------------------------------

Maybe this could be done via a system property (inside gshell) so that could be controlled dynamically.
   set gshell.show.stacktraces = true
or something like that...

> Add flag to show exception stacktraces
> --------------------------------------
>
>                 Key: GSHELL-46
>                 URL: https://issues.apache.org/jira/browse/GSHELL-46
>             Project: GShell
>          Issue Type: New Feature
>      Security Level: public(Regular issues) 
>          Components: CLI
>    Affects Versions: 1.0-alpha-1
>            Reporter: Jason Dillon
>            Assignee: Jason Warner
>            Priority: Trivial
>             Fix For: 1.0-alpha-2
>
>
> Add a flag to the main CLI to show exception stacktraces (like mvn -e)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (GSHELL-46) Add flag to show exception stacktraces

Posted by "Jason Warner (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/GSHELL-46?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12549896 ] 

Jason Warner commented on GSHELL-46:
------------------------------------

Actually, it works with setting the property within GShell as well.  I just needed to remember that the set command defaults to setting the value as a variable rather than as a property.  When setting the mode to PROPERTY, it works just as it should.

> Add flag to show exception stacktraces
> --------------------------------------
>
>                 Key: GSHELL-46
>                 URL: https://issues.apache.org/jira/browse/GSHELL-46
>             Project: GShell
>          Issue Type: New Feature
>      Security Level: public(Regular issues) 
>          Components: CLI
>    Affects Versions: 1.0-alpha-1
>            Reporter: Jason Dillon
>            Assignee: Jason Warner
>            Priority: Trivial
>             Fix For: 1.0-alpha-2
>
>         Attachments: GShell-46.patch
>
>
> Add a flag to the main CLI to show exception stacktraces (like mvn -e)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (GSHELL-46) Add flag to show exception stacktraces

Posted by "Jason Warner (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/GSHELL-46?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12548525 ] 

Jason Warner commented on GSHELL-46:
------------------------------------

I just type up a whole long thing for this and then lost it when I clicked add and my session had timed out, so I'll be brief.  I found I can get the exception stack traces by setting the verbosity level to "VERBOSE".  I'm not sure if this is what you were looking for or not, even though it seems to accomplish the goal.  My only issue is that the only difference between this and --verbose is --verbose also alters the log level.  

I also looked into setting a system property.  Assuming changing the verbosity is sufficient, it would only be a matter of checking this property at set points and then changing the verbosity accordingly.  I thought this check could be done on ever output, but then realized that output is done through PrintWriters that have already been defined.  Is there a good place to perform this check?  If you don't actually know of a place off hand, let me know and I'll do my own leg work.  I just thought it'd be fun to leverage the knowledge of someone with a ton more GShell experience than myself.

Finally, I like the idea of persistent options loaded from the preferences but think that probably should be covered in a separate jira as it's work effort is outside the scope of this one.  If there isn't one already, I'll open one up myself.

Ok, that wasn't too brief.  My mistake.



> Add flag to show exception stacktraces
> --------------------------------------
>
>                 Key: GSHELL-46
>                 URL: https://issues.apache.org/jira/browse/GSHELL-46
>             Project: GShell
>          Issue Type: New Feature
>      Security Level: public(Regular issues) 
>          Components: CLI
>    Affects Versions: 1.0-alpha-1
>            Reporter: Jason Dillon
>            Assignee: Jason Warner
>            Priority: Trivial
>             Fix For: 1.0-alpha-2
>
>
> Add a flag to the main CLI to show exception stacktraces (like mvn -e)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (GSHELL-46) Add flag to show exception stacktraces

Posted by "Jason Dillon (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/GSHELL-46?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12546896 ] 

Jason Dillon commented on GSHELL-46:
------------------------------------

Sure, could use preferences too, or both...

Though the point of this issue is to add something like the {{mvn -e}} muck to make the GShell cli display full stacks.  and for cases like you might be thinking, of embedding GShell or something, I'd not expect the GShell cli to be used at all, so you can do whatever you like with the exceptions, just catch them.

I would like to get these modal options to read from user prefs for defaults, and then allow the cli to override.  Like some folks might want GShell to always dump stacks (er like me) so I can flip that preference and it will stick.

> Add flag to show exception stacktraces
> --------------------------------------
>
>                 Key: GSHELL-46
>                 URL: https://issues.apache.org/jira/browse/GSHELL-46
>             Project: GShell
>          Issue Type: New Feature
>      Security Level: public(Regular issues) 
>          Components: CLI
>    Affects Versions: 1.0-alpha-1
>            Reporter: Jason Dillon
>            Assignee: Jason Warner
>            Priority: Trivial
>             Fix For: 1.0-alpha-2
>
>
> Add a flag to the main CLI to show exception stacktraces (like mvn -e)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (GSHELL-46) Add flag to show exception stacktraces

Posted by "Jason Dillon (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/GSHELL-46?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jason Dillon reassigned GSHELL-46:
----------------------------------

    Assignee: Jason Dillon  (was: Jason Warner)

> Add flag to show exception stacktraces
> --------------------------------------
>
>                 Key: GSHELL-46
>                 URL: https://issues.apache.org/jira/browse/GSHELL-46
>             Project: GShell
>          Issue Type: New Feature
>      Security Level: public(Regular issues) 
>          Components: CLI
>    Affects Versions: 1.0-alpha-1
>            Reporter: Jason Dillon
>            Assignee: Jason Dillon
>            Priority: Trivial
>             Fix For: 1.0-alpha-2
>
>         Attachments: GShell-46.patch
>
>
> Add a flag to the main CLI to show exception stacktraces (like mvn -e)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (GSHELL-46) Add flag to show exception stacktraces

Posted by "Jason Warner (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/GSHELL-46?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jason Warner updated GSHELL-46:
-------------------------------

    Attachment: GShell-46.patch

Assuming this is what you were looking for, this was a lot easier than I kept making it out to be once I found what I was looking for.  The only issue is, it only works when activated when launching gshell.  I'm still trying to figure out why the system property doesn't get picked up when it's set from within the gshell environment.

Are the system properties being used by DefaultGshell.java and SetCommand.java different?

> Add flag to show exception stacktraces
> --------------------------------------
>
>                 Key: GSHELL-46
>                 URL: https://issues.apache.org/jira/browse/GSHELL-46
>             Project: GShell
>          Issue Type: New Feature
>      Security Level: public(Regular issues) 
>          Components: CLI
>    Affects Versions: 1.0-alpha-1
>            Reporter: Jason Dillon
>            Assignee: Jason Warner
>            Priority: Trivial
>             Fix For: 1.0-alpha-2
>
>         Attachments: GShell-46.patch
>
>
> Add a flag to the main CLI to show exception stacktraces (like mvn -e)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.