You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "samueleresca (via GitHub)" <gi...@apache.org> on 2023/10/01 19:28:15 UTC
[GitHub] [incubator-pekko-samples] samueleresca opened a new pull request, #75: Adding gRPC Kubernetes sample
samueleresca opened a new pull request, #75:
URL: https://github.com/apache/incubator-pekko-samples/pull/75
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-samples] pjfanning commented on a diff in pull request #75: Adding gRPC Kubernetes sample
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #75:
URL: https://github.com/apache/incubator-pekko-samples/pull/75#discussion_r1342187657
##########
pekko-sample-grpc-kubernetes-scala/http-to-grpc/src/main/resources/logback.xml:
##########
@@ -0,0 +1,21 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<configuration>
+
+ <appender name="CONSOLE" class="ch.qos.logback.core.ConsoleAppender">
+ <target>System.out</target>
+ <encoder>
+ <pattern>%date{MM/dd HH:mm:ss} %-5level[%thread] %logger{1} - %m%n%xException</pattern>
+ </encoder>
+ </appender>
+
+ <appender name="ASYNC" class="ch.qos.logback.classic.AsyncAppender">
+ <queueSize>1024</queueSize>
+ <neverBlock>true</neverBlock>
+ <appender-ref ref="CONSOLE" />
+ </appender>
+
+ <root level="INFO">
+ <appender-ref ref="ASYNC"/>
+ </root>
+
+</configuration>
Review Comment:
could you add a new line at end of file?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Adding gRPC Kubernetes sample [incubator-pekko-samples]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #75:
URL: https://github.com/apache/incubator-pekko-samples/pull/75#issuecomment-1743177705
Thanks - merged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Adding gRPC Kubernetes sample [incubator-pekko-samples]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #75:
URL: https://github.com/apache/incubator-pekko-samples/pull/75#discussion_r1342433778
##########
pekko-sample-grpc-kubernetes-scala/build.sbt:
##########
@@ -0,0 +1,49 @@
+name := "pekko-grpc-kubernetes"
+scalaVersion := "2.13.11"
+
+lazy val pekkoVersion = "1.0.1"
+lazy val discoveryVersion = "1.0.0"
+lazy val pekkoHttpVersion = "1.0.0"
+
+lazy val root = (project in file("."))
+ .aggregate(httpToGrpc, grpcService)
+
+// HTTP service that calls out to a gRPC back end
+lazy val httpToGrpc = (project in file("http-to-grpc"))
+ .enablePlugins(PekkoGrpcPlugin, DockerPlugin, JavaAppPackaging)
+ .settings(
+ libraryDependencies ++= Seq(
+ "org.apache.pekko" %% "pekko-actor-typed" % pekkoVersion,
+ "org.apache.pekko" %% "pekko-slf4j" % pekkoVersion,
+ "org.apache.pekko" %% "pekko-discovery" % pekkoVersion,
+ "org.apache.pekko" %% "pekko-stream" % pekkoVersion,
+
+ "org.apache.pekko" %% "pekko-parsing" % pekkoHttpVersion,
+ "org.apache.pekko" %% "pekko-http-core" % pekkoHttpVersion,
+ "org.apache.pekko" %% "pekko-http" % pekkoHttpVersion,
+ "org.apache.pekko" %% "pekko-http-spray-json" % pekkoHttpVersion,
+
+ "org.apache.pekko" %% "pekko-discovery-kubernetes-api" % discoveryVersion,
+
+ "ch.qos.logback" % "logback-classic" % "1.4.11"
+ ),
+ dockerExposedPorts := Seq(8080),
+ )
+
+// gRPC back end that echoes back messages
+lazy val grpcService = (project in file("grpc-service"))
+ .enablePlugins(PekkoGrpcPlugin, DockerPlugin, JavaAppPackaging)
+ .settings(
+ dockerExposedPorts := Seq(8080),
+ libraryDependencies ++= Seq(
+ "org.apache.pekko" %% "pekko-actor" % pekkoVersion,
+ "org.apache.pekko" %% "pekko-actor-typed" % pekkoVersion,
+ "org.apache.pekko" %% "pekko-slf4j" % pekkoVersion,
+ "org.apache.pekko" %% "pekko-stream" % pekkoVersion,
+ "org.apache.pekko" %% "pekko-discovery" % pekkoVersion,
+
+ "org.apache.pekko" %% "pekko-http" % pekkoHttpVersion,
+
+ "ch.qos.logback" % "logback-classic" % "1.4.11"
Review Comment:
could we stick with logback 1.2.x - just a new version of 1.2.x? 1.4 requires Java 11 or something like that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-samples] pjfanning commented on a diff in pull request #75: Adding gRPC Kubernetes sample
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #75:
URL: https://github.com/apache/incubator-pekko-samples/pull/75#discussion_r1342187588
##########
pekko-sample-grpc-kubernetes-scala/build.sbt:
##########
@@ -0,0 +1,50 @@
+name := "pekko-grpc-kubernetes"
+scalaVersion := "2.13.3"
+
+lazy val pekkoVersion = "1.0.1"
+lazy val discoveryVersion = "1.0.0"
+lazy val pekkoHttpVersion = "1.0.0"
+
+lazy val root = (project in file("."))
+ .aggregate(httpToGrpc, grpcService)
+
+// HTTP service that calls out to a gRPC back end
+lazy val httpToGrpc = (project in file("http-to-grpc"))
+ .enablePlugins(PekkoGrpcPlugin, DockerPlugin, JavaAppPackaging)
+ .settings(
+ libraryDependencies ++= Seq(
+ "org.apache.pekko" %% "pekko-actor-typed" % pekkoVersion,
+ "org.apache.pekko" %% "pekko-slf4j" % pekkoVersion,
+ "org.apache.pekko" %% "pekko-discovery" % pekkoVersion,
+ "org.apache.pekko" %% "pekko-stream" % pekkoVersion,
+
+ "org.apache.pekko" %% "pekko-parsing" % pekkoHttpVersion,
+ "org.apache.pekko" %% "pekko-http-core" % pekkoHttpVersion,
+ "org.apache.pekko" %% "pekko-http" % pekkoHttpVersion,
+ "org.apache.pekko" %% "pekko-http-spray-json" % pekkoHttpVersion,
+
+ "org.apache.pekko" %% "pekko-discovery-kubernetes-api" % discoveryVersion,
+
+ "ch.qos.logback" % "logback-classic" % "1.2.3"
Review Comment:
could you use 1.2.10 or something newer?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Adding gRPC Kubernetes sample [incubator-pekko-samples]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning merged PR #75:
URL: https://github.com/apache/incubator-pekko-samples/pull/75
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org