You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@jena.apache.org by GitBox <gi...@apache.org> on 2021/11/28 22:45:30 UTC

[GitHub] [jena] kinow edited a comment on pull request #1115: [JENA-1911] vue

kinow edited a comment on pull request #1115:
URL: https://github.com/apache/jena/pull/1115#issuecomment-981165872


   On the performance, the framerate is about 60 fps, then if I remove the code that loads the query editors (yasqe) then it keeps the framerate about the same.
   
   ![Screenshot from 2021-11-28 22-33-53](https://user-images.githubusercontent.com/304786/143789024-e93de3c7-5da0-4467-9866-76a93bced775.png)
   
   But leaving just this:
   
   ```js
         vm.yasqe = new Yasqe(
           document.getElementById('yasqe'),
           {
             showQueryButton: true,
             resizeable: false,
             requestConfig: {
               endpoint: `/${vm.datasetName}/sparql`
             }
           }
         )
   ```
   
   It drops from 60 to under 10, since the main thread is busy creating that object, and the impression that the UI is really slow when opening the query editor.
   
   To improve user experience a little, I have deferred the YASR/YASQE DOM operations, and added a spinner/loading indication in the UI. Also fixed a bug where I used the wrong prop in the `TableListing` component (re-used whenever we render a table, like listing datasets), so now the `TableListing` components should display a spinner/loading symbol too.
   
   The fps is still dropping, but not much I can do I think, except for trying to understand what can be improved in YASR/YASQE. These libraries manipulate the DOM, creating components, attaching to the DOM, resizing it, adding listeners, etc.
   
   ![Screenshot from 2021-11-29 11-26-28](https://user-images.githubusercontent.com/304786/143789111-4b4a7237-a7bc-4320-85e3-a20529c731a9.png)
   
   (In the image above the fps drop is still present, but shouldn't bother users as much as before).
   
   @afs one item fixed I think :+1: 
   
   ![GIFrecord_2021-11-29_114142](https://user-images.githubusercontent.com/304786/143789241-b6e2b58c-7d3d-43d3-8fba-29d1eb86d27b.gif)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org