[jira] [Closed] (TAP5-2423) Wrong component id check for inherited pages/components

["Howard M. Lewis Ship (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/TAP5-2423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Howard M. Lewis Ship closed TAP5-2423.
--------------------------------------
    Resolution: Invalid

As Joachen pointed out, templates are not overridden, they entirely replace. (well, unless you use the extensible template support, which you are not doing). This alone is a great reason to avoid component inheritance wherever possible.

> Wrong component id check for inherited pages/components
> -------------------------------------------------------
>
>                 Key: TAP5-2423
>                 URL: https://issues.apache.org/jira/browse/TAP5-2423
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.4
>            Reporter: Nourredine K.
>              Labels: easytest
>         Attachments: sample.zip
>
>
> When page B inherits page A (providing its own template) and A implements some event handler methods on some components, displaying page B throws an TapestryException that claims page B does not contain those components in its template.
> I think the pb occurs in the [ComponentIdValidator#validate(ComponentResources)|https://git-wip-us.apache.org/repos/asf?p=tapestry-5.git;a=blob;f=tapestry-core/src/main/java/org/apache/tapestry5/internal/transform/OnEventWorker.java;h=c640158666493ebc669ff561de25b62a9236f54a;hb=HEAD#l91] method because, we only check in the current ComponentResource and never in its parents if they exist.
> Remarks : 
> - Occurs with tapestry 5.4-beta-22
> - Symbol tapestry.compatibility.unknown-component-id-check-enabled can't be used (no more used in 5.4-beta-22)
> Regards,
> Nourredine.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)