[GitHub] [ignite-3] zstan commented on a diff in pull request #1873: IGNITE-18875 : Sql. Drop AbstractPlannerTest.TestTable.

["zstan (via GitHub)" <gi...@apache.org>]

zstan commented on code in PR #1873:
URL: https://github.com/apache/ignite-3/pull/1873#discussion_r1155564707


##########
modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/framework/TestTable.java:
##########
@@ -67,11 +68,13 @@ public class TestTable implements IgniteTable {
     private final UUID id = UUID.randomUUID();
     private final Map<String, IgniteIndex> indexes = new HashMap<>();
 
-    private final String name;
-    private final double rowCnt;
-    private final ColocationGroup colocationGroup;
-    private final TableDescriptor descriptor;
-    private final Map<String, DataProvider<?>> dataProviders;
+    private String name;
+    private double rowCnt;
+    private ColocationGroup colocationGroup;
+    private RelDataType type;
+    private TableDescriptor descriptor;
+    private SchemaDescriptor schemaDesc;

Review Comment:
   this field is never used



##########
modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/framework/TestTable.java:
##########
@@ -67,11 +68,13 @@ public class TestTable implements IgniteTable {
     private final UUID id = UUID.randomUUID();
     private final Map<String, IgniteIndex> indexes = new HashMap<>();
 
-    private final String name;
-    private final double rowCnt;
-    private final ColocationGroup colocationGroup;
-    private final TableDescriptor descriptor;
-    private final Map<String, DataProvider<?>> dataProviders;
+    private String name;
+    private double rowCnt;
+    private ColocationGroup colocationGroup;
+    private RelDataType type;

Review Comment:
   this field is never used



##########
modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/exec/rel/IndexScanNodeExecutionTest.java:
##########
@@ -438,7 +430,7 @@ private void validateIndexScan(
                 ectx,
                 ectx.rowHandler().factory(ectx.getTypeFactory(), rowType),
                 index,
-                new TestTable(rowType, schemaDescriptor),
+                new org.apache.ignite.internal.sql.engine.framework.TestTable(rowType, schemaDescriptor),

Review Comment:
   previous TestTable distribution was: broadcast, current is undefined, all tests are failed here.
   also we not use class with package names, import correctly.
   Seems there are numerous problems in changed classes, plz check and run TC



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org