You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@trafficserver.apache.org by "maskit (via GitHub)" <gi...@apache.org> on 2025/01/07 18:18:32 UTC

[PR] Do not allow extra CRs in chunks (#11936) [trafficserver]

maskit opened a new pull request, #11942:
URL: https://github.com/apache/trafficserver/pull/11942

   * Do not allow extra CRs in chunks
   
   * Renumber test uuid
   
   * Add test cases and fix an oversight
   
   * Use prefix increment
   
   (cherry picked from commit f5f2256c00abbfd02c22fbae3937da1c7bd8a34f)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Do not allow extra CRs in chunks (#11936) [trafficserver]

Posted by "maskit (via GitHub)" <gi...@apache.org>.

maskit commented on PR #11942:
URL: https://github.com/apache/trafficserver/pull/11942#issuecomment-2591191047

   The keyword, "abc", should not appear on the origin server log, because requests that contains the keyword should be blocked by ATS, and the test origin server does not send the keyword. But the keyword accidentally appears because the response data which I added for testing response parser has "abc" where it should be "def".
   
   https://github.com/apache/trafficserver/blob/d9195ac85c4958355e5202006d2495989b959652/tests/gold_tests/chunked_encoding/bad_chunked_encoding.test.py#L184-L186
   
   The test passes if I fix the test case (I confirmed this locally), but that makes me wonder why the tests passed on master.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Do not allow extra CRs in chunks (#11936) [trafficserver]

Posted by "maskit (via GitHub)" <gi...@apache.org>.

maskit commented on PR #11942:
URL: https://github.com/apache/trafficserver/pull/11942#issuecomment-2591312255

   [approve ci autest 3]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Do not allow extra CRs in chunks (#11936) [trafficserver]

Posted by "maskit (via GitHub)" <gi...@apache.org>.

maskit merged PR #11942:
URL: https://github.com/apache/trafficserver/pull/11942


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Do not allow extra CRs in chunks (#11936) [trafficserver]

Posted by "maskit (via GitHub)" <gi...@apache.org>.

maskit commented on PR #11942:
URL: https://github.com/apache/trafficserver/pull/11942#issuecomment-2591229149

   The test on master is slightly different. It checks "abcwxyz" instead of "abc". Thus, "abc" was not caught.
   https://github.com/apache/trafficserver/pull/11843


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Do not allow extra CRs in chunks (#11936) [trafficserver]

Posted by "bneradt (via GitHub)" <gi...@apache.org>.

bneradt commented on PR #11942:
URL: https://github.com/apache/trafficserver/pull/11942#issuecomment-2587789113

   [approve ci autest 0]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Do not allow extra CRs in chunks (#11936) [trafficserver]

Posted by "maskit (via GitHub)" <gi...@apache.org>.

maskit commented on PR #11942:
URL: https://github.com/apache/trafficserver/pull/11942#issuecomment-2591311834

   tls_verify4 failed


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org