You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/11/08 03:16:27 UTC
[GitHub] [spark] itholic opened a new pull request, #38548: [SPARK-40663][SQL][FOLLOWUP] `SparkIllegalArgumentException` should accept `cause`
itholic opened a new pull request, #38548:
URL: https://github.com/apache/spark/pull/38548
### What changes were proposed in this pull request?
This PR proposes to enable `SparkIllegalArgumentException` accept `cause` parameter.
### Why are the changes needed?
The original error message generated by `IllegalArgumentException` can accept the `cause` parameter, but `SparkIllegalArgumentException` cannot, so there it some regression was made that we should enable back.
e.g. https://github.com/apache/spark/pull/38123/files#r1014645753
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
```
./build/sbt "sql/testOnly org.apache.spark.sql.SQLQueryTestSuite*"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] itholic commented on pull request #38548: [SPARK-40663][SQL][FOLLOWUP] `SparkIllegalArgumentException` should accept `cause`
Posted by GitBox <gi...@apache.org>.
itholic commented on PR #38548:
URL: https://github.com/apache/spark/pull/38548#issuecomment-1306569142
cc @MaxGekk for address the https://github.com/apache/spark/pull/38104/files#r1014645923
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk closed pull request #38548: [SPARK-40663][SQL][FOLLOWUP] `SparkIllegalArgumentException` should accept `cause`
Posted by GitBox <gi...@apache.org>.
MaxGekk closed pull request #38548: [SPARK-40663][SQL][FOLLOWUP] `SparkIllegalArgumentException` should accept `cause`
URL: https://github.com/apache/spark/pull/38548
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org