[GitHub] [incubator-uniffle] jerqi commented on a diff in pull request #1023: Fix the flaky test GrpcServerTest

["jerqi (via GitHub)" <gi...@apache.org>]

jerqi commented on code in PR #1023:
URL: https://github.com/apache/incubator-uniffle/pull/1023#discussion_r1267524768


##########
common/src/main/java/org/apache/uniffle/common/rpc/GrpcServer.java:
##########
@@ -49,6 +49,7 @@ public class GrpcServer implements ServerInterface {
 
   private static final Logger LOG = LoggerFactory.getLogger(GrpcServer.class);
 
+  public static int testVarCount = 0;

Review Comment:
   Could we use private here and add a getter for this variable? Could we use `volatitle` here? Because this variable is used for multi threads?  Could we use `boolean` type here? Should we use `static` here? Maybe we should give this variable a better name like `hasExecuted`? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org