You are viewing a plain text version of this content. The canonical link for it is here.
Posted to c-dev@axis.apache.org by "Senaka Fernando (JIRA)" <ji...@apache.org> on 2008/02/03 16:06:10 UTC

[jira] Created: (AXIS2C-959) Guththila parser can't handle comments.

Guththila parser can't handle comments.
---------------------------------------

                 Key: AXIS2C-959
                 URL: https://issues.apache.org/jira/browse/AXIS2C-959
             Project: Axis2-C
          Issue Type: Bug
          Components: guththila
         Environment: Windows XP SP2, libcurl
            Reporter: Senaka Fernando
             Fix For: 1.3.0


It seems that Guththila can't properly print comments appreaing in XML. It simply adds an additional '-->' at the end unlike it's counterpart libxml2.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: axis-c-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-c-dev-help@ws.apache.org


[jira] Commented: (AXIS2C-959) Guththila parser can't handle comments.

Posted by "Bill Mitchell (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/AXIS2C-959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12567615#action_12567615 ] 

Bill Mitchell commented on AXIS2C-959:
--------------------------------------

Senaka, I thought your changes looked right, but when I stepped through them on a SOAP message containing a comment, I found the calculated length of the comment was one character too short, so the comment value was getting truncated.  It seems the token open/token close logic in guththila expects that the character following the token has already been scanned, here the leading hyphen.  

I checked in a fix to adjust the next pointer back by 2 instead of 3, in rev 620476.  

Regards,
Bill

> Guththila parser can't handle comments.
> ---------------------------------------
>
>                 Key: AXIS2C-959
>                 URL: https://issues.apache.org/jira/browse/AXIS2C-959
>             Project: Axis2-C
>          Issue Type: Bug
>          Components: guththila
>         Environment: Windows XP SP2, libcurl
>            Reporter: Senaka Fernando
>            Assignee: Senaka Fernando
>             Fix For: 1.3.0
>
>         Attachments: diff.txt
>
>
> It seems that Guththila can't properly print comments appreaing in XML. It simply adds an additional '-->' at the end unlike it's counterpart libxml2.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: axis-c-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-c-dev-help@ws.apache.org


[jira] Resolved: (AXIS2C-959) Guththila parser can't handle comments.

Posted by "Senaka Fernando (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AXIS2C-959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Senaka Fernando resolved AXIS2C-959.
------------------------------------

    Resolution: Fixed
      Assignee: Senaka Fernando

Committed changes to head as there were no comments.

Regards,
Senaka

> Guththila parser can't handle comments.
> ---------------------------------------
>
>                 Key: AXIS2C-959
>                 URL: https://issues.apache.org/jira/browse/AXIS2C-959
>             Project: Axis2-C
>          Issue Type: Bug
>          Components: guththila
>         Environment: Windows XP SP2, libcurl
>            Reporter: Senaka Fernando
>            Assignee: Senaka Fernando
>             Fix For: 1.3.0
>
>         Attachments: diff.txt
>
>
> It seems that Guththila can't properly print comments appreaing in XML. It simply adds an additional '-->' at the end unlike it's counterpart libxml2.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: axis-c-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-c-dev-help@ws.apache.org


[jira] Commented: (AXIS2C-959) Guththila parser can't handle comments.

Posted by "Senaka Fernando (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/AXIS2C-959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12567644#action_12567644 ] 

Senaka Fernando commented on AXIS2C-959:
----------------------------------------

Hi Bill,

Thanks, for the fix. Sorry 4 not noticing that. :)...

Regards,
Senaka

> Guththila parser can't handle comments.
> ---------------------------------------
>
>                 Key: AXIS2C-959
>                 URL: https://issues.apache.org/jira/browse/AXIS2C-959
>             Project: Axis2-C
>          Issue Type: Bug
>          Components: guththila
>         Environment: Windows XP SP2, libcurl
>            Reporter: Senaka Fernando
>            Assignee: Senaka Fernando
>             Fix For: 1.3.0
>
>         Attachments: diff.txt
>
>
> It seems that Guththila can't properly print comments appreaing in XML. It simply adds an additional '-->' at the end unlike it's counterpart libxml2.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: axis-c-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-c-dev-help@ws.apache.org


[jira] Updated: (AXIS2C-959) Guththila parser can't handle comments.

Posted by "Senaka Fernando (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AXIS2C-959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Senaka Fernando updated AXIS2C-959:
-----------------------------------

    Attachment: diff.txt

Hi all,

I have attached a patch (diff.txt) to solve this issue. However, I'm not quite certain whether this is "THE SOLUTION" :)... Pls test this before committing.

Thanks,
Senaka

> Guththila parser can't handle comments.
> ---------------------------------------
>
>                 Key: AXIS2C-959
>                 URL: https://issues.apache.org/jira/browse/AXIS2C-959
>             Project: Axis2-C
>          Issue Type: Bug
>          Components: guththila
>         Environment: Windows XP SP2, libcurl
>            Reporter: Senaka Fernando
>             Fix For: 1.3.0
>
>         Attachments: diff.txt
>
>
> It seems that Guththila can't properly print comments appreaing in XML. It simply adds an additional '-->' at the end unlike it's counterpart libxml2.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: axis-c-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-c-dev-help@ws.apache.org