You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "redlsz (via GitHub)" <gi...@apache.org> on 2025/01/05 13:07:44 UTC
[PR] [ISSUE #9106] Fix revive backoff retry not effective in Pop Consumption based on rocksdb [rocketmq]
redlsz opened a new pull request, #9107:
URL: https://github.com/apache/rocketmq/pull/9107
<!-- Please make sure the target branch is right. In most case, the target branch should be `develop`. -->
### Which Issue(s) This PR Fixes
<!-- Please ensure that the related issue has already been created, and [link this pull request to that issue using keywords](<https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword>) to ensure automatic closure. -->
Fixes #9106
### Brief Description
<!-- Write a brief description for your pull request to help the maintainer understand the reasons behind your changes. -->
When revive is needed to be retried, the original PopConsumerRecord object and the retry one should be independent of each other.
### How Did You Test This Change?
<!-- In order to ensure the code quality of Apache RocketMQ, we expect every pull request to have undergone thorough testing. -->
Unit Test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #9106] Fix revive backoff retry not effective in Pop Consumption based on rocksdb [rocketmq]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins merged PR #9107:
URL: https://github.com/apache/rocketmq/pull/9107
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #9106] Fix revive backoff retry not effective in Pop Consumption based on rocksdb [rocketmq]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #9107:
URL: https://github.com/apache/rocketmq/pull/9107#issuecomment-2571629414
## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/9107?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 47.97%. Comparing base [(`a3afb05`)](https://app.codecov.io/gh/apache/rocketmq/commit/a3afb05cb32f6c63fe8af5aef7a86ad1a4d5797f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`6c37a81`)](https://app.codecov.io/gh/apache/rocketmq/commit/6c37a8146f161ecb3b6e7fd9b6fd33cf55796db8?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## develop #9107 +/- ##
=============================================
- Coverage 48.04% 47.97% -0.08%
+ Complexity 12064 12039 -25
=============================================
Files 1320 1320
Lines 92824 92827 +3
Branches 11897 11897
=============================================
- Hits 44596 44530 -66
- Misses 42734 42782 +48
- Partials 5494 5515 +21
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/rocketmq/pull/9107?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org