You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/02/17 22:06:25 UTC

[GitHub] [superset] AAfghahi opened a new pull request #13190: feature: Added Rows Returned 

AAfghahi opened a new pull request #13190:
URL: https://github.com/apache/superset/pull/13190


   ### SUMMARY
   SQL Lab shows how many rows have been returned. 
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   ![Screen Shot 2021-02-17 at 5 01 01 PM](https://user-images.githubusercontent.com/48933336/108273909-35d71380-7142-11eb-9856-6546b4042c0d.png)
   ![Screen Shot 2021-02-17 at 5 01 16 PM](https://user-images.githubusercontent.com/48933336/108273916-38396d80-7142-11eb-9dcb-d2b9cae3064f.png)
   ![Screen Shot 2021-02-17 at 5 01 35 PM](https://user-images.githubusercontent.com/48933336/108273926-3b345e00-7142-11eb-911a-e5f332146b7d.png)
   
   These show if you have no Limit, if you have a Limit, or if your results are less than the max limit. 
   
   ### TEST PLAN
   <!--- What steps should be taken to verify the changes -->
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue: https://github.com/apache/superset/issues/12436
   - [ X] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov-io edited a comment on pull request #13190: feat: Added Rows Returned

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13190:
URL: https://github.com/apache/superset/pull/13190#issuecomment-782353235


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13190?src=pr&el=h1) Report
   > Merging [#13190](https://codecov.io/gh/apache/superset/pull/13190?src=pr&el=desc) (eb8a3cc) into [master](https://codecov.io/gh/apache/superset/commit/2ce79823dfad61bce6196fcacd56a844f44818c0?el=desc) (2ce7982) will **increase** coverage by `19.82%`.
   > The diff coverage is `61.95%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13190/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13190?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           master   #13190       +/-   ##
   ===========================================
   + Coverage   53.06%   72.88%   +19.82%     
   ===========================================
     Files         489      555       +66     
     Lines       17314    20541     +3227     
     Branches     4482     5376      +894     
   ===========================================
   + Hits         9187    14972     +5785     
   + Misses       8127     5441     -2686     
   - Partials        0      128      +128     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `58.45% <67.49%> (+5.38%)` | :arrow_up: |
   | javascript | `62.13% <46.77%> (?)` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13190?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...end/src/SqlLab/components/RunQueryActionButton.tsx](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1J1blF1ZXJ5QWN0aW9uQnV0dG9uLnRzeA==) | `64.28% <ø> (+11.50%)` | :arrow_up: |
   | [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `56.13% <ø> (+1.67%)` | :arrow_up: |
   | [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `100.00% <ø> (ø)` | |
   | [superset-frontend/src/chart/ChartRenderer.jsx](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0UmVuZGVyZXIuanN4) | `77.02% <0.00%> (+0.31%)` | :arrow_up: |
   | [...perset-frontend/src/common/components/Dropdown.tsx](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0Ryb3Bkb3duLnRzeA==) | `54.76% <ø> (+4.76%)` | :arrow_up: |
   | [.../src/common/components/Tooltip/Tooltip.stories.tsx](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL1Rvb2x0aXAvVG9vbHRpcC5zdG9yaWVzLnRzeA==) | `0.00% <0.00%> (ø)` | |
   | [...t-frontend/src/common/components/Tooltip/index.tsx](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL1Rvb2x0aXAvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
   | [...perset-frontend/src/components/AlteredSliceTag.jsx](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnLmpzeA==) | `98.66% <ø> (+6.66%)` | :arrow_up: |
   | [superset-frontend/src/components/CachedLabel.jsx](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2FjaGVkTGFiZWwuanN4) | `42.10% <ø> (ø)` | |
   | [...perset-frontend/src/components/CopyToClipboard.jsx](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ29weVRvQ2xpcGJvYXJkLmpzeA==) | `60.00% <0.00%> (+2.85%)` | :arrow_up: |
   | ... and [532 more](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13190?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13190?src=pr&el=footer). Last update [1e17ef3...a9e293d](https://codecov.io/gh/apache/superset/pull/13190?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] eschutho commented on a change in pull request #13190: feat: Added Rows Returned

Posted by GitBox <gi...@apache.org>.
eschutho commented on a change in pull request #13190:
URL: https://github.com/apache/superset/pull/13190#discussion_r578000340



##########
File path: superset-frontend/src/SqlLab/components/ResultSet.tsx
##########
@@ -476,6 +476,18 @@ export default class ResultSet extends React.PureComponent<
     return <div className="noControls" />;
   }
 
+  rowsReturned() {
+    return (
+      <div className="ReturnedRows">
+        {this.state.data && this.state.data.length >= 0 && (
+          <span>
+            {t(`%s rows returned`, this.props.query.results.data.length)}

Review comment:
       it feels like this length should be referencing the same length as above?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] AAfghahi commented on a change in pull request #13190: feat: Added Rows Returned

Posted by GitBox <gi...@apache.org>.
AAfghahi commented on a change in pull request #13190:
URL: https://github.com/apache/superset/pull/13190#discussion_r581250461



##########
File path: superset-frontend/src/SqlLab/components/ResultSet.tsx
##########
@@ -100,6 +100,22 @@ const MonospaceDiv = styled.div`
   white-space: pre-wrap;
 `;
 
+const ReturnedRows = styled.div`
+  margin-top: 48px;
+  margin-bottom: -32px;

Review comment:
       Looks like: 
   ![Screen Shot 2021-02-23 at 12 22 58 PM](https://user-images.githubusercontent.com/48933336/108884558-bbd8db80-75d4-11eb-97bd-89911abe79ea.png)
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov-io edited a comment on pull request #13190: feat: Added Rows Returned

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13190:
URL: https://github.com/apache/superset/pull/13190#issuecomment-782353235


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13190?src=pr&el=h1) Report
   > Merging [#13190](https://codecov.io/gh/apache/superset/pull/13190?src=pr&el=desc) (e599a9c) into [master](https://codecov.io/gh/apache/superset/commit/2ce79823dfad61bce6196fcacd56a844f44818c0?el=desc) (2ce7982) will **increase** coverage by `5.38%`.
   > The diff coverage is `67.28%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13190/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13190?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13190      +/-   ##
   ==========================================
   + Coverage   53.06%   58.44%   +5.38%     
   ==========================================
     Files         489      468      -21     
     Lines       17314    15945    -1369     
     Branches     4482     4110     -372     
   ==========================================
   + Hits         9187     9319     +132     
   + Misses       8127     6626    -1501     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `58.44% <67.28%> (+5.38%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13190?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...erset-frontend/src/SqlLab/components/ResultSet.tsx](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1Jlc3VsdFNldC50c3g=) | `4.00% <0.00%> (-0.26%)` | :arrow_down: |
   | [...end/src/SqlLab/components/RunQueryActionButton.tsx](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1J1blF1ZXJ5QWN0aW9uQnV0dG9uLnRzeA==) | `52.77% <ø> (ø)` | |
   | [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `54.28% <ø> (-0.18%)` | :arrow_down: |
   | [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `100.00% <ø> (ø)` | |
   | [superset-frontend/src/chart/ChartRenderer.jsx](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0UmVuZGVyZXIuanN4) | `75.67% <0.00%> (-1.04%)` | :arrow_down: |
   | [...perset-frontend/src/common/components/Dropdown.tsx](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0Ryb3Bkb3duLnRzeA==) | `50.00% <ø> (ø)` | |
   | [...t-frontend/src/common/components/Tooltip/index.tsx](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL1Rvb2x0aXAvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
   | [...perset-frontend/src/components/AlteredSliceTag.jsx](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnLmpzeA==) | `92.00% <ø> (ø)` | |
   | [superset-frontend/src/components/CachedLabel.jsx](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2FjaGVkTGFiZWwuanN4) | `42.10% <ø> (ø)` | |
   | [...ontend/src/components/CertifiedIconWithTooltip.tsx](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2VydGlmaWVkSWNvbldpdGhUb29sdGlwLnRzeA==) | `0.00% <ø> (ø)` | |
   | ... and [159 more](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13190?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13190?src=pr&el=footer). Last update [1e17ef3...f995d78](https://codecov.io/gh/apache/superset/pull/13190?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] eschutho commented on a change in pull request #13190: feat: Added Rows Returned

Posted by GitBox <gi...@apache.org>.
eschutho commented on a change in pull request #13190:
URL: https://github.com/apache/superset/pull/13190#discussion_r584023836



##########
File path: superset-frontend/src/SqlLab/components/ResultSet.tsx
##########
@@ -481,6 +495,28 @@ export default class ResultSet extends React.PureComponent<
     return <div className="noControls" />;
   }
 
+  renderRowsReturned() {
+    const { results, rows } = this.props.query;

Review comment:
       will `this.props.query` always have a value?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov-io edited a comment on pull request #13190: feat: Added Rows Returned

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13190:
URL: https://github.com/apache/superset/pull/13190#issuecomment-782353235


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13190?src=pr&el=h1) Report
   > Merging [#13190](https://codecov.io/gh/apache/superset/pull/13190?src=pr&el=desc) (ff73170) into [master](https://codecov.io/gh/apache/superset/commit/892eef1af6a5e61763a8f26f6d2396ff9bda8d11?el=desc) (892eef1) will **decrease** coverage by `4.35%`.
   > The diff coverage is `71.42%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13190/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13190?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13190      +/-   ##
   ==========================================
   - Coverage   77.05%   72.70%   -4.36%     
   ==========================================
     Files         897      596     -301     
     Lines       45710    21270   -24440     
     Branches     5497     5500       +3     
   ==========================================
   - Hits        35224    15464   -19760     
   + Misses      10362     5682    -4680     
     Partials      124      124              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `57.55% <7.69%> (-0.04%)` | :arrow_down: |
   | hive | `?` | |
   | javascript | `62.50% <71.42%> (+<0.01%)` | :arrow_up: |
   | mysql | `?` | |
   | postgres | `?` | |
   | presto | `?` | |
   | python | `?` | |
   | sqlite | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13190?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...erset-frontend/src/SqlLab/components/SouthPane.jsx](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NvdXRoUGFuZS5qc3g=) | `82.05% <ø> (ø)` | |
   | [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `55.86% <ø> (-0.15%)` | :arrow_down: |
   | [...erset-frontend/src/SqlLab/components/ResultSet.tsx](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1Jlc3VsdFNldC50c3g=) | `68.51% <69.23%> (+0.04%)` | :arrow_up: |
   | [...src/components/FilterableTable/FilterableTable.tsx](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRmlsdGVyYWJsZVRhYmxlL0ZpbHRlcmFibGVUYWJsZS50c3g=) | `82.26% <100.00%> (ø)` | |
   | [superset/tasks/thumbnails.py](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvdGh1bWJuYWlscy5weQ==) | | |
   | [superset/examples/tabbed\_dashboard.py](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvdGFiYmVkX2Rhc2hib2FyZC5weQ==) | | |
   | [superset/models/alerts.py](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2FsZXJ0cy5weQ==) | | |
   | [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | | |
   | [superset/queries/schemas.py](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zY2hlbWFzLnB5) | | |
   | [superset/commands/export.py](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvZXhwb3J0LnB5) | | |
   | ... and [295 more](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13190?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13190?src=pr&el=footer). Last update [892eef1...e5ed831](https://codecov.io/gh/apache/superset/pull/13190?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] eschutho commented on a change in pull request #13190: feat: Added Rows Returned

Posted by GitBox <gi...@apache.org>.
eschutho commented on a change in pull request #13190:
URL: https://github.com/apache/superset/pull/13190#discussion_r584025741



##########
File path: superset-frontend/src/SqlLab/components/ResultSet.tsx
##########
@@ -100,6 +100,22 @@ const MonospaceDiv = styled.div`
   white-space: pre-wrap;
 `;
 
+const ReturnedRows = styled.div`
+  margin-top: 48px;
+  margin-bottom: -32px;

Review comment:
       yeah, that looks great! also, correct on the negative margins. :)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov-io edited a comment on pull request #13190: feat: Added Rows Returned

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13190:
URL: https://github.com/apache/superset/pull/13190#issuecomment-782353235


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13190?src=pr&el=h1) Report
   > Merging [#13190](https://codecov.io/gh/apache/superset/pull/13190?src=pr&el=desc) (8dc1ffe) into [master](https://codecov.io/gh/apache/superset/commit/892eef1af6a5e61763a8f26f6d2396ff9bda8d11?el=desc) (892eef1) will **decrease** coverage by `4.12%`.
   > The diff coverage is `77.03%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13190/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13190?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13190      +/-   ##
   ==========================================
   - Coverage   77.05%   72.93%   -4.13%     
   ==========================================
     Files         897      597     -300     
     Lines       45710    21275   -24435     
     Branches     5497     5498       +1     
   ==========================================
   - Hits        35224    15517   -19707     
   + Misses      10362     5631    -4731     
   - Partials      124      127       +3     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `57.60% <71.69%> (+0.01%)` | :arrow_up: |
   | hive | `?` | |
   | javascript | `62.76% <55.55%> (+0.26%)` | :arrow_up: |
   | mysql | `?` | |
   | postgres | `?` | |
   | presto | `?` | |
   | python | `?` | |
   | sqlite | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13190?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...erset-frontend/src/SqlLab/components/SouthPane.jsx](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NvdXRoUGFuZS5qc3g=) | `82.05% <ø> (ø)` | |
   | [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `55.86% <ø> (-0.15%)` | :arrow_down: |
   | [...rset-frontend/src/components/ButtonGroup/index.tsx](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQnV0dG9uR3JvdXAvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
   | [...et-frontend/src/components/ErrorBoundary/index.jsx](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JCb3VuZGFyeS9pbmRleC5qc3g=) | `95.45% <ø> (ø)` | |
   | [...perset-frontend/src/components/FormLabel/index.tsx](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRm9ybUxhYmVsL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
   | [...-frontend/src/components/Select/Select.stories.tsx](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L1NlbGVjdC5zdG9yaWVzLnRzeA==) | `0.00% <0.00%> (ø)` | |
   | [superset-frontend/src/components/Select/Select.tsx](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L1NlbGVjdC50c3g=) | `90.81% <ø> (ø)` | |
   | [superset-frontend/src/components/Select/styles.tsx](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L3N0eWxlcy50c3g=) | `86.30% <ø> (ø)` | |
   | [...et-frontend/src/components/Timer/Timer.stories.tsx](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGltZXIvVGltZXIuc3Rvcmllcy50c3g=) | `0.00% <0.00%> (ø)` | |
   | [superset-frontend/src/components/Timer/index.tsx](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGltZXIvaW5kZXgudHN4) | `95.83% <ø> (ø)` | |
   | ... and [332 more](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13190?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13190?src=pr&el=footer). Last update [892eef1...ab89d5f](https://codecov.io/gh/apache/superset/pull/13190?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov-io edited a comment on pull request #13190: feat: Added Rows Returned

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13190:
URL: https://github.com/apache/superset/pull/13190#issuecomment-782353235






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] AAfghahi commented on a change in pull request #13190: feat: Added Rows Returned

Posted by GitBox <gi...@apache.org>.
AAfghahi commented on a change in pull request #13190:
URL: https://github.com/apache/superset/pull/13190#discussion_r579518997



##########
File path: superset-frontend/src/SqlLab/main.less
##########
@@ -374,6 +374,24 @@ div.tablePopover {
   grid-auto-flow: column;
   grid-gap: 4px;
   padding-right: 8px;
+
+  .ReturnedRows {
+    margin-top: 48px;
+    margin-bottom: -32px;
+    font-size: 13px;
+    line-height: 24px;
+    span {
+      margin-left: 8px;
+    }
+  }
+  
+  .ReturnedRowsImage {
+    color: #FF7F43;
+    vertical-align: bottom;
+  }
+  .LimitMessage{
+    color: #8E94B0;
+  }

Review comment:
       @eschutho changed it to emotion, and also used your updated logic. 
   
   New Look (including Sophie's thoughts):
   ![Screen Shot 2021-02-19 at 5 51 49 PM](https://user-images.githubusercontent.com/48933336/108570146-322ac480-72db-11eb-837f-618135ccdd4a.png)
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] eschutho commented on a change in pull request #13190: feat: Added Rows Returned

Posted by GitBox <gi...@apache.org>.
eschutho commented on a change in pull request #13190:
URL: https://github.com/apache/superset/pull/13190#discussion_r577999693



##########
File path: superset-frontend/src/SqlLab/components/ResultSet.tsx
##########
@@ -476,6 +476,18 @@ export default class ResultSet extends React.PureComponent<
     return <div className="noControls" />;
   }
 
+  rowsReturned() {
+    return (
+      <div className="ReturnedRows">
+        {this.state.data && this.state.data.length >= 0 && (

Review comment:
       you can use optional chaining here. Can the length ever be less than 0?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] eschutho commented on a change in pull request #13190: feat: Added Rows Returned

Posted by GitBox <gi...@apache.org>.
eschutho commented on a change in pull request #13190:
URL: https://github.com/apache/superset/pull/13190#discussion_r579480240



##########
File path: superset-frontend/src/SqlLab/main.less
##########
@@ -374,6 +374,24 @@ div.tablePopover {
   grid-auto-flow: column;
   grid-gap: 4px;
   padding-right: 8px;
+
+  .ReturnedRows {
+    margin-top: 48px;
+    margin-bottom: -32px;
+    font-size: 13px;
+    line-height: 24px;
+    span {
+      margin-left: 8px;
+    }
+  }
+  
+  .ReturnedRowsImage {
+    color: #FF7F43;
+    vertical-align: bottom;
+  }
+  .LimitMessage{
+    color: #8E94B0;
+  }

Review comment:
       we're going clean out these less files soon. I'd suggest using the emotion styles instead.

##########
File path: superset-frontend/src/SqlLab/components/ResultSet.tsx
##########
@@ -481,6 +481,30 @@ export default class ResultSet extends React.PureComponent<
     return <div className="noControls" />;
   }
 
+  rowsReturned() {
+    const { query } = this.props;
+    let limitWarning = null;
+    if (query.results?.displayLimitReached) {
+      limitWarning = <Icon className="ReturnedRowsImage" name="warning" />;
+    }
+    return (
+      <div className="ReturnedRows">
+        {limitWarning}

Review comment:
       a bit of a nit, but instead of making `limitWarning` a react component or null and using it as a boolean, it would be better to use `displayLimitReached` as the boolean in both cases and have limitWarning always be the icon. 
   
   It would read `{displayLimitReached && limitWarning}` for example and the reader would know that it only shows the limitWarning if the displayLimit is reached, rather than always showing the warning, which will be null if the display limit isn't reached. It's a small nuance, but will help. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] AAfghahi commented on a change in pull request #13190: feat: Added Rows Returned

Posted by GitBox <gi...@apache.org>.
AAfghahi commented on a change in pull request #13190:
URL: https://github.com/apache/superset/pull/13190#discussion_r584035644



##########
File path: superset-frontend/src/SqlLab/components/ResultSet.tsx
##########
@@ -100,6 +100,20 @@ const MonospaceDiv = styled.div`
   white-space: pre-wrap;
 `;
 
+const ReturnedRows = styled.div`
+  font-size: 13px;
+  line-height: 24px;
+  .returnedRowsImage {
+    color: #ff7f43;
+    vertical-align: bottom;
+    margin-right: 8px;
+  }
+  .limitMessage {
+    color: #8e94b0;
+    margin-left: 8px;

Review comment:
       Done! I couldn't find the right orange color though, should I add it in? 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] eschutho commented on a change in pull request #13190: feat: Added Rows Returned

Posted by GitBox <gi...@apache.org>.
eschutho commented on a change in pull request #13190:
URL: https://github.com/apache/superset/pull/13190#discussion_r580732239



##########
File path: superset-frontend/src/SqlLab/components/ResultSet.tsx
##########
@@ -100,6 +100,22 @@ const MonospaceDiv = styled.div`
   white-space: pre-wrap;
 `;
 
+const ReturnedRows = styled.div`
+  margin-top: 48px;
+  margin-bottom: -32px;

Review comment:
       there's some weirdness going on with the position: fixed styling of the controls, which is causing these weird margins. Let's see if can remove the position:fixed on the controls. I don't think they are supposed to scroll at all, so we may need to look for a container that has a scroll attribute on the overflow and remove it. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov-io edited a comment on pull request #13190: feat: Added Rows Returned

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13190:
URL: https://github.com/apache/superset/pull/13190#issuecomment-782353235






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov-io edited a comment on pull request #13190: feat: Added Rows Returned

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13190:
URL: https://github.com/apache/superset/pull/13190#issuecomment-782353235


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13190?src=pr&el=h1) Report
   > Merging [#13190](https://codecov.io/gh/apache/superset/pull/13190?src=pr&el=desc) (d9d2e51) into [master](https://codecov.io/gh/apache/superset/commit/892eef1af6a5e61763a8f26f6d2396ff9bda8d11?el=desc) (892eef1) will **decrease** coverage by `4.37%`.
   > The diff coverage is `90.90%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13190/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13190?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13190      +/-   ##
   ==========================================
   - Coverage   77.05%   72.68%   -4.38%     
   ==========================================
     Files         897      571     -326     
     Lines       45710    20863   -24847     
     Branches     5497     5484      -13     
   ==========================================
   - Hits        35224    15164   -20060     
   + Misses      10362     5574    -4788     
   - Partials      124      125       +1     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `58.51% <10.00%> (+0.91%)` | :arrow_up: |
   | hive | `?` | |
   | javascript | `62.35% <90.90%> (-0.14%)` | :arrow_down: |
   | mysql | `?` | |
   | postgres | `?` | |
   | presto | `?` | |
   | python | `?` | |
   | sqlite | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13190?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...erset-frontend/src/SqlLab/components/SouthPane.jsx](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NvdXRoUGFuZS5qc3g=) | `82.05% <ø> (ø)` | |
   | [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `55.86% <ø> (-0.15%)` | :arrow_down: |
   | [...erset-frontend/src/SqlLab/components/ResultSet.tsx](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1Jlc3VsdFNldC50c3g=) | `69.91% <90.00%> (+1.44%)` | :arrow_up: |
   | [...src/components/FilterableTable/FilterableTable.tsx](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRmlsdGVyYWJsZVRhYmxlL0ZpbHRlcmFibGVUYWJsZS50c3g=) | `82.26% <100.00%> (ø)` | |
   | [...et-frontend/src/SqlLab/components/TableElement.jsx](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmxlRWxlbWVudC5qc3g=) | `55.10% <0.00%> (-33.28%)` | :arrow_down: |
   | [superset-frontend/src/utils/urlUtils.ts](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL3VybFV0aWxzLnRz) | `50.00% <0.00%> (-9.10%)` | :arrow_down: |
   | [...dashboard/components/FiltersBadge/DetailsPanel.tsx](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0ZpbHRlcnNCYWRnZS9EZXRhaWxzUGFuZWwudHN4) | `56.52% <0.00%> (-5.71%)` | :arrow_down: |
   | [...set-frontend/src/components/ListViewCard/index.tsx](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXdDYXJkL2luZGV4LnRzeA==) | `94.54% <0.00%> (-5.46%)` | :arrow_down: |
   | [...-frontend/src/common/components/Collapse/index.tsx](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0NvbGxhcHNlL2luZGV4LnRzeA==) | `94.73% <0.00%> (-5.27%)` | :arrow_down: |
   | [...et-frontend/src/messageToasts/components/Toast.tsx](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21lc3NhZ2VUb2FzdHMvY29tcG9uZW50cy9Ub2FzdC50c3g=) | `87.80% <0.00%> (-4.88%)` | :arrow_down: |
   | ... and [381 more](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13190?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13190?src=pr&el=footer). Last update [892eef1...bd4114a](https://codecov.io/gh/apache/superset/pull/13190?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] eschutho commented on a change in pull request #13190: feat: Added Rows Returned

Posted by GitBox <gi...@apache.org>.
eschutho commented on a change in pull request #13190:
URL: https://github.com/apache/superset/pull/13190#discussion_r580723857



##########
File path: superset-frontend/src/SqlLab/components/ResultSet.tsx
##########
@@ -481,6 +497,27 @@ export default class ResultSet extends React.PureComponent<
     return <div className="noControls" />;
   }
 
+  rowsReturned() {
+    const { query } = this.props;
+    const limitWarning = <Icon className="ReturnedRowsImage" name="warning" />;
+    return (
+      <ReturnedRows>
+        {query.results?.displayLimitReached && limitWarning}
+        <span>{t(`%s rows returned`, query.rows)}</span>
+        {query.results?.displayLimitReached && (

Review comment:
       lets see if we can put this value into a variable since you're using it twice. You can also declare it in the destructuring on line 501. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] AAfghahi commented on a change in pull request #13190: feat: Added Rows Returned

Posted by GitBox <gi...@apache.org>.
AAfghahi commented on a change in pull request #13190:
URL: https://github.com/apache/superset/pull/13190#discussion_r581152335



##########
File path: superset-frontend/src/SqlLab/components/ResultSet.tsx
##########
@@ -100,6 +100,22 @@ const MonospaceDiv = styled.div`
   white-space: pre-wrap;
 `;
 
+const ReturnedRows = styled.div`
+  margin-top: 48px;
+  margin-bottom: -32px;

Review comment:
       @eschutho been playing around with this a bit. I got rid of position fixed on the controls, and if do overflow:hidden on the overall container then it replicates the behavior that we want without there being negative margins (I kind of had a theory that you might not like negative margin :) )
   
   What I am currently doing is looking at how to target the overall container. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] eschutho commented on a change in pull request #13190: feat: Added Rows Returned

Posted by GitBox <gi...@apache.org>.
eschutho commented on a change in pull request #13190:
URL: https://github.com/apache/superset/pull/13190#discussion_r580723279



##########
File path: superset-frontend/src/SqlLab/components/ResultSet.tsx
##########
@@ -481,6 +497,27 @@ export default class ResultSet extends React.PureComponent<
     return <div className="noControls" />;
   }
 
+  rowsReturned() {

Review comment:
       nit, but I would rename this `renderRowsReturned` since it's a function, so thus the verb prefix. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov-io edited a comment on pull request #13190: feat: Added Rows Returned

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13190:
URL: https://github.com/apache/superset/pull/13190#issuecomment-782353235


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13190?src=pr&el=h1) Report
   > Merging [#13190](https://codecov.io/gh/apache/superset/pull/13190?src=pr&el=desc) (eb8a3cc) into [master](https://codecov.io/gh/apache/superset/commit/2ce79823dfad61bce6196fcacd56a844f44818c0?el=desc) (2ce7982) will **increase** coverage by `9.07%`.
   > The diff coverage is `46.77%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13190/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13190?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13190      +/-   ##
   ==========================================
   + Coverage   53.06%   62.13%   +9.07%     
   ==========================================
     Files         489      555      +66     
     Lines       17314    20512    +3198     
     Branches     4482     5376     +894     
   ==========================================
   + Hits         9187    12745    +3558     
   + Misses       8127     7551     -576     
   - Partials        0      216     +216     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `?` | |
   | javascript | `62.13% <46.77%> (?)` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13190?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...end/src/SqlLab/components/RunQueryActionButton.tsx](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1J1blF1ZXJ5QWN0aW9uQnV0dG9uLnRzeA==) | `64.28% <ø> (+11.50%)` | :arrow_up: |
   | [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `54.71% <ø> (+0.25%)` | :arrow_up: |
   | [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `100.00% <ø> (ø)` | |
   | [superset-frontend/src/chart/ChartRenderer.jsx](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0UmVuZGVyZXIuanN4) | `39.18% <0.00%> (-37.53%)` | :arrow_down: |
   | [...perset-frontend/src/common/components/Dropdown.tsx](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0Ryb3Bkb3duLnRzeA==) | `54.76% <ø> (+4.76%)` | :arrow_up: |
   | [.../src/common/components/Tooltip/Tooltip.stories.tsx](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL1Rvb2x0aXAvVG9vbHRpcC5zdG9yaWVzLnRzeA==) | `0.00% <0.00%> (ø)` | |
   | [...t-frontend/src/common/components/Tooltip/index.tsx](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL1Rvb2x0aXAvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
   | [...perset-frontend/src/components/AlteredSliceTag.jsx](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnLmpzeA==) | `96.00% <ø> (+4.00%)` | :arrow_up: |
   | [superset-frontend/src/components/CachedLabel.jsx](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2FjaGVkTGFiZWwuanN4) | `42.10% <ø> (ø)` | |
   | [...perset-frontend/src/components/CopyToClipboard.jsx](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ29weVRvQ2xpcGJvYXJkLmpzeA==) | `51.42% <0.00%> (-5.72%)` | :arrow_down: |
   | ... and [582 more](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13190?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13190?src=pr&el=footer). Last update [1e17ef3...eb8a3cc](https://codecov.io/gh/apache/superset/pull/13190?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] AAfghahi commented on pull request #13190: feat: Added Rows Returned

Posted by GitBox <gi...@apache.org>.
AAfghahi commented on pull request #13190:
URL: https://github.com/apache/superset/pull/13190#issuecomment-782342906


   This is what it would look like if you hit the max display rate: 
   ![Screen Shot 2021-02-19 at 3 54 43 PM](https://user-images.githubusercontent.com/48933336/108560491-cd676e00-72ca-11eb-8895-52e6709a4482.png)
    Without: 
    
   ![Screen Shot 2021-02-19 at 3 55 07 PM](https://user-images.githubusercontent.com/48933336/108560527-dc4e2080-72ca-11eb-81b7-35db79b02436.png)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] AAfghahi commented on a change in pull request #13190: feat: Added Rows Returned

Posted by GitBox <gi...@apache.org>.
AAfghahi commented on a change in pull request #13190:
URL: https://github.com/apache/superset/pull/13190#discussion_r579518997



##########
File path: superset-frontend/src/SqlLab/main.less
##########
@@ -374,6 +374,24 @@ div.tablePopover {
   grid-auto-flow: column;
   grid-gap: 4px;
   padding-right: 8px;
+
+  .ReturnedRows {
+    margin-top: 48px;
+    margin-bottom: -32px;
+    font-size: 13px;
+    line-height: 24px;
+    span {
+      margin-left: 8px;
+    }
+  }
+  
+  .ReturnedRowsImage {
+    color: #FF7F43;
+    vertical-align: bottom;
+  }
+  .LimitMessage{
+    color: #8E94B0;
+  }

Review comment:
       @eschutho changed it to emotion, and also used your updated logic. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] eschutho commented on a change in pull request #13190: feat: Added Rows Returned

Posted by GitBox <gi...@apache.org>.
eschutho commented on a change in pull request #13190:
URL: https://github.com/apache/superset/pull/13190#discussion_r585085108



##########
File path: superset-frontend/src/SqlLab/components/ResultSet.tsx
##########
@@ -100,6 +100,20 @@ const MonospaceDiv = styled.div`
   white-space: pre-wrap;
 `;
 
+const ReturnedRows = styled.div`
+  font-size: 13px;
+  line-height: 24px;
+  .returnedRowsImage {
+    color: #ff7f43;
+    vertical-align: bottom;
+    margin-right: 8px;
+  }
+  .limitMessage {
+    color: #8e94b0;
+    margin-left: 8px;

Review comment:
       Let's ask @steejay if the existing orange works: FF7F44




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov-io edited a comment on pull request #13190: feat: Added Rows Returned

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13190:
URL: https://github.com/apache/superset/pull/13190#issuecomment-782353235


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13190?src=pr&el=h1) Report
   > Merging [#13190](https://codecov.io/gh/apache/superset/pull/13190?src=pr&el=desc) (ff73170) into [master](https://codecov.io/gh/apache/superset/commit/892eef1af6a5e61763a8f26f6d2396ff9bda8d11?el=desc) (892eef1) will **decrease** coverage by `4.35%`.
   > The diff coverage is `71.42%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13190/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13190?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13190      +/-   ##
   ==========================================
   - Coverage   77.05%   72.70%   -4.36%     
   ==========================================
     Files         897      596     -301     
     Lines       45710    21270   -24440     
     Branches     5497     5500       +3     
   ==========================================
   - Hits        35224    15464   -19760     
   + Misses      10362     5682    -4680     
     Partials      124      124              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `57.55% <7.69%> (-0.04%)` | :arrow_down: |
   | hive | `?` | |
   | javascript | `62.50% <71.42%> (+<0.01%)` | :arrow_up: |
   | mysql | `?` | |
   | postgres | `?` | |
   | presto | `?` | |
   | python | `?` | |
   | sqlite | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13190?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...erset-frontend/src/SqlLab/components/SouthPane.jsx](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NvdXRoUGFuZS5qc3g=) | `82.05% <ø> (ø)` | |
   | [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `55.86% <ø> (-0.15%)` | :arrow_down: |
   | [...erset-frontend/src/SqlLab/components/ResultSet.tsx](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1Jlc3VsdFNldC50c3g=) | `68.51% <69.23%> (+0.04%)` | :arrow_up: |
   | [...src/components/FilterableTable/FilterableTable.tsx](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRmlsdGVyYWJsZVRhYmxlL0ZpbHRlcmFibGVUYWJsZS50c3g=) | `82.26% <100.00%> (ø)` | |
   | [superset/connectors/base/views.py](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL3ZpZXdzLnB5) | | |
   | [superset/examples/sf\_population\_polygons.py](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvc2ZfcG9wdWxhdGlvbl9wb2x5Z29ucy5weQ==) | | |
   | [superset/queries/schemas.py](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zY2hlbWFzLnB5) | | |
   | [superset/views/filters.py](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZmlsdGVycy5weQ==) | | |
   | [superset/views/alerts.py](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYWxlcnRzLnB5) | | |
   | [superset/views/access\_requests.py](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYWNjZXNzX3JlcXVlc3RzLnB5) | | |
   | ... and [295 more](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13190?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13190?src=pr&el=footer). Last update [892eef1...ff73170](https://codecov.io/gh/apache/superset/pull/13190?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] eschutho commented on pull request #13190: feat: Added Rows Returned

Posted by GitBox <gi...@apache.org>.
eschutho commented on pull request #13190:
URL: https://github.com/apache/superset/pull/13190#issuecomment-786991404


   just so I don't forget, let's follow up on the display alert in this ticket.. does this PR include https://github.com/apache/superset/issues/10330 too?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] Steejay commented on a change in pull request #13190: feat: Added Rows Returned

Posted by GitBox <gi...@apache.org>.
Steejay commented on a change in pull request #13190:
URL: https://github.com/apache/superset/pull/13190#discussion_r585086358



##########
File path: superset-frontend/src/SqlLab/components/ResultSet.tsx
##########
@@ -100,6 +100,20 @@ const MonospaceDiv = styled.div`
   white-space: pre-wrap;
 `;
 
+const ReturnedRows = styled.div`
+  font-size: 13px;
+  line-height: 24px;
+  .returnedRowsImage {
+    color: #ff7f43;
+    vertical-align: bottom;
+    margin-right: 8px;
+  }
+  .limitMessage {
+    color: #8e94b0;
+    margin-left: 8px;

Review comment:
       @eschutho @AAfghahi existing works. nearly identical. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov-io edited a comment on pull request #13190: feat: Added Rows Returned

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13190:
URL: https://github.com/apache/superset/pull/13190#issuecomment-782353235


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13190?src=pr&el=h1) Report
   > Merging [#13190](https://codecov.io/gh/apache/superset/pull/13190?src=pr&el=desc) (d9d2e51) into [master](https://codecov.io/gh/apache/superset/commit/99a0c8a8a129502d6253e000c14db31ab8b0bb19?el=desc) (99a0c8a) will **decrease** coverage by `4.46%`.
   > The diff coverage is `94.44%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13190/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13190?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13190      +/-   ##
   ==========================================
   - Coverage   77.15%   72.68%   -4.47%     
   ==========================================
     Files         866      571     -295     
     Lines       45005    20863   -24142     
     Branches     5357     5484     +127     
   ==========================================
   - Hits        34723    15164   -19559     
   + Misses      10159     5574    -4585     
   - Partials      123      125       +2     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `58.51% <53.84%> (-0.01%)` | :arrow_down: |
   | javascript | `62.35% <91.66%> (+0.15%)` | :arrow_up: |
   | python | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13190?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...erset-frontend/src/SqlLab/components/SouthPane.jsx](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NvdXRoUGFuZS5qc3g=) | `82.05% <ø> (ø)` | |
   | [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `55.86% <ø> (-0.15%)` | :arrow_down: |
   | [superset-frontend/src/components/ListView/utils.ts](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvdXRpbHMudHM=) | `85.95% <ø> (ø)` | |
   | [superset-frontend/src/views/App.tsx](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0FwcC50c3g=) | `38.70% <0.00%> (-0.18%)` | :arrow_down: |
   | [...erset-frontend/src/SqlLab/components/ResultSet.tsx](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1Jlc3VsdFNldC50c3g=) | `69.91% <90.00%> (+0.93%)` | :arrow_up: |
   | [...end/src/common/hooks/useComponentDidMount/index.ts](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9ob29rcy91c2VDb21wb25lbnREaWRNb3VudC9pbmRleC50cw==) | `100.00% <100.00%> (ø)` | |
   | [...hooks/useComponentDidMount/useComponentDidMount.ts](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9ob29rcy91c2VDb21wb25lbnREaWRNb3VudC91c2VDb21wb25lbnREaWRNb3VudC50cw==) | `100.00% <100.00%> (ø)` | |
   | [...src/components/FilterableTable/FilterableTable.tsx](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRmlsdGVyYWJsZVRhYmxlL0ZpbHRlcmFibGVUYWJsZS50c3g=) | `82.26% <100.00%> (ø)` | |
   | [...et-frontend/src/components/FlashProvider/index.tsx](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRmxhc2hQcm92aWRlci9pbmRleC50c3g=) | `100.00% <100.00%> (ø)` | |
   | [...nd/src/explore/components/ExploreViewContainer.jsx](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlVmlld0NvbnRhaW5lci5qc3g=) | `78.18% <100.00%> (ø)` | |
   | ... and [313 more](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13190?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13190?src=pr&el=footer). Last update [99a0c8a...fb29187](https://codecov.io/gh/apache/superset/pull/13190?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] hughhhh merged pull request #13190: feat: Added Rows Returned

Posted by GitBox <gi...@apache.org>.
hughhhh merged pull request #13190:
URL: https://github.com/apache/superset/pull/13190


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] yousoph commented on pull request #13190: feat: Added Rows Returned

Posted by GitBox <gi...@apache.org>.
yousoph commented on pull request #13190:
URL: https://github.com/apache/superset/pull/13190#issuecomment-789423382


   Looked at this with @AAfghahi today, it was looking good to me 👍 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] AAfghahi commented on a change in pull request #13190: feat: Added Rows Returned

Posted by GitBox <gi...@apache.org>.
AAfghahi commented on a change in pull request #13190:
URL: https://github.com/apache/superset/pull/13190#discussion_r584036043



##########
File path: superset-frontend/src/SqlLab/components/ResultSet.tsx
##########
@@ -481,6 +495,28 @@ export default class ResultSet extends React.PureComponent<
     return <div className="noControls" />;
   }
 
+  renderRowsReturned() {
+    const { results, rows } = this.props.query;

Review comment:
       yup! It will only render if query.results exists. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] eschutho commented on a change in pull request #13190: feat: Added Rows Returned

Posted by GitBox <gi...@apache.org>.
eschutho commented on a change in pull request #13190:
URL: https://github.com/apache/superset/pull/13190#discussion_r584023558



##########
File path: superset-frontend/src/SqlLab/components/ResultSet.tsx
##########
@@ -100,6 +100,20 @@ const MonospaceDiv = styled.div`
   white-space: pre-wrap;
 `;
 
+const ReturnedRows = styled.div`
+  font-size: 13px;
+  line-height: 24px;
+  .returnedRowsImage {
+    color: #ff7f43;
+    vertical-align: bottom;
+    margin-right: 8px;
+  }
+  .limitMessage {
+    color: #8e94b0;
+    margin-left: 8px;

Review comment:
       can we try to use the themeProvider here for the spacings and colors?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] AAfghahi commented on a change in pull request #13190: feat: Added Rows Returned

Posted by GitBox <gi...@apache.org>.
AAfghahi commented on a change in pull request #13190:
URL: https://github.com/apache/superset/pull/13190#discussion_r578466987



##########
File path: superset-frontend/src/SqlLab/components/ResultSet.tsx
##########
@@ -476,6 +476,18 @@ export default class ResultSet extends React.PureComponent<
     return <div className="noControls" />;
   }
 
+  rowsReturned() {
+    return (
+      <div className="ReturnedRows">
+        {this.state.data && this.state.data.length >= 0 && (

Review comment:
       I think I could actually just remove the conditions, since a tighter version of it happens in the render. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov-io edited a comment on pull request #13190: feat: Added Rows Returned

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13190:
URL: https://github.com/apache/superset/pull/13190#issuecomment-782353235


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13190?src=pr&el=h1) Report
   > Merging [#13190](https://codecov.io/gh/apache/superset/pull/13190?src=pr&el=desc) (ff73170) into [master](https://codecov.io/gh/apache/superset/commit/892eef1af6a5e61763a8f26f6d2396ff9bda8d11?el=desc) (892eef1) will **decrease** coverage by `4.35%`.
   > The diff coverage is `71.42%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13190/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13190?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13190      +/-   ##
   ==========================================
   - Coverage   77.05%   72.70%   -4.36%     
   ==========================================
     Files         897      596     -301     
     Lines       45710    21270   -24440     
     Branches     5497     5500       +3     
   ==========================================
   - Hits        35224    15464   -19760     
   + Misses      10362     5682    -4680     
     Partials      124      124              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `57.55% <7.69%> (-0.04%)` | :arrow_down: |
   | hive | `?` | |
   | javascript | `62.50% <71.42%> (+<0.01%)` | :arrow_up: |
   | mysql | `?` | |
   | postgres | `?` | |
   | presto | `?` | |
   | python | `?` | |
   | sqlite | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13190?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...erset-frontend/src/SqlLab/components/SouthPane.jsx](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NvdXRoUGFuZS5qc3g=) | `82.05% <ø> (ø)` | |
   | [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `55.86% <ø> (-0.15%)` | :arrow_down: |
   | [...erset-frontend/src/SqlLab/components/ResultSet.tsx](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1Jlc3VsdFNldC50c3g=) | `68.51% <69.23%> (+0.04%)` | :arrow_up: |
   | [...src/components/FilterableTable/FilterableTable.tsx](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRmlsdGVyYWJsZVRhYmxlL0ZpbHRlcmFibGVUYWJsZS50c3g=) | `82.26% <100.00%> (ø)` | |
   | [superset/css\_templates/filters.py](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY3NzX3RlbXBsYXRlcy9maWx0ZXJzLnB5) | | |
   | [superset/commands/utils.py](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvdXRpbHMucHk=) | | |
   | [superset/utils/celery.py](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | | |
   | [superset/models/schedules.py](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3NjaGVkdWxlcy5weQ==) | | |
   | [...notation\_layers/annotations/commands/exceptions.py](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvY29tbWFuZHMvZXhjZXB0aW9ucy5weQ==) | | |
   | [superset/tasks/async\_queries.py](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvYXN5bmNfcXVlcmllcy5weQ==) | | |
   | ... and [295 more](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13190?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13190?src=pr&el=footer). Last update [892eef1...ab89d5f](https://codecov.io/gh/apache/superset/pull/13190?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] eschutho commented on a change in pull request #13190: feat: Added Rows Returned

Posted by GitBox <gi...@apache.org>.
eschutho commented on a change in pull request #13190:
URL: https://github.com/apache/superset/pull/13190#discussion_r580724808



##########
File path: superset-frontend/src/SqlLab/components/ResultSet.tsx
##########
@@ -481,6 +497,27 @@ export default class ResultSet extends React.PureComponent<
     return <div className="noControls" />;
   }
 
+  rowsReturned() {
+    const { query } = this.props;
+    const limitWarning = <Icon className="ReturnedRowsImage" name="warning" />;
+    return (
+      <ReturnedRows>
+        {query.results?.displayLimitReached && limitWarning}
+        <span>{t(`%s rows returned`, query.rows)}</span>
+        {query.results?.displayLimitReached && (
+          <span className="LimitMessage">

Review comment:
       we usually use camel-case (lowercase first letter) for class names. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] eschutho commented on a change in pull request #13190: feat: Added Rows Returned

Posted by GitBox <gi...@apache.org>.
eschutho commented on a change in pull request #13190:
URL: https://github.com/apache/superset/pull/13190#discussion_r578002038



##########
File path: superset-frontend/src/SqlLab/components/ResultSet.tsx
##########
@@ -476,6 +476,18 @@ export default class ResultSet extends React.PureComponent<
     return <div className="noControls" />;
   }
 
+  rowsReturned() {
+    return (
+      <div className="ReturnedRows">
+        {this.state.data && this.state.data.length >= 0 && (
+          <span>
+            {t(`%s rows returned`, this.props.query.results.data.length)}

Review comment:
       Also, the query has a rows prop which may be easier than totaling.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] eschutho commented on a change in pull request #13190: feat: Added Rows Returned

Posted by GitBox <gi...@apache.org>.
eschutho commented on a change in pull request #13190:
URL: https://github.com/apache/superset/pull/13190#discussion_r580723279



##########
File path: superset-frontend/src/SqlLab/components/ResultSet.tsx
##########
@@ -481,6 +497,27 @@ export default class ResultSet extends React.PureComponent<
     return <div className="noControls" />;
   }
 
+  rowsReturned() {

Review comment:
       nit, but I would rename this `renderRowsReturned` since it's a function, so thus the verb prefix. Also to be consistent with renderControls




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] AAfghahi commented on a change in pull request #13190: feat: Added Rows Returned

Posted by GitBox <gi...@apache.org>.
AAfghahi commented on a change in pull request #13190:
URL: https://github.com/apache/superset/pull/13190#discussion_r579518997



##########
File path: superset-frontend/src/SqlLab/main.less
##########
@@ -374,6 +374,24 @@ div.tablePopover {
   grid-auto-flow: column;
   grid-gap: 4px;
   padding-right: 8px;
+
+  .ReturnedRows {
+    margin-top: 48px;
+    margin-bottom: -32px;
+    font-size: 13px;
+    line-height: 24px;
+    span {
+      margin-left: 8px;
+    }
+  }
+  
+  .ReturnedRowsImage {
+    color: #FF7F43;
+    vertical-align: bottom;
+  }
+  .LimitMessage{
+    color: #8E94B0;
+  }

Review comment:
       @eschutho changed it to emotion, and also used your updated logic. 
   
   New Look (including Sophie's thoughts):
   ![image](https://user-images.githubusercontent.com/48933336/108570044-ff80cc00-72da-11eb-87df-f9fd8e9881bd.png)
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov-io commented on pull request #13190: feat: Added Rows Returned

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #13190:
URL: https://github.com/apache/superset/pull/13190#issuecomment-782353235


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13190?src=pr&el=h1) Report
   > Merging [#13190](https://codecov.io/gh/apache/superset/pull/13190?src=pr&el=desc) (e599a9c) into [master](https://codecov.io/gh/apache/superset/commit/2ce79823dfad61bce6196fcacd56a844f44818c0?el=desc) (2ce7982) will **decrease** coverage by `6.85%`.
   > The diff coverage is `47.49%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13190/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13190?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13190      +/-   ##
   ==========================================
   - Coverage   53.06%   46.20%   -6.86%     
   ==========================================
     Files         489      422      -67     
     Lines       17314    13099    -4215     
     Branches     4482     3459    -1023     
   ==========================================
   - Hits         9187     6053    -3134     
   + Misses       8127     7046    -1081     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `46.20% <47.49%> (-6.86%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13190?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `100.00% <ø> (ø)` | |
   | [superset-frontend/src/chart/ChartRenderer.jsx](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0UmVuZGVyZXIuanN4) | `75.67% <0.00%> (-1.04%)` | :arrow_down: |
   | [...t-frontend/src/common/components/Tooltip/index.tsx](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL1Rvb2x0aXAvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
   | [...perset-frontend/src/components/AlteredSliceTag.jsx](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnLmpzeA==) | `82.66% <ø> (-9.34%)` | :arrow_down: |
   | [superset-frontend/src/components/CachedLabel.jsx](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2FjaGVkTGFiZWwuanN4) | `42.10% <ø> (ø)` | |
   | [...perset-frontend/src/components/CopyToClipboard.jsx](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ29weVRvQ2xpcGJvYXJkLmpzeA==) | `11.42% <0.00%> (-45.72%)` | :arrow_down: |
   | [...t-frontend/src/components/DynamicPlugins/index.tsx](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRHluYW1pY1BsdWdpbnMvaW5kZXgudHN4) | `23.25% <ø> (ø)` | |
   | [superset-frontend/src/components/FaveStar.tsx](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRmF2ZVN0YXIudHN4) | `100.00% <ø> (ø)` | |
   | [...rontend/src/components/ListView/CardSortSelect.tsx](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvQ2FyZFNvcnRTZWxlY3QudHN4) | `21.05% <ø> (-57.90%)` | :arrow_down: |
   | [...rset-frontend/src/components/ListView/ListView.tsx](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvTGlzdFZpZXcudHN4) | `80.89% <0.00%> (+4.49%)` | :arrow_up: |
   | ... and [319 more](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13190?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13190?src=pr&el=footer). Last update [1e17ef3...f995d78](https://codecov.io/gh/apache/superset/pull/13190?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] AAfghahi commented on a change in pull request #13190: feat: Added Rows Returned

Posted by GitBox <gi...@apache.org>.
AAfghahi commented on a change in pull request #13190:
URL: https://github.com/apache/superset/pull/13190#discussion_r581233938



##########
File path: superset-frontend/src/SqlLab/components/ResultSet.tsx
##########
@@ -100,6 +100,22 @@ const MonospaceDiv = styled.div`
   white-space: pre-wrap;
 `;
 
+const ReturnedRows = styled.div`
+  margin-top: 48px;
+  margin-bottom: -32px;

Review comment:
       ok, I think I fixed all of it with the last commit! This was a good dive into the various components in the South Pane. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] eschutho commented on a change in pull request #13190: feat: Added Rows Returned

Posted by GitBox <gi...@apache.org>.
eschutho commented on a change in pull request #13190:
URL: https://github.com/apache/superset/pull/13190#discussion_r580723980



##########
File path: superset-frontend/src/SqlLab/components/ResultSet.tsx
##########
@@ -481,6 +497,27 @@ export default class ResultSet extends React.PureComponent<
     return <div className="noControls" />;
   }
 
+  rowsReturned() {
+    const { query } = this.props;
+    const limitWarning = <Icon className="ReturnedRowsImage" name="warning" />;
+    return (
+      <ReturnedRows>
+        {query.results?.displayLimitReached && limitWarning}
+        <span>{t(`%s rows returned`, query.rows)}</span>
+        {query.results?.displayLimitReached && (
+          <span className="LimitMessage">
+            {t(
+              `It appears that the number of rows in the query results displayed
+           was limited on the server side to
+           the %s limit.`,
+              query.rows,

Review comment:
       this is cool. I didn't know that you can do string interpolation in the translate function. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov-io edited a comment on pull request #13190: feat: Added Rows Returned

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13190:
URL: https://github.com/apache/superset/pull/13190#issuecomment-782353235


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13190?src=pr&el=h1) Report
   > Merging [#13190](https://codecov.io/gh/apache/superset/pull/13190?src=pr&el=desc) (d9d2e51) into [master](https://codecov.io/gh/apache/superset/commit/892eef1af6a5e61763a8f26f6d2396ff9bda8d11?el=desc) (892eef1) will **decrease** coverage by `4.37%`.
   > The diff coverage is `90.90%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13190/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13190?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13190      +/-   ##
   ==========================================
   - Coverage   77.05%   72.68%   -4.38%     
   ==========================================
     Files         897      571     -326     
     Lines       45710    20863   -24847     
     Branches     5497     5484      -13     
   ==========================================
   - Hits        35224    15164   -20060     
   + Misses      10362     5574    -4788     
   - Partials      124      125       +1     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `58.51% <10.00%> (+0.91%)` | :arrow_up: |
   | hive | `?` | |
   | javascript | `62.35% <90.90%> (-0.14%)` | :arrow_down: |
   | mysql | `?` | |
   | postgres | `?` | |
   | presto | `?` | |
   | python | `?` | |
   | sqlite | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13190?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...erset-frontend/src/SqlLab/components/SouthPane.jsx](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NvdXRoUGFuZS5qc3g=) | `82.05% <ø> (ø)` | |
   | [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `55.86% <ø> (-0.15%)` | :arrow_down: |
   | [...erset-frontend/src/SqlLab/components/ResultSet.tsx](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1Jlc3VsdFNldC50c3g=) | `69.91% <90.00%> (+1.44%)` | :arrow_up: |
   | [...src/components/FilterableTable/FilterableTable.tsx](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRmlsdGVyYWJsZVRhYmxlL0ZpbHRlcmFibGVUYWJsZS50c3g=) | `82.26% <100.00%> (ø)` | |
   | [...et-frontend/src/SqlLab/components/TableElement.jsx](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmxlRWxlbWVudC5qc3g=) | `55.10% <0.00%> (-33.28%)` | :arrow_down: |
   | [superset-frontend/src/utils/urlUtils.ts](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL3VybFV0aWxzLnRz) | `50.00% <0.00%> (-9.10%)` | :arrow_down: |
   | [...dashboard/components/FiltersBadge/DetailsPanel.tsx](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0ZpbHRlcnNCYWRnZS9EZXRhaWxzUGFuZWwudHN4) | `56.52% <0.00%> (-5.71%)` | :arrow_down: |
   | [...set-frontend/src/components/ListViewCard/index.tsx](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXdDYXJkL2luZGV4LnRzeA==) | `94.54% <0.00%> (-5.46%)` | :arrow_down: |
   | [...-frontend/src/common/components/Collapse/index.tsx](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0NvbGxhcHNlL2luZGV4LnRzeA==) | `94.73% <0.00%> (-5.27%)` | :arrow_down: |
   | [...et-frontend/src/messageToasts/components/Toast.tsx](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21lc3NhZ2VUb2FzdHMvY29tcG9uZW50cy9Ub2FzdC50c3g=) | `87.80% <0.00%> (-4.88%)` | :arrow_down: |
   | ... and [381 more](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13190?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13190?src=pr&el=footer). Last update [892eef1...ff73170](https://codecov.io/gh/apache/superset/pull/13190?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov-io edited a comment on pull request #13190: feat: Added Rows Returned

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13190:
URL: https://github.com/apache/superset/pull/13190#issuecomment-782353235


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13190?src=pr&el=h1) Report
   > Merging [#13190](https://codecov.io/gh/apache/superset/pull/13190?src=pr&el=desc) (d9d2e51) into [master](https://codecov.io/gh/apache/superset/commit/892eef1af6a5e61763a8f26f6d2396ff9bda8d11?el=desc) (892eef1) will **decrease** coverage by `4.37%`.
   > The diff coverage is `90.90%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13190/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13190?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13190      +/-   ##
   ==========================================
   - Coverage   77.05%   72.68%   -4.38%     
   ==========================================
     Files         897      571     -326     
     Lines       45710    20863   -24847     
     Branches     5497     5484      -13     
   ==========================================
   - Hits        35224    15164   -20060     
   + Misses      10362     5574    -4788     
   - Partials      124      125       +1     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `58.51% <10.00%> (+0.91%)` | :arrow_up: |
   | hive | `?` | |
   | javascript | `62.35% <90.90%> (-0.14%)` | :arrow_down: |
   | mysql | `?` | |
   | postgres | `?` | |
   | presto | `?` | |
   | python | `?` | |
   | sqlite | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13190?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...erset-frontend/src/SqlLab/components/SouthPane.jsx](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NvdXRoUGFuZS5qc3g=) | `82.05% <ø> (ø)` | |
   | [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `55.86% <ø> (-0.15%)` | :arrow_down: |
   | [...erset-frontend/src/SqlLab/components/ResultSet.tsx](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1Jlc3VsdFNldC50c3g=) | `69.91% <90.00%> (+1.44%)` | :arrow_up: |
   | [...src/components/FilterableTable/FilterableTable.tsx](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRmlsdGVyYWJsZVRhYmxlL0ZpbHRlcmFibGVUYWJsZS50c3g=) | `82.26% <100.00%> (ø)` | |
   | [...et-frontend/src/SqlLab/components/TableElement.jsx](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmxlRWxlbWVudC5qc3g=) | `55.10% <0.00%> (-33.28%)` | :arrow_down: |
   | [superset-frontend/src/utils/urlUtils.ts](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL3VybFV0aWxzLnRz) | `50.00% <0.00%> (-9.10%)` | :arrow_down: |
   | [...dashboard/components/FiltersBadge/DetailsPanel.tsx](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0ZpbHRlcnNCYWRnZS9EZXRhaWxzUGFuZWwudHN4) | `56.52% <0.00%> (-5.71%)` | :arrow_down: |
   | [...set-frontend/src/components/ListViewCard/index.tsx](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXdDYXJkL2luZGV4LnRzeA==) | `94.54% <0.00%> (-5.46%)` | :arrow_down: |
   | [...-frontend/src/common/components/Collapse/index.tsx](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0NvbGxhcHNlL2luZGV4LnRzeA==) | `94.73% <0.00%> (-5.27%)` | :arrow_down: |
   | [...et-frontend/src/messageToasts/components/Toast.tsx](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21lc3NhZ2VUb2FzdHMvY29tcG9uZW50cy9Ub2FzdC50c3g=) | `87.80% <0.00%> (-4.88%)` | :arrow_down: |
   | ... and [381 more](https://codecov.io/gh/apache/superset/pull/13190/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13190?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13190?src=pr&el=footer). Last update [892eef1...79364b7](https://codecov.io/gh/apache/superset/pull/13190?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] AAfghahi commented on a change in pull request #13190: feat: Added Rows Returned

Posted by GitBox <gi...@apache.org>.
AAfghahi commented on a change in pull request #13190:
URL: https://github.com/apache/superset/pull/13190#discussion_r578474786



##########
File path: superset-frontend/src/SqlLab/components/ResultSet.tsx
##########
@@ -476,6 +476,18 @@ export default class ResultSet extends React.PureComponent<
     return <div className="noControls" />;
   }
 
+  rowsReturned() {
+    return (
+      <div className="ReturnedRows">
+        {this.state.data && this.state.data.length >= 0 && (
+          <span>
+            {t(`%s rows returned`, this.props.query.results.data.length)}

Review comment:
       I originally had this as a drawing from the query function, but when I did that I got an error that said that Query has no property called rows, which is what is being passed into props.query. 
   
   However, when I render with this.props.query.rows, it renders perfectly fine, and is responsive to how many lines the SQL result is. I changed it to this because I was tired of my terminal yelling at me. 
   
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] AAfghahi commented on pull request #13190: feat: Added Rows Returned

Posted by GitBox <gi...@apache.org>.
AAfghahi commented on pull request #13190:
URL: https://github.com/apache/superset/pull/13190#issuecomment-787001689


   > just so I don't forget, let's follow up on the display alert in this ticket.. does this PR include #10330 too?
   
   Portions of it, the portions that are not included are the admin portions and the part that requires a migration. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org