You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@fineract.apache.org by Aleksandar Vidakovic <ch...@monkeysintown.com> on 2022/03/29 07:29:45 UTC
Failing tests on develop...
Hi Manoj, Avik,
... just sending you the stacktraces (please see attachment) I could find
for the failing tests... would be great if you could look at this...
appreciate it.
Please let me know if there's anything I can do to help.
Thanks again,
Aleks
Re: Failing tests on develop...
Posted by Aleksandar Vidakovic <ch...@monkeysintown.com>.
... to get the PRs going again I've disabled temporarily those 3 failing
tests (will put them in a Jira ticket as a reminder to fix).
The PR/commit where those tests are not working anymore:
https://github.com/apache/fineract/commit/d5c611564f7b8c877136f3b3aca647bf7de15fe0
The real problem here are all those 6000 LOC in Loan.java ... data gets
copied... and copied again... which is a bit problematic with a class that
is ultimately under JPA's/EclipseLink's control. What was working with
OpenJPA doesn't necessarily need to work with EclipseLink.
I'm sure we'll find a solution, but we'll try to keep them as small as
possible (to avoid too many changes).
FYI
On Tue, Mar 29, 2022 at 10:49 PM Manoj VM <ma...@fynarfin.io> wrote:
> .. The issue is caused by this line in LoanCharge.java[image: Screenshot
> 2022-03-30 at 1.54.38 AM.png]
>
> this looks like a snake eating its own tail. Kindly fix this.
>
> Thanks and Regards,
> Manoj
> fynarfin.io
>
>
> On Wed, Mar 30, 2022 at 12:57 AM Manoj VM <ma...@fynarfin.io> wrote:
>
>>
>> Absolutely right,
>> the installment charges are getting cleared during the loan approval
>> process.
>>
>> I am diving deep into this.
>>
>>
>> Thanks and Regards,
>> Manoj
>> fynarfin.io
>>
>>
>> On Tue, Mar 29, 2022 at 11:21 PM Aleksandar Vidakovic <
>> cheetah@monkeysintown.com> wrote:
>>
>>> ... I'm a little further down the rabbit hole. So, this is where things
>>> (for one of the errors at least) things start to break:
>>>
>>>
>>> https://github.com/apache/fineract/blob/develop/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanWritePlatformServiceJpaRepositoryImpl.java#L976
>>>
>>> ... which in turn lands us here:
>>>
>>>
>>> https://github.com/apache/fineract/blob/develop/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/LoanCharge.java#L861
>>>
>>> The function "getUnpaidInstallmentLoanCharge()" will return a null,
>>> because the collection "loanInstallmentCharge" is empty.
>>>
>>> I have to admit that I'm not entirely sure about the business logic and
>>> what should be where and when. The only thing I can say is that
>>> "loanInstallmentCharge" should contain an entry and it doesn't.
>>>
>>> Would be great if someone with a better insight into the business logic
>>> could chime in here.
>>>
>>> FYI
>>>
>>> On Tue, Mar 29, 2022 at 6:49 PM Aleksandar Vidakovic <
>>> cheetah@monkeysintown.com> wrote:
>>>
>>>> ... alright, one of the failures is due to a NPE, but additionally the
>>>> error object doesn't get populated properly. The part that should contain
>>>> valid JSON is messed up and contains this:
>>>>
>>>> {"Exception": java.lang.NullPointerException: Cannot invoke
>>>> "org.apache.fineract.portfolio.loanaccount.domain.LoanInstallmentCharge.updatePaidAmountBy(org.apache.fineract.organisation.monetary.domain.Money,
>>>> org.apache.fineract.organisation.monetary.domain.Money)" because the return
>>>> value of
>>>> "org.apache.fineract.portfolio.loanaccount.domain.LoanCharge.getUnpaidInstallmentLoanCharge()"
>>>> is null}
>>>>
>>>> ... which is obviously invalid JSON... which bubbles up at the REST
>>>> endpoint.
>>>>
>>>> So there might be 2 problems here with that one error:
>>>> - the NPE that triggers the error
>>>> - ... and that the error object is not properly populated
>>>>
>>>> Just FYI
>>>>
>>>> On Tue, Mar 29, 2022 at 6:14 PM Aleksandar Vidakovic <
>>>> cheetah@monkeysintown.com> wrote:
>>>>
>>>>> ... thanks a ton Manoj... I'm debugging too... will post if I know
>>>>> more.
>>>>>
>>>>> On Tue, Mar 29, 2022 at 5:53 PM Manoj VM <ma...@fynarfin.io> wrote:
>>>>>
>>>>>> Hi Team,
>>>>>>
>>>>>> Added a ticket to track this issue
>>>>>> https://issues.apache.org/jira/browse/FINERACT-1557 and working on
>>>>>> the same.
>>>>>>
>>>>>> Thanks and Regards,
>>>>>> Manoj
>>>>>> fynarfin.io
>>>>>>
>>>>>>
>>>>>> On Tue, Mar 29, 2022 at 1:16 PM Aleksandar Vidakovic <
>>>>>> cheetah@monkeysintown.com> wrote:
>>>>>>
>>>>>>> ... good point Arnold. Avik, Manoj: just waiting for the current
>>>>>>> build (where these tests are disabled) to pass... hope you don't mind if we
>>>>>>> revert the changes as Arnold said to unblock other PRs.
>>>>>>>
>>>>>>> If you need any help please let me know.
>>>>>>>
>>>>>>> Cheers,
>>>>>>>
>>>>>>> Aleks
>>>>>>>
>>>>>>> On Tue, Mar 29, 2022 at 9:35 AM Arnold Galovics <
>>>>>>> galovicsarnold@gmail.com> wrote:
>>>>>>>
>>>>>>>> Hi Aleks, others,
>>>>>>>>
>>>>>>>> I see we have quite some things lined up to be merged so I'm
>>>>>>>> proposing to revert the particular PR that broke the build. As soon as
>>>>>>>> Manoj, Avik is able to fix the implementation, they can open a new PR to
>>>>>>>> reapply the changes.
>>>>>>>>
>>>>>>>> I'd say let's unblock the build as soon as possible and let other
>>>>>>>> changes come in instead of letting them pile up.
>>>>>>>>
>>>>>>>> Hope that makes sense.
>>>>>>>> Best,
>>>>>>>> Arnold
>>>>>>>>
>>>>>>>> On Tue, Mar 29, 2022 at 9:30 AM Aleksandar Vidakovic <
>>>>>>>> cheetah@monkeysintown.com> wrote:
>>>>>>>>
>>>>>>>>> Hi Manoj, Avik,
>>>>>>>>>
>>>>>>>>> ... just sending you the stacktraces (please see attachment) I
>>>>>>>>> could find for the failing tests... would be great if you could look at
>>>>>>>>> this... appreciate it.
>>>>>>>>>
>>>>>>>>> Please let me know if there's anything I can do to help.
>>>>>>>>>
>>>>>>>>> Thanks again,
>>>>>>>>>
>>>>>>>>> Aleks
>>>>>>>>>
>>>>>>>>
>>>>>> Disclaimer:
>>>>>>
>>>>>> Privileged & confidential information is contained in this message
>>>>>> (including all attachments). If you are not an intended recipient of this
>>>>>> message, please destroy this message immediately and kindly notify
>>>>>> the sender by reply e-mail. Any unauthorised use or dissemination of
>>>>>> this message in any manner whatsoever, in whole or in part, is strictly
>>>>>> prohibited. This e-mail, including all attachments hereto, (i) is for
>>>>>> discussion purposes only and shall not be deemed or construed to be a
>>>>>> professional opinion unless expressly stated otherwise, and (ii) is not
>>>>>> intended, written or sent to be used, and cannot and shall not be used, for
>>>>>> any unlawful purpose. This communication, including any attachments, may
>>>>>> not be free of viruses, interceptions or interference, and may not be
>>>>>> compatible with your systems. You should carry out your own virus checks
>>>>>> before opening any attachment to this e-mail. The sender of this e-mail and
>>>>>> *Fynarfin Tech Private Limited* shall not be liable for any damage
>>>>>> that you may sustain as a result of viruses, incompleteness of this
>>>>>> message, a delay in receipt of this message or computer problems
>>>>>> experienced.
>>>>>>
>>>>>
> Disclaimer:
>
> Privileged & confidential information is contained in this message
> (including all attachments). If you are not an intended recipient of this
> message, please destroy this message immediately and kindly notify
> the sender by reply e-mail. Any unauthorised use or dissemination of this
> message in any manner whatsoever, in whole or in part, is strictly
> prohibited. This e-mail, including all attachments hereto, (i) is for
> discussion purposes only and shall not be deemed or construed to be a
> professional opinion unless expressly stated otherwise, and (ii) is not
> intended, written or sent to be used, and cannot and shall not be used, for
> any unlawful purpose. This communication, including any attachments, may
> not be free of viruses, interceptions or interference, and may not be
> compatible with your systems. You should carry out your own virus checks
> before opening any attachment to this e-mail. The sender of this e-mail and
> *Fynarfin Tech Private Limited* shall not be liable for any damage that
> you may sustain as a result of viruses, incompleteness of this message, a
> delay in receipt of this message or computer problems experienced.
>
Re: Failing tests on develop...
Posted by Manoj VM <ma...@fynarfin.io>.
.. The issue is caused by this line in LoanCharge.java[image: Screenshot
2022-03-30 at 1.54.38 AM.png]
this looks like a snake eating its own tail. Kindly fix this.
Thanks and Regards,
Manoj
fynarfin.io
On Wed, Mar 30, 2022 at 12:57 AM Manoj VM <ma...@fynarfin.io> wrote:
>
> Absolutely right,
> the installment charges are getting cleared during the loan approval
> process.
>
> I am diving deep into this.
>
>
> Thanks and Regards,
> Manoj
> fynarfin.io
>
>
> On Tue, Mar 29, 2022 at 11:21 PM Aleksandar Vidakovic <
> cheetah@monkeysintown.com> wrote:
>
>> ... I'm a little further down the rabbit hole. So, this is where things
>> (for one of the errors at least) things start to break:
>>
>>
>> https://github.com/apache/fineract/blob/develop/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanWritePlatformServiceJpaRepositoryImpl.java#L976
>>
>> ... which in turn lands us here:
>>
>>
>> https://github.com/apache/fineract/blob/develop/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/LoanCharge.java#L861
>>
>> The function "getUnpaidInstallmentLoanCharge()" will return a null,
>> because the collection "loanInstallmentCharge" is empty.
>>
>> I have to admit that I'm not entirely sure about the business logic and
>> what should be where and when. The only thing I can say is that
>> "loanInstallmentCharge" should contain an entry and it doesn't.
>>
>> Would be great if someone with a better insight into the business logic
>> could chime in here.
>>
>> FYI
>>
>> On Tue, Mar 29, 2022 at 6:49 PM Aleksandar Vidakovic <
>> cheetah@monkeysintown.com> wrote:
>>
>>> ... alright, one of the failures is due to a NPE, but additionally the
>>> error object doesn't get populated properly. The part that should contain
>>> valid JSON is messed up and contains this:
>>>
>>> {"Exception": java.lang.NullPointerException: Cannot invoke
>>> "org.apache.fineract.portfolio.loanaccount.domain.LoanInstallmentCharge.updatePaidAmountBy(org.apache.fineract.organisation.monetary.domain.Money,
>>> org.apache.fineract.organisation.monetary.domain.Money)" because the return
>>> value of
>>> "org.apache.fineract.portfolio.loanaccount.domain.LoanCharge.getUnpaidInstallmentLoanCharge()"
>>> is null}
>>>
>>> ... which is obviously invalid JSON... which bubbles up at the REST
>>> endpoint.
>>>
>>> So there might be 2 problems here with that one error:
>>> - the NPE that triggers the error
>>> - ... and that the error object is not properly populated
>>>
>>> Just FYI
>>>
>>> On Tue, Mar 29, 2022 at 6:14 PM Aleksandar Vidakovic <
>>> cheetah@monkeysintown.com> wrote:
>>>
>>>> ... thanks a ton Manoj... I'm debugging too... will post if I know more.
>>>>
>>>> On Tue, Mar 29, 2022 at 5:53 PM Manoj VM <ma...@fynarfin.io> wrote:
>>>>
>>>>> Hi Team,
>>>>>
>>>>> Added a ticket to track this issue
>>>>> https://issues.apache.org/jira/browse/FINERACT-1557 and working on
>>>>> the same.
>>>>>
>>>>> Thanks and Regards,
>>>>> Manoj
>>>>> fynarfin.io
>>>>>
>>>>>
>>>>> On Tue, Mar 29, 2022 at 1:16 PM Aleksandar Vidakovic <
>>>>> cheetah@monkeysintown.com> wrote:
>>>>>
>>>>>> ... good point Arnold. Avik, Manoj: just waiting for the current
>>>>>> build (where these tests are disabled) to pass... hope you don't mind if we
>>>>>> revert the changes as Arnold said to unblock other PRs.
>>>>>>
>>>>>> If you need any help please let me know.
>>>>>>
>>>>>> Cheers,
>>>>>>
>>>>>> Aleks
>>>>>>
>>>>>> On Tue, Mar 29, 2022 at 9:35 AM Arnold Galovics <
>>>>>> galovicsarnold@gmail.com> wrote:
>>>>>>
>>>>>>> Hi Aleks, others,
>>>>>>>
>>>>>>> I see we have quite some things lined up to be merged so I'm
>>>>>>> proposing to revert the particular PR that broke the build. As soon as
>>>>>>> Manoj, Avik is able to fix the implementation, they can open a new PR to
>>>>>>> reapply the changes.
>>>>>>>
>>>>>>> I'd say let's unblock the build as soon as possible and let other
>>>>>>> changes come in instead of letting them pile up.
>>>>>>>
>>>>>>> Hope that makes sense.
>>>>>>> Best,
>>>>>>> Arnold
>>>>>>>
>>>>>>> On Tue, Mar 29, 2022 at 9:30 AM Aleksandar Vidakovic <
>>>>>>> cheetah@monkeysintown.com> wrote:
>>>>>>>
>>>>>>>> Hi Manoj, Avik,
>>>>>>>>
>>>>>>>> ... just sending you the stacktraces (please see attachment) I
>>>>>>>> could find for the failing tests... would be great if you could look at
>>>>>>>> this... appreciate it.
>>>>>>>>
>>>>>>>> Please let me know if there's anything I can do to help.
>>>>>>>>
>>>>>>>> Thanks again,
>>>>>>>>
>>>>>>>> Aleks
>>>>>>>>
>>>>>>>
>>>>> Disclaimer:
>>>>>
>>>>> Privileged & confidential information is contained in this message
>>>>> (including all attachments). If you are not an intended recipient of this
>>>>> message, please destroy this message immediately and kindly notify
>>>>> the sender by reply e-mail. Any unauthorised use or dissemination of
>>>>> this message in any manner whatsoever, in whole or in part, is strictly
>>>>> prohibited. This e-mail, including all attachments hereto, (i) is for
>>>>> discussion purposes only and shall not be deemed or construed to be a
>>>>> professional opinion unless expressly stated otherwise, and (ii) is not
>>>>> intended, written or sent to be used, and cannot and shall not be used, for
>>>>> any unlawful purpose. This communication, including any attachments, may
>>>>> not be free of viruses, interceptions or interference, and may not be
>>>>> compatible with your systems. You should carry out your own virus checks
>>>>> before opening any attachment to this e-mail. The sender of this e-mail and
>>>>> *Fynarfin Tech Private Limited* shall not be liable for any damage
>>>>> that you may sustain as a result of viruses, incompleteness of this
>>>>> message, a delay in receipt of this message or computer problems
>>>>> experienced.
>>>>>
>>>>
--
Disclaimer:
Privileged & confidential information is contained in this
message (including all attachments). If you are not an intended recipient
of this message, please destroy this message immediately and kindly notify
the sender by reply e-mail. Any unauthorised use or dissemination of this
message in any manner whatsoever, in whole or in part, is strictly
prohibited. This e-mail, including all attachments hereto, (i) is for
discussion purposes only and shall not be deemed or construed to be a
professional opinion unless expressly stated otherwise, and (ii) is not
intended, written or sent to be used, and cannot and shall not be used, for
any unlawful purpose. This communication, including any attachments, may
not be free of viruses, interceptions or interference, and may not be
compatible with your systems. You should carry out your own virus checks
before opening any attachment to this e-mail. The sender of this e-mail and
*Fynarfin Tech Private Limited* shall not be liable for any damage that
you may sustain as a result of viruses, incompleteness of this message, a
delay in receipt of this message or computer problems experienced.
Re: Failing tests on develop...
Posted by Manoj VM <ma...@fynarfin.io>.
Absolutely right,
the installment charges are getting cleared during the loan approval
process.
I am diving deep into this.
Thanks and Regards,
Manoj
fynarfin.io
On Tue, Mar 29, 2022 at 11:21 PM Aleksandar Vidakovic <
cheetah@monkeysintown.com> wrote:
> ... I'm a little further down the rabbit hole. So, this is where things
> (for one of the errors at least) things start to break:
>
>
> https://github.com/apache/fineract/blob/develop/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanWritePlatformServiceJpaRepositoryImpl.java#L976
>
> ... which in turn lands us here:
>
>
> https://github.com/apache/fineract/blob/develop/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/LoanCharge.java#L861
>
> The function "getUnpaidInstallmentLoanCharge()" will return a null,
> because the collection "loanInstallmentCharge" is empty.
>
> I have to admit that I'm not entirely sure about the business logic and
> what should be where and when. The only thing I can say is that
> "loanInstallmentCharge" should contain an entry and it doesn't.
>
> Would be great if someone with a better insight into the business logic
> could chime in here.
>
> FYI
>
> On Tue, Mar 29, 2022 at 6:49 PM Aleksandar Vidakovic <
> cheetah@monkeysintown.com> wrote:
>
>> ... alright, one of the failures is due to a NPE, but additionally the
>> error object doesn't get populated properly. The part that should contain
>> valid JSON is messed up and contains this:
>>
>> {"Exception": java.lang.NullPointerException: Cannot invoke
>> "org.apache.fineract.portfolio.loanaccount.domain.LoanInstallmentCharge.updatePaidAmountBy(org.apache.fineract.organisation.monetary.domain.Money,
>> org.apache.fineract.organisation.monetary.domain.Money)" because the return
>> value of
>> "org.apache.fineract.portfolio.loanaccount.domain.LoanCharge.getUnpaidInstallmentLoanCharge()"
>> is null}
>>
>> ... which is obviously invalid JSON... which bubbles up at the REST
>> endpoint.
>>
>> So there might be 2 problems here with that one error:
>> - the NPE that triggers the error
>> - ... and that the error object is not properly populated
>>
>> Just FYI
>>
>> On Tue, Mar 29, 2022 at 6:14 PM Aleksandar Vidakovic <
>> cheetah@monkeysintown.com> wrote:
>>
>>> ... thanks a ton Manoj... I'm debugging too... will post if I know more.
>>>
>>> On Tue, Mar 29, 2022 at 5:53 PM Manoj VM <ma...@fynarfin.io> wrote:
>>>
>>>> Hi Team,
>>>>
>>>> Added a ticket to track this issue
>>>> https://issues.apache.org/jira/browse/FINERACT-1557 and working on the
>>>> same.
>>>>
>>>> Thanks and Regards,
>>>> Manoj
>>>> fynarfin.io
>>>>
>>>>
>>>> On Tue, Mar 29, 2022 at 1:16 PM Aleksandar Vidakovic <
>>>> cheetah@monkeysintown.com> wrote:
>>>>
>>>>> ... good point Arnold. Avik, Manoj: just waiting for the current build
>>>>> (where these tests are disabled) to pass... hope you don't mind if we
>>>>> revert the changes as Arnold said to unblock other PRs.
>>>>>
>>>>> If you need any help please let me know.
>>>>>
>>>>> Cheers,
>>>>>
>>>>> Aleks
>>>>>
>>>>> On Tue, Mar 29, 2022 at 9:35 AM Arnold Galovics <
>>>>> galovicsarnold@gmail.com> wrote:
>>>>>
>>>>>> Hi Aleks, others,
>>>>>>
>>>>>> I see we have quite some things lined up to be merged so I'm
>>>>>> proposing to revert the particular PR that broke the build. As soon as
>>>>>> Manoj, Avik is able to fix the implementation, they can open a new PR to
>>>>>> reapply the changes.
>>>>>>
>>>>>> I'd say let's unblock the build as soon as possible and let other
>>>>>> changes come in instead of letting them pile up.
>>>>>>
>>>>>> Hope that makes sense.
>>>>>> Best,
>>>>>> Arnold
>>>>>>
>>>>>> On Tue, Mar 29, 2022 at 9:30 AM Aleksandar Vidakovic <
>>>>>> cheetah@monkeysintown.com> wrote:
>>>>>>
>>>>>>> Hi Manoj, Avik,
>>>>>>>
>>>>>>> ... just sending you the stacktraces (please see attachment) I could
>>>>>>> find for the failing tests... would be great if you could look at this...
>>>>>>> appreciate it.
>>>>>>>
>>>>>>> Please let me know if there's anything I can do to help.
>>>>>>>
>>>>>>> Thanks again,
>>>>>>>
>>>>>>> Aleks
>>>>>>>
>>>>>>
>>>> Disclaimer:
>>>>
>>>> Privileged & confidential information is contained in this message
>>>> (including all attachments). If you are not an intended recipient of this
>>>> message, please destroy this message immediately and kindly notify
>>>> the sender by reply e-mail. Any unauthorised use or dissemination of
>>>> this message in any manner whatsoever, in whole or in part, is strictly
>>>> prohibited. This e-mail, including all attachments hereto, (i) is for
>>>> discussion purposes only and shall not be deemed or construed to be a
>>>> professional opinion unless expressly stated otherwise, and (ii) is not
>>>> intended, written or sent to be used, and cannot and shall not be used, for
>>>> any unlawful purpose. This communication, including any attachments, may
>>>> not be free of viruses, interceptions or interference, and may not be
>>>> compatible with your systems. You should carry out your own virus checks
>>>> before opening any attachment to this e-mail. The sender of this e-mail and
>>>> *Fynarfin Tech Private Limited* shall not be liable for any damage
>>>> that you may sustain as a result of viruses, incompleteness of this
>>>> message, a delay in receipt of this message or computer problems
>>>> experienced.
>>>>
>>>
--
Disclaimer:
Privileged & confidential information is contained in this
message (including all attachments). If you are not an intended recipient
of this message, please destroy this message immediately and kindly notify
the sender by reply e-mail. Any unauthorised use or dissemination of this
message in any manner whatsoever, in whole or in part, is strictly
prohibited. This e-mail, including all attachments hereto, (i) is for
discussion purposes only and shall not be deemed or construed to be a
professional opinion unless expressly stated otherwise, and (ii) is not
intended, written or sent to be used, and cannot and shall not be used, for
any unlawful purpose. This communication, including any attachments, may
not be free of viruses, interceptions or interference, and may not be
compatible with your systems. You should carry out your own virus checks
before opening any attachment to this e-mail. The sender of this e-mail and
*Fynarfin Tech Private Limited* shall not be liable for any damage that
you may sustain as a result of viruses, incompleteness of this message, a
delay in receipt of this message or computer problems experienced.
Re: Failing tests on develop...
Posted by Aleksandar Vidakovic <ch...@monkeysintown.com>.
... I'm a little further down the rabbit hole. So, this is where things
(for one of the errors at least) things start to break:
https://github.com/apache/fineract/blob/develop/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanWritePlatformServiceJpaRepositoryImpl.java#L976
... which in turn lands us here:
https://github.com/apache/fineract/blob/develop/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/LoanCharge.java#L861
The function "getUnpaidInstallmentLoanCharge()" will return a null, because
the collection "loanInstallmentCharge" is empty.
I have to admit that I'm not entirely sure about the business logic and
what should be where and when. The only thing I can say is that
"loanInstallmentCharge" should contain an entry and it doesn't.
Would be great if someone with a better insight into the business logic
could chime in here.
FYI
On Tue, Mar 29, 2022 at 6:49 PM Aleksandar Vidakovic <
cheetah@monkeysintown.com> wrote:
> ... alright, one of the failures is due to a NPE, but additionally the
> error object doesn't get populated properly. The part that should contain
> valid JSON is messed up and contains this:
>
> {"Exception": java.lang.NullPointerException: Cannot invoke
> "org.apache.fineract.portfolio.loanaccount.domain.LoanInstallmentCharge.updatePaidAmountBy(org.apache.fineract.organisation.monetary.domain.Money,
> org.apache.fineract.organisation.monetary.domain.Money)" because the return
> value of
> "org.apache.fineract.portfolio.loanaccount.domain.LoanCharge.getUnpaidInstallmentLoanCharge()"
> is null}
>
> ... which is obviously invalid JSON... which bubbles up at the REST
> endpoint.
>
> So there might be 2 problems here with that one error:
> - the NPE that triggers the error
> - ... and that the error object is not properly populated
>
> Just FYI
>
> On Tue, Mar 29, 2022 at 6:14 PM Aleksandar Vidakovic <
> cheetah@monkeysintown.com> wrote:
>
>> ... thanks a ton Manoj... I'm debugging too... will post if I know more.
>>
>> On Tue, Mar 29, 2022 at 5:53 PM Manoj VM <ma...@fynarfin.io> wrote:
>>
>>> Hi Team,
>>>
>>> Added a ticket to track this issue
>>> https://issues.apache.org/jira/browse/FINERACT-1557 and working on the
>>> same.
>>>
>>> Thanks and Regards,
>>> Manoj
>>> fynarfin.io
>>>
>>>
>>> On Tue, Mar 29, 2022 at 1:16 PM Aleksandar Vidakovic <
>>> cheetah@monkeysintown.com> wrote:
>>>
>>>> ... good point Arnold. Avik, Manoj: just waiting for the current build
>>>> (where these tests are disabled) to pass... hope you don't mind if we
>>>> revert the changes as Arnold said to unblock other PRs.
>>>>
>>>> If you need any help please let me know.
>>>>
>>>> Cheers,
>>>>
>>>> Aleks
>>>>
>>>> On Tue, Mar 29, 2022 at 9:35 AM Arnold Galovics <
>>>> galovicsarnold@gmail.com> wrote:
>>>>
>>>>> Hi Aleks, others,
>>>>>
>>>>> I see we have quite some things lined up to be merged so I'm proposing
>>>>> to revert the particular PR that broke the build. As soon as Manoj, Avik is
>>>>> able to fix the implementation, they can open a new PR to reapply the
>>>>> changes.
>>>>>
>>>>> I'd say let's unblock the build as soon as possible and let other
>>>>> changes come in instead of letting them pile up.
>>>>>
>>>>> Hope that makes sense.
>>>>> Best,
>>>>> Arnold
>>>>>
>>>>> On Tue, Mar 29, 2022 at 9:30 AM Aleksandar Vidakovic <
>>>>> cheetah@monkeysintown.com> wrote:
>>>>>
>>>>>> Hi Manoj, Avik,
>>>>>>
>>>>>> ... just sending you the stacktraces (please see attachment) I could
>>>>>> find for the failing tests... would be great if you could look at this...
>>>>>> appreciate it.
>>>>>>
>>>>>> Please let me know if there's anything I can do to help.
>>>>>>
>>>>>> Thanks again,
>>>>>>
>>>>>> Aleks
>>>>>>
>>>>>
>>> Disclaimer:
>>>
>>> Privileged & confidential information is contained in this message
>>> (including all attachments). If you are not an intended recipient of this
>>> message, please destroy this message immediately and kindly notify
>>> the sender by reply e-mail. Any unauthorised use or dissemination of
>>> this message in any manner whatsoever, in whole or in part, is strictly
>>> prohibited. This e-mail, including all attachments hereto, (i) is for
>>> discussion purposes only and shall not be deemed or construed to be a
>>> professional opinion unless expressly stated otherwise, and (ii) is not
>>> intended, written or sent to be used, and cannot and shall not be used, for
>>> any unlawful purpose. This communication, including any attachments, may
>>> not be free of viruses, interceptions or interference, and may not be
>>> compatible with your systems. You should carry out your own virus checks
>>> before opening any attachment to this e-mail. The sender of this e-mail and
>>> *Fynarfin Tech Private Limited* shall not be liable for any damage that
>>> you may sustain as a result of viruses, incompleteness of this message, a
>>> delay in receipt of this message or computer problems experienced.
>>>
>>
Re: Failing tests on develop...
Posted by Aleksandar Vidakovic <ch...@monkeysintown.com>.
... alright, one of the failures is due to a NPE, but additionally the
error object doesn't get populated properly. The part that should contain
valid JSON is messed up and contains this:
{"Exception": java.lang.NullPointerException: Cannot invoke
"org.apache.fineract.portfolio.loanaccount.domain.LoanInstallmentCharge.updatePaidAmountBy(org.apache.fineract.organisation.monetary.domain.Money,
org.apache.fineract.organisation.monetary.domain.Money)" because the return
value of
"org.apache.fineract.portfolio.loanaccount.domain.LoanCharge.getUnpaidInstallmentLoanCharge()"
is null}
... which is obviously invalid JSON... which bubbles up at the REST
endpoint.
So there might be 2 problems here with that one error:
- the NPE that triggers the error
- ... and that the error object is not properly populated
Just FYI
On Tue, Mar 29, 2022 at 6:14 PM Aleksandar Vidakovic <
cheetah@monkeysintown.com> wrote:
> ... thanks a ton Manoj... I'm debugging too... will post if I know more.
>
> On Tue, Mar 29, 2022 at 5:53 PM Manoj VM <ma...@fynarfin.io> wrote:
>
>> Hi Team,
>>
>> Added a ticket to track this issue
>> https://issues.apache.org/jira/browse/FINERACT-1557 and working on the
>> same.
>>
>> Thanks and Regards,
>> Manoj
>> fynarfin.io
>>
>>
>> On Tue, Mar 29, 2022 at 1:16 PM Aleksandar Vidakovic <
>> cheetah@monkeysintown.com> wrote:
>>
>>> ... good point Arnold. Avik, Manoj: just waiting for the current build
>>> (where these tests are disabled) to pass... hope you don't mind if we
>>> revert the changes as Arnold said to unblock other PRs.
>>>
>>> If you need any help please let me know.
>>>
>>> Cheers,
>>>
>>> Aleks
>>>
>>> On Tue, Mar 29, 2022 at 9:35 AM Arnold Galovics <
>>> galovicsarnold@gmail.com> wrote:
>>>
>>>> Hi Aleks, others,
>>>>
>>>> I see we have quite some things lined up to be merged so I'm proposing
>>>> to revert the particular PR that broke the build. As soon as Manoj, Avik is
>>>> able to fix the implementation, they can open a new PR to reapply the
>>>> changes.
>>>>
>>>> I'd say let's unblock the build as soon as possible and let other
>>>> changes come in instead of letting them pile up.
>>>>
>>>> Hope that makes sense.
>>>> Best,
>>>> Arnold
>>>>
>>>> On Tue, Mar 29, 2022 at 9:30 AM Aleksandar Vidakovic <
>>>> cheetah@monkeysintown.com> wrote:
>>>>
>>>>> Hi Manoj, Avik,
>>>>>
>>>>> ... just sending you the stacktraces (please see attachment) I could
>>>>> find for the failing tests... would be great if you could look at this...
>>>>> appreciate it.
>>>>>
>>>>> Please let me know if there's anything I can do to help.
>>>>>
>>>>> Thanks again,
>>>>>
>>>>> Aleks
>>>>>
>>>>
>> Disclaimer:
>>
>> Privileged & confidential information is contained in this message
>> (including all attachments). If you are not an intended recipient of this
>> message, please destroy this message immediately and kindly notify
>> the sender by reply e-mail. Any unauthorised use or dissemination of this
>> message in any manner whatsoever, in whole or in part, is strictly
>> prohibited. This e-mail, including all attachments hereto, (i) is for
>> discussion purposes only and shall not be deemed or construed to be a
>> professional opinion unless expressly stated otherwise, and (ii) is not
>> intended, written or sent to be used, and cannot and shall not be used, for
>> any unlawful purpose. This communication, including any attachments, may
>> not be free of viruses, interceptions or interference, and may not be
>> compatible with your systems. You should carry out your own virus checks
>> before opening any attachment to this e-mail. The sender of this e-mail and
>> *Fynarfin Tech Private Limited* shall not be liable for any damage that
>> you may sustain as a result of viruses, incompleteness of this message, a
>> delay in receipt of this message or computer problems experienced.
>>
>
Re: Failing tests on develop...
Posted by Aleksandar Vidakovic <ch...@monkeysintown.com>.
... thanks a ton Manoj... I'm debugging too... will post if I know more.
On Tue, Mar 29, 2022 at 5:53 PM Manoj VM <ma...@fynarfin.io> wrote:
> Hi Team,
>
> Added a ticket to track this issue
> https://issues.apache.org/jira/browse/FINERACT-1557 and working on the
> same.
>
> Thanks and Regards,
> Manoj
> fynarfin.io
>
>
> On Tue, Mar 29, 2022 at 1:16 PM Aleksandar Vidakovic <
> cheetah@monkeysintown.com> wrote:
>
>> ... good point Arnold. Avik, Manoj: just waiting for the current build
>> (where these tests are disabled) to pass... hope you don't mind if we
>> revert the changes as Arnold said to unblock other PRs.
>>
>> If you need any help please let me know.
>>
>> Cheers,
>>
>> Aleks
>>
>> On Tue, Mar 29, 2022 at 9:35 AM Arnold Galovics <ga...@gmail.com>
>> wrote:
>>
>>> Hi Aleks, others,
>>>
>>> I see we have quite some things lined up to be merged so I'm proposing
>>> to revert the particular PR that broke the build. As soon as Manoj, Avik is
>>> able to fix the implementation, they can open a new PR to reapply the
>>> changes.
>>>
>>> I'd say let's unblock the build as soon as possible and let other
>>> changes come in instead of letting them pile up.
>>>
>>> Hope that makes sense.
>>> Best,
>>> Arnold
>>>
>>> On Tue, Mar 29, 2022 at 9:30 AM Aleksandar Vidakovic <
>>> cheetah@monkeysintown.com> wrote:
>>>
>>>> Hi Manoj, Avik,
>>>>
>>>> ... just sending you the stacktraces (please see attachment) I could
>>>> find for the failing tests... would be great if you could look at this...
>>>> appreciate it.
>>>>
>>>> Please let me know if there's anything I can do to help.
>>>>
>>>> Thanks again,
>>>>
>>>> Aleks
>>>>
>>>
> Disclaimer:
>
> Privileged & confidential information is contained in this message
> (including all attachments). If you are not an intended recipient of this
> message, please destroy this message immediately and kindly notify
> the sender by reply e-mail. Any unauthorised use or dissemination of this
> message in any manner whatsoever, in whole or in part, is strictly
> prohibited. This e-mail, including all attachments hereto, (i) is for
> discussion purposes only and shall not be deemed or construed to be a
> professional opinion unless expressly stated otherwise, and (ii) is not
> intended, written or sent to be used, and cannot and shall not be used, for
> any unlawful purpose. This communication, including any attachments, may
> not be free of viruses, interceptions or interference, and may not be
> compatible with your systems. You should carry out your own virus checks
> before opening any attachment to this e-mail. The sender of this e-mail and
> *Fynarfin Tech Private Limited* shall not be liable for any damage that
> you may sustain as a result of viruses, incompleteness of this message, a
> delay in receipt of this message or computer problems experienced.
>
Re: Failing tests on develop...
Posted by Manoj VM <ma...@fynarfin.io>.
Hi Team,
Added a ticket to track this issue
https://issues.apache.org/jira/browse/FINERACT-1557 and working on the same.
Thanks and Regards,
Manoj
fynarfin.io
On Tue, Mar 29, 2022 at 1:16 PM Aleksandar Vidakovic <
cheetah@monkeysintown.com> wrote:
> ... good point Arnold. Avik, Manoj: just waiting for the current build
> (where these tests are disabled) to pass... hope you don't mind if we
> revert the changes as Arnold said to unblock other PRs.
>
> If you need any help please let me know.
>
> Cheers,
>
> Aleks
>
> On Tue, Mar 29, 2022 at 9:35 AM Arnold Galovics <ga...@gmail.com>
> wrote:
>
>> Hi Aleks, others,
>>
>> I see we have quite some things lined up to be merged so I'm proposing to
>> revert the particular PR that broke the build. As soon as Manoj, Avik is
>> able to fix the implementation, they can open a new PR to reapply the
>> changes.
>>
>> I'd say let's unblock the build as soon as possible and let other changes
>> come in instead of letting them pile up.
>>
>> Hope that makes sense.
>> Best,
>> Arnold
>>
>> On Tue, Mar 29, 2022 at 9:30 AM Aleksandar Vidakovic <
>> cheetah@monkeysintown.com> wrote:
>>
>>> Hi Manoj, Avik,
>>>
>>> ... just sending you the stacktraces (please see attachment) I could
>>> find for the failing tests... would be great if you could look at this...
>>> appreciate it.
>>>
>>> Please let me know if there's anything I can do to help.
>>>
>>> Thanks again,
>>>
>>> Aleks
>>>
>>
--
Disclaimer:
Privileged & confidential information is contained in this
message (including all attachments). If you are not an intended recipient
of this message, please destroy this message immediately and kindly notify
the sender by reply e-mail. Any unauthorised use or dissemination of this
message in any manner whatsoever, in whole or in part, is strictly
prohibited. This e-mail, including all attachments hereto, (i) is for
discussion purposes only and shall not be deemed or construed to be a
professional opinion unless expressly stated otherwise, and (ii) is not
intended, written or sent to be used, and cannot and shall not be used, for
any unlawful purpose. This communication, including any attachments, may
not be free of viruses, interceptions or interference, and may not be
compatible with your systems. You should carry out your own virus checks
before opening any attachment to this e-mail. The sender of this e-mail and
*Fynarfin Tech Private Limited* shall not be liable for any damage that
you may sustain as a result of viruses, incompleteness of this message, a
delay in receipt of this message or computer problems experienced.
Re: Failing tests on develop...
Posted by Aleksandar Vidakovic <ch...@monkeysintown.com>.
... good point Arnold. Avik, Manoj: just waiting for the current build
(where these tests are disabled) to pass... hope you don't mind if we
revert the changes as Arnold said to unblock other PRs.
If you need any help please let me know.
Cheers,
Aleks
On Tue, Mar 29, 2022 at 9:35 AM Arnold Galovics <ga...@gmail.com>
wrote:
> Hi Aleks, others,
>
> I see we have quite some things lined up to be merged so I'm proposing to
> revert the particular PR that broke the build. As soon as Manoj, Avik is
> able to fix the implementation, they can open a new PR to reapply the
> changes.
>
> I'd say let's unblock the build as soon as possible and let other changes
> come in instead of letting them pile up.
>
> Hope that makes sense.
> Best,
> Arnold
>
> On Tue, Mar 29, 2022 at 9:30 AM Aleksandar Vidakovic <
> cheetah@monkeysintown.com> wrote:
>
>> Hi Manoj, Avik,
>>
>> ... just sending you the stacktraces (please see attachment) I could find
>> for the failing tests... would be great if you could look at this...
>> appreciate it.
>>
>> Please let me know if there's anything I can do to help.
>>
>> Thanks again,
>>
>> Aleks
>>
>
Re: Failing tests on develop...
Posted by Arnold Galovics <ga...@gmail.com>.
Hi Aleks, others,
I see we have quite some things lined up to be merged so I'm proposing to
revert the particular PR that broke the build. As soon as Manoj, Avik is
able to fix the implementation, they can open a new PR to reapply the
changes.
I'd say let's unblock the build as soon as possible and let other changes
come in instead of letting them pile up.
Hope that makes sense.
Best,
Arnold
On Tue, Mar 29, 2022 at 9:30 AM Aleksandar Vidakovic <
cheetah@monkeysintown.com> wrote:
> Hi Manoj, Avik,
>
> ... just sending you the stacktraces (please see attachment) I could find
> for the failing tests... would be great if you could look at this...
> appreciate it.
>
> Please let me know if there's anything I can do to help.
>
> Thanks again,
>
> Aleks
>