[GitHub] keith-turner commented on a change in pull request #902: fixes #894 merge SimpleConfiguration Objects

[gi...@git.apache.org]

keith-turner commented on a change in pull request #902: fixes #894 merge SimpleConfiguration Objects
URL: https://github.com/apache/fluo/pull/902#discussion_r131747961
 
 

 ##########
 File path: modules/api/src/main/java/org/apache/fluo/api/config/SimpleConfiguration.java
 ##########
 @@ -250,6 +277,22 @@ public SimpleConfiguration subset(String prefix) {
     return new SimpleConfiguration(internalConfig.subset(prefix));
   }
 
+  /**
+   * @param SimpleConfigs SimpleConfiguration's to be merged
+   * @return SimpleConfiguration
+   * 
+   * @since 1.2.0
+   */
+  public static SimpleConfiguration merge(SimpleConfiguration... simpleConfigs) {
+    SimpleConfiguration mrg = new SimpleConfiguration();
+    for (SimpleConfiguration sc : simpleConfigs) {
+      for (Map.Entry<String, String> entry : sc.toMap().entrySet()) {
+        mrg.addProperty(entry.getKey(), entry.getValue());
 
 Review comment:
   Maybe merge is the wrong name.  I was interested in method that chooses a value in a way that is defined in its javadoc.  For example, in the case where multiple simple configs have the same key could always take the value of the latest or earliest.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services