You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kyuubi.apache.org by GitBox <gi...@apache.org> on 2021/09/06 09:08:45 UTC

[GitHub] [incubator-kyuubi] zhang1002 opened a new pull request #1037: Add classification of SQL_Type: for dql and auxiliary statement

zhang1002 opened a new pull request #1037:
URL: https://github.com/apache/incubator-kyuubi/pull/1037


   This PR, we have two different of sql classification:
   - other:  all auxiliary statement fail into this classification
   - dql
   
   We support the user use the self-defined matching rule: sql-classification.json.
   If there have no this named jsonFile, the service will upload the default matching rule: sql-classification-default.json.
   
   ### _Why are the changes needed?_
   <!--
   Please clarify why the changes are needed. For instance,
     1. If you add a feature, you can talk about the use case of it.
     2. If you fix a bug, you can clarify why it is a bug.
   -->
   
   
   ### _How was this patch tested?_
   - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
   
   - [ ] Add screenshots for manual tests if appropriate
   
   - [ ] [Run test](https://kyuubi.readthedocs.io/en/latest/develop_tools/testing.html#running-tests) locally before make a pull request
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1037: Add classification of SQL_Type: for dql and auxiliary statement

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1037:
URL: https://github.com/apache/incubator-kyuubi/pull/1037#issuecomment-913945391


   # [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1037](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a73941e) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/c1e5545c648fbd9d62c562014447eea205849094?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c1e5545) will **increase** coverage by `0.09%`.
   > The diff coverage is `100.00%`.
   
   > :exclamation: Current head a73941e differs from pull request most recent head 9d346c6. Consider uploading reports for the commit 9d346c6 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/graphs/tree.svg?width=650&height=150&src=pr&token=925D4tb9AH&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1037      +/-   ##
   ============================================
   + Coverage     78.42%   78.51%   +0.09%     
   - Complexity       61       74      +13     
   ============================================
     Files           167      169       +2     
     Lines          6196     6464     +268     
     Branches        723      754      +31     
   ============================================
   + Hits           4859     5075     +216     
   - Misses          915      963      +48     
   - Partials        422      426       +4     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...sqlclassification/KyuubiGetSqlClassification.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstMy0xL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9zcWxjbGFzc2lmaWNhdGlvbi9LeXV1YmlHZXRTcWxDbGFzc2lmaWNhdGlvbi5zY2FsYQ==) | `77.77% <100.00%> (+4.44%)` | :arrow_up: |
   | [...g/apache/kyuubi/session/KyuubiSessionManager.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXNzaW9uL0t5dXViaVNlc3Npb25NYW5hZ2VyLnNjYWxh) | `95.00% <0.00%> (-2.06%)` | :arrow_down: |
   | [...org/apache/kyuubi/server/RestFrontendService.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvUmVzdEZyb250ZW5kU2VydmljZS5zY2FsYQ==) | `82.75% <0.00%> (-1.86%)` | :arrow_down: |
   | [.../apache/kyuubi/server/api/v1/ApiRootResource.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvYXBpL3YxL0FwaVJvb3RSZXNvdXJjZS5zY2FsYQ==) | `100.00% <0.00%> (ø)` | |
   | [...pache/kyuubi/sql/KyuubiQueryStagePreparation.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstMy0xL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9LeXV1YmlRdWVyeVN0YWdlUHJlcGFyYXRpb24uc2NhbGE=) | `80.39% <0.00%> (ø)` | |
   | [...kyuubi/engine/spark/session/SparkSessionImpl.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1zcGFyay1zcWwtZW5naW5lL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2VuZ2luZS9zcGFyay9zZXNzaW9uL1NwYXJrU2Vzc2lvbkltcGwuc2NhbGE=) | `100.00% <0.00%> (ø)` | |
   | [...e/kyuubi/server/api/v1/dto/SessionOpenedCount.java](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3l1dWJpL3NlcnZlci9hcGkvdjEvZHRvL1Nlc3Npb25PcGVuZWRDb3VudC5qYXZh) | `100.00% <0.00%> (ø)` | |
   | [...apache/kyuubi/server/api/v1/SessionsResource.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvYXBpL3YxL1Nlc3Npb25zUmVzb3VyY2Uuc2NhbGE=) | `100.00% <0.00%> (ø)` | |
   | [...la/org/apache/kyuubi/session/AbstractSession.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXNzaW9uL0Fic3RyYWN0U2Vzc2lvbi5zY2FsYQ==) | `97.08% <0.00%> (+1.57%)` | :arrow_up: |
   | [.../scala/org/apache/kyuubi/server/KyuubiServer.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvS3l1dWJpU2VydmVyLnNjYWxh) | `58.69% <0.00%> (+2.17%)` | :arrow_up: |
   | ... and [7 more](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [c1e5545...9d346c6](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1037: Add classification of SQL_Type: for dql and auxiliary statement

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1037:
URL: https://github.com/apache/incubator-kyuubi/pull/1037#issuecomment-913945391


   # [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1037](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e6f9b6b) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/c1e5545c648fbd9d62c562014447eea205849094?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c1e5545) will **increase** coverage by `0.01%`.
   > The diff coverage is `100.00%`.
   
   > :exclamation: Current head e6f9b6b differs from pull request most recent head d7f7538. Consider uploading reports for the commit d7f7538 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/graphs/tree.svg?width=650&height=150&src=pr&token=925D4tb9AH&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1037      +/-   ##
   ============================================
   + Coverage     78.42%   78.43%   +0.01%     
     Complexity       61       61              
   ============================================
     Files           167      167              
     Lines          6196     6199       +3     
     Branches        723      723              
   ============================================
   + Hits           4859     4862       +3     
     Misses          915      915              
     Partials        422      422              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...sqlclassification/KyuubiGetSqlClassification.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstMy0xL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9zcWxjbGFzc2lmaWNhdGlvbi9LeXV1YmlHZXRTcWxDbGFzc2lmaWNhdGlvbi5zY2FsYQ==) | `77.77% <100.00%> (+4.44%)` | :arrow_up: |
   | [...pache/kyuubi/sql/KyuubiQueryStagePreparation.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstMy0xL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9LeXV1YmlRdWVyeVN0YWdlUHJlcGFyYXRpb24uc2NhbGE=) | `80.39% <0.00%> (ø)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [c1e5545...d7f7538](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1037: Add classification of SQL_Type: for dql and auxiliary statement

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1037:
URL: https://github.com/apache/incubator-kyuubi/pull/1037#issuecomment-913945391


   # [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1037](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (72a18ec) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/c1e5545c648fbd9d62c562014447eea205849094?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c1e5545) will **increase** coverage by `0.09%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/graphs/tree.svg?width=650&height=150&src=pr&token=925D4tb9AH&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1037      +/-   ##
   ============================================
   + Coverage     78.42%   78.51%   +0.09%     
   - Complexity       61       81      +20     
   ============================================
     Files           167      169       +2     
     Lines          6196     6464     +268     
     Branches        723      754      +31     
   ============================================
   + Hits           4859     5075     +216     
   - Misses          915      963      +48     
   - Partials        422      426       +4     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...sqlclassification/KyuubiGetSqlClassification.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstMy0xL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9zcWxjbGFzc2lmaWNhdGlvbi9LeXV1YmlHZXRTcWxDbGFzc2lmaWNhdGlvbi5zY2FsYQ==) | `77.77% <100.00%> (+4.44%)` | :arrow_up: |
   | [...g/apache/kyuubi/session/KyuubiSessionManager.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXNzaW9uL0t5dXViaVNlc3Npb25NYW5hZ2VyLnNjYWxh) | `95.00% <0.00%> (-2.06%)` | :arrow_down: |
   | [...org/apache/kyuubi/server/RestFrontendService.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvUmVzdEZyb250ZW5kU2VydmljZS5zY2FsYQ==) | `82.75% <0.00%> (-1.86%)` | :arrow_down: |
   | [.../apache/kyuubi/server/api/v1/ApiRootResource.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvYXBpL3YxL0FwaVJvb3RSZXNvdXJjZS5zY2FsYQ==) | `100.00% <0.00%> (ø)` | |
   | [...pache/kyuubi/sql/KyuubiQueryStagePreparation.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstMy0xL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9LeXV1YmlRdWVyeVN0YWdlUHJlcGFyYXRpb24uc2NhbGE=) | `80.39% <0.00%> (ø)` | |
   | [...kyuubi/engine/spark/session/SparkSessionImpl.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1zcGFyay1zcWwtZW5naW5lL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2VuZ2luZS9zcGFyay9zZXNzaW9uL1NwYXJrU2Vzc2lvbkltcGwuc2NhbGE=) | `100.00% <0.00%> (ø)` | |
   | [...e/kyuubi/server/api/v1/dto/SessionOpenedCount.java](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3l1dWJpL3NlcnZlci9hcGkvdjEvZHRvL1Nlc3Npb25PcGVuZWRDb3VudC5qYXZh) | `100.00% <0.00%> (ø)` | |
   | [...apache/kyuubi/server/api/v1/SessionsResource.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvYXBpL3YxL1Nlc3Npb25zUmVzb3VyY2Uuc2NhbGE=) | `100.00% <0.00%> (ø)` | |
   | [...la/org/apache/kyuubi/session/AbstractSession.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXNzaW9uL0Fic3RyYWN0U2Vzc2lvbi5zY2FsYQ==) | `97.08% <0.00%> (+1.57%)` | :arrow_up: |
   | [.../scala/org/apache/kyuubi/server/KyuubiServer.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvS3l1dWJpU2VydmVyLnNjYWxh) | `58.69% <0.00%> (+2.17%)` | :arrow_up: |
   | ... and [7 more](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [c1e5545...72a18ec](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-kyuubi] zhang1002 commented on a change in pull request #1037: Add classification of SQL_Type: for dql and auxiliary statement

Posted by GitBox <gi...@apache.org>.
zhang1002 commented on a change in pull request #1037:
URL: https://github.com/apache/incubator-kyuubi/pull/1037#discussion_r703479165



##########
File path: dev/kyuubi-extension-spark-3-1/src/test/scala/org/apache/spark/sql/KyuubiExtensionSuite.scala
##########
@@ -1026,4 +1046,402 @@ class KyuubiExtensionSuite extends QueryTest with SQLTestUtils with AdaptiveSpar
       }
     }
   }
+
+  test("get simple name for auxiliary statement") {
+    val auxiStatementSimpleName: Set[String] = Set()
+
+    var pre_sql = "CREATE TABLE IF NOT EXISTS students_testtest " +
+      "(name STRING, student_id INT) PARTITIONED BY (student_id);"
+    spark.sql(pre_sql)
+    pre_sql = "INSERT INTO students_testtest PARTITION (student_id = 111111) VALUES ('Mark');"
+    spark.sql(pre_sql)
+    pre_sql = "INSERT INTO students_testtest PARTITION (student_id = 222222) VALUES ('John');"
+    spark.sql(pre_sql)
+
+    val sql01 = "ANALYZE TABLE students_testtest COMPUTE STATISTICS NOSCAN;"
+    auxiStatementSimpleName.add(
+      spark.sessionState.analyzer.execute(
+        spark.sessionState.sqlParser.parsePlan(sql01)
+      ).getClass.getSimpleName
+    )
+
+    val sql48 = "ANALYZE TABLE students_testtest PARTITION " +
+      "(student_id = 111111) COMPUTE STATISTICS;"
+    auxiStatementSimpleName.add(
+      spark.sessionState.analyzer.execute(
+        spark.sessionState.sqlParser.parsePlan(sql48)
+      ).getClass.getSimpleName
+    )
+
+    val sql49 = "ANALYZE TABLE students_testtest COMPUTE STATISTICS FOR COLUMNS name;"
+    auxiStatementSimpleName.add(
+      spark.sessionState.analyzer.execute(
+        spark.sessionState.sqlParser.parsePlan(sql49)
+      ).getClass.getSimpleName
+    )
+
+    val sql29 = "SHOW PARTITIONS students_testtest;"
+    auxiStatementSimpleName.add(
+      spark.sessionState.analyzer.execute(
+        spark.sessionState.sqlParser.parsePlan(sql29)
+      ).getClass.getSimpleName
+    )
+
+    val sql30 = "SHOW PARTITIONS students_testtest PARTITION (student_id = 111111);"
+    auxiStatementSimpleName.add(
+      spark.sessionState.analyzer.execute(
+        spark.sessionState.sqlParser.parsePlan(sql30)
+      ).getClass.getSimpleName
+    )
+
+    val sql31 = "SHOW TABLE EXTENDED LIKE 'students_testtest';"
+    auxiStatementSimpleName.add(
+      spark.sessionState.analyzer.execute(
+        spark.sessionState.sqlParser.parsePlan(sql31)
+      ).getClass.getSimpleName
+    )
+
+    val sql32 = "SHOW TABLES;"
+    auxiStatementSimpleName.add(
+      spark.sessionState.analyzer.execute(
+        spark.sessionState.sqlParser.parsePlan(sql32)
+      ).getClass.getSimpleName
+    )
+
+    val sql33 = "SHOW TABLES FROM default;"
+    auxiStatementSimpleName.add(
+      spark.sessionState.analyzer.execute(
+        spark.sessionState.sqlParser.parsePlan(sql33)
+      ).getClass.getSimpleName
+    )
+
+    val sql02 = "CACHE TABLE testCache OPTIONS ('storageLevel' 'DISK_ONLY') " +
+      "SELECT * FROM students_testtest;"
+    auxiStatementSimpleName.add(
+      spark.sessionState.analyzer.execute(
+        spark.sessionState.sqlParser.parsePlan(sql02)
+      ).getClass.getSimpleName
+    )
+
+    val sql03 = "CACHE LAZY TABLE testCache OPTIONS ('storageLevel' 'DISK_ONLY') " +
+      "SELECT * FROM students_testtest;"
+    auxiStatementSimpleName.add(
+      spark.sessionState.analyzer.execute(
+        spark.sessionState.sqlParser.parsePlan(sql03)
+      ).getClass.getSimpleName
+    )
+
+    val sql09 = "REFRESH \"hdfs://path/to/table\""
+    auxiStatementSimpleName.add(
+      spark.sessionState.analyzer.execute(
+        spark.sessionState.sqlParser.parsePlan(sql09)
+      ).getClass.getSimpleName
+    )
+
+    val sql04 = "UNCACHE TABLE IF EXISTS testCache;"
+    auxiStatementSimpleName.add(
+      spark.sessionState.analyzer.execute(
+        spark.sessionState.sqlParser.parsePlan(sql04)
+      ).getClass.getSimpleName
+    )
+
+    val sql05 = "CLEAR CACHE;"
+    auxiStatementSimpleName.add(
+      spark.sessionState.analyzer.execute(
+        spark.sessionState.sqlParser.parsePlan(sql05)
+      ).getClass.getSimpleName
+    )
+
+    val sql06 = "REFRESH TABLE students_testtest;"
+    auxiStatementSimpleName.add(
+      spark.sessionState.analyzer.execute(
+        spark.sessionState.sqlParser.parsePlan(sql06)
+      ).getClass.getSimpleName
+    )
+
+    pre_sql = "CREATE OR REPLACE VIEW students_testtest_view " +
+      "AS SELECT name, student_id FROM students_testtest;"
+    spark.sql(pre_sql)
+    val sql07 = "REFRESH TABLE default.students_testtest_view;"
+    auxiStatementSimpleName.add(
+      spark.sessionState.analyzer.execute(
+        spark.sessionState.sqlParser.parsePlan(sql07)
+      ).getClass.getSimpleName
+    )
+
+    val sql35 = "SHOW VIEWS;"
+    auxiStatementSimpleName.add(
+      spark.sessionState.analyzer.execute(
+        spark.sessionState.sqlParser.parsePlan(sql35)
+      ).getClass.getSimpleName
+    )
+
+    pre_sql = "DROP VIEW IF EXISTS students_testtest_view;"
+    spark.sql(pre_sql)
+
+    pre_sql = "CREATE FUNCTION IF NOT EXISTS test_avg AS " +
+      "'org.apache.hadoop.hive.ql.udf.generic.GenericUDAFAverage';"
+    spark.sql(pre_sql)
+    val sql08 = "REFRESH FUNCTION test_avg;"
+    auxiStatementSimpleName.add(
+      spark.sessionState.analyzer.execute(
+        spark.sessionState.sqlParser.parsePlan(sql08)
+      ).getClass.getSimpleName
+    )
+
+    val sql15 = "DESC FUNCTION test_avg;"
+    auxiStatementSimpleName.add(
+      spark.sessionState.analyzer.execute(
+        spark.sessionState.sqlParser.parsePlan(sql15)
+      ).getClass.getSimpleName
+    )
+
+    val sql26 = "SHOW FUNCTIONS test_avg;"
+    auxiStatementSimpleName.add(
+      spark.sessionState.analyzer.execute(
+        spark.sessionState.sqlParser.parsePlan(sql26)
+      ).getClass.getSimpleName
+    )
+
+    val sql27 = "SHOW SYSTEM FUNCTIONS concat;"
+    auxiStatementSimpleName.add(
+      spark.sessionState.analyzer.execute(
+        spark.sessionState.sqlParser.parsePlan(sql27)
+      ).getClass.getSimpleName
+    )
+
+    val sql28 = "SHOW FUNCTIONS LIKE 'test*';"
+    auxiStatementSimpleName.add(
+      spark.sessionState.analyzer.execute(
+        spark.sessionState.sqlParser.parsePlan(sql28)
+      ).getClass.getSimpleName
+    )
+
+    pre_sql = "DROP FUNCTION IF EXISTS test_avg;"
+    spark.sql(pre_sql)
+
+    pre_sql = "CREATE DATABASE IF NOT EXISTS employees COMMENT 'For software companies';"
+    spark.sql(pre_sql)
+    val sql10 = "DESCRIBE DATABASE employees;"
+    auxiStatementSimpleName.add(
+      spark.sessionState.analyzer.execute(
+        spark.sessionState.sqlParser.parsePlan(sql10)
+      ).getClass.getSimpleName
+    )
+
+    val sql23 = "SHOW DATABASES;"
+    auxiStatementSimpleName.add(
+      spark.sessionState.analyzer.execute(
+        spark.sessionState.sqlParser.parsePlan(sql23)
+      ).getClass.getSimpleName
+    )
+
+    val sql24 = "SHOW DATABASES LIKE 'employ*';"
+    auxiStatementSimpleName.add(
+      spark.sessionState.analyzer.execute(
+        spark.sessionState.sqlParser.parsePlan(sql24)
+      ).getClass.getSimpleName
+    )
+
+    val sql25 = "SHOW SCHEMAS;"
+    auxiStatementSimpleName.add(
+      spark.sessionState.analyzer.execute(
+        spark.sessionState.sqlParser.parsePlan(sql25)
+      ).getClass.getSimpleName
+    )
+
+    pre_sql = "ALTER DATABASE employees SET DBPROPERTIES " +
+      "('Create-by' = 'Kevin', 'Create-date' = '09/01/2019');"
+    val sql11 = "DESCRIBE DATABASE EXTENDED employees;"
+    auxiStatementSimpleName.add(
+      spark.sessionState.analyzer.execute(
+        spark.sessionState.sqlParser.parsePlan(sql11)
+      ).getClass.getSimpleName
+    )
+    pre_sql = "DROP DATABASE IF EXISTS employees;"
+    spark.sql(pre_sql)
+
+    pre_sql = "CREATE TABLE IF NOT EXISTS customer" +
+      "(cust_id INT, state VARCHAR(20), name STRING COMMENT 'Short name') " +
+      "USING parquet PARTITIONED BY (state);"
+    spark.sql(pre_sql)
+    pre_sql = "INSERT INTO customer PARTITION (state = 'AR') VALUES (100, 'Mike');"
+    val sql12 = "DESCRIBE TABLE customer;"
+    auxiStatementSimpleName.add(
+      spark.sessionState.analyzer.execute(
+        spark.sessionState.sqlParser.parsePlan(sql12)
+      ).getClass.getSimpleName
+    )
+
+    val sql21 = "SHOW COLUMNS IN customer;"
+    auxiStatementSimpleName.add(
+      spark.sessionState.analyzer.execute(
+        spark.sessionState.sqlParser.parsePlan(sql21)
+      ).getClass.getSimpleName
+    )
+
+    val sql22 = "SHOW CREATE TABLE customer;"
+    auxiStatementSimpleName.add(
+      spark.sessionState.analyzer.execute(
+        spark.sessionState.sqlParser.parsePlan(sql22)
+      ).getClass.getSimpleName
+    )
+
+    val sql13 = "DESCRIBE TABLE EXTENDED customer PARTITION (state = 'AR');"
+    auxiStatementSimpleName.add(
+      spark.sessionState.analyzer.execute(
+        spark.sessionState.sqlParser.parsePlan(sql13)
+      ).getClass.getSimpleName
+    )
+
+    val sql14 = "DESCRIBE customer salesdb.customer.name;"
+    auxiStatementSimpleName.add(
+      spark.sessionState.analyzer.execute(
+        spark.sessionState.sqlParser.parsePlan(sql14)
+      ).getClass.getSimpleName
+    )
+    pre_sql = "DROP TABLE IF EXISTS customer;"
+    spark.sql(pre_sql)
+
+    pre_sql = "CREATE TABLE IF NOT EXISTS person " +
+      "(name STRING , age INT COMMENT 'Age column', address STRING);"
+    spark.sql(pre_sql)
+    val sql16 = "DESCRIBE QUERY SELECT age, sum(age) FROM person GROUP BY age;"
+    auxiStatementSimpleName.add(
+      spark.sessionState.analyzer.execute(
+        spark.sessionState.sqlParser.parsePlan(sql16)
+      ).getClass.getSimpleName
+    )
+
+    val sql17 = "DESCRIBE QUERY WITH all_names_cte AS " +
+      "(SELECT name from person) SELECT * FROM all_names_cte;"
+    auxiStatementSimpleName.add(
+      spark.sessionState.analyzer.execute(
+        spark.sessionState.sqlParser.parsePlan(sql17)
+      ).getClass.getSimpleName
+    )
+
+    val sql18 = "DESC QUERY VALUES(100, 'John', 10000.20D) " +
+      "AS employee(id, name, salary);"
+    auxiStatementSimpleName.add(
+      spark.sessionState.analyzer.execute(
+        spark.sessionState.sqlParser.parsePlan(sql18)
+      ).getClass.getSimpleName
+    )
+
+    val sql19 = "DESC QUERY TABLE person;"
+    auxiStatementSimpleName.add(
+      spark.sessionState.analyzer.execute(
+        spark.sessionState.sqlParser.parsePlan(sql19)
+      ).getClass.getSimpleName
+    )
+
+    val sql20 = "DESCRIBE FROM person SELECT age;"
+    auxiStatementSimpleName.add(
+      spark.sessionState.analyzer.execute(
+        spark.sessionState.sqlParser.parsePlan(sql20)
+      ).getClass.getSimpleName
+    )
+    pre_sql = "DROP TABLE IF EXISTS person;"
+    spark.sql(pre_sql)
+
+    pre_sql = "CREATE TABLE IF NOT EXISTS customer" +
+      "(cust_code INT, name VARCHAR(100), cust_addr STRING) " +
+      "TBLPROPERTIES ('created.by.user' = 'John', 'created.date' = '01-01-2001');"
+    spark.sql(pre_sql)
+    val sql34 = "SHOW TBLPROPERTIES customer;"
+    auxiStatementSimpleName.add(
+      spark.sessionState.analyzer.execute(
+        spark.sessionState.sqlParser.parsePlan(sql34)
+      ).getClass.getSimpleName
+    )
+
+    val sql36 = "SET spark.sql.variable.substitute=false"
+    auxiStatementSimpleName.add(
+      spark.sessionState.analyzer.execute(
+        spark.sessionState.sqlParser.parsePlan(sql36)
+      ).getClass.getSimpleName
+    )
+
+    val sql37 = "SET"
+    auxiStatementSimpleName.add(
+      spark.sessionState.analyzer.execute(
+        spark.sessionState.sqlParser.parsePlan(sql37)
+      ).getClass.getSimpleName
+    )
+
+    val sql38 = "SET spark.sql.variable.substitute"
+    auxiStatementSimpleName.add(
+      spark.sessionState.analyzer.execute(
+        spark.sessionState.sqlParser.parsePlan(sql38)
+      ).getClass.getSimpleName
+    )
+
+    val sql39 = "RESET"
+    auxiStatementSimpleName.add(
+      spark.sessionState.analyzer.execute(
+        spark.sessionState.sqlParser.parsePlan(sql39)
+      ).getClass.getSimpleName
+    )
+
+    val sql40 = "RESET spark.sql.variable.substitute"
+    auxiStatementSimpleName.add(
+      spark.sessionState.analyzer.execute(
+        spark.sessionState.sqlParser.parsePlan(sql40)
+      ).getClass.getSimpleName
+    )
+
+    val sql41 = "SET TIME ZONE LOCAL;"
+    auxiStatementSimpleName.add(
+      spark.sessionState.analyzer.execute(
+        spark.sessionState.sqlParser.parsePlan(sql41)
+      ).getClass.getSimpleName
+    )
+
+    val sql42 = "ADD FILE /tmp/test;"
+    auxiStatementSimpleName.add(
+      spark.sessionState.analyzer.execute(
+        spark.sessionState.sqlParser.parsePlan(sql42)
+      ).getClass.getSimpleName
+    )
+
+    val sql43 = "ADD JAR /tmp/test.jar;"
+    auxiStatementSimpleName.add(
+      spark.sessionState.analyzer.execute(
+        spark.sessionState.sqlParser.parsePlan(sql43)
+      ).getClass.getSimpleName
+    )
+
+    val sql44 = "LIST FILE;"
+    auxiStatementSimpleName.add(
+      spark.sessionState.analyzer.execute(
+        spark.sessionState.sqlParser.parsePlan(sql44)
+      ).getClass.getSimpleName
+    )
+
+    val sql45 = "LIST JAR;"
+    auxiStatementSimpleName.add(
+      spark.sessionState.analyzer.execute(
+        spark.sessionState.sqlParser.parsePlan(sql45)
+      ).getClass.getSimpleName
+    )
+
+    val sql46 = "EXPLAIN select k, sum(v) from values (1, 2), (1, 3) t(k, v) group by k;"
+    auxiStatementSimpleName.add(
+      spark.sessionState.analyzer.execute(
+        spark.sessionState.sqlParser.parsePlan(sql46)
+      ).getClass.getSimpleName
+    )
+
+    val sql47 = "EXPLAIN EXTENDED select k, sum(v) from values (1, 2), (1, 3) t(k, v) group by k;"
+    auxiStatementSimpleName.add(
+      spark.sessionState.analyzer.execute(
+        spark.sessionState.sqlParser.parsePlan(sql47)
+      ).getClass.getSimpleName
+    )
+
+    // scalastyle:off println
+    println("auxiliary statement simple name is :" + auxiStatementSimpleName.toSeq.sorted)

Review comment:
       this ut is just for me to check the plan and get their simpleName.
   Then I use those result set to generat the jsonFile.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1037: Add classification of SQL_Type: for dql and auxiliary statement

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1037:
URL: https://github.com/apache/incubator-kyuubi/pull/1037#issuecomment-913945391


   # [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1037](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e636adb) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/888651353482ba49abe7c8077ac478ec795e2b97?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8886513) will **increase** coverage by `0.03%`.
   > The diff coverage is `88.88%`.
   
   > :exclamation: Current head e636adb differs from pull request most recent head e6e9e90. Consider uploading reports for the commit e6e9e90 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/graphs/tree.svg?width=650&height=150&src=pr&token=925D4tb9AH&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1037      +/-   ##
   ============================================
   + Coverage     78.57%   78.61%   +0.03%     
     Complexity       71       71              
   ============================================
     Files           170      170              
     Lines          6277     6284       +7     
     Branches        725      726       +1     
   ============================================
   + Hits           4932     4940       +8     
     Misses          920      920              
   + Partials        425      424       -1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...sqlclassification/KyuubiGetSqlClassification.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstMy0xL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9zcWxjbGFzc2lmaWNhdGlvbi9LeXV1YmlHZXRTcWxDbGFzc2lmaWNhdGlvbi5zY2FsYQ==) | `77.27% <88.88%> (+3.93%)` | :arrow_up: |
   | [...pache/kyuubi/sql/KyuubiQueryStagePreparation.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstMy0xL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9LeXV1YmlRdWVyeVN0YWdlUHJlcGFyYXRpb24uc2NhbGE=) | `80.39% <0.00%> (+0.98%)` | :arrow_up: |
   | [...n/scala/org/apache/kyuubi/engine/ProcBuilder.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9lbmdpbmUvUHJvY0J1aWxkZXIuc2NhbGE=) | `92.20% <0.00%> (+1.29%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [8886513...e6e9e90](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-kyuubi] ulysses-you commented on pull request #1037: Add classification of SQL_Type: for dql and auxiliary statement

Posted by GitBox <gi...@apache.org>.
ulysses-you commented on pull request #1037:
URL: https://github.com/apache/incubator-kyuubi/pull/1037#issuecomment-913929856


   @zhang1002  please fix the conflict, thank you !


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-kyuubi] zhang1002 commented on a change in pull request #1037: Add classification of SQL_Type: for dql and auxiliary statement

Posted by GitBox <gi...@apache.org>.
zhang1002 commented on a change in pull request #1037:
URL: https://github.com/apache/incubator-kyuubi/pull/1037#discussion_r703437070



##########
File path: dev/kyuubi-extension-spark-3-1/src/test/resources/sql-classification-default.json
##########
@@ -1,34 +1,60 @@
 {
   "AlterDatabasePropertiesCommand": "ddl",
-  "AlterTableRenameCommand": "ddl",
-  "AlterTableRenamePartitionCommand": "ddl",
   "AlterTableAddColumnsCommand": "ddl",
-  "AlterTableChangeColumnCommand": "ddl",
   "AlterTableAddPartitionCommand": "ddl",
+  "AlterTableChangeColumnCommand": "ddl",
   "AlterTableDropPartitionCommand": "ddl",
-  "AlterTableSetPropertiesCommand": "ddl",
-  "AlterTableSetLocationCommand": "ddl",
-  "AlterTableSerDePropertiesCommand": "ddl",
-  "AlterTableUnsetPropertiesCommand": "ddl",
+  "AlterTableRecoverPartitionsCommand": "ddl",
+  "AlterTableRenameCommand": "ddl",
   "AlterTableRenameCommand": "ddl",
+  "AlterTableRenamePartitionCommand": "ddl",
+  "AlterTableSerDePropertiesCommand": "ddl",
+  "AlterTableSetLocationCommand": "ddl",
   "AlterTableSetPropertiesCommand": "ddl",
+  "AlterTableSetPropertiesCommand": "ddl",
+  "AlterTableUnsetPropertiesCommand": "ddl",
   "AlterTableUnsetPropertiesCommand": "ddl",
   "AlterViewAsCommand": "ddl",
+  "CreateDataSourceTableAsSelectCommand": "ddl",
+  "CreateDataSourceTableCommand": "ddl",
   "CreateDatabaseCommand": "ddl",
   "CreateFunctionCommand": "ddl",
-  "CreateDataSourceTableCommand": "ddl",
-  "CreateDataSourceTableAsSelectCommand": "ddl",
   "CreateTableLikeCommand": "ddl",
   "CreateViewCommand": "ddl",
   "DropDatabaseCommand": "ddl",
   "DropFunctionCommand": "ddl",
-  "NoopDropTable": "ddl",
   "DropTableCommand": "ddl",
-  "TruncateTableCommand": "ddl",
-  "AlterTableRecoverPartitionsCommand": "ddl",
+  "NoopDropTable": "ddl",
   "SetCatalogAndNamespace": "ddl",
+  "TruncateTableCommand": "ddl",
+  "InsertIntoDataSourceDirCommand": "dml",
   "InsertIntoHadoopFsRelationCommand": "dml",
+  "InsertIntoHiveDirCommand": "dml",
   "LoadDataCommand": "dml",
-  "InsertIntoDataSourceDirCommand": "dml",
-  "InsertIntoHiveDirCommand": "dml"
+  "AddFileCommand": "other",
+  "AddJarCommand": "other",
+  "AnalyzeTable": "other",

Review comment:
       done.
   and add AnalyzePartitionCommand




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-kyuubi] ulysses-you commented on a change in pull request #1037: Add classification of SQL_Type: for dql and auxiliary statement

Posted by GitBox <gi...@apache.org>.
ulysses-you commented on a change in pull request #1037:
URL: https://github.com/apache/incubator-kyuubi/pull/1037#discussion_r703452249



##########
File path: dev/kyuubi-extension-spark-3-1/src/main/resources/sql-classification-default.json
##########
@@ -1,34 +1,60 @@
 {
   "AlterDatabasePropertiesCommand": "ddl",
-  "AlterTableRenameCommand": "ddl",
-  "AlterTableRenamePartitionCommand": "ddl",
   "AlterTableAddColumnsCommand": "ddl",
-  "AlterTableChangeColumnCommand": "ddl",
   "AlterTableAddPartitionCommand": "ddl",
+  "AlterTableChangeColumnCommand": "ddl",
   "AlterTableDropPartitionCommand": "ddl",
-  "AlterTableSetPropertiesCommand": "ddl",
-  "AlterTableSetLocationCommand": "ddl",
-  "AlterTableSerDePropertiesCommand": "ddl",
-  "AlterTableUnsetPropertiesCommand": "ddl",
+  "AlterTableRecoverPartitionsCommand": "ddl",
+  "AlterTableRenameCommand": "ddl",
   "AlterTableRenameCommand": "ddl",
+  "AlterTableRenamePartitionCommand": "ddl",
+  "AlterTableSerDePropertiesCommand": "ddl",
+  "AlterTableSetLocationCommand": "ddl",
   "AlterTableSetPropertiesCommand": "ddl",
+  "AlterTableSetPropertiesCommand": "ddl",
+  "AlterTableUnsetPropertiesCommand": "ddl",
   "AlterTableUnsetPropertiesCommand": "ddl",
   "AlterViewAsCommand": "ddl",
+  "CreateDataSourceTableAsSelectCommand": "ddl",
+  "CreateDataSourceTableCommand": "ddl",
   "CreateDatabaseCommand": "ddl",
   "CreateFunctionCommand": "ddl",
-  "CreateDataSourceTableCommand": "ddl",
-  "CreateDataSourceTableAsSelectCommand": "ddl",
   "CreateTableLikeCommand": "ddl",
   "CreateViewCommand": "ddl",
   "DropDatabaseCommand": "ddl",
   "DropFunctionCommand": "ddl",
-  "NoopDropTable": "ddl",
   "DropTableCommand": "ddl",
-  "TruncateTableCommand": "ddl",
-  "AlterTableRecoverPartitionsCommand": "ddl",
+  "NoopDropTable": "ddl",
   "SetCatalogAndNamespace": "ddl",
+  "TruncateTableCommand": "ddl",

Review comment:
       seems  in spark 3.2




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-kyuubi] codecov-commenter commented on pull request #1037: Add classification of SQL_Type: for dql and auxiliary statement

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1037:
URL: https://github.com/apache/incubator-kyuubi/pull/1037#issuecomment-913945391


   # [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1037](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (59c6f9b) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/c1e5545c648fbd9d62c562014447eea205849094?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c1e5545) will **increase** coverage by `2.43%`.
   > The diff coverage is `100.00%`.
   
   > :exclamation: Current head 59c6f9b differs from pull request most recent head d258e80. Consider uploading reports for the commit d258e80 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/graphs/tree.svg?width=650&height=150&src=pr&token=925D4tb9AH&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1037      +/-   ##
   ============================================
   + Coverage     78.42%   80.85%   +2.43%     
   + Complexity       61       14      -47     
   ============================================
     Files           167      159       -8     
     Lines          6196     5840     -356     
     Branches        723      657      -66     
   ============================================
   - Hits           4859     4722     -137     
   + Misses          915      723     -192     
   + Partials        422      395      -27     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...sqlclassification/KyuubiGetSqlClassification.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstMy0xL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9zcWxjbGFzc2lmaWNhdGlvbi9LeXV1YmlHZXRTcWxDbGFzc2lmaWNhdGlvbi5zY2FsYQ==) | `77.77% <100.00%> (+4.44%)` | :arrow_up: |
   | [...apache/kyuubi/sql/zorder/ZorderSqlAstBuilder.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstMy0xL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC96b3JkZXIvWm9yZGVyU3FsQXN0QnVpbGRlci5zY2FsYQ==) | | |
   | [...g/apache/kyuubi/sql/zorder/ZorderBeforeWrite.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstMy0xL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC96b3JkZXIvWm9yZGVyQmVmb3JlV3JpdGUuc2NhbGE=) | | |
   | [...ache/kyuubi/sql/zorder/OptimizeZorderCommand.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstMy0xL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC96b3JkZXIvT3B0aW1pemVab3JkZXJDb21tYW5kLnNjYWxh) | | |
   | [...bi/sql/zorder/ZorderSparkSqlExtensionsParser.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstMy0xL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC96b3JkZXIvWm9yZGVyU3BhcmtTcWxFeHRlbnNpb25zUGFyc2VyLnNjYWxh) | | |
   | [...org/apache/kyuubi/sql/zorder/ZorderException.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstMy0xL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC96b3JkZXIvWm9yZGVyRXhjZXB0aW9uLnNjYWxh) | | |
   | [...in/scala/org/apache/kyuubi/sql/zorder/Zorder.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstMy0xL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC96b3JkZXIvWm9yZGVyLnNjYWxh) | | |
   | [...rg/apache/kyuubi/sql/zorder/ZorderBytesUtils.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstMy0xL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC96b3JkZXIvWm9yZGVyQnl0ZXNVdGlscy5zY2FsYQ==) | | |
   | [...ache/kyuubi/sql/zorder/KyuubiZorderExtension.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstMy0xL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC96b3JkZXIvS3l1dWJpWm9yZGVyRXh0ZW5zaW9uLnNjYWxh) | | |
   | [...pache/kyuubi/sql/KyuubiQueryStagePreparation.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstMy0xL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9LeXV1YmlRdWVyeVN0YWdlUHJlcGFyYXRpb24uc2NhbGE=) | `81.37% <0.00%> (+0.98%)` | :arrow_up: |
   | ... and [3 more](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [c1e5545...d258e80](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-kyuubi] zhang1002 commented on a change in pull request #1037: Add classification of SQL_Type: for dql and auxiliary statement

Posted by GitBox <gi...@apache.org>.
zhang1002 commented on a change in pull request #1037:
URL: https://github.com/apache/incubator-kyuubi/pull/1037#discussion_r703973178



##########
File path: dev/kyuubi-extension-spark-3-1/src/main/scala/org/apache/kyuubi/sql/sqlclassification/KyuubiGetSqlClassification.scala
##########
@@ -28,22 +28,29 @@ import org.apache.kyuubi.sql.KyuubiSQLConf._
  * This object is used for getting sql_classification by the logicalPlan's simpleName.
  * When the configuration item: SQL_CLASSIFICATION_ENABLED is on,
  * we will load the rule from sql-classification-default.json.
+ *
+ * Notice:
+ *  We support the user use the self-defined matching rule: sql-classification.json.
+ *  If there have no this named jsonFile,
+ *  the service will upload the default matching rule: sql-classification-default.json.
  */
 object KyuubiGetSqlClassification {
 
   private val jsonNode: Option[JsonNode] = {
     SQLConf.get.getConf(SQL_CLASSIFICATION_ENABLED) match {
       case true =>
+        val objectMapper = new ObjectMapper
+        var defaultSqlClassificationFile: String = null
         try {
-          val defaultSqlClassificationFile =
-            Thread.currentThread().getContextClassLoader
-              .getResource("sql-classification-default.json").getPath
-          val objectMapper = new ObjectMapper
-          Some(objectMapper.readTree(new File(defaultSqlClassificationFile)))
+          defaultSqlClassificationFile = Thread.currentThread().getContextClassLoader
+            .getResource("sql-classification.json").getPath
         } catch {
-          case e: Exception =>
-            throw new IllegalArgumentException("sql-classification-default.json is not exist.", e)
+          case e: NullPointerException =>

Review comment:
       done
   remove NullPointerException.
   when the url is null, then i use the default jsonFile




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1037: Add classification of SQL_Type: for dql and auxiliary statement

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1037:
URL: https://github.com/apache/incubator-kyuubi/pull/1037#issuecomment-913945391


   # [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1037](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (81e6795) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/888651353482ba49abe7c8077ac478ec795e2b97?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8886513) will **increase** coverage by `0.16%`.
   > The diff coverage is `88.88%`.
   
   > :exclamation: Current head 81e6795 differs from pull request most recent head e6e9e90. Consider uploading reports for the commit e6e9e90 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/graphs/tree.svg?width=650&height=150&src=pr&token=925D4tb9AH&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1037      +/-   ##
   ============================================
   + Coverage     78.57%   78.74%   +0.16%     
   + Complexity       71       61      -10     
   ============================================
     Files           170      169       -1     
     Lines          6277     6256      -21     
     Branches        725      726       +1     
   ============================================
   - Hits           4932     4926       -6     
   + Misses          920      907      -13     
   + Partials        425      423       -2     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...sqlclassification/KyuubiGetSqlClassification.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstMy0xL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9zcWxjbGFzc2lmaWNhdGlvbi9LeXV1YmlHZXRTcWxDbGFzc2lmaWNhdGlvbi5zY2FsYQ==) | `77.27% <88.88%> (+3.93%)` | :arrow_up: |
   | [...ache/kyuubi/sql/zorder/OptimizeZorderCommand.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstMy0xL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC96b3JkZXIvT3B0aW1pemVab3JkZXJDb21tYW5kLnNjYWxh) | `81.81% <0.00%> (-2.40%)` | :arrow_down: |
   | [...kyuubi/engine/spark/operation/SparkOperation.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1zcGFyay1zcWwtZW5naW5lL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2VuZ2luZS9zcGFyay9vcGVyYXRpb24vU3BhcmtPcGVyYXRpb24uc2NhbGE=) | `68.85% <0.00%> (-0.51%)` | :arrow_down: |
   | [...apache/kyuubi/sql/zorder/ZorderSqlAstBuilder.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstMy0xL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC96b3JkZXIvWm9yZGVyU3FsQXN0QnVpbGRlci5zY2FsYQ==) | `33.07% <0.00%> (-0.50%)` | :arrow_down: |
   | [...in/scala/org/apache/kyuubi/sql/zorder/Zorder.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstMy0xL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC96b3JkZXIvWm9yZGVyLnNjYWxh) | `15.00% <0.00%> (ø)` | |
   | [...rg/apache/kyuubi/sql/zorder/ZorderBytesUtils.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstMy0xL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC96b3JkZXIvWm9yZGVyQnl0ZXNVdGlscy5zY2FsYQ==) | `41.66% <0.00%> (ø)` | |
   | [...he/kyuubi/sql/zorder/OptimizeZorderStatement.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstMy0xL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC96b3JkZXIvT3B0aW1pemVab3JkZXJTdGF0ZW1lbnQuc2NhbGE=) | | |
   | [...pache/kyuubi/sql/KyuubiSQLExtensionException.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstMy0xL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9LeXV1YmlTUUxFeHRlbnNpb25FeGNlcHRpb24uc2NhbGE=) | | |
   | [...a/org/apache/kyuubi/sql/zorder/ResolveZorder.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstMy0xL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC96b3JkZXIvUmVzb2x2ZVpvcmRlci5zY2FsYQ==) | | |
   | [...org/apache/kyuubi/sql/zorder/ZorderException.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstMy0xL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC96b3JkZXIvWm9yZGVyRXhjZXB0aW9uLnNjYWxh) | `100.00% <0.00%> (ø)` | |
   | ... and [5 more](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [8886513...e6e9e90](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1037: Add classification of SQL_Type: for dql and auxiliary statement

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1037:
URL: https://github.com/apache/incubator-kyuubi/pull/1037#issuecomment-913945391


   # [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1037](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e94ad82) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/c1e5545c648fbd9d62c562014447eea205849094?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c1e5545) will **increase** coverage by `0.00%`.
   > The diff coverage is `88.88%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/graphs/tree.svg?width=650&height=150&src=pr&token=925D4tb9AH&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff            @@
   ##             master    #1037   +/-   ##
   =========================================
     Coverage     78.42%   78.42%           
     Complexity       61       61           
   =========================================
     Files           167      167           
     Lines          6196     6203    +7     
     Branches        723      724    +1     
   =========================================
   + Hits           4859     4865    +6     
     Misses          915      915           
   - Partials        422      423    +1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...sqlclassification/KyuubiGetSqlClassification.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstMy0xL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9zcWxjbGFzc2lmaWNhdGlvbi9LeXV1YmlHZXRTcWxDbGFzc2lmaWNhdGlvbi5zY2FsYQ==) | `77.27% <88.88%> (+3.93%)` | :arrow_up: |
   | [...pache/kyuubi/sql/KyuubiQueryStagePreparation.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstMy0xL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9LeXV1YmlRdWVyeVN0YWdlUHJlcGFyYXRpb24uc2NhbGE=) | `80.39% <0.00%> (ø)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [c1e5545...e94ad82](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-kyuubi] ulysses-you commented on a change in pull request #1037: Add classification of SQL_Type: for dql and auxiliary statement

Posted by GitBox <gi...@apache.org>.
ulysses-you commented on a change in pull request #1037:
URL: https://github.com/apache/incubator-kyuubi/pull/1037#discussion_r703475423



##########
File path: dev/kyuubi-extension-spark-3-1/src/test/scala/org/apache/spark/sql/KyuubiExtensionSuite.scala
##########
@@ -673,7 +693,7 @@ class KyuubiExtensionSuite extends QueryTest with SQLTestUtils with AdaptiveSpar
       ).getClass.getSimpleName
     )
     // scalastyle:off println
-    println("ddl simple name is :" + ddlSimpleName)
+    println("ddl simple name is :" + ddlSimpleName.toSeq.sorted)
     // scalastyle:on println

Review comment:
       we can remove this




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1037: Add classification of SQL_Type: for dql and auxiliary statement

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1037:
URL: https://github.com/apache/incubator-kyuubi/pull/1037#issuecomment-913945391


   # [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1037](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d7f7538) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/c1e5545c648fbd9d62c562014447eea205849094?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c1e5545) will **increase** coverage by `0.04%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/graphs/tree.svg?width=650&height=150&src=pr&token=925D4tb9AH&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1037      +/-   ##
   ============================================
   + Coverage     78.42%   78.46%   +0.04%     
     Complexity       61       61              
   ============================================
     Files           167      167              
     Lines          6196     6205       +9     
     Branches        723      724       +1     
   ============================================
   + Hits           4859     4869      +10     
     Misses          915      915              
   + Partials        422      421       -1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...sqlclassification/KyuubiGetSqlClassification.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstMy0xL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9zcWxjbGFzc2lmaWNhdGlvbi9LeXV1YmlHZXRTcWxDbGFzc2lmaWNhdGlvbi5zY2FsYQ==) | `77.77% <100.00%> (+4.44%)` | :arrow_up: |
   | [.../org/apache/kyuubi/events/KyuubiSessionEvent.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9ldmVudHMvS3l1dWJpU2Vzc2lvbkV2ZW50LnNjYWxh) | `92.00% <0.00%> (-0.31%)` | :arrow_down: |
   | [...ain/scala/org/apache/kyuubi/engine/EngineRef.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9lbmdpbmUvRW5naW5lUmVmLnNjYWxh) | `78.94% <0.00%> (-0.28%)` | :arrow_down: |
   | [...g/apache/kyuubi/session/KyuubiSessionManager.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXNzaW9uL0t5dXViaVNlc3Npb25NYW5hZ2VyLnNjYWxh) | `97.05% <0.00%> (ø)` | |
   | [...pache/kyuubi/sql/KyuubiQueryStagePreparation.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstMy0xL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9LeXV1YmlRdWVyeVN0YWdlUHJlcGFyYXRpb24uc2NhbGE=) | `80.39% <0.00%> (ø)` | |
   | [.../apache/kyuubi/client/KyuubiSyncThriftClient.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jbGllbnQvS3l1dWJpU3luY1RocmlmdENsaWVudC5zY2FsYQ==) | `82.02% <0.00%> (+0.20%)` | :arrow_up: |
   | [...n/scala/org/apache/kyuubi/engine/ProcBuilder.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9lbmdpbmUvUHJvY0J1aWxkZXIuc2NhbGE=) | `92.20% <0.00%> (+1.29%)` | :arrow_up: |
   | [.../org/apache/kyuubi/session/KyuubiSessionImpl.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXNzaW9uL0t5dXViaVNlc3Npb25JbXBsLnNjYWxh) | `89.58% <0.00%> (+1.77%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [c1e5545...d7f7538](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-kyuubi] zhang1002 commented on a change in pull request #1037: Add classification of SQL_Type: for dql and auxiliary statement

Posted by GitBox <gi...@apache.org>.
zhang1002 commented on a change in pull request #1037:
URL: https://github.com/apache/incubator-kyuubi/pull/1037#discussion_r703490533



##########
File path: dev/kyuubi-extension-spark-3-1/src/main/scala/org/apache/kyuubi/sql/sqlclassification/KyuubiGetSqlClassification.scala
##########
@@ -28,22 +28,29 @@ import org.apache.kyuubi.sql.KyuubiSQLConf._
  * This object is used for getting sql_classification by the logicalPlan's simpleName.
  * When the configuration item: SQL_CLASSIFICATION_ENABLED is on,
  * we will load the rule from sql-classification-default.json.
+ *
+ * Notice:
+ *  We support the user use the self-defined matching rule: sql-classification.json.
+ *  If there have no this named jsonFile,
+ *  the service will upload the default matching rule: sql-classification-default.json.
  */
 object KyuubiGetSqlClassification {
 
   private val jsonNode: Option[JsonNode] = {
     SQLConf.get.getConf(SQL_CLASSIFICATION_ENABLED) match {
       case true =>
+        val objectMapper = new ObjectMapper
+        var defaultSqlClassificationFile: String = null
         try {
-          val defaultSqlClassificationFile =
-            Thread.currentThread().getContextClassLoader
-              .getResource("sql-classification-default.json").getPath
-          val objectMapper = new ObjectMapper
-          Some(objectMapper.readTree(new File(defaultSqlClassificationFile)))
+          defaultSqlClassificationFile = Thread.currentThread().getContextClassLoader
+            .getResource("sql-classification.json").getPath
         } catch {
-          case e: Exception =>
-            throw new IllegalArgumentException("sql-classification-default.json is not exist.", e)
+          case e: NullPointerException =>

Review comment:
       the method: getResource is an nullAble method. so we can get null_object.
   
   why i use this exception:
   Because when the jsonFile is not exist, this line only throw NullPointerException, so i can only catch this exception...




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-kyuubi] ulysses-you commented on a change in pull request #1037: Add classification of SQL_Type: for dql and auxiliary statement

Posted by GitBox <gi...@apache.org>.
ulysses-you commented on a change in pull request #1037:
URL: https://github.com/apache/incubator-kyuubi/pull/1037#discussion_r703476798



##########
File path: dev/kyuubi-extension-spark-3-1/src/test/scala/org/apache/spark/sql/KyuubiExtensionSuite.scala
##########
@@ -1026,4 +1046,402 @@ class KyuubiExtensionSuite extends QueryTest with SQLTestUtils with AdaptiveSpar
       }
     }
   }
+
+  test("get simple name for auxiliary statement") {
+    val auxiStatementSimpleName: Set[String] = Set()
+
+    var pre_sql = "CREATE TABLE IF NOT EXISTS students_testtest " +
+      "(name STRING, student_id INT) PARTITIONED BY (student_id);"
+    spark.sql(pre_sql)
+    pre_sql = "INSERT INTO students_testtest PARTITION (student_id = 111111) VALUES ('Mark');"
+    spark.sql(pre_sql)
+    pre_sql = "INSERT INTO students_testtest PARTITION (student_id = 222222) VALUES ('John');"
+    spark.sql(pre_sql)
+
+    val sql01 = "ANALYZE TABLE students_testtest COMPUTE STATISTICS NOSCAN;"
+    auxiStatementSimpleName.add(
+      spark.sessionState.analyzer.execute(
+        spark.sessionState.sqlParser.parsePlan(sql01)
+      ).getClass.getSimpleName
+    )
+
+    val sql48 = "ANALYZE TABLE students_testtest PARTITION " +
+      "(student_id = 111111) COMPUTE STATISTICS;"
+    auxiStatementSimpleName.add(
+      spark.sessionState.analyzer.execute(
+        spark.sessionState.sqlParser.parsePlan(sql48)
+      ).getClass.getSimpleName
+    )
+
+    val sql49 = "ANALYZE TABLE students_testtest COMPUTE STATISTICS FOR COLUMNS name;"
+    auxiStatementSimpleName.add(
+      spark.sessionState.analyzer.execute(
+        spark.sessionState.sqlParser.parsePlan(sql49)
+      ).getClass.getSimpleName
+    )
+
+    val sql29 = "SHOW PARTITIONS students_testtest;"
+    auxiStatementSimpleName.add(
+      spark.sessionState.analyzer.execute(
+        spark.sessionState.sqlParser.parsePlan(sql29)
+      ).getClass.getSimpleName
+    )
+
+    val sql30 = "SHOW PARTITIONS students_testtest PARTITION (student_id = 111111);"
+    auxiStatementSimpleName.add(
+      spark.sessionState.analyzer.execute(
+        spark.sessionState.sqlParser.parsePlan(sql30)
+      ).getClass.getSimpleName
+    )
+
+    val sql31 = "SHOW TABLE EXTENDED LIKE 'students_testtest';"
+    auxiStatementSimpleName.add(
+      spark.sessionState.analyzer.execute(
+        spark.sessionState.sqlParser.parsePlan(sql31)
+      ).getClass.getSimpleName
+    )
+
+    val sql32 = "SHOW TABLES;"
+    auxiStatementSimpleName.add(
+      spark.sessionState.analyzer.execute(
+        spark.sessionState.sqlParser.parsePlan(sql32)
+      ).getClass.getSimpleName
+    )
+
+    val sql33 = "SHOW TABLES FROM default;"
+    auxiStatementSimpleName.add(
+      spark.sessionState.analyzer.execute(
+        spark.sessionState.sqlParser.parsePlan(sql33)
+      ).getClass.getSimpleName
+    )
+
+    val sql02 = "CACHE TABLE testCache OPTIONS ('storageLevel' 'DISK_ONLY') " +
+      "SELECT * FROM students_testtest;"
+    auxiStatementSimpleName.add(
+      spark.sessionState.analyzer.execute(
+        spark.sessionState.sqlParser.parsePlan(sql02)
+      ).getClass.getSimpleName
+    )
+
+    val sql03 = "CACHE LAZY TABLE testCache OPTIONS ('storageLevel' 'DISK_ONLY') " +
+      "SELECT * FROM students_testtest;"
+    auxiStatementSimpleName.add(
+      spark.sessionState.analyzer.execute(
+        spark.sessionState.sqlParser.parsePlan(sql03)
+      ).getClass.getSimpleName
+    )
+
+    val sql09 = "REFRESH \"hdfs://path/to/table\""
+    auxiStatementSimpleName.add(
+      spark.sessionState.analyzer.execute(
+        spark.sessionState.sqlParser.parsePlan(sql09)
+      ).getClass.getSimpleName
+    )
+
+    val sql04 = "UNCACHE TABLE IF EXISTS testCache;"
+    auxiStatementSimpleName.add(
+      spark.sessionState.analyzer.execute(
+        spark.sessionState.sqlParser.parsePlan(sql04)
+      ).getClass.getSimpleName
+    )
+
+    val sql05 = "CLEAR CACHE;"
+    auxiStatementSimpleName.add(
+      spark.sessionState.analyzer.execute(
+        spark.sessionState.sqlParser.parsePlan(sql05)
+      ).getClass.getSimpleName
+    )
+
+    val sql06 = "REFRESH TABLE students_testtest;"
+    auxiStatementSimpleName.add(
+      spark.sessionState.analyzer.execute(
+        spark.sessionState.sqlParser.parsePlan(sql06)
+      ).getClass.getSimpleName
+    )
+
+    pre_sql = "CREATE OR REPLACE VIEW students_testtest_view " +
+      "AS SELECT name, student_id FROM students_testtest;"
+    spark.sql(pre_sql)
+    val sql07 = "REFRESH TABLE default.students_testtest_view;"
+    auxiStatementSimpleName.add(
+      spark.sessionState.analyzer.execute(
+        spark.sessionState.sqlParser.parsePlan(sql07)
+      ).getClass.getSimpleName
+    )
+
+    val sql35 = "SHOW VIEWS;"
+    auxiStatementSimpleName.add(
+      spark.sessionState.analyzer.execute(
+        spark.sessionState.sqlParser.parsePlan(sql35)
+      ).getClass.getSimpleName
+    )
+
+    pre_sql = "DROP VIEW IF EXISTS students_testtest_view;"
+    spark.sql(pre_sql)
+
+    pre_sql = "CREATE FUNCTION IF NOT EXISTS test_avg AS " +
+      "'org.apache.hadoop.hive.ql.udf.generic.GenericUDAFAverage';"
+    spark.sql(pre_sql)
+    val sql08 = "REFRESH FUNCTION test_avg;"
+    auxiStatementSimpleName.add(
+      spark.sessionState.analyzer.execute(
+        spark.sessionState.sqlParser.parsePlan(sql08)
+      ).getClass.getSimpleName
+    )
+
+    val sql15 = "DESC FUNCTION test_avg;"
+    auxiStatementSimpleName.add(
+      spark.sessionState.analyzer.execute(
+        spark.sessionState.sqlParser.parsePlan(sql15)
+      ).getClass.getSimpleName
+    )
+
+    val sql26 = "SHOW FUNCTIONS test_avg;"
+    auxiStatementSimpleName.add(
+      spark.sessionState.analyzer.execute(
+        spark.sessionState.sqlParser.parsePlan(sql26)
+      ).getClass.getSimpleName
+    )
+
+    val sql27 = "SHOW SYSTEM FUNCTIONS concat;"
+    auxiStatementSimpleName.add(
+      spark.sessionState.analyzer.execute(
+        spark.sessionState.sqlParser.parsePlan(sql27)
+      ).getClass.getSimpleName
+    )
+
+    val sql28 = "SHOW FUNCTIONS LIKE 'test*';"
+    auxiStatementSimpleName.add(
+      spark.sessionState.analyzer.execute(
+        spark.sessionState.sqlParser.parsePlan(sql28)
+      ).getClass.getSimpleName
+    )
+
+    pre_sql = "DROP FUNCTION IF EXISTS test_avg;"
+    spark.sql(pre_sql)
+
+    pre_sql = "CREATE DATABASE IF NOT EXISTS employees COMMENT 'For software companies';"
+    spark.sql(pre_sql)
+    val sql10 = "DESCRIBE DATABASE employees;"
+    auxiStatementSimpleName.add(
+      spark.sessionState.analyzer.execute(
+        spark.sessionState.sqlParser.parsePlan(sql10)
+      ).getClass.getSimpleName
+    )
+
+    val sql23 = "SHOW DATABASES;"
+    auxiStatementSimpleName.add(
+      spark.sessionState.analyzer.execute(
+        spark.sessionState.sqlParser.parsePlan(sql23)
+      ).getClass.getSimpleName
+    )
+
+    val sql24 = "SHOW DATABASES LIKE 'employ*';"
+    auxiStatementSimpleName.add(
+      spark.sessionState.analyzer.execute(
+        spark.sessionState.sqlParser.parsePlan(sql24)
+      ).getClass.getSimpleName
+    )
+
+    val sql25 = "SHOW SCHEMAS;"
+    auxiStatementSimpleName.add(
+      spark.sessionState.analyzer.execute(
+        spark.sessionState.sqlParser.parsePlan(sql25)
+      ).getClass.getSimpleName
+    )
+
+    pre_sql = "ALTER DATABASE employees SET DBPROPERTIES " +
+      "('Create-by' = 'Kevin', 'Create-date' = '09/01/2019');"
+    val sql11 = "DESCRIBE DATABASE EXTENDED employees;"
+    auxiStatementSimpleName.add(
+      spark.sessionState.analyzer.execute(
+        spark.sessionState.sqlParser.parsePlan(sql11)
+      ).getClass.getSimpleName
+    )
+    pre_sql = "DROP DATABASE IF EXISTS employees;"
+    spark.sql(pre_sql)
+
+    pre_sql = "CREATE TABLE IF NOT EXISTS customer" +
+      "(cust_id INT, state VARCHAR(20), name STRING COMMENT 'Short name') " +
+      "USING parquet PARTITIONED BY (state);"
+    spark.sql(pre_sql)
+    pre_sql = "INSERT INTO customer PARTITION (state = 'AR') VALUES (100, 'Mike');"
+    val sql12 = "DESCRIBE TABLE customer;"
+    auxiStatementSimpleName.add(
+      spark.sessionState.analyzer.execute(
+        spark.sessionState.sqlParser.parsePlan(sql12)
+      ).getClass.getSimpleName
+    )
+
+    val sql21 = "SHOW COLUMNS IN customer;"
+    auxiStatementSimpleName.add(
+      spark.sessionState.analyzer.execute(
+        spark.sessionState.sqlParser.parsePlan(sql21)
+      ).getClass.getSimpleName
+    )
+
+    val sql22 = "SHOW CREATE TABLE customer;"
+    auxiStatementSimpleName.add(
+      spark.sessionState.analyzer.execute(
+        spark.sessionState.sqlParser.parsePlan(sql22)
+      ).getClass.getSimpleName
+    )
+
+    val sql13 = "DESCRIBE TABLE EXTENDED customer PARTITION (state = 'AR');"
+    auxiStatementSimpleName.add(
+      spark.sessionState.analyzer.execute(
+        spark.sessionState.sqlParser.parsePlan(sql13)
+      ).getClass.getSimpleName
+    )
+
+    val sql14 = "DESCRIBE customer salesdb.customer.name;"
+    auxiStatementSimpleName.add(
+      spark.sessionState.analyzer.execute(
+        spark.sessionState.sqlParser.parsePlan(sql14)
+      ).getClass.getSimpleName
+    )
+    pre_sql = "DROP TABLE IF EXISTS customer;"
+    spark.sql(pre_sql)
+
+    pre_sql = "CREATE TABLE IF NOT EXISTS person " +
+      "(name STRING , age INT COMMENT 'Age column', address STRING);"
+    spark.sql(pre_sql)
+    val sql16 = "DESCRIBE QUERY SELECT age, sum(age) FROM person GROUP BY age;"
+    auxiStatementSimpleName.add(
+      spark.sessionState.analyzer.execute(
+        spark.sessionState.sqlParser.parsePlan(sql16)
+      ).getClass.getSimpleName
+    )
+
+    val sql17 = "DESCRIBE QUERY WITH all_names_cte AS " +
+      "(SELECT name from person) SELECT * FROM all_names_cte;"
+    auxiStatementSimpleName.add(
+      spark.sessionState.analyzer.execute(
+        spark.sessionState.sqlParser.parsePlan(sql17)
+      ).getClass.getSimpleName
+    )
+
+    val sql18 = "DESC QUERY VALUES(100, 'John', 10000.20D) " +
+      "AS employee(id, name, salary);"
+    auxiStatementSimpleName.add(
+      spark.sessionState.analyzer.execute(
+        spark.sessionState.sqlParser.parsePlan(sql18)
+      ).getClass.getSimpleName
+    )
+
+    val sql19 = "DESC QUERY TABLE person;"
+    auxiStatementSimpleName.add(
+      spark.sessionState.analyzer.execute(
+        spark.sessionState.sqlParser.parsePlan(sql19)
+      ).getClass.getSimpleName
+    )
+
+    val sql20 = "DESCRIBE FROM person SELECT age;"
+    auxiStatementSimpleName.add(
+      spark.sessionState.analyzer.execute(
+        spark.sessionState.sqlParser.parsePlan(sql20)
+      ).getClass.getSimpleName
+    )
+    pre_sql = "DROP TABLE IF EXISTS person;"
+    spark.sql(pre_sql)
+
+    pre_sql = "CREATE TABLE IF NOT EXISTS customer" +
+      "(cust_code INT, name VARCHAR(100), cust_addr STRING) " +
+      "TBLPROPERTIES ('created.by.user' = 'John', 'created.date' = '01-01-2001');"
+    spark.sql(pre_sql)
+    val sql34 = "SHOW TBLPROPERTIES customer;"
+    auxiStatementSimpleName.add(
+      spark.sessionState.analyzer.execute(
+        spark.sessionState.sqlParser.parsePlan(sql34)
+      ).getClass.getSimpleName
+    )
+
+    val sql36 = "SET spark.sql.variable.substitute=false"
+    auxiStatementSimpleName.add(
+      spark.sessionState.analyzer.execute(
+        spark.sessionState.sqlParser.parsePlan(sql36)
+      ).getClass.getSimpleName
+    )
+
+    val sql37 = "SET"
+    auxiStatementSimpleName.add(
+      spark.sessionState.analyzer.execute(
+        spark.sessionState.sqlParser.parsePlan(sql37)
+      ).getClass.getSimpleName
+    )
+
+    val sql38 = "SET spark.sql.variable.substitute"
+    auxiStatementSimpleName.add(
+      spark.sessionState.analyzer.execute(
+        spark.sessionState.sqlParser.parsePlan(sql38)
+      ).getClass.getSimpleName
+    )
+
+    val sql39 = "RESET"
+    auxiStatementSimpleName.add(
+      spark.sessionState.analyzer.execute(
+        spark.sessionState.sqlParser.parsePlan(sql39)
+      ).getClass.getSimpleName
+    )
+
+    val sql40 = "RESET spark.sql.variable.substitute"
+    auxiStatementSimpleName.add(
+      spark.sessionState.analyzer.execute(
+        spark.sessionState.sqlParser.parsePlan(sql40)
+      ).getClass.getSimpleName
+    )
+
+    val sql41 = "SET TIME ZONE LOCAL;"
+    auxiStatementSimpleName.add(
+      spark.sessionState.analyzer.execute(
+        spark.sessionState.sqlParser.parsePlan(sql41)
+      ).getClass.getSimpleName
+    )
+
+    val sql42 = "ADD FILE /tmp/test;"
+    auxiStatementSimpleName.add(
+      spark.sessionState.analyzer.execute(
+        spark.sessionState.sqlParser.parsePlan(sql42)
+      ).getClass.getSimpleName
+    )
+
+    val sql43 = "ADD JAR /tmp/test.jar;"
+    auxiStatementSimpleName.add(
+      spark.sessionState.analyzer.execute(
+        spark.sessionState.sqlParser.parsePlan(sql43)
+      ).getClass.getSimpleName
+    )
+
+    val sql44 = "LIST FILE;"
+    auxiStatementSimpleName.add(
+      spark.sessionState.analyzer.execute(
+        spark.sessionState.sqlParser.parsePlan(sql44)
+      ).getClass.getSimpleName
+    )
+
+    val sql45 = "LIST JAR;"
+    auxiStatementSimpleName.add(
+      spark.sessionState.analyzer.execute(
+        spark.sessionState.sqlParser.parsePlan(sql45)
+      ).getClass.getSimpleName
+    )
+
+    val sql46 = "EXPLAIN select k, sum(v) from values (1, 2), (1, 3) t(k, v) group by k;"
+    auxiStatementSimpleName.add(
+      spark.sessionState.analyzer.execute(
+        spark.sessionState.sqlParser.parsePlan(sql46)
+      ).getClass.getSimpleName
+    )
+
+    val sql47 = "EXPLAIN EXTENDED select k, sum(v) from values (1, 2), (1, 3) t(k, v) group by k;"
+    auxiStatementSimpleName.add(
+      spark.sessionState.analyzer.execute(
+        spark.sessionState.sqlParser.parsePlan(sql47)
+      ).getClass.getSimpleName
+    )
+
+    // scalastyle:off println
+    println("auxiliary statement simple name is :" + auxiStatementSimpleName.toSeq.sorted)

Review comment:
       what does this test want to do ? not see any assert




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1037: Add classification of SQL_Type: for dql and auxiliary statement

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1037:
URL: https://github.com/apache/incubator-kyuubi/pull/1037#issuecomment-913945391


   # [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1037](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (81e6795) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/c1e5545c648fbd9d62c562014447eea205849094?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c1e5545) will **increase** coverage by `0.31%`.
   > The diff coverage is `84.67%`.
   
   > :exclamation: Current head 81e6795 differs from pull request most recent head e94ad82. Consider uploading reports for the commit e94ad82 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/graphs/tree.svg?width=650&height=150&src=pr&token=925D4tb9AH&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1037      +/-   ##
   ============================================
   + Coverage     78.42%   78.74%   +0.31%     
     Complexity       61       61              
   ============================================
     Files           167      169       +2     
     Lines          6196     6256      +60     
     Branches        723      726       +3     
   ============================================
   + Hits           4859     4926      +67     
   + Misses          915      907       -8     
   - Partials        422      423       +1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...la/org/apache/kyuubi/session/AbstractSession.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXNzaW9uL0Fic3RyYWN0U2Vzc2lvbi5zY2FsYQ==) | `95.40% <ø> (-0.11%)` | :arrow_down: |
   | [.../main/scala/org/apache/kyuubi/server/api/api.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvYXBpL2FwaS5zY2FsYQ==) | `100.00% <ø> (+10.00%)` | :arrow_up: |
   | [...apache/kyuubi/sql/zorder/ZorderSqlAstBuilder.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstMy0xL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC96b3JkZXIvWm9yZGVyU3FsQXN0QnVpbGRlci5zY2FsYQ==) | `33.07% <11.11%> (+1.49%)` | :arrow_up: |
   | [...org/apache/kyuubi/ha/client/ServiceDiscovery.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWhhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2hhL2NsaWVudC9TZXJ2aWNlRGlzY292ZXJ5LnNjYWxh) | `45.52% <33.33%> (ø)` | |
   | [...g/apache/kyuubi/session/KyuubiSessionManager.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXNzaW9uL0t5dXViaVNlc3Npb25NYW5hZ2VyLnNjYWxh) | `97.05% <66.66%> (ø)` | |
   | [...org/apache/kyuubi/server/RestFrontendService.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvUmVzdEZyb250ZW5kU2VydmljZS5zY2FsYQ==) | `83.92% <75.00%> (-0.69%)` | :arrow_down: |
   | [...ain/scala/org/apache/kyuubi/engine/EngineRef.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9lbmdpbmUvRW5naW5lUmVmLnNjYWxh) | `78.94% <77.77%> (-0.28%)` | :arrow_down: |
   | [...sqlclassification/KyuubiGetSqlClassification.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstMy0xL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9zcWxjbGFzc2lmaWNhdGlvbi9LeXV1YmlHZXRTcWxDbGFzc2lmaWNhdGlvbi5zY2FsYQ==) | `77.27% <88.88%> (+3.93%)` | :arrow_up: |
   | [...la/org/apache/kyuubi/ha/HighAvailabilityConf.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWhhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2hhL0hpZ2hBdmFpbGFiaWxpdHlDb25mLnNjYWxh) | `98.27% <92.30%> (ø)` | |
   | [.../credentials/HadoopFsDelegationTokenProvider.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jcmVkZW50aWFscy9IYWRvb3BGc0RlbGVnYXRpb25Ub2tlblByb3ZpZGVyLnNjYWxh) | `96.42% <96.42%> (ø)` | |
   | ... and [14 more](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [c1e5545...e94ad82](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-kyuubi] ulysses-you commented on a change in pull request #1037: Add classification of SQL_Type: for dql and auxiliary statement

Posted by GitBox <gi...@apache.org>.
ulysses-you commented on a change in pull request #1037:
URL: https://github.com/apache/incubator-kyuubi/pull/1037#discussion_r703320873



##########
File path: dev/kyuubi-extension-spark-3-1/src/main/resources/sql-classification-default.json
##########
@@ -1,34 +1,60 @@
 {
   "AlterDatabasePropertiesCommand": "ddl",
-  "AlterTableRenameCommand": "ddl",
-  "AlterTableRenamePartitionCommand": "ddl",
   "AlterTableAddColumnsCommand": "ddl",
-  "AlterTableChangeColumnCommand": "ddl",
   "AlterTableAddPartitionCommand": "ddl",
+  "AlterTableChangeColumnCommand": "ddl",
   "AlterTableDropPartitionCommand": "ddl",
-  "AlterTableSetPropertiesCommand": "ddl",
-  "AlterTableSetLocationCommand": "ddl",
-  "AlterTableSerDePropertiesCommand": "ddl",
-  "AlterTableUnsetPropertiesCommand": "ddl",
+  "AlterTableRecoverPartitionsCommand": "ddl",
+  "AlterTableRenameCommand": "ddl",
   "AlterTableRenameCommand": "ddl",
+  "AlterTableRenamePartitionCommand": "ddl",
+  "AlterTableSerDePropertiesCommand": "ddl",
+  "AlterTableSetLocationCommand": "ddl",
   "AlterTableSetPropertiesCommand": "ddl",
+  "AlterTableSetPropertiesCommand": "ddl",
+  "AlterTableUnsetPropertiesCommand": "ddl",
   "AlterTableUnsetPropertiesCommand": "ddl",
   "AlterViewAsCommand": "ddl",
+  "CreateDataSourceTableAsSelectCommand": "ddl",
+  "CreateDataSourceTableCommand": "ddl",
   "CreateDatabaseCommand": "ddl",
   "CreateFunctionCommand": "ddl",
-  "CreateDataSourceTableCommand": "ddl",
-  "CreateDataSourceTableAsSelectCommand": "ddl",
   "CreateTableLikeCommand": "ddl",
   "CreateViewCommand": "ddl",
   "DropDatabaseCommand": "ddl",
   "DropFunctionCommand": "ddl",
-  "NoopDropTable": "ddl",
   "DropTableCommand": "ddl",
-  "TruncateTableCommand": "ddl",
-  "AlterTableRecoverPartitionsCommand": "ddl",
+  "NoopDropTable": "ddl",
   "SetCatalogAndNamespace": "ddl",
+  "TruncateTableCommand": "ddl",
+  "InsertIntoDataSourceDirCommand": "dml",
   "InsertIntoHadoopFsRelationCommand": "dml",
+  "InsertIntoHiveDirCommand": "dml",
   "LoadDataCommand": "dml",
-  "InsertIntoDataSourceDirCommand": "dml",
-  "InsertIntoHiveDirCommand": "dml"
+  "AddFileCommand": "other",
+  "AddJarCommand": "other",
+  "AnalyzeTable": "other",
+  "CacheTableCommand": "other",
+  "ClearCacheCommand$": "other",
+  "DescribeColumnCommand": "other",
+  "DescribeDatabaseCommand": "other",
+  "DescribeFunctionCommand": "other",
+  "DescribeQueryCommand": "other",
+  "DescribeTableCommand": "other",
+  "ListFilesCommand": "other",
+  "ListJarsCommand": "other",
+  "RefreshFunctionCommand": "other",
+  "RefreshResource": "other",
+  "RefreshTableCommand": "other",
+  "ResetCommand": "other",
+  "SetCommand": "other",
+  "ShowColumnsCommand": "other",
+  "ShowCreateTableCommand": "other",
+  "ShowFunctionsCommand": "other",
+  "ShowNamespaces": "other",
+  "ShowPartitionsCommand": "other",
+  "ShowTablePropertiesCommand": "other",
+  "ShowTablesCommand": "other",
+  "ShowViewsCommand": "other",
+  "UncacheTableCommand": "other"

Review comment:
       `explain` should be `other `




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1037: Add classification of SQL_Type: for dql and auxiliary statement

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1037:
URL: https://github.com/apache/incubator-kyuubi/pull/1037#issuecomment-913945391


   # [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1037](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (72a18ec) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/c1e5545c648fbd9d62c562014447eea205849094?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c1e5545) will **increase** coverage by `0.09%`.
   > The diff coverage is `100.00%`.
   
   > :exclamation: Current head 72a18ec differs from pull request most recent head a73941e. Consider uploading reports for the commit a73941e to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/graphs/tree.svg?width=650&height=150&src=pr&token=925D4tb9AH&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1037      +/-   ##
   ============================================
   + Coverage     78.42%   78.51%   +0.09%     
   - Complexity       61       81      +20     
   ============================================
     Files           167      169       +2     
     Lines          6196     6464     +268     
     Branches        723      754      +31     
   ============================================
   + Hits           4859     5075     +216     
   - Misses          915      963      +48     
   - Partials        422      426       +4     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...sqlclassification/KyuubiGetSqlClassification.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstMy0xL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9zcWxjbGFzc2lmaWNhdGlvbi9LeXV1YmlHZXRTcWxDbGFzc2lmaWNhdGlvbi5zY2FsYQ==) | `77.77% <100.00%> (+4.44%)` | :arrow_up: |
   | [...g/apache/kyuubi/session/KyuubiSessionManager.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXNzaW9uL0t5dXViaVNlc3Npb25NYW5hZ2VyLnNjYWxh) | `95.00% <0.00%> (-2.06%)` | :arrow_down: |
   | [...org/apache/kyuubi/server/RestFrontendService.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvUmVzdEZyb250ZW5kU2VydmljZS5zY2FsYQ==) | `82.75% <0.00%> (-1.86%)` | :arrow_down: |
   | [.../apache/kyuubi/server/api/v1/ApiRootResource.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvYXBpL3YxL0FwaVJvb3RSZXNvdXJjZS5zY2FsYQ==) | `100.00% <0.00%> (ø)` | |
   | [...pache/kyuubi/sql/KyuubiQueryStagePreparation.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstMy0xL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9LeXV1YmlRdWVyeVN0YWdlUHJlcGFyYXRpb24uc2NhbGE=) | `80.39% <0.00%> (ø)` | |
   | [...kyuubi/engine/spark/session/SparkSessionImpl.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1zcGFyay1zcWwtZW5naW5lL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2VuZ2luZS9zcGFyay9zZXNzaW9uL1NwYXJrU2Vzc2lvbkltcGwuc2NhbGE=) | `100.00% <0.00%> (ø)` | |
   | [...e/kyuubi/server/api/v1/dto/SessionOpenedCount.java](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3l1dWJpL3NlcnZlci9hcGkvdjEvZHRvL1Nlc3Npb25PcGVuZWRDb3VudC5qYXZh) | `100.00% <0.00%> (ø)` | |
   | [...apache/kyuubi/server/api/v1/SessionsResource.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvYXBpL3YxL1Nlc3Npb25zUmVzb3VyY2Uuc2NhbGE=) | `100.00% <0.00%> (ø)` | |
   | [...la/org/apache/kyuubi/session/AbstractSession.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXNzaW9uL0Fic3RyYWN0U2Vzc2lvbi5zY2FsYQ==) | `97.08% <0.00%> (+1.57%)` | :arrow_up: |
   | [.../scala/org/apache/kyuubi/server/KyuubiServer.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvS3l1dWJpU2VydmVyLnNjYWxh) | `58.69% <0.00%> (+2.17%)` | :arrow_up: |
   | ... and [7 more](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [c1e5545...a73941e](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-kyuubi] ulysses-you commented on a change in pull request #1037: Add classification of SQL_Type: for dql and auxiliary statement

Posted by GitBox <gi...@apache.org>.
ulysses-you commented on a change in pull request #1037:
URL: https://github.com/apache/incubator-kyuubi/pull/1037#discussion_r703474531



##########
File path: dev/kyuubi-extension-spark-3-1/src/main/scala/org/apache/kyuubi/sql/sqlclassification/KyuubiGetSqlClassification.scala
##########
@@ -28,22 +28,29 @@ import org.apache.kyuubi.sql.KyuubiSQLConf._
  * This object is used for getting sql_classification by the logicalPlan's simpleName.
  * When the configuration item: SQL_CLASSIFICATION_ENABLED is on,
  * we will load the rule from sql-classification-default.json.
+ *
+ * Notice:
+ *  We support the user use the self-defined matching rule: sql-classification.json.
+ *  If there have no this named jsonFile,
+ *  the service will upload the default matching rule: sql-classification-default.json.
  */
 object KyuubiGetSqlClassification {
 
   private val jsonNode: Option[JsonNode] = {
     SQLConf.get.getConf(SQL_CLASSIFICATION_ENABLED) match {
       case true =>
+        val objectMapper = new ObjectMapper
+        var defaultSqlClassificationFile: String = null
         try {
-          val defaultSqlClassificationFile =
-            Thread.currentThread().getContextClassLoader
-              .getResource("sql-classification-default.json").getPath
-          val objectMapper = new ObjectMapper
-          Some(objectMapper.readTree(new File(defaultSqlClassificationFile)))
+          defaultSqlClassificationFile = Thread.currentThread().getContextClassLoader
+            .getResource("sql-classification.json").getPath
         } catch {
-          case e: Exception =>
-            throw new IllegalArgumentException("sql-classification-default.json is not exist.", e)
+          case e: NullPointerException =>

Review comment:
       it's overkill to catch `NullPointerException`, `Exception` should be good enough




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1037: Add classification of SQL_Type: for dql and auxiliary statement

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1037:
URL: https://github.com/apache/incubator-kyuubi/pull/1037#issuecomment-913945391


   # [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1037](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9d346c6) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/c1e5545c648fbd9d62c562014447eea205849094?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c1e5545) will **increase** coverage by `0.32%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/graphs/tree.svg?width=650&height=150&src=pr&token=925D4tb9AH&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1037      +/-   ##
   ============================================
   + Coverage     78.42%   78.74%   +0.32%     
     Complexity       61       61              
   ============================================
     Files           167      169       +2     
     Lines          6196     6252      +56     
     Branches        723      725       +2     
   ============================================
   + Hits           4859     4923      +64     
   + Misses          915      907       -8     
     Partials        422      422              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...sqlclassification/KyuubiGetSqlClassification.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstMy0xL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9zcWxjbGFzc2lmaWNhdGlvbi9LeXV1YmlHZXRTcWxDbGFzc2lmaWNhdGlvbi5zY2FsYQ==) | `77.77% <100.00%> (+4.44%)` | :arrow_up: |
   | [...bi/sql/zorder/ZorderSparkSqlExtensionsParser.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstMy0xL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC96b3JkZXIvWm9yZGVyU3BhcmtTcWxFeHRlbnNpb25zUGFyc2VyLnNjYWxh) | `66.66% <0.00%> (-1.42%)` | :arrow_down: |
   | [...org/apache/kyuubi/server/RestFrontendService.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvUmVzdEZyb250ZW5kU2VydmljZS5zY2FsYQ==) | `83.92% <0.00%> (-0.69%)` | :arrow_down: |
   | [.../org/apache/kyuubi/events/KyuubiSessionEvent.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9ldmVudHMvS3l1dWJpU2Vzc2lvbkV2ZW50LnNjYWxh) | `92.00% <0.00%> (-0.31%)` | :arrow_down: |
   | [...ain/scala/org/apache/kyuubi/engine/EngineRef.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9lbmdpbmUvRW5naW5lUmVmLnNjYWxh) | `78.94% <0.00%> (-0.28%)` | :arrow_down: |
   | [...la/org/apache/kyuubi/session/AbstractSession.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXNzaW9uL0Fic3RyYWN0U2Vzc2lvbi5zY2FsYQ==) | `95.40% <0.00%> (-0.11%)` | :arrow_down: |
   | [...g/apache/kyuubi/session/KyuubiSessionManager.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXNzaW9uL0t5dXViaVNlc3Npb25NYW5hZ2VyLnNjYWxh) | `97.05% <0.00%> (ø)` | |
   | [.../apache/kyuubi/server/api/v1/ApiRootResource.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvYXBpL3YxL0FwaVJvb3RSZXNvdXJjZS5zY2FsYQ==) | `100.00% <0.00%> (ø)` | |
   | [...kyuubi/engine/spark/session/SparkSessionImpl.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1zcGFyay1zcWwtZW5naW5lL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2VuZ2luZS9zcGFyay9zZXNzaW9uL1NwYXJrU2Vzc2lvbkltcGwuc2NhbGE=) | `100.00% <0.00%> (ø)` | |
   | [...ache/kyuubi/sql/zorder/KyuubiZorderExtension.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstMy0xL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC96b3JkZXIvS3l1dWJpWm9yZGVyRXh0ZW5zaW9uLnNjYWxh) | | |
   | ... and [10 more](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [c1e5545...9d346c6](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1037: Add classification of SQL_Type: for dql and auxiliary statement

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1037:
URL: https://github.com/apache/incubator-kyuubi/pull/1037#issuecomment-913945391


   # [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1037](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a73941e) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/c1e5545c648fbd9d62c562014447eea205849094?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c1e5545) will **increase** coverage by `0.09%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/graphs/tree.svg?width=650&height=150&src=pr&token=925D4tb9AH&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1037      +/-   ##
   ============================================
   + Coverage     78.42%   78.51%   +0.09%     
   - Complexity       61       74      +13     
   ============================================
     Files           167      169       +2     
     Lines          6196     6464     +268     
     Branches        723      754      +31     
   ============================================
   + Hits           4859     5075     +216     
   - Misses          915      963      +48     
   - Partials        422      426       +4     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...sqlclassification/KyuubiGetSqlClassification.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstMy0xL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9zcWxjbGFzc2lmaWNhdGlvbi9LeXV1YmlHZXRTcWxDbGFzc2lmaWNhdGlvbi5zY2FsYQ==) | `77.77% <100.00%> (+4.44%)` | :arrow_up: |
   | [...g/apache/kyuubi/session/KyuubiSessionManager.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXNzaW9uL0t5dXViaVNlc3Npb25NYW5hZ2VyLnNjYWxh) | `95.00% <0.00%> (-2.06%)` | :arrow_down: |
   | [...org/apache/kyuubi/server/RestFrontendService.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvUmVzdEZyb250ZW5kU2VydmljZS5zY2FsYQ==) | `82.75% <0.00%> (-1.86%)` | :arrow_down: |
   | [.../apache/kyuubi/server/api/v1/ApiRootResource.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvYXBpL3YxL0FwaVJvb3RSZXNvdXJjZS5zY2FsYQ==) | `100.00% <0.00%> (ø)` | |
   | [...pache/kyuubi/sql/KyuubiQueryStagePreparation.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstMy0xL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9LeXV1YmlRdWVyeVN0YWdlUHJlcGFyYXRpb24uc2NhbGE=) | `80.39% <0.00%> (ø)` | |
   | [...kyuubi/engine/spark/session/SparkSessionImpl.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1zcGFyay1zcWwtZW5naW5lL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2VuZ2luZS9zcGFyay9zZXNzaW9uL1NwYXJrU2Vzc2lvbkltcGwuc2NhbGE=) | `100.00% <0.00%> (ø)` | |
   | [...apache/kyuubi/server/api/v1/SessionsResource.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvYXBpL3YxL1Nlc3Npb25zUmVzb3VyY2Uuc2NhbGE=) | `100.00% <0.00%> (ø)` | |
   | [...e/kyuubi/server/api/v1/dto/SessionOpenedCount.java](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3l1dWJpL3NlcnZlci9hcGkvdjEvZHRvL1Nlc3Npb25PcGVuZWRDb3VudC5qYXZh) | `100.00% <0.00%> (ø)` | |
   | [...la/org/apache/kyuubi/session/AbstractSession.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXNzaW9uL0Fic3RyYWN0U2Vzc2lvbi5zY2FsYQ==) | `97.08% <0.00%> (+1.57%)` | :arrow_up: |
   | [.../scala/org/apache/kyuubi/server/KyuubiServer.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvS3l1dWJpU2VydmVyLnNjYWxh) | `58.69% <0.00%> (+2.17%)` | :arrow_up: |
   | ... and [7 more](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [c1e5545...a73941e](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1037: Add classification of SQL_Type: for dql and auxiliary statement

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1037:
URL: https://github.com/apache/incubator-kyuubi/pull/1037#issuecomment-913945391


   # [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1037](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (72a18ec) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/c1e5545c648fbd9d62c562014447eea205849094?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c1e5545) will **increase** coverage by `0.18%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/graphs/tree.svg?width=650&height=150&src=pr&token=925D4tb9AH&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1037      +/-   ##
   ============================================
   + Coverage     78.42%   78.60%   +0.18%     
     Complexity       61       61              
   ============================================
     Files           167      168       +1     
     Lines          6196     6212      +16     
     Branches        723      725       +2     
   ============================================
   + Hits           4859     4883      +24     
   + Misses          915      907       -8     
     Partials        422      422              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...sqlclassification/KyuubiGetSqlClassification.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstMy0xL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9zcWxjbGFzc2lmaWNhdGlvbi9LeXV1YmlHZXRTcWxDbGFzc2lmaWNhdGlvbi5zY2FsYQ==) | `77.77% <100.00%> (+4.44%)` | :arrow_up: |
   | [...bi/sql/zorder/ZorderSparkSqlExtensionsParser.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstMy0xL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC96b3JkZXIvWm9yZGVyU3BhcmtTcWxFeHRlbnNpb25zUGFyc2VyLnNjYWxh) | `66.66% <0.00%> (-1.42%)` | :arrow_down: |
   | [...org/apache/kyuubi/server/RestFrontendService.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvUmVzdEZyb250ZW5kU2VydmljZS5zY2FsYQ==) | `83.92% <0.00%> (-0.69%)` | :arrow_down: |
   | [.../org/apache/kyuubi/events/KyuubiSessionEvent.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9ldmVudHMvS3l1dWJpU2Vzc2lvbkV2ZW50LnNjYWxh) | `92.00% <0.00%> (-0.31%)` | :arrow_down: |
   | [...ain/scala/org/apache/kyuubi/engine/EngineRef.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9lbmdpbmUvRW5naW5lUmVmLnNjYWxh) | `78.94% <0.00%> (-0.28%)` | :arrow_down: |
   | [...la/org/apache/kyuubi/session/AbstractSession.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXNzaW9uL0Fic3RyYWN0U2Vzc2lvbi5zY2FsYQ==) | `95.40% <0.00%> (-0.11%)` | :arrow_down: |
   | [...g/apache/kyuubi/session/KyuubiSessionManager.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXNzaW9uL0t5dXViaVNlc3Npb25NYW5hZ2VyLnNjYWxh) | `97.05% <0.00%> (ø)` | |
   | [.../apache/kyuubi/server/api/v1/ApiRootResource.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvYXBpL3YxL0FwaVJvb3RSZXNvdXJjZS5zY2FsYQ==) | `100.00% <0.00%> (ø)` | |
   | [...pache/kyuubi/sql/KyuubiQueryStagePreparation.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstMy0xL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9LeXV1YmlRdWVyeVN0YWdlUHJlcGFyYXRpb24uc2NhbGE=) | `80.39% <0.00%> (ø)` | |
   | [...kyuubi/engine/spark/session/SparkSessionImpl.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1zcGFyay1zcWwtZW5naW5lL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2VuZ2luZS9zcGFyay9zZXNzaW9uL1NwYXJrU2Vzc2lvbkltcGwuc2NhbGE=) | `100.00% <0.00%> (ø)` | |
   | ... and [8 more](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [c1e5545...72a18ec](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-kyuubi] ulysses-you commented on a change in pull request #1037: Add classification of SQL_Type: for dql and auxiliary statement

Posted by GitBox <gi...@apache.org>.
ulysses-you commented on a change in pull request #1037:
URL: https://github.com/apache/incubator-kyuubi/pull/1037#discussion_r703452056



##########
File path: dev/kyuubi-extension-spark-3-1/src/main/resources/sql-classification-default.json
##########
@@ -1,34 +1,60 @@
 {
   "AlterDatabasePropertiesCommand": "ddl",
-  "AlterTableRenameCommand": "ddl",
-  "AlterTableRenamePartitionCommand": "ddl",
   "AlterTableAddColumnsCommand": "ddl",
-  "AlterTableChangeColumnCommand": "ddl",
   "AlterTableAddPartitionCommand": "ddl",
+  "AlterTableChangeColumnCommand": "ddl",
   "AlterTableDropPartitionCommand": "ddl",
-  "AlterTableSetPropertiesCommand": "ddl",
-  "AlterTableSetLocationCommand": "ddl",
-  "AlterTableSerDePropertiesCommand": "ddl",
-  "AlterTableUnsetPropertiesCommand": "ddl",
+  "AlterTableRecoverPartitionsCommand": "ddl",
+  "AlterTableRenameCommand": "ddl",
   "AlterTableRenameCommand": "ddl",
+  "AlterTableRenamePartitionCommand": "ddl",
+  "AlterTableSerDePropertiesCommand": "ddl",
+  "AlterTableSetLocationCommand": "ddl",
   "AlterTableSetPropertiesCommand": "ddl",
+  "AlterTableSetPropertiesCommand": "ddl",
+  "AlterTableUnsetPropertiesCommand": "ddl",
   "AlterTableUnsetPropertiesCommand": "ddl",
   "AlterViewAsCommand": "ddl",
+  "CreateDataSourceTableAsSelectCommand": "ddl",
+  "CreateDataSourceTableCommand": "ddl",
   "CreateDatabaseCommand": "ddl",
   "CreateFunctionCommand": "ddl",
-  "CreateDataSourceTableCommand": "ddl",
-  "CreateDataSourceTableAsSelectCommand": "ddl",
   "CreateTableLikeCommand": "ddl",
   "CreateViewCommand": "ddl",
   "DropDatabaseCommand": "ddl",
   "DropFunctionCommand": "ddl",
-  "NoopDropTable": "ddl",
   "DropTableCommand": "ddl",
-  "TruncateTableCommand": "ddl",
-  "AlterTableRecoverPartitionsCommand": "ddl",
+  "NoopDropTable": "ddl",
   "SetCatalogAndNamespace": "ddl",
+  "TruncateTableCommand": "ddl",
+  "InsertIntoDataSourceDirCommand": "dml",
   "InsertIntoHadoopFsRelationCommand": "dml",
+  "InsertIntoHiveDirCommand": "dml",
   "LoadDataCommand": "dml",
-  "InsertIntoDataSourceDirCommand": "dml",
-  "InsertIntoHiveDirCommand": "dml"
+  "AddFileCommand": "other",
+  "AddJarCommand": "other",
+  "AnalyzeTable": "other",
+  "CacheTableCommand": "other",
+  "ClearCacheCommand$": "other",
+  "DescribeColumnCommand": "other",
+  "DescribeDatabaseCommand": "other",
+  "DescribeFunctionCommand": "other",
+  "DescribeQueryCommand": "other",
+  "DescribeTableCommand": "other",
+  "ListFilesCommand": "other",
+  "ListJarsCommand": "other",

Review comment:
       ah, this is in spark 3.2




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1037: Add classification of SQL_Type: for dql and auxiliary statement

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1037:
URL: https://github.com/apache/incubator-kyuubi/pull/1037#issuecomment-913945391


   # [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1037](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d258e80) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/c1e5545c648fbd9d62c562014447eea205849094?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c1e5545) will **increase** coverage by `0.23%`.
   > The diff coverage is `100.00%`.
   
   > :exclamation: Current head d258e80 differs from pull request most recent head d7f7538. Consider uploading reports for the commit d7f7538 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/graphs/tree.svg?width=650&height=150&src=pr&token=925D4tb9AH&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1037      +/-   ##
   ============================================
   + Coverage     78.42%   78.65%   +0.23%     
     Complexity       61       61              
   ============================================
     Files           167      167              
     Lines          6196     6306     +110     
     Branches        723      738      +15     
   ============================================
   + Hits           4859     4960     +101     
   - Misses          915      921       +6     
   - Partials        422      425       +3     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...sqlclassification/KyuubiGetSqlClassification.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstMy0xL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9zcWxjbGFzc2lmaWNhdGlvbi9LeXV1YmlHZXRTcWxDbGFzc2lmaWNhdGlvbi5zY2FsYQ==) | `77.77% <100.00%> (+4.44%)` | :arrow_up: |
   | [...g/apache/kyuubi/session/KyuubiSessionManager.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXNzaW9uL0t5dXViaVNlc3Npb25NYW5hZ2VyLnNjYWxh) | `95.00% <0.00%> (-2.06%)` | :arrow_down: |
   | [...pache/kyuubi/sql/KyuubiQueryStagePreparation.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstMy0xL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9LeXV1YmlRdWVyeVN0YWdlUHJlcGFyYXRpb24uc2NhbGE=) | `80.39% <0.00%> (ø)` | |
   | [.../apache/kyuubi/client/KyuubiSyncThriftClient.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jbGllbnQvS3l1dWJpU3luY1RocmlmdENsaWVudC5zY2FsYQ==) | `84.05% <0.00%> (+2.23%)` | :arrow_up: |
   | [...ain/scala/org/apache/kyuubi/engine/EngineRef.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9lbmdpbmUvRW5naW5lUmVmLnNjYWxh) | `82.56% <0.00%> (+3.34%)` | :arrow_up: |
   | [.../org/apache/kyuubi/session/KyuubiSessionImpl.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXNzaW9uL0t5dXViaVNlc3Npb25JbXBsLnNjYWxh) | `91.37% <0.00%> (+3.57%)` | :arrow_up: |
   | [.../org/apache/kyuubi/events/KyuubiSessionEvent.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9ldmVudHMvS3l1dWJpU2Vzc2lvbkV2ZW50LnNjYWxh) | `96.42% <0.00%> (+4.12%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [c1e5545...d7f7538](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-kyuubi] zhang1002 commented on a change in pull request #1037: Add classification of SQL_Type: for dql and auxiliary statement

Posted by GitBox <gi...@apache.org>.
zhang1002 commented on a change in pull request #1037:
URL: https://github.com/apache/incubator-kyuubi/pull/1037#discussion_r703432993



##########
File path: dev/kyuubi-extension-spark-3-1/src/test/resources/sql-classification-default.json
##########
@@ -1,34 +1,60 @@
 {
   "AlterDatabasePropertiesCommand": "ddl",
-  "AlterTableRenameCommand": "ddl",
-  "AlterTableRenamePartitionCommand": "ddl",
   "AlterTableAddColumnsCommand": "ddl",
-  "AlterTableChangeColumnCommand": "ddl",
   "AlterTableAddPartitionCommand": "ddl",
+  "AlterTableChangeColumnCommand": "ddl",
   "AlterTableDropPartitionCommand": "ddl",
-  "AlterTableSetPropertiesCommand": "ddl",
-  "AlterTableSetLocationCommand": "ddl",
-  "AlterTableSerDePropertiesCommand": "ddl",
-  "AlterTableUnsetPropertiesCommand": "ddl",
+  "AlterTableRecoverPartitionsCommand": "ddl",
+  "AlterTableRenameCommand": "ddl",
   "AlterTableRenameCommand": "ddl",
+  "AlterTableRenamePartitionCommand": "ddl",
+  "AlterTableSerDePropertiesCommand": "ddl",
+  "AlterTableSetLocationCommand": "ddl",
   "AlterTableSetPropertiesCommand": "ddl",
+  "AlterTableSetPropertiesCommand": "ddl",
+  "AlterTableUnsetPropertiesCommand": "ddl",
   "AlterTableUnsetPropertiesCommand": "ddl",
   "AlterViewAsCommand": "ddl",
+  "CreateDataSourceTableAsSelectCommand": "ddl",
+  "CreateDataSourceTableCommand": "ddl",
   "CreateDatabaseCommand": "ddl",
   "CreateFunctionCommand": "ddl",
-  "CreateDataSourceTableCommand": "ddl",
-  "CreateDataSourceTableAsSelectCommand": "ddl",
   "CreateTableLikeCommand": "ddl",
   "CreateViewCommand": "ddl",
   "DropDatabaseCommand": "ddl",
   "DropFunctionCommand": "ddl",
-  "NoopDropTable": "ddl",
   "DropTableCommand": "ddl",
-  "TruncateTableCommand": "ddl",
-  "AlterTableRecoverPartitionsCommand": "ddl",
+  "NoopDropTable": "ddl",
   "SetCatalogAndNamespace": "ddl",
+  "TruncateTableCommand": "ddl",
+  "InsertIntoDataSourceDirCommand": "dml",
   "InsertIntoHadoopFsRelationCommand": "dml",
+  "InsertIntoHiveDirCommand": "dml",

Review comment:
       this grammar is "INSERT OVERWRITE DIRECTORY".
   when we got its logicalPlan, the simple name is "InsertIntoDataSourceDirCommand"




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1037: Add classification of SQL_Type: for dql and auxiliary statement

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1037:
URL: https://github.com/apache/incubator-kyuubi/pull/1037#issuecomment-913945391


   # [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1037](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d7f7538) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/c1e5545c648fbd9d62c562014447eea205849094?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c1e5545) will **increase** coverage by `0.24%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/graphs/tree.svg?width=650&height=150&src=pr&token=925D4tb9AH&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1037      +/-   ##
   ============================================
   + Coverage     78.42%   78.67%   +0.24%     
     Complexity       61       61              
   ============================================
     Files           167      167              
     Lines          6196     6306     +110     
     Branches        723      738      +15     
   ============================================
   + Hits           4859     4961     +102     
   - Misses          915      921       +6     
   - Partials        422      424       +2     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...sqlclassification/KyuubiGetSqlClassification.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstMy0xL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9zcWxjbGFzc2lmaWNhdGlvbi9LeXV1YmlHZXRTcWxDbGFzc2lmaWNhdGlvbi5zY2FsYQ==) | `77.77% <100.00%> (+4.44%)` | :arrow_up: |
   | [...g/apache/kyuubi/session/KyuubiSessionManager.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXNzaW9uL0t5dXViaVNlc3Npb25NYW5hZ2VyLnNjYWxh) | `95.00% <0.00%> (-2.06%)` | :arrow_down: |
   | [...pache/kyuubi/sql/KyuubiQueryStagePreparation.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstMy0xL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9LeXV1YmlRdWVyeVN0YWdlUHJlcGFyYXRpb24uc2NhbGE=) | `80.39% <0.00%> (ø)` | |
   | [...n/scala/org/apache/kyuubi/engine/ProcBuilder.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9lbmdpbmUvUHJvY0J1aWxkZXIuc2NhbGE=) | `92.20% <0.00%> (+1.29%)` | :arrow_up: |
   | [.../apache/kyuubi/client/KyuubiSyncThriftClient.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jbGllbnQvS3l1dWJpU3luY1RocmlmdENsaWVudC5zY2FsYQ==) | `84.05% <0.00%> (+2.23%)` | :arrow_up: |
   | [...ain/scala/org/apache/kyuubi/engine/EngineRef.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9lbmdpbmUvRW5naW5lUmVmLnNjYWxh) | `82.56% <0.00%> (+3.34%)` | :arrow_up: |
   | [.../org/apache/kyuubi/session/KyuubiSessionImpl.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXNzaW9uL0t5dXViaVNlc3Npb25JbXBsLnNjYWxh) | `91.37% <0.00%> (+3.57%)` | :arrow_up: |
   | [.../org/apache/kyuubi/events/KyuubiSessionEvent.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9ldmVudHMvS3l1dWJpU2Vzc2lvbkV2ZW50LnNjYWxh) | `96.42% <0.00%> (+4.12%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [c1e5545...d7f7538](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-kyuubi] zhang1002 commented on pull request #1037: Add classification of SQL_Type: for dql and auxiliary statement

Posted by GitBox <gi...@apache.org>.
zhang1002 commented on pull request #1037:
URL: https://github.com/apache/incubator-kyuubi/pull/1037#issuecomment-913481946


   cc @yaooqinn @ulysses-you @zhouyifan279 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1037: Add classification of SQL_Type: for dql and auxiliary statement

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1037:
URL: https://github.com/apache/incubator-kyuubi/pull/1037#issuecomment-913945391


   # [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1037](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a73941e) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/c1e5545c648fbd9d62c562014447eea205849094?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c1e5545) will **increase** coverage by `0.02%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/graphs/tree.svg?width=650&height=150&src=pr&token=925D4tb9AH&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1037      +/-   ##
   ============================================
   + Coverage     78.42%   78.44%   +0.02%     
     Complexity       61       61              
   ============================================
     Files           167      167              
     Lines          6196     6199       +3     
     Branches        723      723              
   ============================================
   + Hits           4859     4863       +4     
   + Misses          915      914       -1     
     Partials        422      422              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...sqlclassification/KyuubiGetSqlClassification.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstMy0xL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9zcWxjbGFzc2lmaWNhdGlvbi9LeXV1YmlHZXRTcWxDbGFzc2lmaWNhdGlvbi5zY2FsYQ==) | `77.77% <100.00%> (+4.44%)` | :arrow_up: |
   | [...pache/kyuubi/sql/KyuubiQueryStagePreparation.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstMy0xL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9LeXV1YmlRdWVyeVN0YWdlUHJlcGFyYXRpb24uc2NhbGE=) | `80.39% <0.00%> (ø)` | |
   | [.../scala/org/apache/kyuubi/server/KyuubiServer.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvS3l1dWJpU2VydmVyLnNjYWxh) | `58.69% <0.00%> (+2.17%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [c1e5545...a73941e](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1037: Add classification of SQL_Type: for dql and auxiliary statement

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1037:
URL: https://github.com/apache/incubator-kyuubi/pull/1037#issuecomment-913945391


   # [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1037](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9d346c6) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/c1e5545c648fbd9d62c562014447eea205849094?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c1e5545) will **increase** coverage by `0.69%`.
   > The diff coverage is `100.00%`.
   
   > :exclamation: Current head 9d346c6 differs from pull request most recent head e94ad82. Consider uploading reports for the commit e94ad82 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/graphs/tree.svg?width=650&height=150&src=pr&token=925D4tb9AH&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1037      +/-   ##
   ============================================
   + Coverage     78.42%   79.11%   +0.69%     
   - Complexity       61       81      +20     
   ============================================
     Files           167      170       +3     
     Lines          6196     6650     +454     
     Branches        723      765      +42     
   ============================================
   + Hits           4859     5261     +402     
   - Misses          915      963      +48     
   - Partials        422      426       +4     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...sqlclassification/KyuubiGetSqlClassification.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstMy0xL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9zcWxjbGFzc2lmaWNhdGlvbi9LeXV1YmlHZXRTcWxDbGFzc2lmaWNhdGlvbi5zY2FsYQ==) | `77.77% <100.00%> (+4.44%)` | :arrow_up: |
   | [...g/apache/kyuubi/session/KyuubiSessionManager.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXNzaW9uL0t5dXViaVNlc3Npb25NYW5hZ2VyLnNjYWxh) | `95.00% <0.00%> (-2.06%)` | :arrow_down: |
   | [...org/apache/kyuubi/server/RestFrontendService.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvUmVzdEZyb250ZW5kU2VydmljZS5zY2FsYQ==) | `82.75% <0.00%> (-1.86%)` | :arrow_down: |
   | [.../apache/kyuubi/server/api/v1/ApiRootResource.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvYXBpL3YxL0FwaVJvb3RSZXNvdXJjZS5zY2FsYQ==) | `100.00% <0.00%> (ø)` | |
   | [...kyuubi/engine/spark/session/SparkSessionImpl.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1zcGFyay1zcWwtZW5naW5lL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2VuZ2luZS9zcGFyay9zZXNzaW9uL1NwYXJrU2Vzc2lvbkltcGwuc2NhbGE=) | `100.00% <0.00%> (ø)` | |
   | [...apache/kyuubi/server/api/v1/SessionsResource.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvYXBpL3YxL1Nlc3Npb25zUmVzb3VyY2Uuc2NhbGE=) | `100.00% <0.00%> (ø)` | |
   | [.../credentials/HadoopFsDelegationTokenProvider.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jcmVkZW50aWFscy9IYWRvb3BGc0RlbGVnYXRpb25Ub2tlblByb3ZpZGVyLnNjYWxh) | `96.42% <0.00%> (ø)` | |
   | [...e/kyuubi/server/api/v1/dto/SessionOpenedCount.java](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3l1dWJpL3NlcnZlci9hcGkvdjEvZHRvL1Nlc3Npb25PcGVuZWRDb3VudC5qYXZh) | `100.00% <0.00%> (ø)` | |
   | [...pache/kyuubi/sql/KyuubiQueryStagePreparation.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstMy0xL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9LeXV1YmlRdWVyeVN0YWdlUHJlcGFyYXRpb24uc2NhbGE=) | `81.37% <0.00%> (+0.98%)` | :arrow_up: |
   | [...in/scala/org/apache/kyuubi/config/KyuubiConf.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jb25maWcvS3l1dWJpQ29uZi5zY2FsYQ==) | `96.31% <0.00%> (+1.17%)` | :arrow_up: |
   | ... and [9 more](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [c1e5545...e94ad82](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-kyuubi] ulysses-you commented on a change in pull request #1037: Add classification of SQL_Type: for dql and auxiliary statement

Posted by GitBox <gi...@apache.org>.
ulysses-you commented on a change in pull request #1037:
URL: https://github.com/apache/incubator-kyuubi/pull/1037#discussion_r703473781



##########
File path: dev/kyuubi-extension-spark-3-1/src/main/scala/org/apache/kyuubi/sql/sqlclassification/KyuubiGetSqlClassification.scala
##########
@@ -28,22 +28,29 @@ import org.apache.kyuubi.sql.KyuubiSQLConf._
  * This object is used for getting sql_classification by the logicalPlan's simpleName.
  * When the configuration item: SQL_CLASSIFICATION_ENABLED is on,
  * we will load the rule from sql-classification-default.json.
+ *
+ * Notice:
+ *  We support the user use the self-defined matching rule: sql-classification.json.
+ *  If there have no this named jsonFile,
+ *  the service will upload the default matching rule: sql-classification-default.json.
  */
 object KyuubiGetSqlClassification {
 
   private val jsonNode: Option[JsonNode] = {
     SQLConf.get.getConf(SQL_CLASSIFICATION_ENABLED) match {

Review comment:
       not related this PR, we don't need check this config here since we check it at use side. That saied we can always load the file but use it depend on the config. can you send a new PR to do this ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-kyuubi] ulysses-you closed pull request #1037: Add classification of SQL_Type: for dql and auxiliary statement

Posted by GitBox <gi...@apache.org>.
ulysses-you closed pull request #1037:
URL: https://github.com/apache/incubator-kyuubi/pull/1037


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-kyuubi] ulysses-you commented on pull request #1037: Add classification of SQL_Type: for dql and auxiliary statement

Posted by GitBox <gi...@apache.org>.
ulysses-you commented on pull request #1037:
URL: https://github.com/apache/incubator-kyuubi/pull/1037#issuecomment-915860833


   thanks, merging to master. Hope we can optimize the test quickly about https://github.com/apache/incubator-kyuubi/issues/1064


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-kyuubi] zhang1002 commented on a change in pull request #1037: Add classification of SQL_Type: for dql and auxiliary statement

Posted by GitBox <gi...@apache.org>.
zhang1002 commented on a change in pull request #1037:
URL: https://github.com/apache/incubator-kyuubi/pull/1037#discussion_r703443315



##########
File path: dev/kyuubi-extension-spark-3-1/src/main/resources/sql-classification-default.json
##########
@@ -1,34 +1,60 @@
 {
   "AlterDatabasePropertiesCommand": "ddl",
-  "AlterTableRenameCommand": "ddl",
-  "AlterTableRenamePartitionCommand": "ddl",
   "AlterTableAddColumnsCommand": "ddl",
-  "AlterTableChangeColumnCommand": "ddl",
   "AlterTableAddPartitionCommand": "ddl",
+  "AlterTableChangeColumnCommand": "ddl",
   "AlterTableDropPartitionCommand": "ddl",
-  "AlterTableSetPropertiesCommand": "ddl",
-  "AlterTableSetLocationCommand": "ddl",
-  "AlterTableSerDePropertiesCommand": "ddl",
-  "AlterTableUnsetPropertiesCommand": "ddl",
+  "AlterTableRecoverPartitionsCommand": "ddl",

Review comment:
       There is no such grammar.
   "REPAIR TABLE" is belong to "AlterTableRecoverPartitionsCommand".




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1037: Add classification of SQL_Type: for dql and auxiliary statement

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1037:
URL: https://github.com/apache/incubator-kyuubi/pull/1037#issuecomment-913945391


   # [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1037](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9d346c6) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/c1e5545c648fbd9d62c562014447eea205849094?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c1e5545) will **increase** coverage by `0.69%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/graphs/tree.svg?width=650&height=150&src=pr&token=925D4tb9AH&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1037      +/-   ##
   ============================================
   + Coverage     78.42%   79.11%   +0.69%     
   - Complexity       61       81      +20     
   ============================================
     Files           167      170       +3     
     Lines          6196     6650     +454     
     Branches        723      765      +42     
   ============================================
   + Hits           4859     5261     +402     
   - Misses          915      963      +48     
   - Partials        422      426       +4     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...sqlclassification/KyuubiGetSqlClassification.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstMy0xL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9zcWxjbGFzc2lmaWNhdGlvbi9LeXV1YmlHZXRTcWxDbGFzc2lmaWNhdGlvbi5zY2FsYQ==) | `77.77% <100.00%> (+4.44%)` | :arrow_up: |
   | [...g/apache/kyuubi/session/KyuubiSessionManager.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXNzaW9uL0t5dXViaVNlc3Npb25NYW5hZ2VyLnNjYWxh) | `95.00% <0.00%> (-2.06%)` | :arrow_down: |
   | [...org/apache/kyuubi/server/RestFrontendService.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvUmVzdEZyb250ZW5kU2VydmljZS5zY2FsYQ==) | `82.75% <0.00%> (-1.86%)` | :arrow_down: |
   | [.../apache/kyuubi/server/api/v1/ApiRootResource.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvYXBpL3YxL0FwaVJvb3RSZXNvdXJjZS5zY2FsYQ==) | `100.00% <0.00%> (ø)` | |
   | [...kyuubi/engine/spark/session/SparkSessionImpl.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1zcGFyay1zcWwtZW5naW5lL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2VuZ2luZS9zcGFyay9zZXNzaW9uL1NwYXJrU2Vzc2lvbkltcGwuc2NhbGE=) | `100.00% <0.00%> (ø)` | |
   | [...apache/kyuubi/server/api/v1/SessionsResource.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvYXBpL3YxL1Nlc3Npb25zUmVzb3VyY2Uuc2NhbGE=) | `100.00% <0.00%> (ø)` | |
   | [.../credentials/HadoopFsDelegationTokenProvider.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jcmVkZW50aWFscy9IYWRvb3BGc0RlbGVnYXRpb25Ub2tlblByb3ZpZGVyLnNjYWxh) | `96.42% <0.00%> (ø)` | |
   | [...e/kyuubi/server/api/v1/dto/SessionOpenedCount.java](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3l1dWJpL3NlcnZlci9hcGkvdjEvZHRvL1Nlc3Npb25PcGVuZWRDb3VudC5qYXZh) | `100.00% <0.00%> (ø)` | |
   | [...pache/kyuubi/sql/KyuubiQueryStagePreparation.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstMy0xL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9LeXV1YmlRdWVyeVN0YWdlUHJlcGFyYXRpb24uc2NhbGE=) | `81.37% <0.00%> (+0.98%)` | :arrow_up: |
   | [...in/scala/org/apache/kyuubi/config/KyuubiConf.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jb25maWcvS3l1dWJpQ29uZi5zY2FsYQ==) | `96.31% <0.00%> (+1.17%)` | :arrow_up: |
   | ... and [9 more](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [c1e5545...9d346c6](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-kyuubi] zhang1002 commented on a change in pull request #1037: Add classification of SQL_Type: for dql and auxiliary statement

Posted by GitBox <gi...@apache.org>.
zhang1002 commented on a change in pull request #1037:
URL: https://github.com/apache/incubator-kyuubi/pull/1037#discussion_r703454190



##########
File path: dev/kyuubi-extension-spark-3-1/src/main/resources/sql-classification-default.json
##########
@@ -1,34 +1,60 @@
 {
   "AlterDatabasePropertiesCommand": "ddl",
-  "AlterTableRenameCommand": "ddl",
-  "AlterTableRenamePartitionCommand": "ddl",
   "AlterTableAddColumnsCommand": "ddl",
-  "AlterTableChangeColumnCommand": "ddl",
   "AlterTableAddPartitionCommand": "ddl",
+  "AlterTableChangeColumnCommand": "ddl",
   "AlterTableDropPartitionCommand": "ddl",
-  "AlterTableSetPropertiesCommand": "ddl",
-  "AlterTableSetLocationCommand": "ddl",
-  "AlterTableSerDePropertiesCommand": "ddl",
-  "AlterTableUnsetPropertiesCommand": "ddl",
+  "AlterTableRecoverPartitionsCommand": "ddl",
+  "AlterTableRenameCommand": "ddl",
   "AlterTableRenameCommand": "ddl",
+  "AlterTableRenamePartitionCommand": "ddl",
+  "AlterTableSerDePropertiesCommand": "ddl",
+  "AlterTableSetLocationCommand": "ddl",
   "AlterTableSetPropertiesCommand": "ddl",
+  "AlterTableSetPropertiesCommand": "ddl",
+  "AlterTableUnsetPropertiesCommand": "ddl",
   "AlterTableUnsetPropertiesCommand": "ddl",
   "AlterViewAsCommand": "ddl",
+  "CreateDataSourceTableAsSelectCommand": "ddl",
+  "CreateDataSourceTableCommand": "ddl",
   "CreateDatabaseCommand": "ddl",
   "CreateFunctionCommand": "ddl",
-  "CreateDataSourceTableCommand": "ddl",
-  "CreateDataSourceTableAsSelectCommand": "ddl",
   "CreateTableLikeCommand": "ddl",
   "CreateViewCommand": "ddl",
   "DropDatabaseCommand": "ddl",
   "DropFunctionCommand": "ddl",
-  "NoopDropTable": "ddl",
   "DropTableCommand": "ddl",
-  "TruncateTableCommand": "ddl",
-  "AlterTableRecoverPartitionsCommand": "ddl",
+  "NoopDropTable": "ddl",
   "SetCatalogAndNamespace": "ddl",
+  "TruncateTableCommand": "ddl",
+  "InsertIntoDataSourceDirCommand": "dml",
   "InsertIntoHadoopFsRelationCommand": "dml",
+  "InsertIntoHiveDirCommand": "dml",
   "LoadDataCommand": "dml",
-  "InsertIntoDataSourceDirCommand": "dml",
-  "InsertIntoHiveDirCommand": "dml"
+  "AddFileCommand": "other",
+  "AddJarCommand": "other",
+  "AnalyzeTable": "other",
+  "CacheTableCommand": "other",
+  "ClearCacheCommand$": "other",
+  "DescribeColumnCommand": "other",
+  "DescribeDatabaseCommand": "other",
+  "DescribeFunctionCommand": "other",
+  "DescribeQueryCommand": "other",
+  "DescribeTableCommand": "other",
+  "ListFilesCommand": "other",
+  "ListJarsCommand": "other",

Review comment:
       e...
   this sql classification is based on spark_version_3.1.2




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-kyuubi] ulysses-you commented on a change in pull request #1037: Add classification of SQL_Type: for dql and auxiliary statement

Posted by GitBox <gi...@apache.org>.
ulysses-you commented on a change in pull request #1037:
URL: https://github.com/apache/incubator-kyuubi/pull/1037#discussion_r703323541



##########
File path: dev/kyuubi-extension-spark-3-1/src/main/resources/sql-classification-default.json
##########
@@ -1,34 +1,60 @@
 {
   "AlterDatabasePropertiesCommand": "ddl",
-  "AlterTableRenameCommand": "ddl",
-  "AlterTableRenamePartitionCommand": "ddl",
   "AlterTableAddColumnsCommand": "ddl",
-  "AlterTableChangeColumnCommand": "ddl",
   "AlterTableAddPartitionCommand": "ddl",
+  "AlterTableChangeColumnCommand": "ddl",
   "AlterTableDropPartitionCommand": "ddl",
-  "AlterTableSetPropertiesCommand": "ddl",
-  "AlterTableSetLocationCommand": "ddl",
-  "AlterTableSerDePropertiesCommand": "ddl",
-  "AlterTableUnsetPropertiesCommand": "ddl",
+  "AlterTableRecoverPartitionsCommand": "ddl",
+  "AlterTableRenameCommand": "ddl",
   "AlterTableRenameCommand": "ddl",
+  "AlterTableRenamePartitionCommand": "ddl",
+  "AlterTableSerDePropertiesCommand": "ddl",
+  "AlterTableSetLocationCommand": "ddl",
   "AlterTableSetPropertiesCommand": "ddl",
+  "AlterTableSetPropertiesCommand": "ddl",
+  "AlterTableUnsetPropertiesCommand": "ddl",
   "AlterTableUnsetPropertiesCommand": "ddl",
   "AlterViewAsCommand": "ddl",
+  "CreateDataSourceTableAsSelectCommand": "ddl",
+  "CreateDataSourceTableCommand": "ddl",
   "CreateDatabaseCommand": "ddl",
   "CreateFunctionCommand": "ddl",
-  "CreateDataSourceTableCommand": "ddl",
-  "CreateDataSourceTableAsSelectCommand": "ddl",
   "CreateTableLikeCommand": "ddl",
   "CreateViewCommand": "ddl",
   "DropDatabaseCommand": "ddl",
   "DropFunctionCommand": "ddl",
-  "NoopDropTable": "ddl",
   "DropTableCommand": "ddl",
-  "TruncateTableCommand": "ddl",
-  "AlterTableRecoverPartitionsCommand": "ddl",
+  "NoopDropTable": "ddl",
   "SetCatalogAndNamespace": "ddl",
+  "TruncateTableCommand": "ddl",

Review comment:
       TruncatePartitionCommand




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-kyuubi] zhang1002 commented on a change in pull request #1037: Add classification of SQL_Type: for dql and auxiliary statement

Posted by GitBox <gi...@apache.org>.
zhang1002 commented on a change in pull request #1037:
URL: https://github.com/apache/incubator-kyuubi/pull/1037#discussion_r703426069



##########
File path: dev/kyuubi-extension-spark-3-1/src/main/resources/sql-classification-default.json
##########
@@ -1,34 +1,60 @@
 {
   "AlterDatabasePropertiesCommand": "ddl",
-  "AlterTableRenameCommand": "ddl",
-  "AlterTableRenamePartitionCommand": "ddl",
   "AlterTableAddColumnsCommand": "ddl",
-  "AlterTableChangeColumnCommand": "ddl",
   "AlterTableAddPartitionCommand": "ddl",
+  "AlterTableChangeColumnCommand": "ddl",
   "AlterTableDropPartitionCommand": "ddl",
-  "AlterTableSetPropertiesCommand": "ddl",
-  "AlterTableSetLocationCommand": "ddl",
-  "AlterTableSerDePropertiesCommand": "ddl",
-  "AlterTableUnsetPropertiesCommand": "ddl",
+  "AlterTableRecoverPartitionsCommand": "ddl",
+  "AlterTableRenameCommand": "ddl",
   "AlterTableRenameCommand": "ddl",
+  "AlterTableRenamePartitionCommand": "ddl",
+  "AlterTableSerDePropertiesCommand": "ddl",
+  "AlterTableSetLocationCommand": "ddl",
   "AlterTableSetPropertiesCommand": "ddl",
+  "AlterTableSetPropertiesCommand": "ddl",
+  "AlterTableUnsetPropertiesCommand": "ddl",
   "AlterTableUnsetPropertiesCommand": "ddl",
   "AlterViewAsCommand": "ddl",
+  "CreateDataSourceTableAsSelectCommand": "ddl",
+  "CreateDataSourceTableCommand": "ddl",
   "CreateDatabaseCommand": "ddl",
   "CreateFunctionCommand": "ddl",
-  "CreateDataSourceTableCommand": "ddl",
-  "CreateDataSourceTableAsSelectCommand": "ddl",
   "CreateTableLikeCommand": "ddl",
   "CreateViewCommand": "ddl",
   "DropDatabaseCommand": "ddl",
   "DropFunctionCommand": "ddl",
-  "NoopDropTable": "ddl",
   "DropTableCommand": "ddl",
-  "TruncateTableCommand": "ddl",
-  "AlterTableRecoverPartitionsCommand": "ddl",
+  "NoopDropTable": "ddl",
   "SetCatalogAndNamespace": "ddl",
+  "TruncateTableCommand": "ddl",
+  "InsertIntoDataSourceDirCommand": "dml",
   "InsertIntoHadoopFsRelationCommand": "dml",
+  "InsertIntoHiveDirCommand": "dml",
   "LoadDataCommand": "dml",
-  "InsertIntoDataSourceDirCommand": "dml",
-  "InsertIntoHiveDirCommand": "dml"
+  "AddFileCommand": "other",
+  "AddJarCommand": "other",
+  "AnalyzeTable": "other",
+  "CacheTableCommand": "other",
+  "ClearCacheCommand$": "other",
+  "DescribeColumnCommand": "other",
+  "DescribeDatabaseCommand": "other",
+  "DescribeFunctionCommand": "other",
+  "DescribeQueryCommand": "other",
+  "DescribeTableCommand": "other",
+  "ListFilesCommand": "other",
+  "ListJarsCommand": "other",
+  "RefreshFunctionCommand": "other",
+  "RefreshResource": "other",
+  "RefreshTableCommand": "other",
+  "ResetCommand": "other",
+  "SetCommand": "other",
+  "ShowColumnsCommand": "other",
+  "ShowCreateTableCommand": "other",
+  "ShowFunctionsCommand": "other",
+  "ShowNamespaces": "other",
+  "ShowPartitionsCommand": "other",
+  "ShowTablePropertiesCommand": "other",
+  "ShowTablesCommand": "other",
+  "ShowViewsCommand": "other",
+  "UncacheTableCommand": "other"

Review comment:
       done




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-kyuubi] zhang1002 commented on a change in pull request #1037: Add classification of SQL_Type: for dql and auxiliary statement

Posted by GitBox <gi...@apache.org>.
zhang1002 commented on a change in pull request #1037:
URL: https://github.com/apache/incubator-kyuubi/pull/1037#discussion_r703426343



##########
File path: dev/kyuubi-extension-spark-3-1/src/main/resources/sql-classification-default.json
##########
@@ -1,34 +1,60 @@
 {
   "AlterDatabasePropertiesCommand": "ddl",
-  "AlterTableRenameCommand": "ddl",
-  "AlterTableRenamePartitionCommand": "ddl",
   "AlterTableAddColumnsCommand": "ddl",
-  "AlterTableChangeColumnCommand": "ddl",
   "AlterTableAddPartitionCommand": "ddl",
+  "AlterTableChangeColumnCommand": "ddl",
   "AlterTableDropPartitionCommand": "ddl",
-  "AlterTableSetPropertiesCommand": "ddl",
-  "AlterTableSetLocationCommand": "ddl",
-  "AlterTableSerDePropertiesCommand": "ddl",
-  "AlterTableUnsetPropertiesCommand": "ddl",
+  "AlterTableRecoverPartitionsCommand": "ddl",
+  "AlterTableRenameCommand": "ddl",
   "AlterTableRenameCommand": "ddl",
+  "AlterTableRenamePartitionCommand": "ddl",
+  "AlterTableSerDePropertiesCommand": "ddl",
+  "AlterTableSetLocationCommand": "ddl",
   "AlterTableSetPropertiesCommand": "ddl",
+  "AlterTableSetPropertiesCommand": "ddl",
+  "AlterTableUnsetPropertiesCommand": "ddl",
   "AlterTableUnsetPropertiesCommand": "ddl",
   "AlterViewAsCommand": "ddl",
+  "CreateDataSourceTableAsSelectCommand": "ddl",
+  "CreateDataSourceTableCommand": "ddl",
   "CreateDatabaseCommand": "ddl",
   "CreateFunctionCommand": "ddl",
-  "CreateDataSourceTableCommand": "ddl",
-  "CreateDataSourceTableAsSelectCommand": "ddl",
   "CreateTableLikeCommand": "ddl",
   "CreateViewCommand": "ddl",
   "DropDatabaseCommand": "ddl",
   "DropFunctionCommand": "ddl",
-  "NoopDropTable": "ddl",
   "DropTableCommand": "ddl",
-  "TruncateTableCommand": "ddl",
-  "AlterTableRecoverPartitionsCommand": "ddl",
+  "NoopDropTable": "ddl",
   "SetCatalogAndNamespace": "ddl",
+  "TruncateTableCommand": "ddl",
+  "InsertIntoDataSourceDirCommand": "dml",
   "InsertIntoHadoopFsRelationCommand": "dml",
+  "InsertIntoHiveDirCommand": "dml",
   "LoadDataCommand": "dml",
-  "InsertIntoDataSourceDirCommand": "dml",
-  "InsertIntoHiveDirCommand": "dml"
+  "AddFileCommand": "other",
+  "AddJarCommand": "other",
+  "AnalyzeTable": "other",
+  "CacheTableCommand": "other",
+  "ClearCacheCommand$": "other",
+  "DescribeColumnCommand": "other",
+  "DescribeDatabaseCommand": "other",
+  "DescribeFunctionCommand": "other",
+  "DescribeQueryCommand": "other",
+  "DescribeTableCommand": "other",
+  "ListFilesCommand": "other",
+  "ListJarsCommand": "other",

Review comment:
       this is hive's grammar, not spark's grammar




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-kyuubi] ulysses-you commented on a change in pull request #1037: Add classification of SQL_Type: for dql and auxiliary statement

Posted by GitBox <gi...@apache.org>.
ulysses-you commented on a change in pull request #1037:
URL: https://github.com/apache/incubator-kyuubi/pull/1037#discussion_r703322827



##########
File path: dev/kyuubi-extension-spark-3-1/src/test/resources/sql-classification-default.json
##########
@@ -1,34 +1,60 @@
 {
   "AlterDatabasePropertiesCommand": "ddl",
-  "AlterTableRenameCommand": "ddl",
-  "AlterTableRenamePartitionCommand": "ddl",
   "AlterTableAddColumnsCommand": "ddl",
-  "AlterTableChangeColumnCommand": "ddl",
   "AlterTableAddPartitionCommand": "ddl",
+  "AlterTableChangeColumnCommand": "ddl",
   "AlterTableDropPartitionCommand": "ddl",
-  "AlterTableSetPropertiesCommand": "ddl",
-  "AlterTableSetLocationCommand": "ddl",
-  "AlterTableSerDePropertiesCommand": "ddl",
-  "AlterTableUnsetPropertiesCommand": "ddl",
+  "AlterTableRecoverPartitionsCommand": "ddl",
+  "AlterTableRenameCommand": "ddl",
   "AlterTableRenameCommand": "ddl",
+  "AlterTableRenamePartitionCommand": "ddl",
+  "AlterTableSerDePropertiesCommand": "ddl",
+  "AlterTableSetLocationCommand": "ddl",
   "AlterTableSetPropertiesCommand": "ddl",
+  "AlterTableSetPropertiesCommand": "ddl",
+  "AlterTableUnsetPropertiesCommand": "ddl",
   "AlterTableUnsetPropertiesCommand": "ddl",
   "AlterViewAsCommand": "ddl",
+  "CreateDataSourceTableAsSelectCommand": "ddl",
+  "CreateDataSourceTableCommand": "ddl",
   "CreateDatabaseCommand": "ddl",
   "CreateFunctionCommand": "ddl",
-  "CreateDataSourceTableCommand": "ddl",
-  "CreateDataSourceTableAsSelectCommand": "ddl",
   "CreateTableLikeCommand": "ddl",
   "CreateViewCommand": "ddl",
   "DropDatabaseCommand": "ddl",
   "DropFunctionCommand": "ddl",
-  "NoopDropTable": "ddl",
   "DropTableCommand": "ddl",
-  "TruncateTableCommand": "ddl",
-  "AlterTableRecoverPartitionsCommand": "ddl",
+  "NoopDropTable": "ddl",
   "SetCatalogAndNamespace": "ddl",
+  "TruncateTableCommand": "ddl",
+  "InsertIntoDataSourceDirCommand": "dml",
   "InsertIntoHadoopFsRelationCommand": "dml",
+  "InsertIntoHiveDirCommand": "dml",

Review comment:
       insertintodir

##########
File path: dev/kyuubi-extension-spark-3-1/src/main/resources/sql-classification-default.json
##########
@@ -1,34 +1,60 @@
 {
   "AlterDatabasePropertiesCommand": "ddl",
-  "AlterTableRenameCommand": "ddl",
-  "AlterTableRenamePartitionCommand": "ddl",
   "AlterTableAddColumnsCommand": "ddl",
-  "AlterTableChangeColumnCommand": "ddl",
   "AlterTableAddPartitionCommand": "ddl",
+  "AlterTableChangeColumnCommand": "ddl",
   "AlterTableDropPartitionCommand": "ddl",
-  "AlterTableSetPropertiesCommand": "ddl",
-  "AlterTableSetLocationCommand": "ddl",
-  "AlterTableSerDePropertiesCommand": "ddl",
-  "AlterTableUnsetPropertiesCommand": "ddl",
+  "AlterTableRecoverPartitionsCommand": "ddl",
+  "AlterTableRenameCommand": "ddl",
   "AlterTableRenameCommand": "ddl",
+  "AlterTableRenamePartitionCommand": "ddl",
+  "AlterTableSerDePropertiesCommand": "ddl",
+  "AlterTableSetLocationCommand": "ddl",
   "AlterTableSetPropertiesCommand": "ddl",
+  "AlterTableSetPropertiesCommand": "ddl",
+  "AlterTableUnsetPropertiesCommand": "ddl",
   "AlterTableUnsetPropertiesCommand": "ddl",
   "AlterViewAsCommand": "ddl",
+  "CreateDataSourceTableAsSelectCommand": "ddl",
+  "CreateDataSourceTableCommand": "ddl",
   "CreateDatabaseCommand": "ddl",
   "CreateFunctionCommand": "ddl",
-  "CreateDataSourceTableCommand": "ddl",
-  "CreateDataSourceTableAsSelectCommand": "ddl",
   "CreateTableLikeCommand": "ddl",
   "CreateViewCommand": "ddl",
   "DropDatabaseCommand": "ddl",
   "DropFunctionCommand": "ddl",
-  "NoopDropTable": "ddl",
   "DropTableCommand": "ddl",
-  "TruncateTableCommand": "ddl",
-  "AlterTableRecoverPartitionsCommand": "ddl",
+  "NoopDropTable": "ddl",
   "SetCatalogAndNamespace": "ddl",
+  "TruncateTableCommand": "ddl",
+  "InsertIntoDataSourceDirCommand": "dml",
   "InsertIntoHadoopFsRelationCommand": "dml",
+  "InsertIntoHiveDirCommand": "dml",
   "LoadDataCommand": "dml",
-  "InsertIntoDataSourceDirCommand": "dml",
-  "InsertIntoHiveDirCommand": "dml"
+  "AddFileCommand": "other",
+  "AddJarCommand": "other",
+  "AnalyzeTable": "other",
+  "CacheTableCommand": "other",
+  "ClearCacheCommand$": "other",
+  "DescribeColumnCommand": "other",
+  "DescribeDatabaseCommand": "other",
+  "DescribeFunctionCommand": "other",
+  "DescribeQueryCommand": "other",
+  "DescribeTableCommand": "other",
+  "ListFilesCommand": "other",
+  "ListJarsCommand": "other",

Review comment:
       ListArchivesCommand

##########
File path: dev/kyuubi-extension-spark-3-1/src/main/resources/sql-classification-default.json
##########
@@ -1,34 +1,60 @@
 {
   "AlterDatabasePropertiesCommand": "ddl",
-  "AlterTableRenameCommand": "ddl",
-  "AlterTableRenamePartitionCommand": "ddl",
   "AlterTableAddColumnsCommand": "ddl",
-  "AlterTableChangeColumnCommand": "ddl",
   "AlterTableAddPartitionCommand": "ddl",
+  "AlterTableChangeColumnCommand": "ddl",
   "AlterTableDropPartitionCommand": "ddl",
-  "AlterTableSetPropertiesCommand": "ddl",
-  "AlterTableSetLocationCommand": "ddl",
-  "AlterTableSerDePropertiesCommand": "ddl",
-  "AlterTableUnsetPropertiesCommand": "ddl",
+  "AlterTableRecoverPartitionsCommand": "ddl",

Review comment:
       RepairTableCommand

##########
File path: dev/kyuubi-extension-spark-3-1/src/main/resources/sql-classification-default.json
##########
@@ -1,34 +1,60 @@
 {
   "AlterDatabasePropertiesCommand": "ddl",
-  "AlterTableRenameCommand": "ddl",
-  "AlterTableRenamePartitionCommand": "ddl",
   "AlterTableAddColumnsCommand": "ddl",
-  "AlterTableChangeColumnCommand": "ddl",
   "AlterTableAddPartitionCommand": "ddl",
+  "AlterTableChangeColumnCommand": "ddl",
   "AlterTableDropPartitionCommand": "ddl",
-  "AlterTableSetPropertiesCommand": "ddl",
-  "AlterTableSetLocationCommand": "ddl",
-  "AlterTableSerDePropertiesCommand": "ddl",
-  "AlterTableUnsetPropertiesCommand": "ddl",
+  "AlterTableRecoverPartitionsCommand": "ddl",
+  "AlterTableRenameCommand": "ddl",
   "AlterTableRenameCommand": "ddl",
+  "AlterTableRenamePartitionCommand": "ddl",
+  "AlterTableSerDePropertiesCommand": "ddl",
+  "AlterTableSetLocationCommand": "ddl",
   "AlterTableSetPropertiesCommand": "ddl",
+  "AlterTableSetPropertiesCommand": "ddl",
+  "AlterTableUnsetPropertiesCommand": "ddl",
   "AlterTableUnsetPropertiesCommand": "ddl",
   "AlterViewAsCommand": "ddl",
+  "CreateDataSourceTableAsSelectCommand": "ddl",
+  "CreateDataSourceTableCommand": "ddl",
   "CreateDatabaseCommand": "ddl",
   "CreateFunctionCommand": "ddl",
-  "CreateDataSourceTableCommand": "ddl",
-  "CreateDataSourceTableAsSelectCommand": "ddl",
   "CreateTableLikeCommand": "ddl",
   "CreateViewCommand": "ddl",
   "DropDatabaseCommand": "ddl",
   "DropFunctionCommand": "ddl",
-  "NoopDropTable": "ddl",
   "DropTableCommand": "ddl",
-  "TruncateTableCommand": "ddl",
-  "AlterTableRecoverPartitionsCommand": "ddl",
+  "NoopDropTable": "ddl",
   "SetCatalogAndNamespace": "ddl",
+  "TruncateTableCommand": "ddl",

Review comment:
       TruncateTableCommand

##########
File path: dev/kyuubi-extension-spark-3-1/src/test/resources/sql-classification-default.json
##########
@@ -1,34 +1,60 @@
 {
   "AlterDatabasePropertiesCommand": "ddl",
-  "AlterTableRenameCommand": "ddl",
-  "AlterTableRenamePartitionCommand": "ddl",
   "AlterTableAddColumnsCommand": "ddl",
-  "AlterTableChangeColumnCommand": "ddl",
   "AlterTableAddPartitionCommand": "ddl",
+  "AlterTableChangeColumnCommand": "ddl",
   "AlterTableDropPartitionCommand": "ddl",
-  "AlterTableSetPropertiesCommand": "ddl",
-  "AlterTableSetLocationCommand": "ddl",
-  "AlterTableSerDePropertiesCommand": "ddl",
-  "AlterTableUnsetPropertiesCommand": "ddl",
+  "AlterTableRecoverPartitionsCommand": "ddl",
+  "AlterTableRenameCommand": "ddl",
   "AlterTableRenameCommand": "ddl",
+  "AlterTableRenamePartitionCommand": "ddl",
+  "AlterTableSerDePropertiesCommand": "ddl",
+  "AlterTableSetLocationCommand": "ddl",
   "AlterTableSetPropertiesCommand": "ddl",
+  "AlterTableSetPropertiesCommand": "ddl",
+  "AlterTableUnsetPropertiesCommand": "ddl",
   "AlterTableUnsetPropertiesCommand": "ddl",
   "AlterViewAsCommand": "ddl",
+  "CreateDataSourceTableAsSelectCommand": "ddl",
+  "CreateDataSourceTableCommand": "ddl",
   "CreateDatabaseCommand": "ddl",
   "CreateFunctionCommand": "ddl",
-  "CreateDataSourceTableCommand": "ddl",
-  "CreateDataSourceTableAsSelectCommand": "ddl",
   "CreateTableLikeCommand": "ddl",
   "CreateViewCommand": "ddl",
   "DropDatabaseCommand": "ddl",
   "DropFunctionCommand": "ddl",
-  "NoopDropTable": "ddl",
   "DropTableCommand": "ddl",
-  "TruncateTableCommand": "ddl",
-  "AlterTableRecoverPartitionsCommand": "ddl",
+  "NoopDropTable": "ddl",
   "SetCatalogAndNamespace": "ddl",
+  "TruncateTableCommand": "ddl",
+  "InsertIntoDataSourceDirCommand": "dml",
   "InsertIntoHadoopFsRelationCommand": "dml",
+  "InsertIntoHiveDirCommand": "dml",
   "LoadDataCommand": "dml",
-  "InsertIntoDataSourceDirCommand": "dml",
-  "InsertIntoHiveDirCommand": "dml"
+  "AddFileCommand": "other",
+  "AddJarCommand": "other",
+  "AnalyzeTable": "other",

Review comment:
       AnalyzeColumn




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1037: Add classification of SQL_Type: for dql and auxiliary statement

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1037:
URL: https://github.com/apache/incubator-kyuubi/pull/1037#issuecomment-913945391


   # [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1037](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d258e80) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/c1e5545c648fbd9d62c562014447eea205849094?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c1e5545) will **increase** coverage by `0.03%`.
   > The diff coverage is `100.00%`.
   
   > :exclamation: Current head d258e80 differs from pull request most recent head d7f7538. Consider uploading reports for the commit d7f7538 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/graphs/tree.svg?width=650&height=150&src=pr&token=925D4tb9AH&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1037      +/-   ##
   ============================================
   + Coverage     78.42%   78.45%   +0.03%     
     Complexity       61       61              
   ============================================
     Files           167      167              
     Lines          6196     6205       +9     
     Branches        723      724       +1     
   ============================================
   + Hits           4859     4868       +9     
     Misses          915      915              
     Partials        422      422              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...sqlclassification/KyuubiGetSqlClassification.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstMy0xL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9zcWxjbGFzc2lmaWNhdGlvbi9LeXV1YmlHZXRTcWxDbGFzc2lmaWNhdGlvbi5zY2FsYQ==) | `77.77% <100.00%> (+4.44%)` | :arrow_up: |
   | [.../org/apache/kyuubi/events/KyuubiSessionEvent.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9ldmVudHMvS3l1dWJpU2Vzc2lvbkV2ZW50LnNjYWxh) | `92.00% <0.00%> (-0.31%)` | :arrow_down: |
   | [...ain/scala/org/apache/kyuubi/engine/EngineRef.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9lbmdpbmUvRW5naW5lUmVmLnNjYWxh) | `78.94% <0.00%> (-0.28%)` | :arrow_down: |
   | [...g/apache/kyuubi/session/KyuubiSessionManager.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXNzaW9uL0t5dXViaVNlc3Npb25NYW5hZ2VyLnNjYWxh) | `97.05% <0.00%> (ø)` | |
   | [...pache/kyuubi/sql/KyuubiQueryStagePreparation.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstMy0xL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9LeXV1YmlRdWVyeVN0YWdlUHJlcGFyYXRpb24uc2NhbGE=) | `80.39% <0.00%> (ø)` | |
   | [.../apache/kyuubi/client/KyuubiSyncThriftClient.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jbGllbnQvS3l1dWJpU3luY1RocmlmdENsaWVudC5zY2FsYQ==) | `82.02% <0.00%> (+0.20%)` | :arrow_up: |
   | [.../org/apache/kyuubi/session/KyuubiSessionImpl.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXNzaW9uL0t5dXViaVNlc3Npb25JbXBsLnNjYWxh) | `89.58% <0.00%> (+1.77%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [c1e5545...d7f7538](https://codecov.io/gh/apache/incubator-kyuubi/pull/1037?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-kyuubi] zhang1002 commented on a change in pull request #1037: Add classification of SQL_Type: for dql and auxiliary statement

Posted by GitBox <gi...@apache.org>.
zhang1002 commented on a change in pull request #1037:
URL: https://github.com/apache/incubator-kyuubi/pull/1037#discussion_r703456615



##########
File path: dev/kyuubi-extension-spark-3-1/src/main/resources/sql-classification-default.json
##########
@@ -1,34 +1,60 @@
 {
   "AlterDatabasePropertiesCommand": "ddl",
-  "AlterTableRenameCommand": "ddl",
-  "AlterTableRenamePartitionCommand": "ddl",
   "AlterTableAddColumnsCommand": "ddl",
-  "AlterTableChangeColumnCommand": "ddl",
   "AlterTableAddPartitionCommand": "ddl",
+  "AlterTableChangeColumnCommand": "ddl",
   "AlterTableDropPartitionCommand": "ddl",
-  "AlterTableSetPropertiesCommand": "ddl",
-  "AlterTableSetLocationCommand": "ddl",
-  "AlterTableSerDePropertiesCommand": "ddl",
-  "AlterTableUnsetPropertiesCommand": "ddl",
+  "AlterTableRecoverPartitionsCommand": "ddl",
+  "AlterTableRenameCommand": "ddl",
   "AlterTableRenameCommand": "ddl",
+  "AlterTableRenamePartitionCommand": "ddl",
+  "AlterTableSerDePropertiesCommand": "ddl",
+  "AlterTableSetLocationCommand": "ddl",
   "AlterTableSetPropertiesCommand": "ddl",
+  "AlterTableSetPropertiesCommand": "ddl",
+  "AlterTableUnsetPropertiesCommand": "ddl",
   "AlterTableUnsetPropertiesCommand": "ddl",
   "AlterViewAsCommand": "ddl",
+  "CreateDataSourceTableAsSelectCommand": "ddl",
+  "CreateDataSourceTableCommand": "ddl",
   "CreateDatabaseCommand": "ddl",
   "CreateFunctionCommand": "ddl",
-  "CreateDataSourceTableCommand": "ddl",
-  "CreateDataSourceTableAsSelectCommand": "ddl",
   "CreateTableLikeCommand": "ddl",
   "CreateViewCommand": "ddl",
   "DropDatabaseCommand": "ddl",
   "DropFunctionCommand": "ddl",
-  "NoopDropTable": "ddl",
   "DropTableCommand": "ddl",
-  "TruncateTableCommand": "ddl",
-  "AlterTableRecoverPartitionsCommand": "ddl",
+  "NoopDropTable": "ddl",
   "SetCatalogAndNamespace": "ddl",
+  "TruncateTableCommand": "ddl",

Review comment:
       we support the user use the self-defined matching rule. if the grammar have added or you want to change some classification for the sql, you can self-defined matching rule with jsonFile named "sql-classification.json". The code will upload your jsonFile.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-kyuubi] zhang1002 commented on a change in pull request #1037: Add classification of SQL_Type: for dql and auxiliary statement

Posted by GitBox <gi...@apache.org>.
zhang1002 commented on a change in pull request #1037:
URL: https://github.com/apache/incubator-kyuubi/pull/1037#discussion_r703441820



##########
File path: dev/kyuubi-extension-spark-3-1/src/main/resources/sql-classification-default.json
##########
@@ -1,34 +1,60 @@
 {
   "AlterDatabasePropertiesCommand": "ddl",
-  "AlterTableRenameCommand": "ddl",
-  "AlterTableRenamePartitionCommand": "ddl",
   "AlterTableAddColumnsCommand": "ddl",
-  "AlterTableChangeColumnCommand": "ddl",
   "AlterTableAddPartitionCommand": "ddl",
+  "AlterTableChangeColumnCommand": "ddl",
   "AlterTableDropPartitionCommand": "ddl",
-  "AlterTableSetPropertiesCommand": "ddl",
-  "AlterTableSetLocationCommand": "ddl",
-  "AlterTableSerDePropertiesCommand": "ddl",
-  "AlterTableUnsetPropertiesCommand": "ddl",
+  "AlterTableRecoverPartitionsCommand": "ddl",
+  "AlterTableRenameCommand": "ddl",
   "AlterTableRenameCommand": "ddl",
+  "AlterTableRenamePartitionCommand": "ddl",
+  "AlterTableSerDePropertiesCommand": "ddl",
+  "AlterTableSetLocationCommand": "ddl",
   "AlterTableSetPropertiesCommand": "ddl",
+  "AlterTableSetPropertiesCommand": "ddl",
+  "AlterTableUnsetPropertiesCommand": "ddl",
   "AlterTableUnsetPropertiesCommand": "ddl",
   "AlterViewAsCommand": "ddl",
+  "CreateDataSourceTableAsSelectCommand": "ddl",
+  "CreateDataSourceTableCommand": "ddl",
   "CreateDatabaseCommand": "ddl",
   "CreateFunctionCommand": "ddl",
-  "CreateDataSourceTableCommand": "ddl",
-  "CreateDataSourceTableAsSelectCommand": "ddl",
   "CreateTableLikeCommand": "ddl",
   "CreateViewCommand": "ddl",
   "DropDatabaseCommand": "ddl",
   "DropFunctionCommand": "ddl",
-  "NoopDropTable": "ddl",
   "DropTableCommand": "ddl",
-  "TruncateTableCommand": "ddl",
-  "AlterTableRecoverPartitionsCommand": "ddl",
+  "NoopDropTable": "ddl",
   "SetCatalogAndNamespace": "ddl",
+  "TruncateTableCommand": "ddl",

Review comment:
       There is no such grammar.
   In spark, "TRUNCATE TABLE tablename [PARTITION (partcol1=val1, partcol2=val2 ...)]" is belong to "TruncateTableCommand".




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org