You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/01/27 14:09:28 UTC

[GitHub] [iotdb] HTHou commented on a change in pull request #2578: [ISSUE-2573] Create timeseries root.sg.d1\n.s1 should be disabled using native session api

HTHou commented on a change in pull request #2578:
URL: https://github.com/apache/iotdb/pull/2578#discussion_r565336341



##########
File path: session/src/test/java/org/apache/iotdb/session/SessionUT.java
##########
@@ -170,7 +170,7 @@ public void testInsertByStrAndSelectFailedData()
       RowRecord record = dataSet.next();
       int nullCount = 0;
       for (int j = 0; j < 4; ++j) {
-        if (record.getFields().get(j) == null) {
+        if (record.getFields().get(j) == null || record.getFields().get(j).getDataType() == null) {

Review comment:
       I added it because this UT failed on my local machine if missing it. Let me try to remove this and see the GitHub actions test results. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org