You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "Fokko (via GitHub)" <gi...@apache.org> on 2025/09/01 04:08:08 UTC
Re: [PR] chore: Replace async-std with smol [iceberg-rust]
Fokko commented on code in PR #1640:
URL: https://github.com/apache/iceberg-rust/pull/1640#discussion_r2312843956
##########
.github/workflows/ci.yml:
##########
@@ -137,8 +137,8 @@ jobs:
- name: Test
run: cargo test --no-fail-fast --all-targets --all-features --workspace
- - name: Async-std Test
- run: cargo test --no-fail-fast --all-targets --no-default-features --features "async-std" --features "storage-all" --workspace
+ - name: Smol Test
+ run: cargo test --no-fail-fast --all-targets --no-default-features --features "smol" --features "storage-all" --workspace
Review Comment:
Unrelated, but I noticed that there is an extra space:
```suggestion
run: cargo test --no-fail-fast --all-targets --no-default-features --features "smol" --features "storage-all" --workspace
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org