You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2014/05/03 19:05:16 UTC
svn commit: r1592252 - in
/pdfbox/branches/1.8/pdfbox/src/main/java/org/apache/pdfbox/pdmodel:
documentinterchange/logicalstructure/ documentinterchange/taggedpdf/
encryption/ font/ graphics/
Author: tilman
Date: Sat May 3 17:05:15 2014
New Revision: 1592252
URL: http://svn.apache.org/r1592252
Log:
PDFBOX-2054: remove printStackTrace as suggested by Hong-Thai Nguyen
Modified:
pdfbox/branches/1.8/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/documentinterchange/logicalstructure/PDStructureTreeRoot.java
pdfbox/branches/1.8/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/documentinterchange/taggedpdf/StandardStructureTypes.java
pdfbox/branches/1.8/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/encryption/PublicKeySecurityHandler.java
pdfbox/branches/1.8/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/encryption/SecurityHandlersManager.java
pdfbox/branches/1.8/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/font/FontManager.java
pdfbox/branches/1.8/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/font/PDFont.java
pdfbox/branches/1.8/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/graphics/PDGraphicsState.java
pdfbox/branches/1.8/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/graphics/PDLineDashPattern.java
Modified: pdfbox/branches/1.8/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/documentinterchange/logicalstructure/PDStructureTreeRoot.java
URL: http://svn.apache.org/viewvc/pdfbox/branches/1.8/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/documentinterchange/logicalstructure/PDStructureTreeRoot.java?rev=1592252&r1=1592251&r2=1592252&view=diff
==============================================================================
--- pdfbox/branches/1.8/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/documentinterchange/logicalstructure/PDStructureTreeRoot.java (original)
+++ pdfbox/branches/1.8/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/documentinterchange/logicalstructure/PDStructureTreeRoot.java Sat May 3 17:05:15 2014
@@ -19,6 +19,8 @@ package org.apache.pdfbox.pdmodel.docume
import java.io.IOException;
import java.util.Hashtable;
import java.util.Map;
+import org.apache.commons.logging.Log;
+import org.apache.commons.logging.LogFactory;
import org.apache.pdfbox.cos.COSArray;
import org.apache.pdfbox.cos.COSBase;
@@ -38,6 +40,11 @@ import org.apache.pdfbox.pdmodel.common.
public class PDStructureTreeRoot extends PDStructureNode
{
+ /**
+ * Log instance.
+ */
+ private static final Log LOG = LogFactory.getLog(PDStructureTreeRoot.class);
+
private static final String TYPE = "StructTreeRoot";
/**
@@ -192,7 +199,7 @@ public class PDStructureTreeRoot extends
}
catch (IOException e)
{
- e.printStackTrace();
+ LOG.error(e,e);
}
}
return new Hashtable<String, Object>();
Modified: pdfbox/branches/1.8/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/documentinterchange/taggedpdf/StandardStructureTypes.java
URL: http://svn.apache.org/viewvc/pdfbox/branches/1.8/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/documentinterchange/taggedpdf/StandardStructureTypes.java?rev=1592252&r1=1592251&r2=1592252&view=diff
==============================================================================
--- pdfbox/branches/1.8/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/documentinterchange/taggedpdf/StandardStructureTypes.java (original)
+++ pdfbox/branches/1.8/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/documentinterchange/taggedpdf/StandardStructureTypes.java Sat May 3 17:05:15 2014
@@ -21,6 +21,8 @@ import java.lang.reflect.Modifier;
import java.util.ArrayList;
import java.util.Collections;
import java.util.List;
+import org.apache.commons.logging.Log;
+import org.apache.commons.logging.LogFactory;
/**
* The standard structure types.
@@ -31,11 +33,15 @@ import java.util.List;
public class StandardStructureTypes
{
+ /**
+ * Log instance.
+ */
+ private static final Log LOG = LogFactory.getLog(StandardStructureTypes.class);
+
private StandardStructureTypes()
{
}
-
// Grouping Elements
/**
* Document
@@ -306,11 +312,11 @@ public class StandardStructureTypes
}
catch (IllegalArgumentException e)
{
- e.printStackTrace();
+ LOG.error(e,e);
}
catch (IllegalAccessException e)
{
- e.printStackTrace();
+ LOG.error(e,e);
}
}
}
Modified: pdfbox/branches/1.8/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/encryption/PublicKeySecurityHandler.java
URL: http://svn.apache.org/viewvc/pdfbox/branches/1.8/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/encryption/PublicKeySecurityHandler.java?rev=1592252&r1=1592251&r2=1592252&view=diff
==============================================================================
--- pdfbox/branches/1.8/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/encryption/PublicKeySecurityHandler.java (original)
+++ pdfbox/branches/1.8/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/encryption/PublicKeySecurityHandler.java Sat May 3 17:05:15 2014
@@ -35,6 +35,8 @@ import java.util.Iterator;
import javax.crypto.Cipher;
import javax.crypto.KeyGenerator;
import javax.crypto.SecretKey;
+import org.apache.commons.logging.Log;
+import org.apache.commons.logging.LogFactory;
import org.bouncycastle.asn1.ASN1InputStream;
import org.bouncycastle.asn1.DERObject;
@@ -74,6 +76,11 @@ import org.apache.pdfbox.pdmodel.PDDocum
*/
public class PublicKeySecurityHandler extends SecurityHandler
{
+
+ /**
+ * Log instance.
+ */
+ private static final Log LOG = LogFactory.getLog(PublicKeySecurityHandler.class);
/**
* The filter name.
@@ -370,7 +377,7 @@ public class PublicKeySecurityHandler ex
}
catch(Exception e)
{
- e.printStackTrace();
+ LOG.error(e,e);
throw new CryptographyException(e);
}
Modified: pdfbox/branches/1.8/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/encryption/SecurityHandlersManager.java
URL: http://svn.apache.org/viewvc/pdfbox/branches/1.8/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/encryption/SecurityHandlersManager.java?rev=1592252&r1=1592251&r2=1592252&view=diff
==============================================================================
--- pdfbox/branches/1.8/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/encryption/SecurityHandlersManager.java (original)
+++ pdfbox/branches/1.8/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/encryption/SecurityHandlersManager.java Sat May 3 17:05:15 2014
@@ -20,6 +20,8 @@ package org.apache.pdfbox.pdmodel.encryp
import java.lang.reflect.Constructor;
import java.security.Security;
import java.util.Hashtable;
+import org.apache.commons.logging.Log;
+import org.apache.commons.logging.LogFactory;
import org.bouncycastle.jce.provider.BouncyCastleProvider;
@@ -37,6 +39,11 @@ public class SecurityHandlersManager
{
/**
+ * Log instance.
+ */
+ private static final Log LOG = LogFactory.getLog(SecurityHandlersManager.class);
+
+ /**
* The unique instance of this manager.
*/
private static SecurityHandlersManager instance;
@@ -177,7 +184,7 @@ public class SecurityHandlersManager
}
catch(Exception e)
{
- e.printStackTrace();
+ LOG(e,e);
throw new BadSecurityHandlerException(
"problem while trying to instanciate the security handler "+
handlerclass.getName() + ": " + e.getMessage());
@@ -214,7 +221,7 @@ public class SecurityHandlersManager
}
catch(Exception e)
{
- e.printStackTrace();
+ LOG(e,e);
throw new BadSecurityHandlerException(
"problem while trying to instanciate the security handler "+
handlerclass.getName() + ": " + e.getMessage());
Modified: pdfbox/branches/1.8/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/font/FontManager.java
URL: http://svn.apache.org/viewvc/pdfbox/branches/1.8/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/font/FontManager.java?rev=1592252&r1=1592251&r2=1592252&view=diff
==============================================================================
--- pdfbox/branches/1.8/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/font/FontManager.java (original)
+++ pdfbox/branches/1.8/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/font/FontManager.java Sat May 3 17:05:15 2014
@@ -55,7 +55,7 @@ public class FontManager
}
catch( IOException io )
{
- io.printStackTrace();
+ LOG.error(io,io);
throw new RuntimeException( "Error loading font mapping" );
}
loadFonts();
Modified: pdfbox/branches/1.8/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/font/PDFont.java
URL: http://svn.apache.org/viewvc/pdfbox/branches/1.8/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/font/PDFont.java?rev=1592252&r1=1592251&r2=1592252&view=diff
==============================================================================
--- pdfbox/branches/1.8/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/font/PDFont.java (original)
+++ pdfbox/branches/1.8/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/font/PDFont.java Sat May 3 17:05:15 2014
@@ -563,7 +563,7 @@ public abstract class PDFont implements
catch (UnsupportedEncodingException e)
{
// Nothing should happen here
- e.printStackTrace();
+ LOG.error(e,e);
}
for( int j=0; j<256; j++ )
{
@@ -574,7 +574,7 @@ public abstract class PDFont implements
catch (UnsupportedEncodingException e)
{
// Nothing should happen here
- e.printStackTrace();
+ LOG.error(e,e);
}
}
}
Modified: pdfbox/branches/1.8/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/graphics/PDGraphicsState.java
URL: http://svn.apache.org/viewvc/pdfbox/branches/1.8/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/graphics/PDGraphicsState.java?rev=1592252&r1=1592251&r2=1592252&view=diff
==============================================================================
--- pdfbox/branches/1.8/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/graphics/PDGraphicsState.java (original)
+++ pdfbox/branches/1.8/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/graphics/PDGraphicsState.java Sat May 3 17:05:15 2014
@@ -18,6 +18,8 @@ package org.apache.pdfbox.pdmodel.graphi
import java.awt.*;
import java.awt.geom.GeneralPath;
+import org.apache.commons.logging.Log;
+import org.apache.commons.logging.LogFactory;
import org.apache.pdfbox.pdmodel.common.PDRectangle;
import org.apache.pdfbox.pdmodel.graphics.color.PDColorState;
@@ -33,6 +35,12 @@ import org.apache.pdfbox.util.Matrix;
*/
public class PDGraphicsState implements Cloneable
{
+
+ /**
+ * Log instance.
+ */
+ private static final Log LOG = LogFactory.getLog(PDGraphicsState.class);
+
private Matrix currentTransformationMatrix = new Matrix();
//Here are some attributes of the Graphics state, but have not been created yet.
@@ -434,7 +442,7 @@ public class PDGraphicsState implements
}
catch( CloneNotSupportedException e )
{
- e.printStackTrace();
+ LOG.error(e, e);
}
return clone;
}
Modified: pdfbox/branches/1.8/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/graphics/PDLineDashPattern.java
URL: http://svn.apache.org/viewvc/pdfbox/branches/1.8/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/graphics/PDLineDashPattern.java?rev=1592252&r1=1592251&r2=1592252&view=diff
==============================================================================
--- pdfbox/branches/1.8/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/graphics/PDLineDashPattern.java (original)
+++ pdfbox/branches/1.8/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/graphics/PDLineDashPattern.java Sat May 3 17:05:15 2014
@@ -25,6 +25,8 @@ import org.apache.pdfbox.pdmodel.common.
import org.apache.pdfbox.pdmodel.common.COSObjectable;
import java.util.List;
+import org.apache.commons.logging.Log;
+import org.apache.commons.logging.LogFactory;
/**
* This class represents the line dash pattern for a graphics state. See PDF
@@ -35,6 +37,12 @@ import java.util.List;
*/
public class PDLineDashPattern implements COSObjectable, Cloneable
{
+
+ /**
+ * Log instance.
+ */
+ private static final Log LOG = LogFactory.getLog(PDLineDashPattern.class);
+
private COSArray lineDashPattern = null;
/**
@@ -82,9 +90,9 @@ public class PDLineDashPattern implement
pattern.setDashPattern(getDashPattern());
pattern.setPhaseStart(getPhaseStart());
}
- catch(CloneNotSupportedException exception)
+ catch(CloneNotSupportedException e)
{
- exception.printStackTrace();
+ LOG.error(e,e);
}
return pattern;
}