You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/07/28 18:31:10 UTC
[GitHub] [arrow] nealrichardson opened a new pull request #10824: [MINOR] Bump 5.0.0 version in r/NEWS.md
nealrichardson opened a new pull request #10824:
URL: https://github.com/apache/arrow/pull/10824
FYI @kszucs, this was missed in #10821. There's slightly different version bumping logic when going from snapshot to release than when going from release to snapshot: https://github.com/apache/arrow/blob/master/dev/release/utils-prepare.sh#L124-L136
So now that we don't rebase master on the release, when bumping the snapshot version on master after the release, it would be good to run `update_versions` twice, first to the release version, then to the new snapshot version. Or else first cherry-pick the version bump commit from the release branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #10824: MINOR: [R] Bump 5.0.0 version in r/NEWS.md
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #10824:
URL: https://github.com/apache/arrow/pull/10824#issuecomment-888695893
I'll open a pull request for the change with test later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #10824: [MINOR] Bump 5.0.0 version in r/NEWS.md
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10824:
URL: https://github.com/apache/arrow/pull/10824#issuecomment-888528817
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
If this is not a [minor PR](https://github.com/apache/arrow/blob/master/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW
Opening JIRAs ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
Then could you also rename pull request title in the following format?
ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
See also:
* [Other pull requests](https://github.com/apache/arrow/pulls/)
* [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou closed pull request #10824: MINOR: [R] Bump 5.0.0 version in r/NEWS.md
Posted by GitBox <gi...@apache.org>.
kou closed pull request #10824:
URL: https://github.com/apache/arrow/pull/10824
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #10824: [MINOR] Bump 5.0.0 version in r/NEWS.md
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #10824:
URL: https://github.com/apache/arrow/pull/10824#issuecomment-888529999
Can we figure out a simpler solution rather than calling `update_versions` twice? cc @kou
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on pull request #10824: [MINOR] Bump 5.0.0 version in r/NEWS.md
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on pull request #10824:
URL: https://github.com/apache/arrow/pull/10824#issuecomment-888694488
@kou that's cool I think, but we use `r_version` for some other files (PKGBUILD etc.) so those also should be updated (or the variable restored). But they just insert the new version, no different behavior whether it's a release or snapshot.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #10824: [MINOR] Bump 5.0.0 version in r/NEWS.md
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #10824:
URL: https://github.com/apache/arrow/pull/10824#issuecomment-888647510
How about the following?
```diff
index 93ddb18b7..d9b0ef798 100644
--- a/dev/release/utils-prepare.sh
+++ b/dev/release/utils-prepare.sh
@@ -25,11 +25,9 @@ update_versions() {
case ${type} in
release)
local version=${base_version}
- local r_version=${base_version}
;;
snapshot)
local version=${next_version}-SNAPSHOT
- local r_version=${base_version}.9000
;;
esac
@@ -121,17 +119,14 @@ update_versions() {
DESCRIPTION
rm -f DESCRIPTION.bak
git add DESCRIPTION
+ # Replace dev version with release version
+ sed -i.bak -E -e \
+ "0,/^# arrow /s/^# arrow .+/# arrow ${base_version}/" \
+ NEWS.md
if [ ${type} = "snapshot" ]; then
# Add a news entry for the new dev version
- echo "dev"
- sed -i.bak -E -e \
- "0,/^# arrow /s/^(# arrow .+)/# arrow ${r_version}\n\n\1/" \
- NEWS.md
- else
- # Replace dev version with release version
- echo "release"
sed -i.bak -E -e \
- "0,/^# arrow /s/^# arrow .+/# arrow ${r_version}/" \
+ "0,/^# arrow /s/^(# arrow .+)/# arrow ${base_version}.9000\n\n\1/" \
NEWS.md
fi
rm -f NEWS.md.bak
```
For release:
* `4.0.1.9000` is replaced with `5.0.0`
For snapshot:
* `4.0.1.9000` is replaced with `5.0.0`
* `5.0.0.9000` is added
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #10824: MINOR: [R] Bump 5.0.0 version in r/NEWS.md
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #10824:
URL: https://github.com/apache/arrow/pull/10824#issuecomment-888732098
https://github.com/apache/arrow/pull/10828
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org