You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by pdube <gi...@git.apache.org> on 2016/12/07 19:43:26 UTC
[GitHub] cloudstack pull request #1820: CLOUDSTACK-9656 Preventing autoboxing NPE in ...
GitHub user pdube opened a pull request:
https://github.com/apache/cloudstack/pull/1820
CLOUDSTACK-9656 Preventing autoboxing NPE in Usage by setting a default role when not found
https://issues.apache.org/jira/browse/CLOUDSTACK-9656
This is a workaround to avoid NPE when using the usage server with Projects
To reproduce bug:
Create project
Add account to project
Create VM within that project
Run the usage server
Same steps to test resolution
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pdube/cloudstack CLOUDSTACK-9656-usage-exception
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1820.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1820
----
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1820: CLOUDSTACK-9656 Preventing autoboxing NPE in Usage b...
Posted by pdube <gi...@git.apache.org>.
Github user pdube commented on the issue:
https://github.com/apache/cloudstack/pull/1820
Ok will do, thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1820: CLOUDSTACK-9656 Preventing autoboxing NPE in Usage b...
Posted by syed <gi...@git.apache.org>.
Github user syed commented on the issue:
https://github.com/apache/cloudstack/pull/1820
LGTM :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1820: CLOUDSTACK-9656 Preventing autoboxing NPE in Usage b...
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1820
LGTM. @pdube since this is a bugfix, can you rebase the PR against 4.9, and change PR's base branch to 4.9? Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1820: CLOUDSTACK-9656 Preventing autoboxing NPE in Usage b...
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1820
LGTM, verified manually. Merging this based on usage related tests. Trillian smoke tests don't cover usage server to the extent of changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1820: CLOUDSTACK-9656 Preventing autoboxing NPE in Usage b...
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1820
@pdube sure, you're welcome. Trying my best to include as many useful bugfix PRs as possible before the RC is cut on Monday.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1820: CLOUDSTACK-9656 Preventing autoboxing NPE in ...
Posted by pdube <gi...@git.apache.org>.
GitHub user pdube reopened a pull request:
https://github.com/apache/cloudstack/pull/1820
CLOUDSTACK-9656 Preventing autoboxing NPE in Usage by setting a default role when not found
https://issues.apache.org/jira/browse/CLOUDSTACK-9656
This is a workaround to avoid NPE when using the usage server with Projects
To reproduce bug:
Create project
Add account to project
Create VM within that project
Run the usage server
Same steps to test resolution
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pdube/cloudstack CLOUDSTACK-9656-usage-exception
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1820.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1820
----
commit b7ac7fd2a3eddbe66c36a83b80ae6be303c01bc4
Author: Patrick Dube <pd...@cloudops.com>
Date: 2016-12-07T19:39:28Z
Preventing autoboxing NPE by setting a default role when not found
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1820: CLOUDSTACK-9656 Preventing autoboxing NPE in Usage b...
Posted by pdube <gi...@git.apache.org>.
Github user pdube commented on the issue:
https://github.com/apache/cloudstack/pull/1820
@rhtyd Changed the PR to be against 4.9
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1820: CLOUDSTACK-9656 Preventing autoboxing NPE in Usage b...
Posted by pdube <gi...@git.apache.org>.
Github user pdube commented on the issue:
https://github.com/apache/cloudstack/pull/1820
@rhtyd Thanks for the speedy responses
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1820: CLOUDSTACK-9656 Preventing autoboxing NPE in ...
Posted by pdube <gi...@git.apache.org>.
Github user pdube closed the pull request at:
https://github.com/apache/cloudstack/pull/1820
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1820: CLOUDSTACK-9656 Preventing autoboxing NPE in ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1820
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1820: CLOUDSTACK-9656 Preventing autoboxing NPE in Usage b...
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1820
@pdube also amend the git commit message to include the JIRA id, such as `CLOUDSTACK-xxxx: one line summary`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---