[jira] [Commented] (AIRFLOW-6020) KubernetesExecutor iteritems() exception when using Python 3.*

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-6020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16978394#comment-16978394 ] 

ASF GitHub Bot commented on AIRFLOW-6020:
-----------------------------------------

eserdyuk-exos commented on pull request #6614: [AIRFLOW-6020] fix python 3 KubernetesExecutor iteritems exception
URL: https://github.com/apache/airflow/pull/6614
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-6020
     - In case you are fixing a typo in the documentation you can prepend your commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
     - In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
     - In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   
   ### Description
   
   - [x] Here are some details about my PR, including screenshots of any UI changes:  
   `kubernetes_executor.py` didn't support Python 3 cause of `dict.iteritems()` using.
   It has been fixed with the help of `six.iteritems` for a backward compatibility.
   
   ### Tests
   
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> KubernetesExecutor iteritems() exception when using Python 3.*
> --------------------------------------------------------------
>
>                 Key: AIRFLOW-6020
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-6020
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: executor-kubernetes, executors
>    Affects Versions: 1.10.6
>            Reporter: Eugene Serdyuk
>            Assignee: Eugene Serdyuk
>            Priority: Blocker
>         Attachments: logs.txt
>
>
> When running scheduler using {{KubernetesExecutor}} with Python 3.7 the exception occurs due to the use of {{iteritems()}} within dictionaries.
> {{iteritems()}} found:
> - {{airflow/executors/kubernetes_executor.py}} line 277
> - {{airflow/executors/kubernetes_executor.py}} line 655
>  
> TODO: use {{six.iteritems}} function.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)