[GitHub] flink pull request #5448: [FLINK-6469] Configure Memory Sizes with units

[dawidwys <gi...@git.apache.org>]

Github user dawidwys commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5448#discussion_r191190916
  
    --- Diff: flink-core/src/main/java/org/apache/flink/configuration/TaskManagerOptions.java ---
    @@ -176,19 +188,19 @@
     	/**
     	 * Size of memory buffers used by the network stack and the memory manager (in bytes).
     	 */
    -	public static final ConfigOption<Integer> MEMORY_SEGMENT_SIZE =
    +	public static final ConfigOption<String> MEMORY_SEGMENT_SIZE =
     			key("taskmanager.memory.segment-size")
    -			.defaultValue(32768)
    -			.withDescription("Size of memory buffers used by the network stack and the memory manager (in bytes).");
    +			.defaultValue("32768")
    +			.withDescription("Size of memory buffers used by the network stack and the memory manager.");
     
     	/**
     	 * Amount of memory to be allocated by the task manager's memory manager (in megabytes). If not
     	 * set, a relative fraction will be allocated, as defined by {@link #MANAGED_MEMORY_FRACTION}.
     	 */
    -	public static final ConfigOption<Long> MANAGED_MEMORY_SIZE =
    +	public static final ConfigOption<String> MANAGED_MEMORY_SIZE =
    --- End diff --
    
    Also I think we should add tests that explicitly test using old style configuration.


---