You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Madhan Neethiraj <ma...@apache.org> on 2015/09/25 22:56:12 UTC
Review Request 38772: RANGER-645: updates to support all DB flavors
for TagDBStore
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38772/
-----------------------------------------------------------
Review request for ranger, Gautam Borad, Abhay Kulkarni, and Velmurugan Periasamy.
Bugs: RANGER-645
https://issues.apache.org/jira/browse/RANGER-645
Repository: ranger
Description
-------
This is the updated verison of review https://reviews.apache.org/r/38760/, after latest merge and few minor updates.
Main changes :
* Added DB Schema for all the databases supported for Ranger
Other changes introduced :
1. Newly required column 'options' of Table X_SERVICE_DEF is changed to 'def_options' as 'options' and 'option' are reserved keyword in SQL Anywhere.
2. Patch 015 which was using three alter statement to add three column, is now adjusted in one alter table statement. Similarly patch 011 also has been changed.
3. Sequence name has been changed with actual Sequence name used for Oracle/Postgres schema.
Diffs
-----
jisql/src/main/java/org/apache/util/sql/Jisql.java cf7563c
security-admin/db/mysql/init/schema_mysql.sql 6df7195
security-admin/db/mysql/patches/016-updated-schema-for-tag-based-policy.sql 532e723
security-admin/db/mysql/patches/audit/011-auditcolumnssize.sql b38ae8c
security-admin/db/mysql/patches/audit/015-auditlogaggregation.sql c88c5b4
security-admin/db/mysql/xa_audit_db.sql 8334dce
security-admin/db/mysql/xa_db.sql 9aba91f
security-admin/db/oracle/patches/009-updated_schema.sql ed47237
security-admin/db/oracle/patches/016-updated-schema-for-tag-based-policy.sql PRE-CREATION
security-admin/db/oracle/patches/audit/011-auditcolumnssize.sql 35a9320
security-admin/db/oracle/patches/audit/015-auditlogaggregation.sql 756ee61
security-admin/db/oracle/patches/audit/017-add-new-column-to-store-tags.sql PRE-CREATION
security-admin/db/oracle/xa_audit_db_oracle.sql 607a8b2
security-admin/db/oracle/xa_core_db_oracle.sql 9c18ead
security-admin/db/postgres/patches/016-updated-schema-for-tag-based-policy.sql PRE-CREATION
security-admin/db/postgres/patches/audit/017-add-new-column-to-store-tags.sql PRE-CREATION
security-admin/db/postgres/xa_audit_db_postgres.sql cace5c5
security-admin/db/postgres/xa_core_db_postgres.sql 123732e
security-admin/db/sqlanywhere/patches/016-updated-schema-for-tag-based-policy.sql PRE-CREATION
security-admin/db/sqlanywhere/patches/audit/017-add-new-column-to-store-tags.sql PRE-CREATION
security-admin/db/sqlserver/patches/016-updated-schema-for-tag-based-policy.sql PRE-CREATION
security-admin/db/sqlserver/patches/audit/017-add-new-column-to-store-tags.sql PRE-CREATION
security-admin/db/sqlserver/xa_audit_db_sqlserver.sql 783b968
security-admin/db/sqlserver/xa_core_db_sqlserver.sql 6e304d4
security-admin/scripts/db_setup.py 1edc628
security-admin/src/main/java/org/apache/ranger/entity/XXServiceDefBase.java 868de4a
security-admin/src/main/java/org/apache/ranger/entity/XXServiceResource.java 2624154
security-admin/src/main/java/org/apache/ranger/entity/XXServiceResourceElement.java cd60736
security-admin/src/main/java/org/apache/ranger/entity/XXServiceResourceElementValue.java 77c83ec
security-admin/src/main/java/org/apache/ranger/entity/XXTag.java c8a9d35
security-admin/src/main/java/org/apache/ranger/entity/XXTagAttribute.java cbbc102
security-admin/src/main/java/org/apache/ranger/entity/XXTagAttributeDef.java acf6697
security-admin/src/main/java/org/apache/ranger/entity/XXTagDef.java 5a3df65
security-admin/src/main/java/org/apache/ranger/entity/XXTagResourceMap.java 98f2355
security-admin/src/main/java/org/apache/ranger/service/RangerServiceDefServiceBase.java df3fa1b
Diff: https://reviews.apache.org/r/38772/diff/
Testing
-------
Tested on a local centos instance with Ranger and different DB Flavors.
Thanks,
Madhan Neethiraj
Re: Review Request 38772: RANGER-645: updates to support all DB
flavors for TagDBStore
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38772/#review100772
-----------------------------------------------------------
Ship it!
- Madhan Neethiraj
On Sept. 27, 2015, 7:13 a.m., Madhan Neethiraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38772/
> -----------------------------------------------------------
>
> (Updated Sept. 27, 2015, 7:13 a.m.)
>
>
> Review request for ranger, Gautam Borad, Abhay Kulkarni, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-645
> https://issues.apache.org/jira/browse/RANGER-645
>
>
> Repository: ranger
>
>
> Description
> -------
>
> This is the updated verison of review https://reviews.apache.org/r/38760/, after latest merge and few minor updates.
>
> Main changes :
> * Added DB Schema for all the databases supported for Ranger
>
>
> Other changes introduced :
> 1. Newly required column 'options' of Table X_SERVICE_DEF is changed to 'def_options' as 'options' and 'option' are reserved keyword in SQL Anywhere.
> 2. Patch 015 which was using three alter statement to add three column, is now adjusted in one alter table statement. Similarly patch 011 also has been changed.
> 3. Sequence name has been changed with actual Sequence name used for Oracle/Postgres schema.
>
>
> Diffs
> -----
>
> jisql/src/main/java/org/apache/util/sql/Jisql.java cc1be2a
> security-admin/db/mysql/patches/016-updated-schema-for-tag-based-policy.sql c5b813f
> security-admin/db/oracle/patches/016-updated-schema-for-tag-based-policy.sql 1bc8921
> security-admin/db/postgres/patches/016-updated-schema-for-tag-based-policy.sql d84bb03
> security-admin/db/sqlanywhere/patches/016-updated-schema-for-tag-based-policy.sql 21f0fcc
> security-admin/db/sqlserver/patches/016-updated-schema-for-tag-based-policy.sql af9f083
>
> Diff: https://reviews.apache.org/r/38772/diff/
>
>
> Testing
> -------
>
> Tested on a local centos instance with Ranger and different DB Flavors.
>
>
> Thanks,
>
> Madhan Neethiraj
>
>
Re: Review Request 38772: RANGER-645: updates to support all DB
flavors for TagDBStore
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38772/
-----------------------------------------------------------
(Updated Sept. 27, 2015, 7:13 a.m.)
Review request for ranger, Gautam Borad, Abhay Kulkarni, and Velmurugan Periasamy.
Changes
-------
RANGER-645: fix to DB schema update scripts per review comments (patch from Gautam)
Bugs: RANGER-645
https://issues.apache.org/jira/browse/RANGER-645
Repository: ranger
Description
-------
This is the updated verison of review https://reviews.apache.org/r/38760/, after latest merge and few minor updates.
Main changes :
* Added DB Schema for all the databases supported for Ranger
Other changes introduced :
1. Newly required column 'options' of Table X_SERVICE_DEF is changed to 'def_options' as 'options' and 'option' are reserved keyword in SQL Anywhere.
2. Patch 015 which was using three alter statement to add three column, is now adjusted in one alter table statement. Similarly patch 011 also has been changed.
3. Sequence name has been changed with actual Sequence name used for Oracle/Postgres schema.
Diffs (updated)
-----
jisql/src/main/java/org/apache/util/sql/Jisql.java cc1be2a
security-admin/db/mysql/patches/016-updated-schema-for-tag-based-policy.sql c5b813f
security-admin/db/oracle/patches/016-updated-schema-for-tag-based-policy.sql 1bc8921
security-admin/db/postgres/patches/016-updated-schema-for-tag-based-policy.sql d84bb03
security-admin/db/sqlanywhere/patches/016-updated-schema-for-tag-based-policy.sql 21f0fcc
security-admin/db/sqlserver/patches/016-updated-schema-for-tag-based-policy.sql af9f083
Diff: https://reviews.apache.org/r/38772/diff/
Testing
-------
Tested on a local centos instance with Ranger and different DB Flavors.
Thanks,
Madhan Neethiraj
Re: Review Request 38772: RANGER-645: updates to support all DB
flavors for TagDBStore
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38772/#review100684
-----------------------------------------------------------
Ship it!
security-admin/db/mysql/patches/016-updated-schema-for-tag-based-policy.sql (line 184)
<https://reviews.apache.org/r/38772/#comment157947>
tinyint(3) - would this limit the number of values for a resource to 8? This might be too small. Lets use 8 bits (256 max values per resource)
security-admin/db/mysql/patches/016-updated-schema-for-tag-based-policy.sql (line 240)
<https://reviews.apache.org/r/38772/#comment157942>
tag_service column should have FK reference to x_service.id column.
security-admin/db/oracle/patches/016-updated-schema-for-tag-based-policy.sql (line 235)
<https://reviews.apache.org/r/38772/#comment157943>
tag_service column should have FK reference to x_service.id column.
security-admin/db/postgres/patches/016-updated-schema-for-tag-based-policy.sql (line 240)
<https://reviews.apache.org/r/38772/#comment157944>
tag_service column should have FK reference to x_service.id column.
security-admin/db/sqlanywhere/patches/016-updated-schema-for-tag-based-policy.sql (line 229)
<https://reviews.apache.org/r/38772/#comment157945>
tag_service column should have FK reference to x_service.id column.
security-admin/db/sqlserver/patches/016-updated-schema-for-tag-based-policy.sql (line 572)
<https://reviews.apache.org/r/38772/#comment157946>
tag_service column should have FK reference to x_service.id column.
- Madhan Neethiraj
On Sept. 25, 2015, 8:56 p.m., Madhan Neethiraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38772/
> -----------------------------------------------------------
>
> (Updated Sept. 25, 2015, 8:56 p.m.)
>
>
> Review request for ranger, Gautam Borad, Abhay Kulkarni, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-645
> https://issues.apache.org/jira/browse/RANGER-645
>
>
> Repository: ranger
>
>
> Description
> -------
>
> This is the updated verison of review https://reviews.apache.org/r/38760/, after latest merge and few minor updates.
>
> Main changes :
> * Added DB Schema for all the databases supported for Ranger
>
>
> Other changes introduced :
> 1. Newly required column 'options' of Table X_SERVICE_DEF is changed to 'def_options' as 'options' and 'option' are reserved keyword in SQL Anywhere.
> 2. Patch 015 which was using three alter statement to add three column, is now adjusted in one alter table statement. Similarly patch 011 also has been changed.
> 3. Sequence name has been changed with actual Sequence name used for Oracle/Postgres schema.
>
>
> Diffs
> -----
>
> jisql/src/main/java/org/apache/util/sql/Jisql.java cf7563c
> security-admin/db/mysql/init/schema_mysql.sql 6df7195
> security-admin/db/mysql/patches/016-updated-schema-for-tag-based-policy.sql 532e723
> security-admin/db/mysql/patches/audit/011-auditcolumnssize.sql b38ae8c
> security-admin/db/mysql/patches/audit/015-auditlogaggregation.sql c88c5b4
> security-admin/db/mysql/xa_audit_db.sql 8334dce
> security-admin/db/mysql/xa_db.sql 9aba91f
> security-admin/db/oracle/patches/009-updated_schema.sql ed47237
> security-admin/db/oracle/patches/016-updated-schema-for-tag-based-policy.sql PRE-CREATION
> security-admin/db/oracle/patches/audit/011-auditcolumnssize.sql 35a9320
> security-admin/db/oracle/patches/audit/015-auditlogaggregation.sql 756ee61
> security-admin/db/oracle/patches/audit/017-add-new-column-to-store-tags.sql PRE-CREATION
> security-admin/db/oracle/xa_audit_db_oracle.sql 607a8b2
> security-admin/db/oracle/xa_core_db_oracle.sql 9c18ead
> security-admin/db/postgres/patches/016-updated-schema-for-tag-based-policy.sql PRE-CREATION
> security-admin/db/postgres/patches/audit/017-add-new-column-to-store-tags.sql PRE-CREATION
> security-admin/db/postgres/xa_audit_db_postgres.sql cace5c5
> security-admin/db/postgres/xa_core_db_postgres.sql 123732e
> security-admin/db/sqlanywhere/patches/016-updated-schema-for-tag-based-policy.sql PRE-CREATION
> security-admin/db/sqlanywhere/patches/audit/017-add-new-column-to-store-tags.sql PRE-CREATION
> security-admin/db/sqlserver/patches/016-updated-schema-for-tag-based-policy.sql PRE-CREATION
> security-admin/db/sqlserver/patches/audit/017-add-new-column-to-store-tags.sql PRE-CREATION
> security-admin/db/sqlserver/xa_audit_db_sqlserver.sql 783b968
> security-admin/db/sqlserver/xa_core_db_sqlserver.sql 6e304d4
> security-admin/scripts/db_setup.py 1edc628
> security-admin/src/main/java/org/apache/ranger/entity/XXServiceDefBase.java 868de4a
> security-admin/src/main/java/org/apache/ranger/entity/XXServiceResource.java 2624154
> security-admin/src/main/java/org/apache/ranger/entity/XXServiceResourceElement.java cd60736
> security-admin/src/main/java/org/apache/ranger/entity/XXServiceResourceElementValue.java 77c83ec
> security-admin/src/main/java/org/apache/ranger/entity/XXTag.java c8a9d35
> security-admin/src/main/java/org/apache/ranger/entity/XXTagAttribute.java cbbc102
> security-admin/src/main/java/org/apache/ranger/entity/XXTagAttributeDef.java acf6697
> security-admin/src/main/java/org/apache/ranger/entity/XXTagDef.java 5a3df65
> security-admin/src/main/java/org/apache/ranger/entity/XXTagResourceMap.java 98f2355
> security-admin/src/main/java/org/apache/ranger/service/RangerServiceDefServiceBase.java df3fa1b
>
> Diff: https://reviews.apache.org/r/38772/diff/
>
>
> Testing
> -------
>
> Tested on a local centos instance with Ranger and different DB Flavors.
>
>
> Thanks,
>
> Madhan Neethiraj
>
>