You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/05/05 00:33:07 UTC
[GitHub] [kafka] hachikuji commented on a change in pull request #8609: KAFKA-9946; StopReplicaRequest deletePartition changes may cause premature topic deletion handling in controller
hachikuji commented on a change in pull request #8609:
URL: https://github.com/apache/kafka/pull/8609#discussion_r419803119
##########
File path: core/src/main/scala/kafka/controller/ControllerChannelManager.scala
##########
@@ -590,7 +569,26 @@ abstract class AbstractControllerBrokerRequestBatch(config: KafkaConfig,
stateChangeLog.info(s"Sending StopReplica request for ${partitionStates.size} " +
s"replicas to broker $brokerId")
- sendStopReplicaRequest(brokerId, brokerEpoch, false, stopReplicaTopicState)
+ val stopReplicaRequestBuilder = new StopReplicaRequest.Builder(
+ stopReplicaRequestVersion, controllerId, controllerEpoch, brokerEpoch,
+ false, stopReplicaTopicState.values.toBuffer.asJava)
+
+ sendRequest(brokerId, stopReplicaRequestBuilder, (r: AbstractResponse) => {
+ val stopReplicaResponse = r.asInstanceOf[StopReplicaResponse]
Review comment:
I agree the duplication is a tad vexing. Perhaps we could pass a function `TopicPartition -> Boolean` to the callback which tells whether deletion was requested. For the old version, we would return `true` blindly.
##########
File path: core/src/main/scala/kafka/controller/ControllerChannelManager.scala
##########
@@ -590,7 +569,26 @@ abstract class AbstractControllerBrokerRequestBatch(config: KafkaConfig,
stateChangeLog.info(s"Sending StopReplica request for ${partitionStates.size} " +
s"replicas to broker $brokerId")
- sendStopReplicaRequest(brokerId, brokerEpoch, false, stopReplicaTopicState)
+ val stopReplicaRequestBuilder = new StopReplicaRequest.Builder(
+ stopReplicaRequestVersion, controllerId, controllerEpoch, brokerEpoch,
+ false, stopReplicaTopicState.values.toBuffer.asJava)
+
+ sendRequest(brokerId, stopReplicaRequestBuilder, (r: AbstractResponse) => {
+ val stopReplicaResponse = r.asInstanceOf[StopReplicaResponse]
+ val partitionErrorsForDeletingTopics = mutable.Map.empty[TopicPartition, Errors]
+ stopReplicaResponse.partitionErrors.asScala.foreach { pe =>
+ val tp = new TopicPartition(pe.topicName, pe.partitionIndex)
+ // Verify that the topic deletion is in progress and
+ // that the request deleted the replica
+ if (controllerContext.isTopicDeletionInProgress(pe.topicName) &&
+ partitionStates.get(tp).exists(_.deletePartition)) {
Review comment:
nit: could we align with the `controllerContext`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org