[GitHub] [kafka] rondagostino commented on a change in pull request #9356: KAFKA-10556: NPE if sasl.mechanism is unrecognized

[GitBox <gi...@apache.org>]

rondagostino commented on a change in pull request #9356:
URL: https://github.com/apache/kafka/pull/9356#discussion_r497653222



##########
File path: clients/src/main/java/org/apache/kafka/common/security/authenticator/SaslClientAuthenticator.java
##########
@@ -214,7 +214,11 @@ SaslClient createSaslClient() {
                 String[] mechs = {mechanism};
                 log.debug("Creating SaslClient: client={};service={};serviceHostname={};mechs={}",
                     clientPrincipalName, servicePrincipal, host, Arrays.toString(mechs));
-                return Sasl.createSaslClient(mechs, clientPrincipalName, servicePrincipal, host, configs, callbackHandler);
+                SaslClient retvalSaslClient = Sasl.createSaslClient(mechs, clientPrincipalName, servicePrincipal, host, configs, callbackHandler);

Review comment:
       @rajinisivaram good point.  It's now fixed.  All client tests pass locally.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org