[GitHub] [jmeter] FSchumacher commented on pull request #727: Bug 66269: Add NoThreadClone to HeaderManager to reduce heap utilization

[GitBox <gi...@apache.org>]

FSchumacher commented on PR #727:
URL: https://github.com/apache/jmeter/pull/727#issuecomment-1320862583

   > The change would impact the ones who attempt to add/remove headers dynamically via JSR223 or something similar.
   > 
   > For instance, https://sqa.stackexchange.com/questions/41708/jmeter-header-manager-alters-the-headers-during-test attempts
   > 
   > ```java
   > sampler.getHeaderManager().add(new Header("Authorization","Bearer " + vars.get("BEARER"))); 
   > ```
   
   Don't you think, this is done more often, than we think about it? I think we have recommended such a workaround for other problems with the samplers setting/not setting headers in the past.
   
   Can we implement a switch to enable sharing of the header manager and expose it with a property (set default to share instances)?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org