You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "linliu-code (via GitHub)" <gi...@apache.org> on 2026/01/13 20:48:19 UTC

[PR] [HUDI-9288] Fixing HoodieFileGroup api related to uncommitted slices [hudi]

linliu-code opened a new pull request, #17847:
URL: https://github.com/apache/hudi/pull/17847

   
   
   ### Change Logs
   Cherry-picked from https://github.com/apache/hudi/pull/13125
   
   Use same filter in getAllFileSlicesBeforeOn as is used in getAllFileSlices
   
   ### Impact
   Fixes bug where slice can be returned without being committed which can cause issues in other parts of the code. This was causing errors in the small file handling flow.
   
   ### Risk level (write none, low medium or high below)
   Low
   
   ### Documentation Update
   
   <!-- Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none".
   
   - The config description must be updated if new configs are added or the default value of the configs are changed.
   - Any new feature or user-facing change requires updating the Hudi website. Please follow the 
     [instruction](https://hudi.apache.org/contribute/developer-setup#website) to make changes to the website. -->
   
   ### Contributor's checklist
   
   - [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
   - [ ] Enough context is provided in the sections above
   - [ ] Adequate tests were added if applicable
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(HUDI-9288): Fixing HoodieFileGroup api related to uncommitted slices [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17847:
URL: https://github.com/apache/hudi/pull/17847#issuecomment-3774738620

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "5a4368cfddf835babffcfa8fd3d253866c66036c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10985",
       "triggerID" : "5a4368cfddf835babffcfa8fd3d253866c66036c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "bd79a69ea9a206e85d5ae6f7fdd96fd3e4e27b0d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11238",
       "triggerID" : "bd79a69ea9a206e85d5ae6f7fdd96fd3e4e27b0d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "bad39447a33d4812d450bdf8790f9b76feea513f",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11240",
       "triggerID" : "bad39447a33d4812d450bdf8790f9b76feea513f",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * bad39447a33d4812d450bdf8790f9b76feea513f Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11240) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(HUDI-9288): Fixing HoodieFileGroup api related to uncommitted slices [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17847:
URL: https://github.com/apache/hudi/pull/17847#issuecomment-3850850312

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "5a4368cfddf835babffcfa8fd3d253866c66036c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10985",
       "triggerID" : "5a4368cfddf835babffcfa8fd3d253866c66036c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "bd79a69ea9a206e85d5ae6f7fdd96fd3e4e27b0d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11238",
       "triggerID" : "bd79a69ea9a206e85d5ae6f7fdd96fd3e4e27b0d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "bad39447a33d4812d450bdf8790f9b76feea513f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11240",
       "triggerID" : "bad39447a33d4812d450bdf8790f9b76feea513f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c92228d4411633637ce88a3f66795fd0e73b95c6",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11680",
       "triggerID" : "c92228d4411633637ce88a3f66795fd0e73b95c6",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c92228d4411633637ce88a3f66795fd0e73b95c6 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11680) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(HUDI-9288): Fixing HoodieFileGroup api related to uncommitted slices [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17847:
URL: https://github.com/apache/hudi/pull/17847#issuecomment-3850784094

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "5a4368cfddf835babffcfa8fd3d253866c66036c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10985",
       "triggerID" : "5a4368cfddf835babffcfa8fd3d253866c66036c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "bd79a69ea9a206e85d5ae6f7fdd96fd3e4e27b0d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11238",
       "triggerID" : "bd79a69ea9a206e85d5ae6f7fdd96fd3e4e27b0d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "bad39447a33d4812d450bdf8790f9b76feea513f",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11240",
       "triggerID" : "bad39447a33d4812d450bdf8790f9b76feea513f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c92228d4411633637ce88a3f66795fd0e73b95c6",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "c92228d4411633637ce88a3f66795fd0e73b95c6",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * bad39447a33d4812d450bdf8790f9b76feea513f Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11240) 
   * c92228d4411633637ce88a3f66795fd0e73b95c6 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(HUDI-9288): Fixing HoodieFileGroup api related to uncommitted slices [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17847:
URL: https://github.com/apache/hudi/pull/17847#issuecomment-3774525157

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "5a4368cfddf835babffcfa8fd3d253866c66036c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10985",
       "triggerID" : "5a4368cfddf835babffcfa8fd3d253866c66036c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "bd79a69ea9a206e85d5ae6f7fdd96fd3e4e27b0d",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11238",
       "triggerID" : "bd79a69ea9a206e85d5ae6f7fdd96fd3e4e27b0d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "bad39447a33d4812d450bdf8790f9b76feea513f",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "bad39447a33d4812d450bdf8790f9b76feea513f",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * bd79a69ea9a206e85d5ae6f7fdd96fd3e4e27b0d Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11238) 
   * bad39447a33d4812d450bdf8790f9b76feea513f UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(HUDI-9288): Fixing HoodieFileGroup api related to uncommitted slices [hudi]

Posted by "linliu-code (via GitHub)" <gi...@apache.org>.
linliu-code commented on code in PR #17847:
URL: https://github.com/apache/hudi/pull/17847#discussion_r2766813967


##########
hudi-common/src/main/java/org/apache/hudi/common/table/view/AbstractTableFileSystemView.java:
##########
@@ -718,7 +719,7 @@ public final Option<HoodieBaseFile> getBaseFileOn(String partitionStr, String in
         return Option.empty();
       } else {
         return fetchHoodieFileGroup(partitionPath, fileId).map(fileGroup -> fileGroup.getAllBaseFiles()
-                .filter(baseFile -> HoodieTimeline.compareTimestamps(baseFile.getCommitTime(), HoodieTimeline.EQUALS,
+                .filter(baseFile -> compareTimestamps(baseFile.getCommitTime(), HoodieTimeline.EQUALS,

Review Comment:
   done.



##########
hudi-common/src/main/java/org/apache/hudi/common/table/view/AbstractTableFileSystemView.java:
##########
@@ -701,7 +702,7 @@ private Stream<HoodieBaseFile> getLatestBaseFilesBeforeOrOnFromCache(String part
     return fetchAllStoredFileGroups(partitionPath)
         .filter(fileGroup -> !isFileGroupReplacedBeforeOrOn(fileGroup.getFileGroupId(), maxCommitTime))
         .map(fileGroup -> Option.fromJavaOptional(fileGroup.getAllBaseFiles()
-            .filter(baseFile -> HoodieTimeline.compareTimestamps(baseFile.getCommitTime(), HoodieTimeline.LESSER_THAN_OR_EQUALS, maxCommitTime
+            .filter(baseFile -> compareTimestamps(baseFile.getCommitTime(), HoodieTimeline.LESSER_THAN_OR_EQUALS, maxCommitTime

Review Comment:
   done.



##########
hudi-common/src/main/java/org/apache/hudi/common/table/view/AbstractTableFileSystemView.java:
##########
@@ -254,7 +255,7 @@ private void resetFileGroupsReplaced(HoodieTimeline timeline) {
 
     // Duplicate key error when insert_overwrite same partition in multi writer, keep the instant with greater timestamp when the file group id conflicts
     Map<HoodieFileGroupId, HoodieInstant> replacedFileGroups = resultStream.collect(Collectors.toMap(Map.Entry::getKey, Map.Entry::getValue,
-        (instance1, instance2) -> HoodieTimeline.compareTimestamps(instance1.getTimestamp(), HoodieTimeline.LESSER_THAN, instance2.getTimestamp()) ? instance2 : instance1));
+        (instance1, instance2) -> compareTimestamps(instance1.getTimestamp(), HoodieTimeline.LESSER_THAN, instance2.getTimestamp()) ? instance2 : instance1));

Review Comment:
   done.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [HUDI-9288] Fixing HoodieFileGroup api related to uncommitted slices [hudi]

Posted by "cshuo (via GitHub)" <gi...@apache.org>.
cshuo commented on PR #17847:
URL: https://github.com/apache/hudi/pull/17847#issuecomment-3766080000

   hi @linliu-code for the failed the flink tests, the cause is: this pr will update `getAllFileSlicesBeforeOn`  method by filtering out file slices based on committed instants in time.
   ```java
   private boolean isFileSliceCommitted(FileSlice slice) {
       if (!compareTimestamps(slice.getBaseInstantTime(), LESSER_THAN_OR_EQUALS, lastInstant.get().getTimestamp())) {
         return false;
       }
   
       return timeline.containsOrBeforeTimelineStarts(slice.getBaseInstantTime());
     }
   ```
   When skip compaction is enabled for flink `IncrementalInputSplits`, the compaction instants is not included in the timeline, so the file slice for second commit is not included in the result, because its base instant time is not in the timeline.
   
   ### Solution
   Modify `AbstractTableFileSystemView#fetchAllLogsMergedFileSlice` as:
   ```java
   private Option<FileSlice> fetchAllLogsMergedFileSlice(HoodieFileGroup fileGroup, String maxInstantTime) {
       List<FileSlice> fileSlices = fileGroup.getAllRawFileSlices().collect(Collectors.toList());
       fileSlices = fileSlices.stream().filter(slice -> compareTimestamps(slice.getBaseInstantTime(), LESSER_THAN_OR_EQUALS, maxInstantTime)).collect(Collectors.toList());
       ...
   }
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [HUDI-9288] Fixing HoodieFileGroup api related to uncommitted slices [hudi]

Posted by "linliu-code (via GitHub)" <gi...@apache.org>.
linliu-code commented on PR #17847:
URL: https://github.com/apache/hudi/pull/17847#issuecomment-3774040685

   > hi @linliu-code for the failed the flink tests, the cause is: this pr will update `getAllFileSlicesBeforeOn` method, which now would filters out file slices based on committed instants in the timeline.
   > 
   > ```java
   > private boolean isFileSliceCommitted(FileSlice slice) {
   >     if (!compareTimestamps(slice.getBaseInstantTime(), LESSER_THAN_OR_EQUALS, lastInstant.get().getTimestamp())) {
   >       return false;
   >     }
   > 
   >     return timeline.containsOrBeforeTimelineStarts(slice.getBaseInstantTime());
   >   }
   > ```
   > 
   > When skip compaction is enabled for flink `IncrementalInputSplits`, the compaction instants is not included in the timeline, so the file slice for second commit is not included in the result, because its base instant time is not in the timeline.
   > 
   > ### Solution
   > Modify `AbstractTableFileSystemView#fetchAllLogsMergedFileSlice` as:
   > 
   > ```java
   > private Option<FileSlice> fetchAllLogsMergedFileSlice(HoodieFileGroup fileGroup, String maxInstantTime) {
   >     List<FileSlice> fileSlices = fileGroup.getAllRawFileSlices().collect(Collectors.toList());
   >     fileSlices = fileSlices.stream().filter(slice -> compareTimestamps(slice.getBaseInstantTime(), LESSER_THAN_OR_EQUALS, maxInstantTime)).collect(Collectors.toList());
   >     ...
   > }
   > ```
   
   @cshuo Thanks for pointing out. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(HUDI-9288): Fixing HoodieFileGroup api related to uncommitted slices [hudi]

Posted by "cshuo (via GitHub)" <gi...@apache.org>.
cshuo commented on code in PR #17847:
URL: https://github.com/apache/hudi/pull/17847#discussion_r2730652938


##########
hudi-common/src/main/java/org/apache/hudi/common/table/view/AbstractTableFileSystemView.java:
##########
@@ -701,7 +702,7 @@ private Stream<HoodieBaseFile> getLatestBaseFilesBeforeOrOnFromCache(String part
     return fetchAllStoredFileGroups(partitionPath)
         .filter(fileGroup -> !isFileGroupReplacedBeforeOrOn(fileGroup.getFileGroupId(), maxCommitTime))
         .map(fileGroup -> Option.fromJavaOptional(fileGroup.getAllBaseFiles()
-            .filter(baseFile -> HoodieTimeline.compareTimestamps(baseFile.getCommitTime(), HoodieTimeline.LESSER_THAN_OR_EQUALS, maxCommitTime
+            .filter(baseFile -> compareTimestamps(baseFile.getCommitTime(), HoodieTimeline.LESSER_THAN_OR_EQUALS, maxCommitTime

Review Comment:
   ditto



##########
hudi-common/src/main/java/org/apache/hudi/common/table/view/AbstractTableFileSystemView.java:
##########
@@ -718,7 +719,7 @@ public final Option<HoodieBaseFile> getBaseFileOn(String partitionStr, String in
         return Option.empty();
       } else {
         return fetchHoodieFileGroup(partitionPath, fileId).map(fileGroup -> fileGroup.getAllBaseFiles()
-                .filter(baseFile -> HoodieTimeline.compareTimestamps(baseFile.getCommitTime(), HoodieTimeline.EQUALS,
+                .filter(baseFile -> compareTimestamps(baseFile.getCommitTime(), HoodieTimeline.EQUALS,

Review Comment:
   ditto



##########
hudi-common/src/main/java/org/apache/hudi/common/table/view/AbstractTableFileSystemView.java:
##########
@@ -254,7 +255,7 @@ private void resetFileGroupsReplaced(HoodieTimeline timeline) {
 
     // Duplicate key error when insert_overwrite same partition in multi writer, keep the instant with greater timestamp when the file group id conflicts
     Map<HoodieFileGroupId, HoodieInstant> replacedFileGroups = resultStream.collect(Collectors.toMap(Map.Entry::getKey, Map.Entry::getValue,
-        (instance1, instance2) -> HoodieTimeline.compareTimestamps(instance1.getTimestamp(), HoodieTimeline.LESSER_THAN, instance2.getTimestamp()) ? instance2 : instance1));
+        (instance1, instance2) -> compareTimestamps(instance1.getTimestamp(), HoodieTimeline.LESSER_THAN, instance2.getTimestamp()) ? instance2 : instance1));

Review Comment:
   unnecessary change.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [HUDI-9288] Fixing HoodieFileGroup api related to uncommitted slices [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17847:
URL: https://github.com/apache/hudi/pull/17847#issuecomment-3746560518

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "5a4368cfddf835babffcfa8fd3d253866c66036c",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10985",
       "triggerID" : "5a4368cfddf835babffcfa8fd3d253866c66036c",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 5a4368cfddf835babffcfa8fd3d253866c66036c Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10985) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [HUDI-9288] Fixing HoodieFileGroup api related to uncommitted slices [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17847:
URL: https://github.com/apache/hudi/pull/17847#issuecomment-3774095073

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "5a4368cfddf835babffcfa8fd3d253866c66036c",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10985",
       "triggerID" : "5a4368cfddf835babffcfa8fd3d253866c66036c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "bd79a69ea9a206e85d5ae6f7fdd96fd3e4e27b0d",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "bd79a69ea9a206e85d5ae6f7fdd96fd3e4e27b0d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 5a4368cfddf835babffcfa8fd3d253866c66036c Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10985) 
   * bd79a69ea9a206e85d5ae6f7fdd96fd3e4e27b0d UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(HUDI-9288): Fixing HoodieFileGroup api related to uncommitted slices [hudi]

Posted by "linliu-code (via GitHub)" <gi...@apache.org>.
linliu-code commented on PR #17847:
URL: https://github.com/apache/hudi/pull/17847#issuecomment-3857557982

   <img width="306" height="519" alt="image" src="https://github.com/user-attachments/assets/dbea9e19-5bc6-4ced-9c5b-fb24806c4451" />
   Azure CI is green


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(HUDI-9288): Fixing HoodieFileGroup api related to uncommitted slices [hudi]

Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 merged PR #17847:
URL: https://github.com/apache/hudi/pull/17847


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(HUDI-9288): Fixing HoodieFileGroup api related to uncommitted slices [hudi]

Posted by "cshuo (via GitHub)" <gi...@apache.org>.
cshuo commented on PR #17847:
URL: https://github.com/apache/hudi/pull/17847#issuecomment-3803582008

   > Is there an alternate fix possible for flink issue? It seems like it worked in 1.1 without making those changes.
   
   @lokeshj1703 the background is for flink incremental reading with compaction instant skipped, the compaction instant will not be included in the timeline. For 1.1, the file slicing has been refactored based on completion time, which makes it work without those changes. 
   
   btw, `fetchAllLogsMergedFileSlice` is introduced specifically for flink `IncrementalInputSplits`, so the risk for the change is very low. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [HUDI-9288] Fixing HoodieFileGroup api related to uncommitted slices [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17847:
URL: https://github.com/apache/hudi/pull/17847#issuecomment-3746524776

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "5a4368cfddf835babffcfa8fd3d253866c66036c",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10985",
       "triggerID" : "5a4368cfddf835babffcfa8fd3d253866c66036c",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 5a4368cfddf835babffcfa8fd3d253866c66036c Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10985) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [HUDI-9288] Fixing HoodieFileGroup api related to uncommitted slices [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17847:
URL: https://github.com/apache/hudi/pull/17847#issuecomment-3774334556

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "5a4368cfddf835babffcfa8fd3d253866c66036c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10985",
       "triggerID" : "5a4368cfddf835babffcfa8fd3d253866c66036c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "bd79a69ea9a206e85d5ae6f7fdd96fd3e4e27b0d",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11238",
       "triggerID" : "bd79a69ea9a206e85d5ae6f7fdd96fd3e4e27b0d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * bd79a69ea9a206e85d5ae6f7fdd96fd3e4e27b0d Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11238) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [HUDI-9288] Fixing HoodieFileGroup api related to uncommitted slices [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17847:
URL: https://github.com/apache/hudi/pull/17847#issuecomment-3746516049

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "5a4368cfddf835babffcfa8fd3d253866c66036c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "5a4368cfddf835babffcfa8fd3d253866c66036c",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 5a4368cfddf835babffcfa8fd3d253866c66036c UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(HUDI-9288): Fixing HoodieFileGroup api related to uncommitted slices [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17847:
URL: https://github.com/apache/hudi/pull/17847#issuecomment-3850790989

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "5a4368cfddf835babffcfa8fd3d253866c66036c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10985",
       "triggerID" : "5a4368cfddf835babffcfa8fd3d253866c66036c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "bd79a69ea9a206e85d5ae6f7fdd96fd3e4e27b0d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11238",
       "triggerID" : "bd79a69ea9a206e85d5ae6f7fdd96fd3e4e27b0d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "bad39447a33d4812d450bdf8790f9b76feea513f",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11240",
       "triggerID" : "bad39447a33d4812d450bdf8790f9b76feea513f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c92228d4411633637ce88a3f66795fd0e73b95c6",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11680",
       "triggerID" : "c92228d4411633637ce88a3f66795fd0e73b95c6",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * bad39447a33d4812d450bdf8790f9b76feea513f Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11240) 
   * c92228d4411633637ce88a3f66795fd0e73b95c6 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11680) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [HUDI-9288] Fixing HoodieFileGroup api related to uncommitted slices [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17847:
URL: https://github.com/apache/hudi/pull/17847#issuecomment-3774109895

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "5a4368cfddf835babffcfa8fd3d253866c66036c",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10985",
       "triggerID" : "5a4368cfddf835babffcfa8fd3d253866c66036c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "bd79a69ea9a206e85d5ae6f7fdd96fd3e4e27b0d",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11238",
       "triggerID" : "bd79a69ea9a206e85d5ae6f7fdd96fd3e4e27b0d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 5a4368cfddf835babffcfa8fd3d253866c66036c Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10985) 
   * bd79a69ea9a206e85d5ae6f7fdd96fd3e4e27b0d Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11238) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(HUDI-9288): Fixing HoodieFileGroup api related to uncommitted slices [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17847:
URL: https://github.com/apache/hudi/pull/17847#issuecomment-3774538096

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "5a4368cfddf835babffcfa8fd3d253866c66036c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10985",
       "triggerID" : "5a4368cfddf835babffcfa8fd3d253866c66036c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "bd79a69ea9a206e85d5ae6f7fdd96fd3e4e27b0d",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11238",
       "triggerID" : "bd79a69ea9a206e85d5ae6f7fdd96fd3e4e27b0d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "bad39447a33d4812d450bdf8790f9b76feea513f",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11240",
       "triggerID" : "bad39447a33d4812d450bdf8790f9b76feea513f",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * bd79a69ea9a206e85d5ae6f7fdd96fd3e4e27b0d Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11238) 
   * bad39447a33d4812d450bdf8790f9b76feea513f Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11240) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org