You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "nikolaos georgosoulos (JIRA)" <de...@myfaces.apache.org> on 2007/09/07 17:38:30 UTC
[jira] Created: (MYFACES-1720) panelGrid header facet and
jsp:include
panelGrid header facet and jsp:include
--------------------------------------
Key: MYFACES-1720
URL: https://issues.apache.org/jira/browse/MYFACES-1720
Project: MyFaces Core
Issue Type: Bug
Components: General
Affects Versions: 1.1.5, 1.1.6-SNAPSHOT
Environment: Tomcat, Myfaces 1.1.5 or 1.1.6-SNAPSHOT tomahawk 1.1.6
Reporter: nikolaos georgosoulos
While <h:panelGrid><f:facet name="header><h:outputText value="something"/></f:facet></h:panelGrid> will render a table and a thead to put inside it the "something" text, the <h:panelGrid><f:facet name="header><jsp:include page="/someotherjsp.jsp"/></f:facet></h:panelGrid> will render the someotherjsp code inside a td inside a tbody. That really limits the choices we have and I think it can be fixed. Unfortunately I cannot do the job here where I am (no svn access to download the code, to many firewalls in between).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Created: (MYFACES-1720) panelGrid header facet and jsp:include
Posted by Andrew Robinson <an...@gmail.com>.
Why doesn't the jsp:include work? Is it simply forgetting that facets
have to be a single component?
Does this work:
<h:panelGrid><f:facet name="header><h:panelGroup><jsp:include
page="/someotherjsp.jsp"/><h:panelGroup></f:facet></h:panelGrid>
On 9/7/07, nikolaos georgosoulos (JIRA) <de...@myfaces.apache.org> wrote:
> panelGrid header facet and jsp:include
> --------------------------------------
>
> Key: MYFACES-1720
> URL: https://issues.apache.org/jira/browse/MYFACES-1720
> Project: MyFaces Core
> Issue Type: Bug
> Components: General
> Affects Versions: 1.1.5, 1.1.6-SNAPSHOT
> Environment: Tomcat, Myfaces 1.1.5 or 1.1.6-SNAPSHOT tomahawk 1.1.6
> Reporter: nikolaos georgosoulos
>
>
> While <h:panelGrid><f:facet name="header><h:outputText value="something"/></f:facet></h:panelGrid> will render a table and a thead to put inside it the "something" text, the <h:panelGrid><f:facet name="header><jsp:include page="/someotherjsp.jsp"/></f:facet></h:panelGrid> will render the someotherjsp code inside a td inside a tbody. That really limits the choices we have and I think it can be fixed. Unfortunately I cannot do the job here where I am (no svn access to download the code, to many firewalls in between).
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>
Re: [jira] Commented: (MYFACES-1720) panelGrid header facet and jsp:include
Posted by Andrew Robinson <an...@gmail.com>.
Actually, the h:panelGroup produces no HTML at all. The renderer for
the panelGrid creates the TH. If a panel group has no attributes, like
ID, style, styleClass, HTML will not be rendered for it. Otherwise, it
creates a SPAN.
Facets must contain 1 and only 1 child component, it is part of the
JSF UIComponent requirements/specification.
-Andrew
On 9/10/07, nikolaos georgosoulos (JIRA) <de...@myfaces.apache.org> wrote:
>
> [ https://issues.apache.org/jira/browse/MYFACES-1720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12526087 ]
>
> nikolaos georgosoulos commented on MYFACES-1720:
> ------------------------------------------------
>
> as a work around Andrew Robinson-5 suggested (and it works) the following:
>
> <h:panelGrid><f:facet name="header><h:panelGroup><jsp:include page="/someotherjsp.jsp"/><h:panelGroup></f:facet></h:panelGrid>
>
> PAY ATTENTION to the h:panelGrid inside the facet. The one thing I don't really like about this is the table inside the th that is produced by the panelgrid inside the facet. E! well... like is not perfect.
>
> > panelGrid header facet and jsp:include
> > --------------------------------------
> >
> > Key: MYFACES-1720
> > URL: https://issues.apache.org/jira/browse/MYFACES-1720
> > Project: MyFaces Core
> > Issue Type: Bug
> > Components: General
> > Affects Versions: 1.1.5, 1.1.6-SNAPSHOT
> > Environment: Tomcat, Myfaces 1.1.5 or 1.1.6-SNAPSHOT tomahawk 1.1.6
> > Reporter: nikolaos georgosoulos
> >
> > While <h:panelGrid><f:facet name="header><h:outputText value="something"/></f:facet></h:panelGrid> will render a table and a thead to put inside it the "something" text, the <h:panelGrid><f:facet name="header><jsp:include page="/someotherjsp.jsp"/></f:facet></h:panelGrid> will render the someotherjsp code inside a td inside a tbody. That really limits the choices we have and I think it can be fixed. Unfortunately I cannot do the job here where I am (no svn access to download the code, to many firewalls in between).
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>
[jira] Resolved: (MYFACES-1720) panelGrid header facet and
jsp:include
Posted by "nikolaos georgosoulos (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-1720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
nikolaos georgosoulos resolved MYFACES-1720.
--------------------------------------------
Resolution: Fixed
since I've been the only one following this issue and since, there is a work around that seams to be "in accordance with the specifications", I am resolving this issue. I have to mention though that the specification does not mention "one JSF child" so the <jsp:include> since it is a tag looks like 1 child as well. Anyway, this all seams like too small letters to actually play any role. Just remember, when you want to use a jsp:include to form your facet content, put it inside a <panelgroup> with no attributes. I hope this saves some time from some people out there.
> panelGrid header facet and jsp:include
> --------------------------------------
>
> Key: MYFACES-1720
> URL: https://issues.apache.org/jira/browse/MYFACES-1720
> Project: MyFaces Core
> Issue Type: Bug
> Components: General
> Affects Versions: 1.1.5, 1.1.6-SNAPSHOT
> Environment: Tomcat, Myfaces 1.1.5 or 1.1.6-SNAPSHOT tomahawk 1.1.6
> Reporter: nikolaos georgosoulos
>
> While <h:panelGrid><f:facet name="header><h:outputText value="something"/></f:facet></h:panelGrid> will render a table and a thead to put inside it the "something" text, the <h:panelGrid><f:facet name="header><jsp:include page="/someotherjsp.jsp"/></f:facet></h:panelGrid> will render the someotherjsp code inside a td inside a tbody. That really limits the choices we have and I think it can be fixed. Unfortunately I cannot do the job here where I am (no svn access to download the code, to many firewalls in between).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-1720) panelGrid header facet and
jsp:include
Posted by "nikolaos georgosoulos (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-1720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12526089 ]
nikolaos georgosoulos commented on MYFACES-1720:
------------------------------------------------
One more idea is to use h:panelGrid instead of panelGrid, this avoids the table inside the th.... is it really important to use a group since the jsp:include has to have a subform?
> panelGrid header facet and jsp:include
> --------------------------------------
>
> Key: MYFACES-1720
> URL: https://issues.apache.org/jira/browse/MYFACES-1720
> Project: MyFaces Core
> Issue Type: Bug
> Components: General
> Affects Versions: 1.1.5, 1.1.6-SNAPSHOT
> Environment: Tomcat, Myfaces 1.1.5 or 1.1.6-SNAPSHOT tomahawk 1.1.6
> Reporter: nikolaos georgosoulos
>
> While <h:panelGrid><f:facet name="header><h:outputText value="something"/></f:facet></h:panelGrid> will render a table and a thead to put inside it the "something" text, the <h:panelGrid><f:facet name="header><jsp:include page="/someotherjsp.jsp"/></f:facet></h:panelGrid> will render the someotherjsp code inside a td inside a tbody. That really limits the choices we have and I think it can be fixed. Unfortunately I cannot do the job here where I am (no svn access to download the code, to many firewalls in between).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-1720) panelGrid header facet and
jsp:include
Posted by "nikolaos georgosoulos (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-1720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12526147 ]
nikolaos georgosoulos commented on MYFACES-1720:
------------------------------------------------
In the last comment I meant subview, not subform (it was early in the morning for us here). The real question is, since inside the someotherjsp I have the tag subview and inside it I have a panelGroup, why would I need the panelgroup again when I'm importing the fragment? it doesn't look good, does it?
> panelGrid header facet and jsp:include
> --------------------------------------
>
> Key: MYFACES-1720
> URL: https://issues.apache.org/jira/browse/MYFACES-1720
> Project: MyFaces Core
> Issue Type: Bug
> Components: General
> Affects Versions: 1.1.5, 1.1.6-SNAPSHOT
> Environment: Tomcat, Myfaces 1.1.5 or 1.1.6-SNAPSHOT tomahawk 1.1.6
> Reporter: nikolaos georgosoulos
>
> While <h:panelGrid><f:facet name="header><h:outputText value="something"/></f:facet></h:panelGrid> will render a table and a thead to put inside it the "something" text, the <h:panelGrid><f:facet name="header><jsp:include page="/someotherjsp.jsp"/></f:facet></h:panelGrid> will render the someotherjsp code inside a td inside a tbody. That really limits the choices we have and I think it can be fixed. Unfortunately I cannot do the job here where I am (no svn access to download the code, to many firewalls in between).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-1720) panelGrid header facet and
jsp:include
Posted by "nikolaos georgosoulos (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-1720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12526087 ]
nikolaos georgosoulos commented on MYFACES-1720:
------------------------------------------------
as a work around Andrew Robinson-5 suggested (and it works) the following:
<h:panelGrid><f:facet name="header><h:panelGroup><jsp:include page="/someotherjsp.jsp"/><h:panelGroup></f:facet></h:panelGrid>
PAY ATTENTION to the h:panelGrid inside the facet. The one thing I don't really like about this is the table inside the th that is produced by the panelgrid inside the facet. E! well... like is not perfect.
> panelGrid header facet and jsp:include
> --------------------------------------
>
> Key: MYFACES-1720
> URL: https://issues.apache.org/jira/browse/MYFACES-1720
> Project: MyFaces Core
> Issue Type: Bug
> Components: General
> Affects Versions: 1.1.5, 1.1.6-SNAPSHOT
> Environment: Tomcat, Myfaces 1.1.5 or 1.1.6-SNAPSHOT tomahawk 1.1.6
> Reporter: nikolaos georgosoulos
>
> While <h:panelGrid><f:facet name="header><h:outputText value="something"/></f:facet></h:panelGrid> will render a table and a thead to put inside it the "something" text, the <h:panelGrid><f:facet name="header><jsp:include page="/someotherjsp.jsp"/></f:facet></h:panelGrid> will render the someotherjsp code inside a td inside a tbody. That really limits the choices we have and I think it can be fixed. Unfortunately I cannot do the job here where I am (no svn access to download the code, to many firewalls in between).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.