You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Colm O hEigeartaigh <co...@apache.org> on 2016/09/14 11:00:59 UTC

Review Request 51889: Add tests for KMS Service and plugin

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51889/
-----------------------------------------------------------

Review request for ranger.


Bugs: RANGER-1174
    https://issues.apache.org/jira/browse/RANGER-1174


Repository: ranger


Description
-------

This task is to add some tests for the KMS server and plugin.


Diffs
-----

  kms/pom.xml e73dd01 
  kms/src/test/java/org/apache/hadoop/crypto/key/kms/server/DerbyTestUtils.java PRE-CREATION 
  kms/src/test/java/org/apache/hadoop/crypto/key/kms/server/RangerKeyStoreProviderTest.java PRE-CREATION 
  kms/src/test/java/org/apache/hadoop/crypto/key/kms/server/RangerMasterKeyTest.java PRE-CREATION 
  kms/src/test/resources/kms/dbks-site.xml PRE-CREATION 
  kms/src/test/resources/kms/kms-site.xml PRE-CREATION 
  plugin-kms/pom.xml 5ac7b20 
  plugin-kms/src/test/java/org/apache/ranger/authorization/kms/authorizer/DerbyTestUtils.java PRE-CREATION 
  plugin-kms/src/test/java/org/apache/ranger/authorization/kms/authorizer/RangerAdminClientImpl.java PRE-CREATION 
  plugin-kms/src/test/java/org/apache/ranger/authorization/kms/authorizer/RangerKmsAuthorizerTest.java PRE-CREATION 
  plugin-kms/src/test/resources/kms-policies.json PRE-CREATION 
  plugin-kms/src/test/resources/kms/dbks-site.xml PRE-CREATION 
  plugin-kms/src/test/resources/kms/kms-site.xml PRE-CREATION 
  plugin-kms/src/test/resources/ranger-kms-security.xml PRE-CREATION 
  pom.xml 39179d5 

Diff: https://reviews.apache.org/r/51889/diff/


Testing
-------


Thanks,

Colm O hEigeartaigh

Re: Review Request 51889: Add tests for KMS Service and plugin

Posted by Colm O hEigeartaigh <co...@apache.org>.

> On Sept. 23, 2016, 3:15 p.m., Velmurugan Periasamy wrote:
> > Colm - For these tests to pass, looks like you are expecting unlimited strength JCE to be available in the build environment. Can you please confirm if Apache build environments are setup with that?

Hi Vel, I've updated the patch so that the tests only run if unlimited strength security policies are installed in the JVM. I've confirmed the build passes with both limited + unlimited security policies installed.


- Colm


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51889/#review150187
-----------------------------------------------------------


On Sept. 26, 2016, 10:55 a.m., Colm O hEigeartaigh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51889/
> -----------------------------------------------------------
> 
> (Updated Sept. 26, 2016, 10:55 a.m.)
> 
> 
> Review request for ranger.
> 
> 
> Bugs: RANGER-1174
>     https://issues.apache.org/jira/browse/RANGER-1174
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> This task is to add some tests for the KMS server and plugin.
> 
> 
> Diffs
> -----
> 
>   kms/pom.xml e73dd01 
>   kms/src/test/java/org/apache/hadoop/crypto/key/kms/server/DerbyTestUtils.java PRE-CREATION 
>   kms/src/test/java/org/apache/hadoop/crypto/key/kms/server/RangerKeyStoreProviderTest.java PRE-CREATION 
>   kms/src/test/java/org/apache/hadoop/crypto/key/kms/server/RangerMasterKeyTest.java PRE-CREATION 
>   kms/src/test/resources/kms/dbks-site.xml PRE-CREATION 
>   kms/src/test/resources/kms/kms-site.xml PRE-CREATION 
>   plugin-kms/pom.xml 5ac7b20 
>   plugin-kms/src/test/java/org/apache/ranger/authorization/kms/authorizer/DerbyTestUtils.java PRE-CREATION 
>   plugin-kms/src/test/java/org/apache/ranger/authorization/kms/authorizer/RangerAdminClientImpl.java PRE-CREATION 
>   plugin-kms/src/test/java/org/apache/ranger/authorization/kms/authorizer/RangerKmsAuthorizerTest.java PRE-CREATION 
>   plugin-kms/src/test/resources/kms-policies.json PRE-CREATION 
>   plugin-kms/src/test/resources/kms/dbks-site.xml PRE-CREATION 
>   plugin-kms/src/test/resources/kms/kms-site.xml PRE-CREATION 
>   plugin-kms/src/test/resources/ranger-kms-security.xml PRE-CREATION 
>   pom.xml 59f7da6 
> 
> Diff: https://reviews.apache.org/r/51889/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Colm O hEigeartaigh
> 
>

Re: Review Request 51889: Add tests for KMS Service and plugin

Posted by Velmurugan Periasamy <vp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51889/#review150187
-----------------------------------------------------------



Colm - For these tests to pass, looks like you are expecting unlimited strength JCE to be available in the build environment. Can you please confirm if Apache build environments are setup with that?

- Velmurugan Periasamy


On Sept. 14, 2016, 11 a.m., Colm O hEigeartaigh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51889/
> -----------------------------------------------------------
> 
> (Updated Sept. 14, 2016, 11 a.m.)
> 
> 
> Review request for ranger.
> 
> 
> Bugs: RANGER-1174
>     https://issues.apache.org/jira/browse/RANGER-1174
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> This task is to add some tests for the KMS server and plugin.
> 
> 
> Diffs
> -----
> 
>   kms/pom.xml e73dd01 
>   kms/src/test/java/org/apache/hadoop/crypto/key/kms/server/DerbyTestUtils.java PRE-CREATION 
>   kms/src/test/java/org/apache/hadoop/crypto/key/kms/server/RangerKeyStoreProviderTest.java PRE-CREATION 
>   kms/src/test/java/org/apache/hadoop/crypto/key/kms/server/RangerMasterKeyTest.java PRE-CREATION 
>   kms/src/test/resources/kms/dbks-site.xml PRE-CREATION 
>   kms/src/test/resources/kms/kms-site.xml PRE-CREATION 
>   plugin-kms/pom.xml 5ac7b20 
>   plugin-kms/src/test/java/org/apache/ranger/authorization/kms/authorizer/DerbyTestUtils.java PRE-CREATION 
>   plugin-kms/src/test/java/org/apache/ranger/authorization/kms/authorizer/RangerAdminClientImpl.java PRE-CREATION 
>   plugin-kms/src/test/java/org/apache/ranger/authorization/kms/authorizer/RangerKmsAuthorizerTest.java PRE-CREATION 
>   plugin-kms/src/test/resources/kms-policies.json PRE-CREATION 
>   plugin-kms/src/test/resources/kms/dbks-site.xml PRE-CREATION 
>   plugin-kms/src/test/resources/kms/kms-site.xml PRE-CREATION 
>   plugin-kms/src/test/resources/ranger-kms-security.xml PRE-CREATION 
>   pom.xml 39179d5 
> 
> Diff: https://reviews.apache.org/r/51889/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Colm O hEigeartaigh
> 
>

Re: Review Request 51889: Add tests for KMS Service and plugin

Posted by Velmurugan Periasamy <vp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51889/#review150402
-----------------------------------------------------------


Ship it!




Thanks Colm for accommodating both environments.

- Velmurugan Periasamy


On Sept. 26, 2016, 10:55 a.m., Colm O hEigeartaigh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51889/
> -----------------------------------------------------------
> 
> (Updated Sept. 26, 2016, 10:55 a.m.)
> 
> 
> Review request for ranger.
> 
> 
> Bugs: RANGER-1174
>     https://issues.apache.org/jira/browse/RANGER-1174
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> This task is to add some tests for the KMS server and plugin.
> 
> 
> Diffs
> -----
> 
>   kms/pom.xml e73dd01 
>   kms/src/test/java/org/apache/hadoop/crypto/key/kms/server/DerbyTestUtils.java PRE-CREATION 
>   kms/src/test/java/org/apache/hadoop/crypto/key/kms/server/RangerKeyStoreProviderTest.java PRE-CREATION 
>   kms/src/test/java/org/apache/hadoop/crypto/key/kms/server/RangerMasterKeyTest.java PRE-CREATION 
>   kms/src/test/resources/kms/dbks-site.xml PRE-CREATION 
>   kms/src/test/resources/kms/kms-site.xml PRE-CREATION 
>   plugin-kms/pom.xml 5ac7b20 
>   plugin-kms/src/test/java/org/apache/ranger/authorization/kms/authorizer/DerbyTestUtils.java PRE-CREATION 
>   plugin-kms/src/test/java/org/apache/ranger/authorization/kms/authorizer/RangerAdminClientImpl.java PRE-CREATION 
>   plugin-kms/src/test/java/org/apache/ranger/authorization/kms/authorizer/RangerKmsAuthorizerTest.java PRE-CREATION 
>   plugin-kms/src/test/resources/kms-policies.json PRE-CREATION 
>   plugin-kms/src/test/resources/kms/dbks-site.xml PRE-CREATION 
>   plugin-kms/src/test/resources/kms/kms-site.xml PRE-CREATION 
>   plugin-kms/src/test/resources/ranger-kms-security.xml PRE-CREATION 
>   pom.xml 59f7da6 
> 
> Diff: https://reviews.apache.org/r/51889/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Colm O hEigeartaigh
> 
>

Re: Review Request 51889: Add tests for KMS Service and plugin

Posted by Colm O hEigeartaigh <co...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51889/
-----------------------------------------------------------

(Updated Sept. 26, 2016, 10:55 a.m.)


Review request for ranger.


Bugs: RANGER-1174
    https://issues.apache.org/jira/browse/RANGER-1174


Repository: ranger


Description
-------

This task is to add some tests for the KMS server and plugin.


Diffs (updated)
-----

  kms/pom.xml e73dd01 
  kms/src/test/java/org/apache/hadoop/crypto/key/kms/server/DerbyTestUtils.java PRE-CREATION 
  kms/src/test/java/org/apache/hadoop/crypto/key/kms/server/RangerKeyStoreProviderTest.java PRE-CREATION 
  kms/src/test/java/org/apache/hadoop/crypto/key/kms/server/RangerMasterKeyTest.java PRE-CREATION 
  kms/src/test/resources/kms/dbks-site.xml PRE-CREATION 
  kms/src/test/resources/kms/kms-site.xml PRE-CREATION 
  plugin-kms/pom.xml 5ac7b20 
  plugin-kms/src/test/java/org/apache/ranger/authorization/kms/authorizer/DerbyTestUtils.java PRE-CREATION 
  plugin-kms/src/test/java/org/apache/ranger/authorization/kms/authorizer/RangerAdminClientImpl.java PRE-CREATION 
  plugin-kms/src/test/java/org/apache/ranger/authorization/kms/authorizer/RangerKmsAuthorizerTest.java PRE-CREATION 
  plugin-kms/src/test/resources/kms-policies.json PRE-CREATION 
  plugin-kms/src/test/resources/kms/dbks-site.xml PRE-CREATION 
  plugin-kms/src/test/resources/kms/kms-site.xml PRE-CREATION 
  plugin-kms/src/test/resources/ranger-kms-security.xml PRE-CREATION 
  pom.xml 59f7da6 

Diff: https://reviews.apache.org/r/51889/diff/


Testing
-------


Thanks,

Colm O hEigeartaigh