You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Benson Margulies (JIRA)" <ji...@codehaus.org> on 2012/11/11 15:48:13 UTC

[jira] (MRELEASE-801) Wrong value of element from branch

Benson Margulies created MRELEASE-801:
-----------------------------------------

             Summary: Wrong value of <tag> element from branch
                 Key: MRELEASE-801
                 URL: https://jira.codehaus.org/browse/MRELEASE-801
             Project: Maven 2.x Release Plugin
          Issue Type: Bug
          Components: branch, Git
    Affects Versions: 2.3.2
            Reporter: Benson Margulies


The branch mojo produces <tag>HEAD</tag>. This can't be right; HEAD isn't the name of a branch, it's the name of a ref.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] (MRELEASE-801) Wrong value of element from branch

Posted by "Darryl L. Miles (JIRA)" <ji...@codehaus.org>.
    [ https://jira.codehaus.org/browse/MRELEASE-801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=315028#comment-315028 ] 

Darryl L. Miles commented on MRELEASE-801:
------------------------------------------

http://maven.apache.org/pom.html#SCM

This is kind of a legacy matter, when the pom.xml was designed git didn't exist.

It would be better however if the actual original value was restored, rather than the "effective model" value of "HEAD" when the <tag> element was not present before.

                
> Wrong value of <tag> element from branch
> ----------------------------------------
>
>                 Key: MRELEASE-801
>                 URL: https://jira.codehaus.org/browse/MRELEASE-801
>             Project: Maven 2.x Release Plugin
>          Issue Type: Bug
>          Components: branch, Git
>    Affects Versions: 2.3.2
>            Reporter: Benson Margulies
>
> The branch mojo produces <tag>HEAD</tag>. This can't be right; HEAD isn't the name of a branch, it's the name of a ref.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] (MRELEASE-801) Wrong value of element from branch

Posted by "Darryl L. Miles (JIRA)" <ji...@codehaus.org>.
     [ https://jira.codehaus.org/browse/MRELEASE-801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Darryl L. Miles updated MRELEASE-801:
-------------------------------------

    Attachment: 0001-MRELEASE-801-don-t-use-scm.tag-HEAD-for-GIT-provider.patch

Patch to GIT maven-release.git trunk  a603d07

This patch copies what CVS does in the situation.
                
> Wrong value of <tag> element from branch
> ----------------------------------------
>
>                 Key: MRELEASE-801
>                 URL: https://jira.codehaus.org/browse/MRELEASE-801
>             Project: Maven 2.x Release Plugin
>          Issue Type: Bug
>          Components: branch, Git
>    Affects Versions: 2.3.2
>            Reporter: Benson Margulies
>         Attachments: 0001-MRELEASE-801-don-t-use-scm.tag-HEAD-for-GIT-provider.patch
>
>
> The branch mojo produces <tag>HEAD</tag>. This can't be right; HEAD isn't the name of a branch, it's the name of a ref.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] (MRELEASE-801) Wrong value of element from branch

Posted by "Darryl L. Miles (JIRA)" <ji...@codehaus.org>.
    [ https://jira.codehaus.org/browse/MRELEASE-801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=315029#comment-315029 ] 

Darryl L. Miles commented on MRELEASE-801:
------------------------------------------

The maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/AbstractRewritePomsPhase.java#buildScm(MavenProject) is the location the <scm> data is restored.

It is not clear how to know if the element was not present before to be able to call scm.setTag(null).
                
> Wrong value of <tag> element from branch
> ----------------------------------------
>
>                 Key: MRELEASE-801
>                 URL: https://jira.codehaus.org/browse/MRELEASE-801
>             Project: Maven 2.x Release Plugin
>          Issue Type: Bug
>          Components: branch, Git
>    Affects Versions: 2.3.2
>            Reporter: Benson Margulies
>
> The branch mojo produces <tag>HEAD</tag>. This can't be right; HEAD isn't the name of a branch, it's the name of a ref.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira