You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "sdedic (via GitHub)" <gi...@apache.org> on 2023/03/06 12:44:44 UTC

[GitHub] [netbeans] sdedic opened a new pull request, #5615: Provide a waitable command that completes after NBLS fully starts & registers server-provided commands

sdedic opened a new pull request, #5615:
URL: https://github.com/apache/netbeans/pull/5615

   Sometimes it is necessary to `executeCommand` a NBLS-provided command. Although vscode may properly activate the NBLS extension (provided the command is in the activation patterns), but the NBLS-originated commands actually register only after the `Initialization` response returns to the vscode - that is asynchronously and **after** extension activation completes (as far as vscode is aware).
   
   We do not **want** now to wait for the initialization as NBLS (now) tries to open projects from workspace before it completes the initialization. That takes too long and NBLS windows do not even appear in the UI during that time. The proper approach would be to make the NBLS startup very lightweight - then the standard `vscode.commands.executeCommand()` will properly activate & wait - and work.
   But this might break the completion / error diagnostics / etc which now suppose everything is 'ready and open' at the moment -- needs some work and investigation.
   
   In the meantime, this PR provides a command that completes after the NBLS initializes and its commands become available - it can be used as a synchronization before the NBLS startup is properly fixed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] sdedic merged pull request #5615: Provide a waitable command that completes after NBLS fully starts & registers server-provided commands

Posted by "sdedic (via GitHub)" <gi...@apache.org>.
sdedic merged PR #5615:
URL: https://github.com/apache/netbeans/pull/5615


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists