[I] InterpolationException silently swallowed in AbstractEarModule.getBundleFileName() [maven-ear-plugin]

["elharo (via GitHub)" <gi...@apache.org>]

elharo opened a new issue, #515:
URL: https://github.com/apache/maven-ear-plugin/issues/515

   ## Description
   
   In `AbstractEarModule.java:268-271`, an `InterpolationException` from `MappingUtils.evaluateFileNameMapping()` is silently swallowed:
   
   ```java
   } catch (InterpolationException e) {
       // We currently ignore this here
       // FIXME: should we handle this better?
   }
   ```
   
   If the file name mapping evaluation fails, the exception is completely ignored. The `bundleFileName` field remains `null`, and downstream code using `getUri()` (which calls `getBundleFileName()`) may get unexpected null values. The FIXME comment confirms this is a known issue.
   
   ## Expected behavior
   
   At minimum, log a warning:
   
   ```java
   } catch (InterpolationException e) {
       getLog().warn("Failed to evaluate file name mapping", e);
   }
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org