You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues-all@impala.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2023/04/04 01:15:00 UTC
[jira] [Commented] (IMPALA-12025) Hide misleading TotalTime and InactiveTotalTime
[ https://issues.apache.org/jira/browse/IMPALA-12025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17708182#comment-17708182 ]
ASF subversion and git services commented on IMPALA-12025:
----------------------------------------------------------
Commit a879bece767336da220f5493e47be1913848f0b0 in impala's branch refs/heads/master from Riza Suminto
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=a879bece7 ]
IMPALA-12025: Hide misleading TotalTime and InactiveTotalTime
RuntimeProfileBase class in runtime-profile.cc always include TotalTime
and InactiveTotalTime counter to query profile. These are being used to
measure fragment instance activities, but meaningless and potentially
misleading in some other parts of query profile.
THis patch hide TotalTime and InactiveTotalTime in the following runtime
profile nodes:
- Right under "Query" (first line)
- All under "Summary:" and "ImpalaServer:"
- "Execution Profile"
- All under "Per Node Profiles:" except for "CodeGen:"
- "Fragment Instance Lifecycle Timings:"
- "Buffer pool:"
- "Dequeue:" and "Enqueue:"
- "Hash Table:"
- "Filter x:"
- "GroupingAggregator x:"
Testing:
- Pass core tests.
Change-Id: I32e68d36549f9730c08232fbc270e518f2acaffa
Reviewed-on: http://gerrit.cloudera.org:8080/19652
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
> Hide misleading TotalTime and InactiveTotalTime
> -----------------------------------------------
>
> Key: IMPALA-12025
> URL: https://issues.apache.org/jira/browse/IMPALA-12025
> Project: IMPALA
> Issue Type: Improvement
> Components: Backend
> Reporter: Riza Suminto
> Assignee: Riza Suminto
> Priority: Major
> Fix For: Impala 4.2.0
>
>
> RuntimeProfileBase class in runtime-profile.cc always include TotalTime and InactiveTotalTime counter to query profile. These are being used to measure fragment instance activities, but meaningless and potentially misleading in some other parts of query profile.
> We should hide TotalTime and InactiveTotalTime in the following runtime profile nodes:
> * All under "Summary:" and "ImpalaServer:"
> * "Execution Profile"
> * All under "Per Node Profiles:" except for "CodeGen:"
> * "Fragment Instance Lifecycle Timings:"
> * "Buffer pool:"
> * "Dequeue:" and "Enqueue:"
> * "Hash Table:"
> * "Filter x:"
> * "GroupingAggregator x:"
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org