You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2021/12/03 07:18:01 UTC

[GitHub] [rocketmq] HScarb commented on a change in pull request #3458: [ISSUE #3449] Delayed message supports asynchronous delivery

HScarb commented on a change in pull request #3458:
URL: https://github.com/apache/rocketmq/pull/3458#discussion_r761696102



##########
File path: store/src/main/java/org/apache/rocketmq/store/schedule/ScheduleMessageService.java
##########
@@ -431,35 +492,414 @@ public void executeOnTimeup() {
             ScheduleMessageService.this.deliverExecutorService.schedule(new DeliverDelayedMessageTimerTask(this.delayLevel,
                 failScheduleOffset), DELAY_FOR_A_WHILE, TimeUnit.MILLISECONDS);
         }
+    }
+
+    class AsyncDeliverDelayedMessageTimerTask implements Runnable {

Review comment:
       `AsyncDeliverDelayedMessageTimerTask` is similar with `DeliverDelayedMessageTimerTask`, consider extending `DeliverDelayedMessageTimerTask`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org