You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@qpid.apache.org by ta...@apache.org on 2017/12/07 20:18:52 UTC

qpid-jms git commit: NO-JIRA clean up type casts in the tests to match spec expectations

Repository: qpid-jms
Updated Branches:
  refs/heads/master 9258e899c -> 7c2545002


NO-JIRA clean up type casts in the tests to match spec expectations

Project: http://git-wip-us.apache.org/repos/asf/qpid-jms/repo
Commit: http://git-wip-us.apache.org/repos/asf/qpid-jms/commit/7c254500
Tree: http://git-wip-us.apache.org/repos/asf/qpid-jms/tree/7c254500
Diff: http://git-wip-us.apache.org/repos/asf/qpid-jms/diff/7c254500

Branch: refs/heads/master
Commit: 7c2545002746f30ddda0940930b112b14e1157f1
Parents: 9258e89
Author: Timothy Bish <ta...@gmail.com>
Authored: Thu Dec 7 15:18:43 2017 -0500
Committer: Timothy Bish <ta...@gmail.com>
Committed: Thu Dec 7 15:18:43 2017 -0500

----------------------------------------------------------------------
 .../provider/amqp/message/AmqpJmsMessageFacadeTest.java  | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/qpid-jms/blob/7c254500/qpid-jms-client/src/test/java/org/apache/qpid/jms/provider/amqp/message/AmqpJmsMessageFacadeTest.java
----------------------------------------------------------------------
diff --git a/qpid-jms-client/src/test/java/org/apache/qpid/jms/provider/amqp/message/AmqpJmsMessageFacadeTest.java b/qpid-jms-client/src/test/java/org/apache/qpid/jms/provider/amqp/message/AmqpJmsMessageFacadeTest.java
index de2171a..0e2d943 100644
--- a/qpid-jms-client/src/test/java/org/apache/qpid/jms/provider/amqp/message/AmqpJmsMessageFacadeTest.java
+++ b/qpid-jms-client/src/test/java/org/apache/qpid/jms/provider/amqp/message/AmqpJmsMessageFacadeTest.java
@@ -1899,7 +1899,7 @@ public class AmqpJmsMessageFacadeTest extends AmqpJmsMessageTypesTestCase  {
 
     @Test
     public void testGetProperties() throws Exception {
-        Map<Object, Object> applicationPropertiesMap = new HashMap<Object, Object>();
+        Map<String, Object> applicationPropertiesMap = new HashMap<>();
         applicationPropertiesMap.put(TEST_PROP_A, TEST_VALUE_STRING_A);
         applicationPropertiesMap.put(TEST_PROP_B, TEST_VALUE_STRING_B);
 
@@ -1928,7 +1928,7 @@ public class AmqpJmsMessageFacadeTest extends AmqpJmsMessageTypesTestCase  {
 
     @Test
     public void testGetPropertyNames() throws Exception {
-        Map<Object, Object> applicationPropertiesMap = new HashMap<Object, Object>();
+        Map<String, Object> applicationPropertiesMap = new HashMap<>();
         applicationPropertiesMap.put(TEST_PROP_A, TEST_VALUE_STRING_A);
         applicationPropertiesMap.put(TEST_PROP_B, TEST_VALUE_STRING_B);
 
@@ -1955,7 +1955,7 @@ public class AmqpJmsMessageFacadeTest extends AmqpJmsMessageTypesTestCase  {
 
     @Test
     public void testClearProperties() throws Exception {
-        Map<Object, Object> applicationPropertiesMap = new HashMap<Object, Object>();
+        Map<String, Object> applicationPropertiesMap = new HashMap<>();
         applicationPropertiesMap.put(TEST_PROP_A, TEST_VALUE_STRING_A);
 
         Message message = Proton.message();
@@ -1974,7 +1974,7 @@ public class AmqpJmsMessageFacadeTest extends AmqpJmsMessageTypesTestCase  {
 
     @Test
     public void testPropertyExists() throws Exception {
-        Map<Object, Object> applicationPropertiesMap = new HashMap<Object, Object>();
+        Map<String, Object> applicationPropertiesMap = new HashMap<>();
         applicationPropertiesMap.put(TEST_PROP_A, TEST_VALUE_STRING_A);
 
         Message message = Proton.message();
@@ -1997,7 +1997,7 @@ public class AmqpJmsMessageFacadeTest extends AmqpJmsMessageTypesTestCase  {
 
     @Test
     public void testGetProperty() throws Exception {
-        Map<Object, Object> applicationPropertiesMap = new HashMap<Object, Object>();
+        Map<String, Object> applicationPropertiesMap = new HashMap<>();
         applicationPropertiesMap.put(TEST_PROP_A, TEST_VALUE_STRING_A);
 
         Message message = Proton.message();
@@ -2018,7 +2018,6 @@ public class AmqpJmsMessageFacadeTest extends AmqpJmsMessageTypesTestCase  {
         amqpMessageFacade.setProperty(TEST_PROP_A, TEST_VALUE_STRING_A);
         assertEquals(TEST_VALUE_STRING_A, amqpMessageFacade.getProperty(TEST_PROP_A));
 
-        @SuppressWarnings("unchecked")
         Map<String, Object> underlyingApplicationProps = amqpMessageFacade.getApplicationProperties().getValue();
         assertTrue(underlyingApplicationProps.containsKey(TEST_PROP_A));
         assertEquals(TEST_VALUE_STRING_A, underlyingApplicationProps.get(TEST_PROP_A));


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@qpid.apache.org
For additional commands, e-mail: commits-help@qpid.apache.org