You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/05/07 08:34:48 UTC
[GitHub] [cloudstack] weizhouapache opened a new pull request #5003: UI: Make 'ACL' field as mandatory and add warning message for default_allow and default_deny
weizhouapache opened a new pull request #5003:
URL: https://github.com/apache/cloudstack/pull/5003
### Description
This PR improves the user experience of ‘ACL’ field in the dialog of creating a new VPC tier on UI.
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [X] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [X] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
'ACL' is a mandatory field (no selection by default).
warning message is displayed for in-built ACL policies (default_allow and default_deny)
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #5003: UI: Make 'ACL' field as mandatory and add warning message for default_allow and default_deny
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #5003:
URL: https://github.com/apache/cloudstack/pull/5003#issuecomment-834205334
@blueorangutan build
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5003: UI: Make 'ACL' field as mandatory and add warning message for default_allow and default_deny
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5003:
URL: https://github.com/apache/cloudstack/pull/5003#issuecomment-834194818
@Pearl1594 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5003: UI: Make 'ACL' field as mandatory and add warning message for default_allow and default_deny
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5003:
URL: https://github.com/apache/cloudstack/pull/5003#issuecomment-834223317
Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 532
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5003: UI: Make 'ACL' field as mandatory and add warning message for default_allow and default_deny
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5003:
URL: https://github.com/apache/cloudstack/pull/5003#issuecomment-834201751
@weizhouapache I understand these words: "help", "hello", "thanks", "package", "test"
Test command usage: test [mgmt os] [hypervisor] [keepEnv]
Mgmt OS options: ['centos6', 'centos7', 'centos8', 'ubuntu18', 'ubuntu20']
Hypervisor options: ['kvm-centos6', 'kvm-centos7', 'kvm-centos8', 'kvm-ubuntu18', 'kvm-ubuntu20', 'xenserver-71', 'xenserver-65sp1', 'vmware-70u1', 'vmware-67u3', 'vmware-65u2', 'vmware-60u2', 'vmware-55u3', 'xcpng76', 'xcpng80', 'xcpng81', 'xenserver-74', 'xcpng74']
Note: when keepEnv is passed, you need to specify mgmt server os and hypervisor or use the `matrix` command.
Blessed contributors for kicking Trillian test jobs: ['rhtyd', 'nvazquez', 'PaulAngus', 'borisstoyanov', 'DaanHoogland', 'shwstppr', 'andrijapanicsb', 'Spaceman1984', 'Pearl1594', 'davidjumani', 'harikrishna-patnala', 'vladimirpetrov', 'sureshanaparti', 'weizhouapache']
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5003: UI: Make 'ACL' field as mandatory and add warning message for default_allow and default_deny
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5003:
URL: https://github.com/apache/cloudstack/pull/5003#issuecomment-834205775
@weizhouapache a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #5003: UI: Make 'ACL' field as mandatory and add warning message for default_allow and default_deny
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #5003:
URL: https://github.com/apache/cloudstack/pull/5003#issuecomment-834194207
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd merged pull request #5003: UI: Make 'ACL' field as mandatory and add warning message for default_allow and default_deny
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #5003:
URL: https://github.com/apache/cloudstack/pull/5003
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher commented on pull request #5003: UI: Make 'ACL' field as mandatory and add warning message for default_allow and default_deny
Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on pull request #5003:
URL: https://github.com/apache/cloudstack/pull/5003#issuecomment-836747933
@weizhouapache this PR is in Draft, are there any changes coming to update it into ready for review?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #5003: UI: Make 'ACL' field as mandatory and add warning message for default_allow and default_deny
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #5003:
URL: https://github.com/apache/cloudstack/pull/5003#issuecomment-834201243
@blueorangutan help
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5003: UI: Make 'ACL' field as mandatory and add warning message for default_allow and default_deny
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5003:
URL: https://github.com/apache/cloudstack/pull/5003#issuecomment-834197813
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5003 (SL-JID-132)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #5003: UI: Make 'ACL' field as mandatory and add warning message for default_allow and default_deny
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #5003:
URL: https://github.com/apache/cloudstack/pull/5003#issuecomment-834205486
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #5003: UI: Make 'ACL' field as mandatory and add warning message for default_allow and default_deny
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #5003:
URL: https://github.com/apache/cloudstack/pull/5003#issuecomment-834175791
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] alexandremattioli commented on pull request #5003: UI: Make 'ACL' field as mandatory and add warning message for default_allow and default_deny
Posted by GitBox <gi...@apache.org>.
alexandremattioli commented on pull request #5003:
URL: https://github.com/apache/cloudstack/pull/5003#issuecomment-844062346
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #5003: UI: Make 'ACL' field as mandatory and add warning message for default_allow and default_deny
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5003:
URL: https://github.com/apache/cloudstack/pull/5003#issuecomment-838332850
We're waiting for a round of manual QA, which is with @vladimirpetrov so it's kept in review so we don't accidently merge this @GabrielBrascher
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org